From: Rob Clark
The GPU (at least a3xx, but I think also a2xx) can render directly to
memory, bypassing tiling. Although it can't do this if blend, depth,
and a few other features of the pipeline are enabled. This direct
memory mode can be faster for some sorts of operations, such as s
From: Rob Clark
The newer snapdragon devices (at least, the one I have in nexus4) no
longer has a dedicated 2D core. For these devices, DDX needs to use
the 3D core. I've implemented support to use XA in the DDX, but it
requires some changes which break the current API in XA.
In parti
From: Rob Clark
For freedreno DDX, we have to create the scanout GEM bo in a special way
(until we have our own KMS/DRM kernel driver.. and even then for
phones/tablets you probably need to use the android drivers if you don't
want to port the lcd panel driver support). The easiest w
From: Jerome Glisse
Allow to retrieve non shared handle.
Signed-off-by: Jerome Glisse
---
src/gallium/state_trackers/xa/xa_tracker.c | 11 ++-
src/gallium/state_trackers/xa/xa_tracker.h | 9 -
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/src/gallium/state_tr
From: Jerome Glisse
First step before moving flushing inside the ddx.
Signed-off-by: Jerome Glisse
---
src/gallium/state_trackers/xa/xa_composite.c | 2 +-
src/gallium/state_trackers/xa/xa_context.c | 17 +++--
src/gallium/state_trackers/xa/xa_context.h | 2 ++
src/gallium/st
From: Jerome Glisse
pipe_transfer_map already offset the surface properly so using the offset
again with util_copy_rect might lead to read/write outside the surface.
Signed-off-by: Jerome Glisse
---
src/gallium/state_trackers/xa/xa_context.c | 5 ++---
1 file changed, 2 insertions(+), 3 deleti
From: Jerome Glisse
Signed-off-by: Jerome Glisse
---
src/gallium/state_trackers/xa/xa_composite.c | 1 -
src/gallium/state_trackers/xa/xa_context.c | 10 ++
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/src/gallium/state_trackers/xa/xa_composite.c
b/src/gallium/stat
From: Jerome Glisse
This make ddx life easier.
Signed-off-by: Jerome Glisse
Signed-off-by: Rob Clark
---
src/gallium/state_trackers/xa/xa_priv.h| 1 +
src/gallium/state_trackers/xa/xa_tracker.c | 16 +++-
src/gallium/state_trackers/xa/xa_tracker.h | 3 ++-
3 files changed
From: Rob Clark
Bump major version, as the change to require explicit
xa_context_flush(), the addition of the handle-type parameter to
xa_surface_handle(), and change of surface to ref/unref will require a
minor change in DDX.
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion
From: Rob Clark
Signed-off-by: Rob Clark
---
configure.ac | 4 +-
src/gallium/targets/Makefile.am | 3 ++
src/gallium/targets/xa-freedreno/Makefile.am | 65
src/gallium/targets/xa-freedreno/fd_target.c | 20
Only just compile tested, as I don't have the "hardware" for it..
Signed-off-by: Rob Clark
---
configure.ac | 2 +-
vmwgfx/vmwgfx_dri2.c | 5 +++--
vmwgfx/vmwgfx_driver.c| 3 ++-
vmwgfx/vmwgfx_saa.c | 20 ++--
vmwgfx/vmwgfx_t
On Wed, Jun 12, 2013 at 11:41 AM, Jakob Bornecrantz
wrote:
> The changes looks good at a first glance.
>
> There are some thoughts tho,
> maybe we should try and make libxatracker.so autodetect
> which driver to use so we don't have to create a libxatracker.so
> for each driver, at least for linux
On Fri, Feb 7, 2014 at 11:20 AM, Christian König
wrote:
> Am 07.02.2014 16:49, schrieb Alex Deucher:
>
>> On Fri, Feb 7, 2014 at 12:34 AM, Connor Abbott
>> wrote:
>>>
>>> Hi,
>>>
>>> So I believe that we can all agree that the tree-based representation
>>> that GLSL IR currently uses for shaders
From: Rob Clark
This lets multiple gallium drivers use XA.
Signed-off-by: Rob Clark
---
configure.ac | 8 ++--
src/gallium/state_trackers/xa/Makefile.am | 11 -
src/gallium/state_trackers/xa/xa_priv.h | 1 +
src/gallium/state_trackers/xa
From: Rob Clark
Now that the rendering corruption issues from the very early days of
a3xx gallium are solved it is time to return to freedreno XA support,
so that presentation blit for windowed apps (and post-sub-buffer) !=
stall + memcpy(). With basic XA working now in xf86-video-freedreno,
it
From: Rob Clark
Build two versions of pipe-loader, with only the client version linking
in x11 client side dependencies. This will allow the XA state tracker
to use pipe-loader.
Signed-off-by: Rob Clark
---
configure.ac | 11 +--
src/gallium
From: Rob Clark
Signed-off-by: Rob Clark
---
src/gallium/targets/pipe-loader/Makefile.am | 16
src/gallium/targets/pipe-loader/pipe_msm.c | 20
2 files changed, 36 insertions(+)
create mode 100644 src/gallium/targets/pipe-loader/pipe_msm.c
diff --git a
On Mon, Feb 10, 2014 at 7:37 AM, Emil Velikov wrote:
> Hi Rob
>
> On 08/02/14 22:41, Rob Clark wrote:
>> From: Rob Clark
>>
>> This lets multiple gallium drivers use XA.
>>
>> Signed-off-by: Rob Clark
>> ---
>> configure.ac
On Mon, Feb 10, 2014 at 12:30 PM, Johannes Obermayr
wrote:
> There should be one called pipe_freedreno and the pipe driver loader should
> support sth. like:
>
>if ((strcmp(dev->driver_name, "kgsl") == 0) || (strcmp(dev->driver_name,
> "msm") == 0))
> dev->driver_name = "freedreno";
>
From: Rob Clark
DRM_API_HANDLE_TYPE_SHARED is zero, so doesn't actually fix anything.
But we shouldn't rely on SHARED handle type being zero.
Signed-off-by: Rob Clark
---
src/gallium/state_trackers/xa/xa_tracker.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/stat
From: Rob Clark
Signed-off-by: Rob Clark
---
src/gallium/targets/pipe-loader/Makefile.am | 16
src/gallium/targets/pipe-loader/pipe_msm.c | 21 +
2 files changed, 37 insertions(+)
create mode 100644 src/gallium/targets/pipe-loader/pipe_msm.c
diff --git a
From: Rob Clark
Original patchset:
http://lists.freedesktop.org/archives/mesa-dev/2014-February/053632.html
v1: original
v2: moves xa target into targets/xa, and fixes various issues spotted
by Emil
Rob Clark (4):
pipe-loader: split out "client" version
st/xa: use pipe-loa
From: Rob Clark
This lets multiple gallium drivers use XA.
Signed-off-by: Rob Clark
---
configure.ac | 9 ++--
src/gallium/state_trackers/xa/Makefile.am | 1 +
src/gallium/state_trackers/xa/xa_priv.h | 1 +
src/gallium/state_trackers/xa
From: Rob Clark
Build two versions of pipe-loader, with only the client version linking
in x11 client side dependencies. This will allow the XA state tracker
to use pipe-loader.
Signed-off-by: Rob Clark
---
configure.ac | 14 +++--
src/gallium
From: Rob Clark
Original patchset:
http://lists.freedesktop.org/archives/mesa-dev/2014-February/053632.html
v1: original
v2: moves xa target into targets/xa, and fixes various issues spotted
by Emil
v3: few more comments from Emil (drop code in targets/xa, get rid of
From: Rob Clark
This lets multiple gallium drivers use XA.
Signed-off-by: Rob Clark
---
configure.ac | 9 +--
src/gallium/auxiliary/pipe-loader/Makefile.am | 1 -
src/gallium/auxiliary/pipe-loader/pipe_loader_sw.c | 2 -
src/gallium/state_trackers
From: Rob Clark
Build two versions of pipe-loader, with only the client version linking
in x11 client side dependencies. This will allow the XA state tracker
to use pipe-loader.
Signed-off-by: Rob Clark
---
configure.ac | 14 +++--
src/gallium
From: Rob Clark
Signed-off-by: Rob Clark
---
src/gallium/targets/pipe-loader/Makefile.am | 17 +
src/gallium/targets/pipe-loader/pipe_msm.c | 21 +
2 files changed, 38 insertions(+)
create mode 100644 src/gallium/targets/pipe-loader/pipe_msm.c
diff --git
From: Rob Clark
DRM_API_HANDLE_TYPE_SHARED is zero, so doesn't actually fix anything.
But we shouldn't rely on SHARED handle type being zero.
Signed-off-by: Rob Clark
---
src/gallium/state_trackers/xa/xa_tracker.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/stat
On Thu, Feb 13, 2014 at 8:39 AM, Emil Velikov wrote:
>> +if HAVE_MESA_LLVM
>> +# Mention a dummy pure C++ file to trigger generation of the $(LINK)
>> variable
>> +nodist_EXTRA_libxatracker_la_SOURCES = dummy-cpp.cpp
> Move before the HAVE_MESA_LLVM. It will translate to no-on if not required.
>
From: Rob Clark
Signed-off-by: Rob Clark
---
For adreno a4xx, we need to lower all TXP, for a3xx, we need to just
lower for certain texture types.
src/gallium/auxiliary/tgsi/tgsi_lowering.c | 35 --
src/gallium/auxiliary/tgsi/tgsi_lowering.h | 3 +++
2 files
From: Rob Clark
v2: actually do perspective divide for RECT/SHADOWRECT
Signed-off-by: Rob Clark
Reviewed-by: Ilia Mirkin
---
src/gallium/auxiliary/tgsi/tgsi_lowering.c | 46 --
src/gallium/auxiliary/tgsi/tgsi_lowering.h | 3 ++
2 files changed, 34 insertions
From: Rob Clark
This emulates alpha-test with a compare + KILL_IF. The alpha-ref value
is passed to the shader via constant tagged with new ALPHAREF semantic.
For example:
FRAG
PROPERTY FS_COLOR0_WRITES_ALL_CBUFS 1
DCL IN[0], COLOR, COLOR
DCL OUT[0], COLOR
0: MOV OUT[0], IN[0
On Fri, Dec 19, 2014 at 3:50 PM, Ilia Mirkin wrote:
> On Fri, Dec 19, 2014 at 2:11 PM, Rob Clark wrote:
>> From: Rob Clark
>>
>> This emulates alpha-test with a compare + KILL_IF. The alpha-ref value
>> is passed to the shader via constant tagged with new ALPHAR
On Fri, Dec 19, 2014 at 4:26 PM, Ilia Mirkin wrote:
> On Fri, Dec 19, 2014 at 4:04 PM, Rob Clark wrote:
>> On Fri, Dec 19, 2014 at 3:50 PM, Ilia Mirkin wrote:
>>> On Fri, Dec 19, 2014 at 2:11 PM, Rob Clark wrote:
>>>> From: Rob Clark
>>>>
>>>
On Fri, Dec 19, 2014 at 5:06 PM, Brian Paul wrote:
> On 12/19/2014 02:47 PM, Rob Clark wrote:
>>
>> On Fri, Dec 19, 2014 at 4:26 PM, Ilia Mirkin wrote:
>>>
>>> On Fri, Dec 19, 2014 at 4:04 PM, Rob Clark wrote:
>>>>
>>>> On Fri, Dec 19,
On Fri, Dec 19, 2014 at 5:18 PM, Chris Forbes wrote:
> On Sat, Dec 20, 2014 at 8:11 AM, Rob Clark wrote:
>> @@ -1452,6 +1593,20 @@ tgsi_transform_lowering(const struct
>> tgsi_lowering_config *config,
>>}
>> }
>>
>> + if ((inf
se of a few extra instructions and extra const slot
for the edge cases?
BR,
-R
> Roland
>
> Am 19.12.2014 um 20:11 schrieb Rob Clark:
>> From: Rob Clark
>>
>> This emulates alpha-test with a compare + KILL_IF. The alpha-ref value
>> is passed to the shader via
i_lowering interface slightly
so the driver does the first tgsi_scan_shader() (so it knows # of
consts) and tgsi_lowering only does the 2nd tgsi_scan_shader() in
cases where the shader is transformed. We seems like a sane change to
me.
BR,
-R
On Fri, Dec 19, 2014 at 2:11 PM, Rob Clark wrote:
> Fr
From: Rob Clark
At least temporarily, I need to fallback to old compiler still for
relative dest (for freedreno), but I can do relative src temp. Only
a temporary situation, but seems easy/reasonable for tgsi-scan to
track this.
Signed-off-by: Rob Clark
---
I could always keep temp indirect
From: Rob Clark
NOTE IN[] and OUT[] don't need (have?) ArrayID's.. and TEMP[] can
optionally have them. So we implicitly assume that ArrayID==0 always
exists for each file. This is why array_max[file] is never less than
zero.
You can tell from indirect_files(_read/written) if the le
MAT_RGB565,
> + { __DRI_IMAGE_FOURCC_ARGB1555, __DRI_IMAGE_FORMAT_ARGB1555,
Hey, I had only just made the exact same change locally, debugging
deqp w/ a 565 visual
(I'm still getting lots of fails, although the small # I've looked at
so far look like precision issues, so not s
On Tue, Jan 15, 2019 at 1:02 AM Tapani Pälli wrote:
>
>
>
> On 1/14/19 2:36 PM, Daniel Stone wrote:
> > Hi,
> >
> > On Fri, 11 Jan 2019 at 17:05, Jason Ekstrand wrote:
> >> 5. There's no way with gitlab for Reviewed-by tags to get automatically
> >> applied as part of the merging process. Thi
On Tue, Jan 15, 2019 at 7:40 AM Daniel Stone wrote:
>
> Hi,
>
> On Tue, 15 Jan 2019 at 12:21, Rob Clark wrote:
> > On Tue, Jan 15, 2019 at 1:02 AM Tapani Pälli wrote:
> > > On 1/14/19 2:36 PM, Daniel Stone wrote:
> > > > On Fri, 11 Jan 2019 at 17:05, Jas
On Tue, Jan 15, 2019 at 5:51 PM Daniel Stone wrote:
>
> Hey,
>
> On Tue, 15 Jan 2019 at 20:22, Rob Clark wrote:
> > On Tue, Jan 15, 2019 at 7:40 AM Daniel Stone wrote:
> > > My question would again be what value that brings you. Do you just
> > > like seei
On Thu, Jan 17, 2019 at 3:56 PM Jonathan Gray wrote:
>
> On Mon, Jan 14, 2019 at 03:46:35PM +0200, Eero Tamminen wrote:
> > Hi,
> >
> > On 13.1.2019 9.44, Jonathan Gray wrote:
> > ...> As we can not depend on python to build Mesa in OpenBSD I will have to
> > > go back to maintaining a local Mesa
Normally modifiers take precendence over use flags, as they are more
explicit. But if the driver supports modifiers, but the xserver does
not, then we should fallback to the old mechanism of allocating a buffer
using 'use' flags.
Fixes: 069fdd5f9facbd72fb6a289696c7b74e3237e70f
Signed-o
I guess as discovered with
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/47 maybe we
should wait to turn on merging MRs via web until we have at least some
basic build-test CI wired up.. the downside is slower 'maintainer'
response (if I am working on some long running branch I tend to
po
On Fri, Jan 25, 2019 at 4:26 PM Eric Anholt wrote:
>
> Rob Clark writes:
>
> > I guess as discovered with
> > https://gitlab.freedesktop.org/mesa/mesa/merge_requests/47 maybe we
> > should wait to turn on merging MRs via web until we have at least some
> > b
On Fri, Jan 25, 2019 at 10:48 AM Eduardo Lima Mitev wrote:
>
> There are a bunch of instructions emitted on ir3_compiler_nir related to
> offset computations for IO opcodes (ssbo, image, etc). This small series
> explores the possibility of moving these instructions to NIR, where we
> have higher
On Mon, Jan 28, 2019 at 3:32 AM Eduardo Lima Mitev wrote:
>
> On 1/26/19 12:42 AM, Rob Clark wrote:
> > On Fri, Jan 25, 2019 at 10:48 AM Eduardo Lima Mitev
> > wrote:
> >>
> >> There are a bunch of instructions emitted on ir3_compiler_nir related to
> >
On Sun, Jan 27, 2019 at 1:33 PM Daniel Stone wrote:
>
> Hi,
>
> On Fri, 25 Jan 2019 at 23:24, Rob Clark wrote:
> > (Hmm, I guess I should take a look at what sort of API gitlab offers,
> > but that will probably have to wait until after the branchpoint.. tbh
> > I&#
On Mon, Jan 28, 2019 at 1:15 PM Eric Anholt wrote:
>
> Marek Olšák writes:
>
> > Hi,
> >
> > People don't prefix merge request names with the component they are
> > changing, so unrelated people have to open merge requests they don't really
> > want to look at.
> >
> > Could you start adding the
On Mon, Jan 28, 2019 at 2:29 PM Ilia Mirkin wrote:
>
> A few thoughts. Given past experience, I don't really expect these to
> have any serious impact on the direction taken, but I also don't want
> to just sit brooding in silence. Please note that full time/paid
> contributors probably have a dif
S(4) |
> MALI_CHANNEL_16,
> + MALI_RGBA32I = MALI_FORMAT_SINT | MALI_NR_CHANNELS(4) |
> MALI_CHANNEL_32,
> + MALI_RGBA16F = MALI_FORMAT_SINT | MALI_NR_CHANNELS(4) |
> MALI_CHANNEL_FLOAT,
> +
> + MALI_RGBA4 = MALI_FORMAT_SPECIAL2 | 0x8,
> + MALI_RGBA8_2= MALI_FORMAT_SPECIAL2 | 0xd,
> + MALI_RGB10_A2_2 = MALI_FORMAT_SPECIAL2 | 0xe,
> +};
> +
> +
> +/* Alpha coverage is encoded as 4-bits (from a clampf), with inversion
> + * literally performing a bitwise invert. This function produces slightly
> wrong
> + * results and I'm not sure why; some rounding issue I suppose... */
> +
> +#define MALI_ALPHA_COVERAGE(clampf) ((uint16_t) (int) (clampf * 15.0f))
> +#define MALI_GET_ALPHA_COVERAGE(nibble) ((float) nibble / 15.0f)
> +
> +/* Applies to unknown1 */
> +#define MALI_NO_ALPHA_TO_COVERAGE (1 << 10)
> +
> +struct mali_blend_meta {
> +#ifdef T8XX
Small comment, you should plan on single build for all supported
generations.. I'm not entirely sure if this same header is eventually
planned to be #include'd from different C code w/ different defines
for gpu gen (afaict you just currently hard-code it at the top of this
header).. But distro's will be unhappy if it comes to different mesa
builds for 8xx vs 6xx ;-)
Also, I guess for your sanity at some point you'll want to autogen
cmdstream encoding and decoding from a single source. I get the
impression that envytools isn't the right thing for the bitpacked
format for mali cmdstream. Maybe the intel thing is better? But I
didn't get very far w/ a2xx r/e before I realized that keeping hand
coded decoding and encoding in sync sucked.
Anyways, totally fine w/ those details getting worked out in-tree,
after merging.
Acked-by: Rob Clark
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
;t hit that, but this looks like the right thing to do
Reviewed-by: Rob Clark
> ---
> src/gallium/drivers/freedreno/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/freedreno/meson.build
> b/src/gallium/drivers/freedreno
On Thu, Feb 14, 2019 at 4:00 AM Daniel Vetter wrote:
>
> Clear rules avoid arguing.
>
> I think it'd be good to have an equally solid list on the kms side.
> But kms is much more meant to be a standard, and the list of userspace
> projects we've accepted in the past is constantly shifting and
> ad
On Tue, Feb 19, 2019 at 6:49 PM Marek Olšák wrote:
>
> st_link_shader takes 55% of CPU time with NIR, and 9% with TGSI.
>
> nir_validate_shader 49%
>
> nir_validate_shader is overused. It doesn't make sense even in debug builds.
tbh, I like nir_validate enabled when I do piglit/deqp runs.. and I
On Thu, Feb 21, 2019 at 1:19 AM Alyssa Rosenzweig wrote:
>
> For reasons that are still unclear (speculation included in the comment
> added in this patch), the tiler? metadata has a fast path that we were
> not enabling; there looks to be a possible time/memory tradeoff, but the
> details remain
On Thu, Feb 21, 2019 at 5:11 PM Connor Abbott wrote:
>
> On Thu, Feb 21, 2019 at 5:07 PM Alyssa Rosenzweig
> wrote:
>>
>> > Yes, there is a buffer for holding the results of the tiler. The way it
>> > works is that the userspace driver allocates a very large buffer with a
>> > "grow on page faul
On Fri, Feb 22, 2019 at 12:39 PM Jason Ekstrand wrote:
>
> On Fri, Feb 22, 2019 at 9:51 AM Eric Anholt wrote:
>>
>> Timothy Arceri writes:
>>
>> > shader-db results i965 (SKL):
>> >
>> > total instructions in shared programs: 13219105 -> 13024761 (-1.47%)
>> > instructions in affected programs:
On Fri, Feb 22, 2019 at 3:47 PM Timothy Arceri wrote:
>
>
>
> On 23/2/19 6:31 am, Rob Clark wrote:
> > On Fri, Feb 22, 2019 at 12:39 PM Jason Ekstrand
> > wrote:
> >>
> >> On Fri, Feb 22, 2019 at 9:51 AM Eric Anholt wrote:
> >>>
> >&g
On Wed, Feb 13, 2019 at 4:30 PM Eduardo Lima Mitev wrote:
>
> This pass moves to NIR some offset computations that are currently
> implemented on the IR3 backend compiler, to allow NIR to possibly
> optimize them.
>
> For now, it only supports lowering byte-offset computation for image
> store and
On Fri, Mar 1, 2019 at 10:54 AM Christian Gmeiner
wrote:
>
> Use u_transfer_helper_resource_create(..) instead which uses the
> resource_create(..) function specified in u_transfer_vtbl.
>
> Signed-off-by: Christian Gmeiner
> ---
> src/gallium/auxiliary/util/u_transfer_helper.c | 2 +-
> 1 file
a bit of memory by holding on to the
sampler view reference.
Signed-off-by: Rob Clark
---
src/gallium/docs/source/context.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/docs/source/context.rst
b/src/gallium/docs/source/context.rst
index f89d9e1005e..199d335f8f4 100644
On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger wrote:
>
> Am 12.03.19 um 16:16 schrieb Rob Clark:
> > This previously was not called out clearly, but based on a survey of the
> > code, it seems the expected behavior is to release the reference to any
> > sampler vi
On Wed, Mar 13, 2019 at 11:37 AM Roland Scheidegger wrote:
>
> Am 12.03.19 um 22:48 schrieb Rob Clark:
> > On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger
> > wrote:
> >>
> >> Am 12.03.19 um 16:16 schrieb Rob Clark:
> >>> This previously was
Thanks Alex. Adding evoc list.
And I'd also like to point out that the mentors (and xorg board
members, etc) are all volunteers who are also busy with their existing
work and flooded inboxes (and in general finding people with bandwidth
to be a mentor is the hardest thing). Students who show som
00644
> > index 000..d543c9a7543
> > --- /dev/null
> > +++ b/src/util/u_drm.h
> > @@ -0,0 +1,46 @@
> > +/*
> > + * Copyright © 2014 Broadcom
> > + * Copyright (C) 2012 Rob Clark
> > + *
> > + * Permission is hereby granted, free of charge
On Thu, Mar 14, 2019 at 12:19 AM Alyssa Rosenzweig wrote:
>
> Signed-off-by: Alyssa Rosenzweig
> Cc: Rob Clark
thanks, r-b
> ---
> .../drivers/freedreno/freedreno_resource.c| 20 ---
> 1 file changed, 4 insertions(+), 16 deletions(-)
>
> diff --g
On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger wrote:
>
> Am 12.03.19 um 16:16 schrieb Rob Clark:
> > This previously was not called out clearly, but based on a survey of the
> > code, it seems the expected behavior is to release the reference to any
> > sampler vi
On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger wrote:
>
> Am 14.03.19 um 14:13 schrieb Rob Clark:
> > On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger
> > wrote:
> >>
> >> Am 12.03.19 um 16:16 schrieb Rob Clark:
> >>> This previously was
On Thu, Mar 14, 2019 at 3:35 PM Eric Anholt wrote:
>
> Rob Clark writes:
>
> > On Fri, Mar 1, 2019 at 10:54 AM Christian Gmeiner
> > wrote:
> >>
> >> Use u_transfer_helper_resource_create(..) instead which uses the
> >> resource_create(..) functio
On Thu, Mar 14, 2019 at 8:28 PM Roland Scheidegger wrote:
>
> Am 14.03.19 um 22:06 schrieb Rob Clark:
> > On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger
> > wrote:
> >>
> >> Am 14.03.19 um 14:13 schrieb Rob Clark:
> >>> On Tue, Mar 12,
On Thu, Mar 14, 2019 at 9:58 PM Roland Scheidegger wrote:
>
> Am 15.03.19 um 02:18 schrieb Rob Clark:
> > On Thu, Mar 14, 2019 at 8:28 PM Roland Scheidegger
> > wrote:
> >>
> >> Am 14.03.19 um 22:06 schrieb Rob Clark:
> >>> On Thu, Mar 14,
On Fri, Mar 15, 2019 at 3:49 AM Axel Davy wrote:
>
> On 15/03/2019 03:12, Rob Clark wrote:
> > On Thu, Mar 14, 2019 at 9:58 PM Roland Scheidegger
> > wrote:
> >> Am 15.03.19 um 02:18 schrieb Rob Clark:
> >>> On Thu, Mar 14, 2019 at 8:28 PM Roland Scheidegg
On Fri, Mar 15, 2019 at 8:21 AM Axel Davy wrote:
>
> On 15/03/2019 13:12, Rob Clark wrote:
> > On Fri, Mar 15, 2019 at 3:49 AM Axel Davy wrote:
>
> >> To my knowledge, the semantic of set_sampler_views was changed two years
> >> ago, and that caused some issues:
Note that the kernel patch for this should land first (at least in
drm-next), and then just sync (copy) the updated file to mesa.
It might be worthwhile to split the patch and anything that depends on
it into a second patchset that can land later once the drm_fourcc.h
parts land on the kernel side
Any chance you could submit a gitlab MR? Replying with comments
inline to the driver patch is a bit more than gmail can handle..
but quick comments:
In lima_pack_pp_frame_reg() maybe the swizzle field in 'struct
util_format_description' is a better way to determine swap_channels?
Not sure how ma
From: Rob Clark
Since debugging issues w/ fd's close()d at the wrong time can be quite
fun, this should probably be made more explicit in the docs.
Signed-off-by: Rob Clark
---
src/gallium/include/pipe/p_screen.h | 8
1 file changed, 8 insertions(+)
diff --git a/src/gallium/in
From: Rob Clark
After inserting instructions the cursor.option becomes _after_instr
(even if it started life as an _after_block). So we cannot simply stash
the current cursor on the if/loop_stack. Otherwise we end up inserting
instructions after the endif/endloop in the block preceeding the if
From: Rob Clark
Sometimes a useful thing for compilers (or, for example, tgsi_to_nir) to
know. And pretty trivial for scan to figure this out for us.
Signed-off-by: Rob Clark
---
src/gallium/auxiliary/tgsi/tgsi_scan.c | 16
src/gallium/auxiliary/tgsi/tgsi_scan.h | 5
From: Rob Clark
Rather than make yet another copy of channel(), let's move it into nir.
Signed-off-by: Rob Clark
---
src/glsl/nir/nir_builder.h | 6 ++
src/glsl/nir/nir_lower_tex_projector.c | 24 +---
src/glsl/nir/nir_normalize_cubemap_coo
From: Rob Clark
So this is basically working as a lowering pass for handling user-clip-
planes, and frag-shader emulation of CLIPDIST for hardware that needs
to handle this in the shader.
For user-clip-planes, instructions are inserted to calculate CLIPDIST
in the VS. And in both cases
On Sep 10, 2015 7:39 PM, "Jason Ekstrand" wrote:
>
> On Thu, Sep 10, 2015 at 2:39 PM, Rob Clark wrote:
> > From: Rob Clark
> >
> > So this is basically working as a lowering pass for handling user-clip-
> > planes, and frag-shader emulation of CLIPDIST fo
On Thu, Sep 10, 2015 at 8:03 PM, Erik Faye-Lund wrote:
> On Thu, Sep 10, 2015 at 10:08 PM, Rob Clark wrote:
>> From: Rob Clark
>>
>> Rather than make yet another copy of channel(), let's move it into nir.
>>
>> Signed-off-by: Rob Clark
On Fri, Sep 11, 2015 at 1:20 AM, Connor Abbott wrote:
> On Thu, Sep 10, 2015 at 10:54 PM, Rob Clark wrote:
>>
>> On Sep 10, 2015 7:39 PM, "Jason Ekstrand" wrote:
>>>
>>> On Thu, Sep 10, 2015 at 2:39 PM, Rob Clark wrote:
>>> > From: R
From: Rob Clark
Use nir_lower_clip pass for adding the VS/FS instructions to handle
user-clip-planes and CLIPDIST. Wire up support for load_user_clip_plane
intrinsic to fetch ucp[plane] values as driver-params (passed as const's
to the shader).
Signed-off-by: Rob Clark
---
src/ga
From: Rob Clark
The vertex shader lowering adds calculation for CLIPDIST, if needed
(ie. user-clip-planes), and the frag shader lowering adds conditional
kills based on CLIPDIST value (which should be treated as a normal
interpolated varying by the driver).
Signed-off-by: Rob Clark
---
src
From: Rob Clark
Signed-off-by: Rob Clark
---
src/gallium/drivers/freedreno/a4xx/fd4_draw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/freedreno/a4xx/fd4_draw.c
b/src/gallium/drivers/freedreno/a4xx/fd4_draw.c
index 2bd2ca2..025753c 100644
--- a/src/gallium/drivers
From: Rob Clark
To avoid propagating the tgsi semantic name/index hack further, and
to avoid a generic nir lowering pass knowing about tgsi semantic,
first I needed to switch over to using VERT_ATTRIB_/VARYING_SLOT_/
FRAG_RESULT_. So I dusted off Eric's patch, split out the vc4
conversion
does the actual conversion.
v3: add frag_result_to_tgsi_semantic() helper and don't try to map
frag_results to semantic name/index as if they were varying_slot's
v4: use VERT_ATTRIB_ for VS inputs
Signed-off-by: Rob Clark
---
src/gallium/auxiliary/nir/tgsi_to_nir.c
From: Rob Clark
Signed-off-by: Rob Clark
---
src/gallium/drivers/freedreno/a3xx/fd3_emit.c | 30 --
src/gallium/drivers/freedreno/a3xx/fd3_program.c | 49 +
src/gallium/drivers/freedreno/a4xx/fd4_emit.c | 31 --
src/gallium/drivers/freedreno/a4xx/fd4_program.c
From: Rob Clark
Used internally in freedreno/ir3 to calc stream-out position. Seems
like a generic enough way to implement stream-out (using str instrs),
plus it avoids compiler warnings by sneaking in a non-enum value in
switch statements.
Signed-off-by: Rob Clark
---
src/glsl
From: Rob Clark
Signed-off-by: Rob Clark
---
src/Makefile.am | 1 +
src/glsl/shader_enums.c | 202 ++
src/glsl/shader_enums.h | 53
src/mesa/Makefile.sources | 4 +-
4 files changed, 259 insertions(+), 1 deletion
From: Rob Clark
A small step towards un-TGSI'ifying ir3.
Signed-off-by: Rob Clark
---
src/gallium/drivers/freedreno/a3xx/fd3_program.c | 5 ++-
src/gallium/drivers/freedreno/a4xx/fd4_program.c | 5 ++-
.../drivers/freedreno/ir3/ir3_compiler_nir.c | 40 +-
From: Rob Clark
For lowering user-clip-planes, we need a way to pass the enabled/used
user-clip-planes in to shader.
Signed-off-by: Rob Clark
---
src/glsl/nir/nir_intrinsics.h | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/src/glsl/nir
From: Eric Anholt
(originally part of previous patch, split out to separate patch by Rob)
Signed-off-by: Rob Clark
---
src/gallium/drivers/vc4/vc4_context.h | 9 +-
src/gallium/drivers/vc4/vc4_nir_lower_blend.c | 5 +-
src/gallium/drivers/vc4/vc4_nir_lower_io.c| 24 +---
src
From: Rob Clark
Signed-off-by: Rob Clark
---
src/glsl/nir/nir_print.c | 73 ++--
1 file changed, 59 insertions(+), 14 deletions(-)
diff --git a/src/glsl/nir/nir_print.c b/src/glsl/nir/nir_print.c
index 69cadba..6c9bd4b 100644
--- a/src/glsl/nir
On Tue, Sep 15, 2015 at 2:55 AM, Iago Toral wrote:
> On Sun, 2015-09-13 at 11:51 -0400, Rob Clark wrote:
>> From: Rob Clark
>>
>> Signed-off-by: Rob Clark
>> ---
>> src/Makefile.am | 1 +
>> src/glsl/shader_enums.c | 202
>> +
501 - 600 of 1957 matches
Mail list logo
