[Mesa-dev] [PATCH 0/2] doxygen: Properly handle doxygen_sqlite3.db output file

A simple patch set for my first proposed Mesa contribution. Modern doxygen uses a SQLite intermediate output file when producing documentation from source code. Mesa's Makefile and .gitignore in doxygen/ could better handle this output file, which these two patches address. Rhys Ki

[Mesa-dev] [PATCH 1/2] doxygen: Add doxygen_sqlite3.db to .gitignore

Signed-off-by: Rhys Kidd --- doxygen/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/doxygen/.gitignore b/doxygen/.gitignore index abf56ac..a5f3921 100644 --- a/doxygen/.gitignore +++ b/doxygen/.gitignore @@ -1,3 +1,4 @@ +*.db *.tag *.tmp agpgart -- 2.1.4

[Mesa-dev] [PATCH 2/2] doxygen: Remove doxygen_sqlite3.db with 'make clean'

Signed-off-by: Rhys Kidd --- doxygen/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/doxygen/Makefile b/doxygen/Makefile index 0a95a35..01c2691 100644 --- a/doxygen/Makefile +++ b/doxygen/Makefile @@ -33,3 +33,4 @@ subset: $(SUBSET:.doxy=.tag) clean: -rm -rf $(FULL:.doxy

[Mesa-dev] [PATCH shader-db 1/3] Makefile: avoid undefined reference build errors with LIBS

Signed-off-by: Rhys Kidd --- .gitignore | 1 + Makefile | 14 +++--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index f69750a..cffa19c 100644 --- a/.gitignore +++ b/.gitignore @@ -1,2 +1,3 @@ bin run +*.o diff --git a/Makefile b/Makefile

[Mesa-dev] [PATCH shader-db 0/3] Makefile and documentation cleanup

tring' /home/usera/Coding/shader-db/run.c:478: undefined reference to `epoxy_glGetString' /home/usera/Coding/shader-db/run.c:417: undefined reference to `epoxy_glGetIntegerv' /home/usera/Coding/shader-db/run.c:426: undefined reference to `epoxy_glGetStringi' /home/user

[Mesa-dev] [PATCH shader-db 2/3] docs: Improve dependencies documentation

Signed-off-by: Rhys Kidd --- README | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/README b/README index e301d0e..6ed3244 100644 --- a/README +++ b/README @@ -47,7 +47,18 @@ ST_DEBUG=precompile R600_DEBUG=ps,vs,gs,precompile ./run shaders -1 2> new-

[Mesa-dev] [PATCH shader-db 3/3] docs: Add symbolic link generation step

Signed-off-by: Rhys Kidd --- README | 5 + 1 file changed, 5 insertions(+) diff --git a/README b/README index 6ed3244..03be4e7 100644 --- a/README +++ b/README @@ -60,6 +60,11 @@ Build with: make ``` +run.py relies on a symbolic link to a built piglit bin directory, as follows: +``` +ln

Re: [Mesa-dev] [PATCH shader-db 0/3] Makefile and documentation cleanup

On Sunday, 11 October 2015, Matt Turner wrote: > On Sat, Oct 10, 2015 at 10:30 PM, Rhys Kidd > wrote: > > Patchset adds Makefile and documentation improvements. > > > > I aimed to write these as I would have found most helpful when seeking to > > understand shader

Re: [Mesa-dev] [PATCH shader-db 0/3] Makefile and documentation cleanup

On 12 October 2015 at 12:09, Matt Turner wrote: > On Sun, Oct 11, 2015 at 4:18 PM, Rhys Kidd wrote: > > On Sunday, 11 October 2015, Matt Turner wrote: > >> > >> On Sat, Oct 10, 2015 at 10:30 PM, Rhys Kidd wrote: > >> > Patchset adds Makefile and docu

[Mesa-dev] [PATCH shader-db v2 1/3] Makefile: avoid undefined reference build errors

Signed-off-by: Rhys Kidd --- v2: Adopt alternative approach to replace LDFLAGS with LDLIBS per discussion with Matt Turner Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 1ae0776..9422b32 100644 --- a/Makefile +++ b/Makefile @@ -21,7

Re: [Mesa-dev] [PATCH shader-db 3/3] docs: Add symbolic link generation step

On 13 October 2015 at 08:54, Matt Turner wrote: > On Sat, Oct 10, 2015 at 10:30 PM, Rhys Kidd wrote: > > Signed-off-by: Rhys Kidd > > --- > > README | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/README b/README > > index 6ed32

[Mesa-dev] [PATCH shader-db v2 2/2] docs: Add symbolic link generation step

Signed-off-by: Rhys Kidd --- README | 5 + 1 file changed, 5 insertions(+) diff --git a/README b/README index 2f83987..cfbc362 100644 --- a/README +++ b/README @@ -55,6 +55,11 @@ Install necessary dependencies on Debian or Ubuntu: sudo apt-get install build-essentials libepoxy-dev libgbm

[Mesa-dev] [PATCH shader-db v2 1/2] docs: Improve dependencies documentation

v2: Reflect feedback from Kenneth Graunke and Matt Turner Signed-off-by: Rhys Kidd --- README | 6 ++ 1 file changed, 6 insertions(+) diff --git a/README b/README index e301d0e..2f83987 100644 --- a/README +++ b/README @@ -49,6 +49,12 @@ ST_DEBUG=precompile R600_DEBUG=ps,vs,gs

Re: [Mesa-dev] [PATCH] etnaviv: Avoid infinite loop in find_frame()

On Sun, Jan 22, 2017 at 1:49 PM Rhys Kidd wrote: > On 20 January 2017 at 17:06, Christian Gmeiner < > christian.gmei...@gmail.com> wrote: > > Hi Rhys, > > 2017-01-19 7:02 GMT+01:00 Rhys Kidd : > > Use of unsigned loop control variable with '>= 0' woul

Re: [Mesa-dev] [PATCH 3/5] travis: correct libdrm required regex to also track libdrm itself

On 2 February 2017 at 02:53, Andres Gomez wrote: > LGTM > > Reviewed-by: Andres Gomez > Reviewed-by: Rhys Kidd > > On Wed, 2017-02-01 at 22:30 +, Emil Velikov wrote: > > From: Emil Velikov > > > > The current regex was tracking only the libdrm

[Mesa-dev] [PATCH] glsl/tests: Add UINT64 and INT64 types

tch [-Wswitch] Fixes: 8ce53d4a2f3 ("glsl: Add basic ARB_gpu_shader_int64 types") Signed-off-by: Rhys Kidd --- src/compiler/glsl/tests/uniform_initializer_utils.cpp | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/compiler/glsl/tests/uniform_initializer_utils.cpp b

Re: [Mesa-dev] [PATCH] glsl/tests: Add UINT64 and INT64 types

On Mon, Feb 13, 2017 at 9:43 AM Elie Tournier wrote: > Seems good to me. > > Reviewed-by: Elie Tournier > Thanks Elie. Given we are both "new-er" Mesa contributors I might wait for one more Reviewed-by before asking for it to be merged. > On Sat, Feb 11, 2017 at 05

Re: [Mesa-dev] [PATCH] travis: bring the scons build on par with AppVeyor

On 16 February 2017 at 09:09, Emil Velikov wrote: > From: Emil Velikov > > Namely, always build with LLVM and run the check target. > > Cc: Rhys Kidd > Cc: Eric Anholt > Signed-off-by: Emil Velikov > Gets my Reviewed-by: Rhys Kidd I had a similar testing branch [

[Mesa-dev] [PATCH 00/21] Resolve GCC sign-compare warnings patchset

piglit regressions on ILK. Rhys Kidd (21): i965: Resolve GCC sign-compare warning. i965: Resolve GCC sign-compare warning. i965: Resolve GCC sign-compare warning. i965: Resolve GCC sign-compare warning. mesa: Resolve GCC sign-compare warning. i965: Resolve GCC sign-compare warning

[Mesa-dev] [PATCH 03/21] i965: Resolve GCC sign-compare warning.

orDrawBuffers; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/intel_fbo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c b/src/mesa/drivers/dri/i965/intel_fbo.c index 87ba624..ab53603 100644 --- a/src/mesa/

[Mesa-dev] [PATCH 04/21] i965: Resolve GCC sign-compare warning.

orDrawBuffers; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/intel_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 147fa1e..f1b9ba9 100644 --- a/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 10/21] mesa/gbm: Resolve GCC sign-compare warning.

: In function '_gbm_create_device': mesa/src/gbm/main/backend.c:95:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(backends) && dev == NULL; ++i) { ^ Signed-off-by: Rhys Kidd --- src/gbm/main/bac

[Mesa-dev] [PATCH 14/21] i965: Resolve GCC sign-compare warning.

; nr_prims; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_primitive_restart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_primitive_restart.c b/src/mesa/drivers/dri/i965/brw_primitive_restart.c index 2c7a7e8..6

[Mesa-dev] [PATCH 12/21] i965: Resolve GCC sign-compare warning.

^ mesa/src/mesa/drivers/dri/i965/brw_draw.c:636:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < brw->vb.nr_enabled; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_draw.c | 2 +- 1 file chan

[Mesa-dev] [PATCH 18/21] i965: Resolve GCC sign-compare warning.

AtomicBuffers; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c index

[Mesa-dev] [PATCH 05/21] mesa: Resolve GCC sign-compare warning.

Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/common/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/common/utils.c b/src/mesa/drivers/dri/common/utils.c index b51b263..4ff71cc 100644 --- a/src/mesa/drivers/dri/common/utils.c +++ b/src/mesa/drive

[Mesa-dev] [PATCH 11/21] mesa/egl: Resolve GCC sign-compare warning.

ARRAY_SIZE(dri2_surf->color_buffers); i++) ^ Signed-off-by: Rhys Kidd --- src/egl/drivers/dri2/platform_drm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/egl/drivers/dri2/platform_drm.c index

[Mesa-dev] [PATCH 02/21] i965: Resolve GCC sign-compare warning.

ColorDrawBuffers; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_wm_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_state.c b/src/mesa/drivers/dri/i965/brw_wm_state.c index 0cd4390..2708919 100644 ---

[Mesa-dev] [PATCH 08/21] mesa/glx: Resolve GCC sign-compare warning.

mesa/src/glx/dri_common.c: In function 'scalarEqual': mesa/src/glx/dri_common.c:259:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(attribMap); i++) ^ Signed-off-by: Rhys Kidd --- src/glx/dri

[Mesa-dev] [PATCH 01/21] i965: Resolve GCC sign-compare warning.

orDrawBuffers; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index b5ef276..d57f502 100644 --- a/src/mesa/

[Mesa-dev] [PATCH 09/21] mesa/glx: Resolve GCC sign-compare warning.

derer_map); i++) ^ Signed-off-by: Rhys Kidd --- src/glx/dri_common_query_renderer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/dri_common_query_renderer.c b/src/glx/dri_common_query_renderer.c index b3e107d..2e7e12c 100644 --- a/src/glx/dri_common_query_ren

[Mesa-dev] [PATCH 15/21] i965: Resolve GCC sign-compare warning.

ache->size; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_state_cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_state_cache.c b/src/mesa/drivers/dri/i965/brw_state_cache.c index 693441c..a849f4c 100644 --- a/src/mesa/

[Mesa-dev] [PATCH 19/21] i965: Resolve GCC sign-compare warning.

r_pull_params; i++) { ^ mesa/src/mesa/drivers/dri/i965/brw_vs_surface_state.c:89:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ALIGN(prog_data->nr_pull_params, 4) / 4; i++) { ^ Signed-off-b

[Mesa-dev] [PATCH 16/21] i965: Resolve GCC sign-compare warning.

[level].depth; q++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_tex_layout.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c b/src/mesa/drivers/dri/i965/brw_tex_layout.c index fb78b08..d3db2e5

[Mesa-dev] [PATCH 13/21] i965: Resolve GCC sign-compare warning.

son between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < nr_uploads; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_draw_upload.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 06/21] i965: Resolve GCC sign-compare warning.

t;Attachment); i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/intel_fbo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c b/src/mesa/drivers/dri/i965/intel_fbo.c index ab53603..5e4a999 100644 --- a/src/mesa/drivers/dri/i965/i

[Mesa-dev] [PATCH 07/21] i965: Resolve GCC sign-compare warning.

ning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < ARRAY_SIZE(formats); i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/intel_screen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) di

[Mesa-dev] [PATCH 17/21] i965: Resolve GCC sign-compare warning.

UniformBlocks; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c index

[Mesa-dev] [PATCH 20/21] i965: Resolve GCC sign-compare warning.

>nr_params; i++) { ^ mesa/src/mesa/drivers/dri/i965/gen6_vs_state.c:92:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < prog_data->nr_params; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/gen

[Mesa-dev] [PATCH 21/21] i965/gen7: Resolve GCC sign-compare warning.

gt;NumOutputs; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/gen7_sol_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/gen7_sol_state.c b/src/mesa/drivers/dri/i965/gen7_sol_state.c index 41573a8..8f0aebb

Re: [Mesa-dev] [PATCH 13/21] i965: Resolve GCC sign-compare warning.

ll push as part of a V2 of this patchset. On 6 August 2015 at 02:07, Ian Romanick wrote: > On 08/02/2015 11:09 PM, Rhys Kidd wrote: > > mesa/src/mesa/drivers/dri/i965/brw_draw_upload.c: In function > 'brw_prepare_vertices': > > mesa/src/mesa/drivers/dri/i965/brw_draw_

[Mesa-dev] [PATCH v2 00/21] Resolve GCC sign-compare warnings patchset

piglit regressions on ILK. v2: Thanks to code review by Matt Turner and Ian Romanick. Rhys Kidd (21): i965: Resolve GCC sign-compare warning. i965: Resolve GCC sign-compare warning. i965: Resolve GCC sign-compare warning. i965: Resolve GCC sign-compare warning. mesa: Resolve GCC sign

[Mesa-dev] [PATCH v2 02/21] i965: Resolve GCC sign-compare warning.

ColorDrawBuffers; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_wm_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_state.c b/src/mesa/drivers/dri/i965/brw_wm_state.c index 0cd4390..cd0b56b 100644 ---

[Mesa-dev] [PATCH v2 01/21] i965: Resolve GCC sign-compare warning.

orDrawBuffers; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index 9113d0f..e61bfb9 100644 --- a/src/mesa/

[Mesa-dev] [PATCH v2 03/21] i965: Resolve GCC sign-compare warning.

orDrawBuffers; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/intel_fbo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c b/src/mesa/drivers/dri/i965/intel_fbo.c index 87ba624..ab53603 100644 --- a/src/mesa/

[Mesa-dev] [PATCH v2 09/21] mesa/glx: Resolve GCC sign-compare warning.

derer_map); i++) ^ Signed-off-by: Rhys Kidd --- src/glx/dri_common_query_renderer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glx/dri_common_query_renderer.c b/src/glx/dri_common_query_renderer.c index b3e107d..ebeedc9 100644 --- a/src/glx/dri_common_query_ren

[Mesa-dev] [PATCH v2 15/21] i965: Resolve GCC sign-compare warning.

ache->size; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_state_cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_state_cache.c b/src/mesa/drivers/dri/i965/brw_state_cache.c index 693441c..2eae6fb 100644 --- a/src/mesa/

[Mesa-dev] [PATCH v2 21/21] i965/gen7: Resolve GCC sign-compare warning.

gt;NumOutputs; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/gen7_sol_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/gen7_sol_state.c b/src/mesa/drivers/dri/i965/gen7_sol_state.c index 41573a8..8cd2fc4

[Mesa-dev] [PATCH v2 12/21] i965: Resolve GCC sign-compare warning.

^ mesa/src/mesa/drivers/dri/i965/brw_draw.c:636:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < brw->vb.nr_enabled; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_draw.c | 2 +- 1 file chan

[Mesa-dev] [PATCH v2 11/21] mesa/egl: Resolve GCC sign-compare warning.

ARRAY_SIZE(dri2_surf->color_buffers); i++) ^ Signed-off-by: Rhys Kidd --- src/egl/drivers/dri2/platform_drm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/egl/drivers/dri2/platform_drm.c index

[Mesa-dev] [PATCH v2 18/21] i965: Resolve GCC sign-compare warning.

AtomicBuffers; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c index

[Mesa-dev] [PATCH v2 04/21] i965: Resolve GCC sign-compare warning.

orDrawBuffers; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/intel_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index 147fa1e..c645b26 100644 --- a/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH v2 07/21] i965: Resolve GCC sign-compare warning.

ning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < ARRAY_SIZE(formats); i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/intel_screen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) di

[Mesa-dev] [PATCH v2 17/21] i965: Resolve GCC sign-compare warning.

UniformBlocks; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c index

[Mesa-dev] [PATCH v2 19/21] i965: Resolve GCC sign-compare warning.

r_pull_params; i++) { ^ mesa/src/mesa/drivers/dri/i965/brw_vs_surface_state.c:89:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ALIGN(prog_data->nr_pull_params, 4) / 4; i++) { ^ Signed-off-b

[Mesa-dev] [PATCH v2 06/21] i965: Resolve GCC sign-compare warning.

t;Attachment); i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/intel_fbo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c b/src/mesa/drivers/dri/i965/intel_fbo.c index ab53603..d7aba12 100644 --- a/src/mesa/drivers/dri/i965/i

[Mesa-dev] [PATCH v2 14/21] i965: Resolve GCC sign-compare warning.

; nr_prims; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_primitive_restart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_primitive_restart.c b/src/mesa/drivers/dri/i965/brw_primitive_restart.c index 2c7a7e8..2

[Mesa-dev] [PATCH v2 20/21] i965/gen6: Resolve GCC sign-compare warning.

>nr_params; i++) { ^ mesa/src/mesa/drivers/dri/i965/gen6_vs_state.c:92:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < prog_data->nr_params; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/gen

[Mesa-dev] [PATCH v2 13/21] i965: Resolve GCC sign-compare warning.

son between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < nr_uploads; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_draw_upload.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src

[Mesa-dev] [PATCH v2 05/21] mesa: Resolve GCC sign-compare warning.

Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/common/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/common/utils.c b/src/mesa/drivers/dri/common/utils.c index b51b263..43d90d9 100644 --- a/src/mesa/drivers/dri/common/utils.c +++ b/src/mesa/drive

[Mesa-dev] [PATCH v2 08/21] mesa/glx: Resolve GCC sign-compare warning.

mesa/src/glx/dri_common.c: In function 'scalarEqual': mesa/src/glx/dri_common.c:259:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(attribMap); i++) ^ Signed-off-by: Rhys Kidd --- src/glx/dri

[Mesa-dev] [PATCH v2 10/21] mesa/gbm: Resolve GCC sign-compare warning.

: In function '_gbm_create_device': mesa/src/gbm/main/backend.c:95:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ARRAY_SIZE(backends) && dev == NULL; ++i) { ^ Signed-off-by: Rhys Kidd --- src/gbm/main/bac

[Mesa-dev] [PATCH v2 16/21] i965: Resolve GCC sign-compare warning.

[level].depth; q++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_tex_layout.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c b/src/mesa/drivers/dri/i965/brw_tex_layout.c index fb78b08..8eac3be

Re: [Mesa-dev] [PATCH v2 21/21] i965/gen7: Resolve GCC sign-compare warning.

xing warnings, and not making things worse) > Either way the series is: > > Reviewed-by: Thomas Helland > > Someone else needs to push these for you (?). > AFAIK you don't have commit access, and neither do I. > > 2015-08-06 8:34 GMT+02:00 Rhys Kidd : > &

[Mesa-dev] [PATCH] docs: Update todo regarding StencilOp and StencilOpSeparate.

. Also better respect the 80 character suggested line length in this file. Signed-off-by: Rhys Kidd --- src/mesa/main/stencil.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/stencil.c b/src/mesa/main/stencil.c index 2a19a17..385a6d0 100644 --- a

Re: [Mesa-dev] [PATCH] docs: Update todo regarding StencilOp and StencilOpSeparate.

On 8 August 2015 at 15:09, Rhys Kidd wrote: > OpenGL 2.0 function StencilOp() is in part internally implemented via > StencilOpSeparate(). This change happened some time ago, however the > accompanying doxygen todo comment was not accordingly updated. > > Replace the outdated

[Mesa-dev] [PATCH v2] docs: Update todo regarding StencilOp and StencilOpSeparate.

. Also better respect the 80 character suggested line length in this file. v2: Fully remove comment, following code review by t_arc...@yahoo.com.au Signed-off-by: Rhys Kidd --- src/mesa/main/stencil.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/mesa

Re: [Mesa-dev] [PATCH] vulkan: Initial partial documentation for Vulkan internals.

On 14 October 2016 at 10:36, wrote: > From: Kevin Rogovin > > A main page ala Doxygen together with a Doxygen file added. > In addition, documentation for portions of anv_private.h: > - placing portions into doxygen groups > - some cross linking doxygen style to other files > Hello Kevin, Th

Re: [Mesa-dev] [PATCH 0/4] Travis CI build fixes

> ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > The series gets my Reviewed-by: Rhys Kidd ___ mesa-dev mailing list me

[Mesa-dev] [PATCH] gallium/ttn: Remove duplicated TGSI_OPCODE_DP2A initialization

Duplicate line is currently on 1535. Identified by Clang, when run through Eric Anholt's Travis harness. Signed-off-by: Rhys Kidd --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliar

[Mesa-dev] [PATCH 1/2] r600g: Avoid duplicated initialization of TGSI_OPCODE_DFMA

: https://bugs.freedesktop.org/show_bug.cgi?id=96782 Fixes: 54c4d525da7c7fc1e103d7a3e6db015abb132d5d ("r600g: Enable FMA on chips that support it") Signed-off-by: Jan Vesely Tested-by: James Harvey Signed-off-by: Marek Olšák Signed-off-by: Rhys Kidd --- src/galli

[Mesa-dev] [PATCH 2/2] r600g: Clean up defined magic numbers for TGSI opcodes

Small code clean up that removes magic numbers where a TGSI opcode has been defined. No functional change expected as each opcode is unsupported on the respective hardware. Signed-off-by: Rhys Kidd --- src/gallium/drivers/r600/r600_shader.c | 14 +++--- src/gallium/include/pipe

[Mesa-dev] [PATCH 0/2] r600g: Pair of small code clean ups with TGSI

re to test this so would appreciated Tested-by's. I do not have commit rights to fd.o so after R-B would appreciate if the reviewer(s) could push to master. Rhys Kidd (2): r600g: Avoid duplicated initialization of TGSI_OPCODE_DFMA r600g: Clean up defined magic numbers for TGSI opcode

Re: [Mesa-dev] [PATCH 1/2] r600g: Avoid duplicated initialization of TGSI_OPCODE_DFMA

On Saturday, August 27, 2016, Jan Vesely wrote: > On Sat, 2016-08-27 at 12:05 -0400, Rhys Kidd wrote: > > As reported by Clang, TGSI_OPCODE_DFMA (defined magic number 118) is > > currently initialized twice for Cayman and Evergreen. > > When Jan Vesely added double precis

Re: [Mesa-dev] [PATCH 0/2] r600g: Pair of small code clean ups with TGSI

On Monday, August 29, 2016, James Harvey wrote: > Hi Rhys, > > I ran piglit on my Evergreen HD5850 with your patches. > > No regressions here. > > Tested-by: James Harvey Thanks James. > > Thanks, > James > > > On 08/27/2016 09:05 AM, Rhys Kidd wrote

Re: [Mesa-dev] [PATCH 2/2] r600g: Clean up defined magic numbers for TGSI opcodes

On Monday, August 29, 2016, Marek Olšák wrote: > For the series: > > Reviewed-by: Marek Olšák > > > Marek Thanks Marek. As I don't have commit access, when you have a moment I would appreciate if you could please push to master. Regards, Rhys > > On Sat, Aug 2

Re: [Mesa-dev] Proposal: move the Mesa documentation to readthedocs.org

On 27 August 2016 at 01:09, Nicholas Bishop wrote: > Hi, > > I'd like to propose a conversion of Mesa's documentation to > reStructuredText (RST) and hosting the result on readthedocs.org. The > intent is to make Mesa's documentation more accessible, searchable, and > easier to edit. > > I put to

[Mesa-dev] [PATCH] glsl: Add pthread libs to cache_test

Fixes the following compile error: CCLD glsl/tests/cache-test glsl/.libs/libglsl.a(libmesautil_la-mesa-sha1.o): In function `call_once': /mesa/src/util/../../include/c11/threads_posix.h:96: undefined reference to `pthread_once' Signed-off-by: Rhys Kidd --- src/compiler/Makefi

[Mesa-dev] [PATCH v2] glsl: Add pthread libs to cache_test

ned-off-by: Rhys Kidd --- v2: Add additional comment to the commit message (Timothy Arceri) src/compiler/Makefile.glsl.am | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compiler/Makefile.glsl.am b/src/compiler/Makefile.glsl.am index 80dfb73..15bea6b 100644 --- a/sr

Re: [Mesa-dev] [PATCH v2] glsl: Add pthread libs to cache_test

On 26 October 2016 at 00:47, Timothy Arceri wrote: > Reviewed-by: Timothy Arceri > > I guess you don't have commit access? > I do not have commit access, so would appreciate if you could please push to master. > > On Wed, 2016-10-26 at 00:13 -0400, Rhys Kidd wrote:

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Make sure display is initialized before using it

Whilst I don't know that code as well as I'd like. It does get my Tested-by: Rhys Kidd for fixing that piglit on i965 ILK. Thanks for the two patches! On 15 July 2016 at 04:28, Nicolas Boichat wrote: > android.opengl.cts.WrapperTest#testGetIntegerv1 CTS test calls > eglTermin

[Mesa-dev] [MR] nv50, nvc0: add missing CAPs for unsupported features

nouveau warns on unhandled pipe CAPs, including where they may be set by u_pipe_screen_get_param_defaults() This patch avoids spurious text in debug outputs, e.g. when running piglit. https://gitlab.freedesktop.org/mesa/mesa/merge_requests/133 Rhys ___

[Mesa-dev] [PATCH] nv50, nvc0: add missing CAPs for unsupported features

Signed-off-by: Rhys Kidd --- src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_screen.c b/src/gallium/drivers/nouveau/nv50/nv50_screen.c index

[Mesa-dev] [PATCH 00/15] Resolve further GCC sign-compare warnings

be pedantic. Unlikely to be any performance improvements, however code quality is enhanced. $ gcc --version gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2 No piglit regressions on Ironlake. Rhys Kidd (15): glsl: Resolve GCC sign-compare warning. glsl: Resolve GCC sign-compare warning. glsl: Resolve

[Mesa-dev] [PATCH 04/15] glsl: Resolve GCC sign-compare warning.

mesa/src/glsl/nir/nir_search.c: In function 'match_value': mesa/src/glsl/nir/nir_search.c:84:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < num_components; ++i) ^ Signed-off-by: Rhys Kidd ---

[Mesa-dev] [PATCH 03/15] glsl: Resolve GCC sign-compare warning.

srcs; proj_index++) { ^ mesa/src/glsl/nir/nir_lower_tex_projector.c:57:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (proj_index == tex->num_srcs) ^ Signed-off-by: Rhys Kidd

[Mesa-dev] [PATCH 05/15] glsl: Resolve GCC sign-compare warning.

mesa/src/glsl/nir/nir_search.c: In function 'match_value': mesa/src/glsl/nir/nir_search.c:110:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < num_components; ++i) { ^ Signed-off-

[Mesa-dev] [PATCH 06/15] glsl: Resolve GCC sign-compare warning.

mesa/src/glsl/nir/nir_search.c: In function 'match_value': mesa/src/glsl/nir/nir_search.c:139:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (i < num_components) ^ Signed-off-by: Rhys Kidd ---

[Mesa-dev] [PATCH 02/15] glsl: Resolve GCC sign-compare warning.

->num_srcs; i++) { ^ Signed-off-by: Rhys Kidd --- src/glsl/nir/nir_lower_tex_projector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_lower_tex_projector.c b/src/glsl/nir/nir_lower_tex_projector.c index 19f1bbd..3ad3450 10064

[Mesa-dev] [PATCH 07/15] mesa: Resolve GCC sign-compare warning.

t;NumTemporaries; i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/program/prog_to_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/program/prog_to_nir.c b/src/mesa/program/prog_to_nir.c index fccd16f..ec61100 100644 --- a/src/mesa/program/prog_to_nir.c +++ b/src/mesa/pr

[Mesa-dev] [PATCH 08/15] i965: Resolve GCC sign-compare warning.

dex_table); i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_eu_compact.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c b/src/mesa/drivers/dri/i965/brw_eu_compact.c index 67f0b45..ea1ae25

[Mesa-dev] [PATCH 01/15] glsl: Resolve GCC sign-compare warning.

->num_srcs; i++) { ^ Signed-off-by: Rhys Kidd --- src/glsl/nir/nir_lower_tex_projector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_lower_tex_projector.c b/src/glsl/nir/nir_lower_tex_projector.c index 8a482b1..19f1bbd 100644 --- a/src/glsl/nir/nir_lower

[Mesa-dev] [PATCH 14/15] i965: Resolve GCC sign-compare warning.

vel[level].depth; ++layer) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index caf7388..e0ed

[Mesa-dev] [PATCH 10/15] i965: Resolve GCC sign-compare warning.

Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_state_dump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_state_dump.c b/src/mesa/drivers/dri/i965/brw_state_dump.c index b6f4d59..0c974c4 100644 --- a/src/mesa/drivers/dri/i965/brw

[Mesa-dev] [PATCH 12/15] i965/gen7: Resolve GCC sign-compare warning.

; level <= mt->last_level; ++level) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/me

[Mesa-dev] [PATCH 11/15] i965: Resolve GCC sign-compare warning.

ned-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_state_upload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.c b/src/mesa/drivers/dri/i965/brw_state_upload.c index b2ca9c2..01c0900 100644 --- a/src/mesa/driver

[Mesa-dev] [PATCH 09/15] i965: Resolve GCC sign-compare warning.

dex_table); i++) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/brw_eu_compact.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c b/src/mesa/drivers/dri/i965/brw_eu_compact.c index ea1ae25..b798931 100

[Mesa-dev] [PATCH 13/15] i965/gen8: Resolve GCC sign-compare warning.

; level <= mt->last_level; ++level) { ^ Signed-off-by: Rhys Kidd --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/me

[Mesa-dev] [PATCH 15/15] glsl: Resolve GCC sign-compare warning.

^ Signed-off-by: Rhys Kidd --- src/glsl/nir/nir_opt_peephole_ffma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_opt_peephole_ffma.c b/src/glsl/nir/nir_opt_peephole_ffma.c index a823adb..97538e5 100644 --- a/src/glsl/nir/nir_opt_peephole_ffma.c +++ b

[Mesa-dev] [PATCH 0/4] Resolve GCC missing field initializer warnings

, easily reviewed, discrete improvements. This patchset resolves a number of warnings reported by GCC when configured to be pedantic. $ gcc --version gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2 No piglit regressions on Ironlake. Rhys Kidd (4): mesa: Resolve GCC missing field initializer warning. mesa

  1   2   3   >