Re: [Mesa-dev] [PATCH 13/16] nvc0: enable compute support by default on Fermi

2015-10-17 Thread Jan Vesely
Does this mean it should be possible to hook up clover with nouveau? Jan On Fri, 2015-10-16 at 19:22 +0200, Samuel Pitoiset wrote: > Compute support was not enabled by default because weird effects > on 3D state happened, but I can't reproduce them anymore. > > This also enables MP performance c

Re: [Mesa-dev] [PATCH 13/16] nvc0: enable compute support by default on Fermi

2015-10-17 Thread Jan Vesely
h even if someone did the work" to "it's feasible if you find someone with plenty of time on his/her hands" is still nice. Jan > > On Sat, Oct 17, 2015 at 3:11 PM, Jan Vesely > wrote: > > Does this mean it should be possible to hook up clover with > > nouv

Re: [Mesa-dev] [PATCH 13/16] nvc0: enable compute support by default on Fermi

2015-10-18 Thread Jan Vesely
On Sat, 2015-10-17 at 16:34 -0400, Ilia Mirkin wrote: > On Sat, Oct 17, 2015 at 4:31 PM, Ilia Mirkin > wrote: > > On Sat, Oct 17, 2015 at 4:24 PM, Jan Vesely > > wrote: > > > On Sat, 2015-10-17 at 15:24 -0400, Ilia Mirkin wrote: > > > > "compute"

Re: [Mesa-dev] [PATCH] nouveau: avoid queueing too much work onto a single fence

2015-11-05 Thread Jan Vesely
On Fri, 2015-11-06 at 00:46 -0500, Ilia Mirkin wrote: > Force the fence to get kicked off, which won't actually wait for its > completion, but any additional work will be put onto a fresh list. > > This fixes crashes in teximage-colors --benchmark with too many > active > maps. > > Signed-off-by:

Re: [Mesa-dev] [PATCH 2/3] mesa: Add initializer macros to fix missing initializer warnings

2015-01-22 Thread Jan Vesely
On Wed, 2015-01-21 at 15:55 -0800, Matt Turner wrote: > On Wed, Jan 21, 2015 at 3:49 PM, Jan Vesely wrote: > > On Wed, 2015-01-21 at 12:34 -0800, Ian Romanick wrote: > >> On 01/21/2015 10:33 AM, Jan Vesely wrote: > >> > NFC. > >> > >> NFC? I'm

Re: [Mesa-dev] [PATCH] configure: Link against all LLVM targets when building clover

2015-01-24 Thread Jan Vesely
already had Tom's rb. you can add mine as well Reviewed-by: Jan Vesely > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 1cce517..2b7f576 100644 > --- a/configure.ac > +++ b/

Re: [Mesa-dev] [PATCH] configure: Link against all LLVM targets when building clover

2015-01-25 Thread Jan Vesely
On Sun, 2015-01-25 at 01:02 +0100, Niels Ole Salscheider wrote: > On Saturday 24 January 2015, 18:24:16, Jan Vesely wrote: > > On Sat, 2015-01-24 at 22:49 +0100, Niels Ole Salscheider wrote: > > > Since 8e7df519bd8556591794b2de08a833a67e34d526, we initialise all targets > >

[Mesa-dev] [PATCH 1/1] clover: Fix build with llvm after r226981

2015-01-25 Thread Jan Vesely
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88783 Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm

Re: [Mesa-dev] [PATCH] st/nine: Mark end of non-void function unreachable

2015-02-09 Thread Jan Vesely
case D3DFMT_INTZ: > return PIPE_BIND_DEPTH_STENCIL | PIPE_BIND_SAMPLER_VIEW; > -default: assert(0); > +default: unreachable(0); Isn't unreachable supposed to use a string instead of 0? > } > } > -- Jan Vesely sign

Re: [Mesa-dev] [PATCH 6/6] i965: Don't write past the end of the application supplied buffer

2015-02-28 Thread Jan Vesely
S; > -data[offset++] = i; > -*((uint64_t *) (&data[offset])) = > monitor->pipeline_stats_results[i]; > -offset += 2; > +if (data + 4 <= data_end) { Same here. > + data[offset++] = PIPELINE_STATS_COUNTERS; >

Re: [Mesa-dev] [PATCH 5/6] i965: Silence unused parameter warning

2015-02-28 Thread Jan Vesely
solution for this, but > it's really elegant. and it's also illegal in C (only allowed in C++) see 6.9.1 of c specs jan > > -Carl > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freede

Re: [Mesa-dev] replace __FUNCTION__ with __func__ task

2015-03-03 Thread Jan Vesely
t; > > _______ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 6/6] i965: Don't write past the end of the application supplied buffer

2015-03-04 Thread Jan Vesely
e calculation. Noticed by Jan. > > Signed-off-by: Ian Romanick > Cc: Kenneth Graunke > Cc: Jan Vesely > --- > src/mesa/drivers/dri/i965/brw_performance_monitor.c | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/src/mesa/d

Re: [Mesa-dev] [PATCH] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG

2015-03-05 Thread Jan Vesely
ce_id d_dev, cl_device_info param, >break; > > case CL_DEVICE_SINGLE_FP_CONFIG: > + // This is the "mandated minimum single precision floating-point > + // capability" OCL 1.2 adds: "for devices that are not of type CL_DEVICE_TYPE_CUSTOM" Reviewed-

Re: [Mesa-dev] [PATCH 1/2] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG v2

2015-03-06 Thread Jan Vesely
. jan >buf.as_scalar() = > - CL_FP_DENORM | CL_FP_INF_NAN | CL_FP_ROUND_TO_NEAREST; > + CL_FP_INF_NAN | CL_FP_ROUND_TO_NEAREST; >break; > > case CL_DEVICE_DOUBLE_FP_CONFIG: -- Jan Vesely signature.asc Description: This is a digitally signe

Re: [Mesa-dev] [PATCH] util/disk_cache: fix d7b3707c612

2017-02-13 Thread Jan Vesely
On Sat, 2017-02-11 at 22:32 +1100, Timothy Arceri wrote: > I forgot to error check stat() and also I wasn't using the subdir in > is_two_character_sub_directory(). can you (mostly) swap title and description? git id is better in Fixes: tag and makes title rather non-descriptive. thanks, Jan > >

[Mesa-dev] [PATCH 1/1] clover: Dump linked module to a different file

2017-02-22 Thread Jan Vesely
This allows to pass the generated files directly to llc or bugpoint. Note that if program links multiple binaries they will still be in the same file, the module name is "link". Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 4 ++-- 1 file

[Mesa-dev] [PATCH v2 1/1] clover: Dump linked binary to a different file

2017-02-24 Thread Jan Vesely
this allows to pass the generated files directly to llc or bugpoint v2: add atomic counter ID Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/clover/llvm

Re: [Mesa-dev] [PATCH 02/24] gallivm, ac: add writeonly and inaccessiblememonly attributes

2017-02-25 Thread Jan Vesely
On Sun, 2017-02-26 at 00:58 +0100, Marek Olšák wrote: > From: Marek Olšák > > --- > src/amd/common/ac_llvm_util.c | 2 ++ > src/amd/common/ac_llvm_util.h | 2 ++ > src/gallium/auxiliary/gallivm/lp_bld_intr.c | 2 ++ > src/gallium/auxiliary/gallivm/lp_bld_intr.h | 2 ++

Re: [Mesa-dev] [PATCH] r600: add amdgpuinfo to the llvm required module list

2017-02-27 Thread Jan Vesely
if test "x$enable_llvm" = xyes -o "x$enable_opencl" = xyes; then > radeon_llvm_check $LLVM_REQUIRED_R600 "r600" > - > -llvm_add_component "asmparser" "r600" > -llvm_add_component "bitreader&

Re: [Mesa-dev] [PATCH v2 1/1] clover: Dump linked binary to a different file

2017-02-27 Thread Jan Vesely
On Sat, 2017-02-25 at 20:46 -0800, Francisco Jerez wrote: > Jan Vesely writes: > > > this allows to pass the generated files directly to llc or bugpoint > > > > v2: add atomic counter ID > > > > Signed-off-by: Jan Vesely > > --- > > src/galli

Re: [Mesa-dev] [PATCH 2/2] clover: pass image attributes to the kernel

2015-08-03 Thread Jan Vesely
gt; + > >>> +typename module::argument::type marg_type; > >>> + if (is_image2d && is_read_only) { > >>> + marg_type = module::argument::image2d_rd; > >>> +} else if (is_image2d && is_

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-04 Thread Jan Vesely
> + auto ty = get_operand_checked(kernel_node, 3, "kernel_arg_type", > +num_args + 1); > >std::vector res; >res.reserve(num_args); -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] clover: fix llvm 3.5 build error

2015-08-05 Thread Jan Vesely
ailure only builds the state tracker with no usable pipe drivers. jan > > On Wed, Aug 5, 2015 at 5:21 AM, Jan Vesely > wrote: > > On Tue, 2015-08-04 at 22:40 +0200, Zoltan Gilian wrote: > > > There is no MDOperand in llvm 3.5. > > > > thanks, this fixes the bu

Re: [Mesa-dev] [PATCH] util: use GCC atomic intrinsics with explicit memory model

2016-10-04 Thread Jan Vesely
On Tue, 2016-10-04 at 16:14 +0200, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This is motivated by the fact that p_atomic_read and p_atomic_set may > somewhat surprisingly not do the right thing in the old version: > while > stores and loads are de facto atomic at least on x86, afaik, this

Re: [Mesa-dev] [PATCH] clover: Allow OpenCL version override

2016-10-06 Thread Jan Vesely
On Thu, 2016-10-06 at 16:26 +0200, Vedran Miletić wrote: > CLOVER_CL_VERSION_OVERRIDE allows overriding default OpenCL version > supported by Clover, analogous to MESA_GL_VERSION_OVERRIDE for > OpenGL. > CLOVER_CL_C_VERSION_OVERRIDE allows overridng default OpenCL C > version. WHat's the use of CL

Re: [Mesa-dev] [PATCH 1/2] clover: support CL_PROGRAM_BINARY_TYPE (CL1.2)

2016-10-06 Thread Jan Vesely
On Fri, 2014-12-19 at 16:42 +0100, EdB wrote: > CL_PROGRAM_BINARY_TYPE have been added to clGetProgramBuildInfo in > CL1.2 > --- >  src/gallium/state_trackers/clover/api/program.cpp  |  4 +++ >  src/gallium/state_trackers/clover/core/program.cpp | 31 > +- >  src/gallium/state_tr

Re: [Mesa-dev] [PATCH v2] clover: Allow OpenCL version override

2016-10-13 Thread Jan Vesely
v2: > - move version getters to version.hpp, simplify > - set -cl-std= to CLOVER_CL_C_VERSION_OVERRIDE > - set __OPENCL_VERSION__ to CLOVER_CL_VERSION_OVERRIDE other than a small nit in docs, LGTM. Reviewed-by: Jan Vesely you probably want Francsisco's RB before pushing it

Re: [Mesa-dev] [PATCH] src: replace RTLD_NOW with RTLD_LAZY

2016-08-06 Thread Jan Vesely
On Sat, 2016-08-06 at 13:00 +0200, ⚛ wrote: > On Sat, Aug 6, 2016 at 4:34 AM, Rob Clark > wrote: > > > > On Fri, Aug 5, 2016 at 8:42 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com> > > wrote: > > > > > > Mesa source code prior to this patch uses both RTLD_NOW and > > > RTLD_LAZY. > > > This patch remove

Re: [Mesa-dev] [PATCH] src: replace RTLD_NOW with RTLD_LAZY

2016-08-06 Thread Jan Vesely
will turn my attention to manifestations of suboptimal Mesa GL in > > other apps as soon as I am satisfied with glxinfo/glxgears (and > > after > > the list of my patches at patchwork gets closer to zero). > > ___ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] src: replace RTLD_NOW with RTLD_LAZY

2016-08-06 Thread Jan Vesely
On Sat, 2016-08-06 at 17:20 +0200, ⚛ wrote: > On Sat, Aug 6, 2016 at 4:32 PM, Jan Vesely > wrote: > > > > sure I can set LD_BIND_NOW > > env var, but there are programs that have much stronger case for > > using > > lazy binding (like LO) that would be n

Re: [Mesa-dev] [PATCH] src: replace RTLD_NOW with RTLD_LAZY

2016-08-06 Thread Jan Vesely
On Sat, 2016-08-06 at 17:34 +0200, ⚛ wrote: > On Sat, Aug 6, 2016 at 4:32 PM, Jan Vesely > wrote: > > > > On Sat, 2016-08-06 at 13:00 +0200, ⚛ wrote: > > > > > > We could add a verifier to the build process that tests the > > > foo_dri.so > >

Re: [Mesa-dev] [PATCH] src: replace RTLD_NOW with RTLD_LAZY

2016-08-06 Thread Jan Vesely
On Sat, 2016-08-06 at 18:52 +0200, ⚛ wrote: > On Sat, Aug 6, 2016 at 5:52 PM, Jan Vesely > wrote: > > > > The situation I'm concerned about is as > > follows: > > 1.) mesa builds fine using existing build environment. > > > > 2.) I update LLVM.

Re: [Mesa-dev] [PATCH] src: replace RTLD_NOW with RTLD_LAZY

2016-08-08 Thread Jan Vesely
On Mon, 2016-08-08 at 08:54 -0700, Ian Romanick wrote: > On 08/05/2016 07:05 PM, ⚛ wrote: > > > > On Sat, Aug 6, 2016 at 3:37 AM, Jan Vesely > > wrote: > > > > > > On Sat, 2016-08-06 at 02:42 +0200, Jan Ziak wrote: > > > > > > > &

Re: [Mesa-dev] [PATCH] gallium: Use enum pipe_shader_type in bind_sampler_states()

2016-08-27 Thread Jan Vesely
On Fri, 2016-08-26 at 17:25 +0100, Eric Engestrom wrote: > On Fri, Aug 26, 2016 at 04:21:14PM +0200, Kai Wasserbäch wrote: > > > > Hey Eric, > > Eric Engestrom wrote on 26.08.2016 15:49: > > > > > > On Fri, Aug 26, 2016 at 03:14:57PM +0200, Kai Wasserbäch wrote: > > > > > > > > Brian Paul wrote

Re: [Mesa-dev] [PATCH 1/2] r600g: Avoid duplicated initialization of TGSI_OPCODE_DFMA

2016-08-27 Thread Jan Vesely
On Sat, 2016-08-27 at 12:05 -0400, Rhys Kidd wrote: > As reported by Clang, TGSI_OPCODE_DFMA (defined magic number 118) is > currently initialized twice for Cayman and Evergreen. > When Jan Vesely added double precision FMA opcode it did make sense > to locate it immediately after TGSI

[Mesa-dev] [PATCH 1/2] gallium: add cap to export device pointer size

2016-08-28 Thread Jan Vesely
Signed-off-by: Jan Vesely --- src/gallium/drivers/ilo/ilo_screen.c | 6 ++ src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 ++ src/gallium/drivers/radeon/r600_pipe_common.c | 8 src/gallium/drivers/softpipe

[Mesa-dev] [PATCH 2/2] clover: Use device cap to query pointer size instead of hardcoded 32bits

2016-08-28 Thread Jan Vesely
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97513 Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/api/device.cpp | 2 +- src/gallium/state_trackers/clover/core/device.cpp | 6 ++ src/gallium/state_trackers/clover/core/device.hpp | 1 + 3 files changed, 8

Re: [Mesa-dev] [PATCH 1/2] gallium: add cap to export device pointer size

2016-08-28 Thread Jan Vesely
r CL1.x, although you might be able to to cheat around this by using cl_ulong/uint. (I haven't looked into details of cl 2.0 SVM) If the window needs to be selected outside of the pointer (config register, instruction immediate, ...) it's still 32bit pointer. I think EG/CM works in a similar wa

[Mesa-dev] [PATCH v2 1/2] gallium: add cap to export device pointer size

2016-08-28 Thread Jan Vesely
v2: document the new cap Signed-off-by: Jan Vesely --- src/gallium/docs/source/screen.rst | 1 + src/gallium/drivers/ilo/ilo_screen.c | 6 ++ src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 ++ src/gallium

Re: [Mesa-dev] [PATCH v2 1/2] gallium: add cap to export device pointer size

2016-08-29 Thread Jan Vesely
On Mon, 2016-08-29 at 14:47 +0200, Marek Olšák wrote: > On Sun, Aug 28, 2016 at 7:57 PM, Jan Vesely > wrote: > > > > v2: document the new cap > > > > Signed-off-by: Jan Vesely > > --- > >  src/gallium/docs/source/screen.rst | 1 +

Re: [Mesa-dev] [PATCH] clover: probe pipe for the value of CL_DEVICE_ADDRESS_BITS

2016-08-29 Thread Jan Vesely
ore/device.hpp > @@ -68,6 +68,7 @@ namespace clover { >   >    std::vector max_block_size() const; >    cl_uint subgroup_size() const; > +  cl_uint address_bits() const; >    std::string device_name() const; >    std::string vendor_name() const; >    enum pipe_shader_ir ir_format() const; -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/clover: Define __OPENCL_VERSION__ on the device side

2016-08-31 Thread Jan Vesely
On Wed, 2016-08-31 at 15:53 +0200, Serge Martin wrote: > On Wednesday 31 August 2016 12:39:23 Vedran Miletić wrote: > > > > On 08/28/2016 04:42 PM, Niels Ole Salscheider wrote: > > > > > > This is required by the OpenCL standard. > > > > > > Signed-off-by: Niels Ole Salscheider > > e.de> > > Re

Re: [Mesa-dev] [PATCH] gallium: fix clang warnings

2016-09-07 Thread Jan Vesely
On Wed, 2016-09-07 at 10:12 +0200, Nicolai Hähnle wrote: > On 07.09.2016 09:38, Michel Dänzer wrote: > > > > On 07/09/16 12:29 AM, Nicolai Hähnle wrote: > > > > > > On 06.09.2016 16:37, Martina Kollarova wrote: > > > > > > > > 1. Variable 'hole' is uninitialized when used here [- > > > > Wuninit

Re: [Mesa-dev] [PATCH v3] clover: Introduce CLOVER_EXTRA_COMPILER_OPTIONS

2016-09-07 Thread Jan Vesely
mp;modules, > enum pipe_shader_ir ir, const std::string > &target, > const std::string &opts, std::string > &r_log) { > -   std::vector options = tokenize(opts + " input.cl"); > +   const std::strin

Re: [Mesa-dev] [PATCH] gallium: fix return value check

2016-09-07 Thread Jan Vesely
EEK_END); > kms_sw_dt->width = width; > kms_sw_dt->height = height; > kms_sw_dt->stride = stride; >   > -   if (kms_sw_dt->size == (off_t)-1) { > -  FREE(kms_sw_dt); > -  return NULL; > -   } > - > lseek(fd, 0, SEEK_SET);

[Mesa-dev] [PATCH 1/1] radeon: Don't check DCC on pipe buffers

2016-09-12 Thread Jan Vesely
Fixes segfaults in EG compute since: commit 21de3be8e62b2b093569a99550e6356ed2f106b4 radeonsi: fix texture format reinterpretation with DCC Signed-off-by: Jan Vesely --- src/gallium/drivers/radeon/r600_texture.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src

Re: [Mesa-dev] [PATCH] gallivm: Fix build after removal of deprecated attribute API

2016-11-07 Thread Jan Vesely
On Mon, 2016-11-07 at 18:44 +, Tom Stellard wrote: > --- > > Build tested only so far. > > src/gallium/auxiliary/draw/draw_llvm.c| 6 +- > src/gallium/auxiliary/gallivm/lp_bld_intr.c | 48 +++- > src/gallium/auxiliary/gallivm/lp_bld_intr.h | 13 - > s

Re: [Mesa-dev] [PATCH] gallivm: Fix build after removal of deprecated attribute API v2

2016-11-07 Thread Jan Vesely
On Mon, 2016-11-07 at 21:06 +, Tom Stellard wrote: > v2: > Fix adding parameter attributes with LLVM < 4.0. > --- > src/gallium/auxiliary/draw/draw_llvm.c| 6 +- > src/gallium/auxiliary/gallivm/lp_bld_intr.c | 52 - > src/gallium/auxiliary/gallivm/lp_bld_in

Re: [Mesa-dev] [PATCH] ac/nir/llvm: adopt to new LLVM attribute API.

2016-11-09 Thread Jan Vesely
coords[2] = emit_llvm_intrinsic(ctx, "llvm.fabs.f32", ctx->f32, > - &coords[2], 1, LLVMReadNoneAttribute); > + &coords[2], 1, AC_FUNC_ATTR_READNONE); > coords[2] = emit_fdiv(ctx, ctx->f32one,

Re: [Mesa-dev] Next Mesa git build error wit latest LLVM version (4.0.0svn).

2016-11-09 Thread Jan Vesely
d of non-void > function [-Wreturn-type] > } > ^ > ac_nir_to_llvm.c: In function 'emit_intrin_2f_param': > ac_nir_to_llvm.c:723:1: warning: control reaches end of non-void > function [-Wreturn-type] > } > ^ > ac_nir_to_llvm.c: In function 'em

Re: [Mesa-dev] [PATCH] clover: adapt to new error API since LLVM r286752

2016-11-14 Thread Jan Vesely
On Mon, 2016-11-14 at 12:17 +0100, Vedran Miletić wrote: > --- > src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/state_trackers/clover/llvm/codegen/bitcode.cpp > b/src/gallium/state_tracker

Re: [Mesa-dev] [PATCH] clover: restore support for LLVM <= 3.9

2016-11-14 Thread Jan Vesely
::string &r_log) { can you merge the ifdef blocks? sharing one line of code is not worth the hit in readability. Jan > +#if HAVE_LLVM >= 0x0400 > +if (::llvm::Error err = mod.takeError()) { > + ::llvm::handleAllErrors(std::move(err), > [&](::llvm::ErrorInfo

Re: [Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

2016-11-16 Thread Jan Vesely
Vedran Miletić LGTM. Reviewed-by: Jan Vesely Jan > --- > .../state_trackers/clover/llvm/codegen/bitcode.cpp | 9 ++- > src/gallium/state_trackers/clover/llvm/compat.hpp | 28 > ++ > 2 files changed, 30 insertions(+), 7 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH v5] clover: restore support for LLVM <= 3.9

2016-11-24 Thread Jan Vesely
def blocks > v3: added support for LLVM 3.6-3.8 > v4: add missing #ifdef around > v5: simplify using templates and lambda > > Signed-off-by: Vedran Miletić > Reviewed-by[v2]: Jan Vesely > Tested-by[v4]: Vinson Lee > Tested-by[v4]: Pierre Moreau > Reviewed-by: Francisco

Re: [Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

2016-11-24 Thread Jan Vesely
s concentrated in the compat layer (llvm/compat.h). Vedran's v5 took that approach. Jan > > Emil > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] swr: [rasterizer jitter] include stdarg.h in builder_misc.cpp

2016-12-02 Thread Jan Vesely
On Fri, 2016-12-02 at 10:53 -0600, Tim Rowley wrote: > Fixes build problem with llvm-svn. > --- > src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/swr/rasterizer/jitter/builder_misc.cpp > b/s

Re: [Mesa-dev] [PATCH] configure.ac: Strip patch version from LLVM version.

2016-12-04 Thread Jan Vesely
-) > > > > > > > > > > diff --git a/configure.ac b/configure.ac > > > > > index f62bc61e5025..3b8b32485ae1 100644 > > > > > --- a/configure.ac > > > > > +++ b/configure.ac > > > > > @@ -2195,7 +2195,7 @@ if t

Re: [Mesa-dev] [PATCH shader-db] run: don't use alloca to avoid random crashes in the GLSL compiler

2016-12-07 Thread Jan Vesely
On Wed, 2016-12-07 at 18:44 +0100, Marek Olšák wrote: > On Wed, Dec 7, 2016 at 6:42 PM, Ilia Mirkin wrote: > > What's wrong with feeding it stack memory? > > I don't really have an answer to that. what happens when you malloc shader[i].length + 1 instead of +1000? looks like you're just hiding o

Re: [Mesa-dev] [PATCH] vl/zscan: fix "Fix trivial sign compare warnings"

2016-12-14 Thread Jan Vesely
On Wed, 2016-12-14 at 17:46 +, Emil Velikov wrote: > On 14 December 2016 at 14:07, Christian König wrote: > > From: Christian König > > > > The variable actually needs to be signed, otherwise converting it to a > > float doesn't work as expected. > > > > Fixes: https://bugs.freedesktop.org/

Re: [Mesa-dev] [RFC PATCH] clover: Return correct CL_EVENT_REFERENCE_COUNT

2016-12-20 Thread Jan Vesely
nly object that seems to require reference count == 1 is root device. Contexts, queues, mem, samplers, programs, kernels, events, all include the above footnote. I think the piglit test should be changed to check for non-zero value instead of 1. Jan > >break; > > > >

Re: [Mesa-dev] [PATCH v2 2/4] clover: Pass work_dim parameter of clEnqueueNDRangeKernel() to driver

2016-06-29 Thread Jan Vesely
;   > // Fill information for the launch_grid() call. > +   info.work_dim = grid_size.size(); > copy(pad_vector(q, block_size, 1), info.block); > copy(pad_vector(q, reduced_grid_size, 1), info.grid); > info.pc = find(name_equals(_name), m.syms).offset; -- Jan Ves

Re: [Mesa-dev] [PATCH v2 2/4] clover: Pass work_dim parameter of clEnqueueNDRangeKernel() to driver

2016-06-29 Thread Jan Vesely
On Wed, 2016-06-29 at 15:45 -0400, Ilia Mirkin wrote: > On Wed, Jun 29, 2016 at 2:42 PM, Jan Vesely > wrote: > > On Wed, 2016-06-29 at 14:37 +0200, Hans de Goede wrote: > > > In order to implement get_work_dim() the driver may need to know > > > the > >

Re: [Mesa-dev] [PATCH v2 2/4] clover: Pass work_dim parameter of clEnqueueNDRangeKernel() to driver

2016-06-29 Thread Jan Vesely
On Wed, 2016-06-29 at 16:18 -0400, Jan Vesely wrote: > On Wed, 2016-06-29 at 15:45 -0400, Ilia Mirkin wrote: > > On Wed, Jun 29, 2016 at 2:42 PM, Jan Vesely > > > > wrote: > > > On Wed, 2016-06-29 at 14:37 +0200, Hans de Goede wrote: > > > > In order

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

2016-07-01 Thread Jan Vesely
On Fri, 2016-07-01 at 13:45 +0200, Vedran Miletić wrote: > On 07/01/2016 11:11 AM, Marek Olšák wrote: > > > > On Fri, Jul 1, 2016 at 10:54 AM, Marek Olšák > > wrote: > > > > > > On Fri, Jul 1, 2016 at 2:52 AM, Vedran Miletić > > t> wrote: > > > > > > > > On 07/01/2016 01:29 AM, Marek Olšák wro

[Mesa-dev] [PATCH 1/1] r600g: Add double precision FMA ops

2016-07-02 Thread Jan Vesely
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96782 Fixes: 54c4d525da7c7fc1e103d7a3e6db015abb132d5d ("r600g: Enable FMA on chips that support it") Signed-off-by: Jan Vesely Tested-by: James Harvey --- src/gallium/drivers/r600/r600_shader.c | 2 ++ 1 file changed, 2

Re: [Mesa-dev] [PATCH 10/47] clover/llvm: Clean up compilation into LLVM IR.

2016-07-03 Thread Jan Vesely
On Sun, 2016-07-03 at 17:51 -0700, Francisco Jerez wrote: > Some assorted and mostly trivial clean-ups for the source to bitcode > compilation path. > > Reviewed-by: Serge Martin > --- >  .../state_trackers/clover/llvm/invocation.cpp  | 52 > +- >  1 file changed, 22 inser

Re: [Mesa-dev] [PATCH 20/47] clover/llvm: Clean up codestyle of get_kernel_args().

2016-07-03 Thread Jan Vesely
On Sun, 2016-07-03 at 17:51 -0700, Francisco Jerez wrote: > Reviewed-by: Serge Martin > --- >  .../state_trackers/clover/llvm/invocation.cpp  | 223 > ++--- >  1 file changed, 103 insertions(+), 120 deletions(-) > > diff --git a/src/gallium/state_trackers/clover/llvm/invocatio

Re: [Mesa-dev] [PATCH 10/47] clover/llvm: Clean up compilation into LLVM IR.

2016-07-04 Thread Jan Vesely
On Mon, 2016-07-04 at 12:32 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > On Sun, 2016-07-03 at 17:51 -0700, Francisco Jerez wrote: > > > Some assorted and mostly trivial clean-ups for the source to > > > bitcode > > > compilation path.

Re: [Mesa-dev] [PATCH 20/47] clover/llvm: Clean up codestyle of get_kernel_args().

2016-07-04 Thread Jan Vesely
On Mon, 2016-07-04 at 12:31 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > On Sun, 2016-07-03 at 17:51 -0700, Francisco Jerez wrote: > > > Reviewed-by: Serge Martin > > > --- > > >  .../state_trackers/clover/llvm/invocation.cpp  | 223 &g

Re: [Mesa-dev] [PATCH 1/4] gallium: add async flag to pipe_debug_callback

2016-07-07 Thread Jan Vesely
On Thu, 2016-07-07 at 09:39 +0200, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- >  src/gallium/include/pipe/p_state.h   | 6 ++ >  src/gallium/state_trackers/clover/core/queue.cpp | 5 - >  src/mesa/state_tracker/st_debug.c| 5 - >  3 files changed, 14

Re: [Mesa-dev] [PATCH RFC 1/1] r600, compute: Use vtx #3 for kernel arguments

2016-07-08 Thread Jan Vesely
ping. is there any other way to get dynamic indices working? Jan On Sun, 2016-06-26 at 20:40 -0400, Jan Vesely wrote: > Both explicit and implicit. > Using vtx 0 (as existing llvm code implies) does not work for dynamic > offsets. > > Signed-off-by: Jan Vesely > --- >

Re: [Mesa-dev] [PATCH 04/47] clover/llvm: Collect #ifdef mess into a separate file.

2016-07-08 Thread Jan Vesely
riple())); >    PMB.populateModulePassManager(PM); >    PM.run(*mod); > } > @@ -828,7 +793,7 @@ clover::compile_program_llvm(const std::string &source, >     std::string triple(target, processor_str_len + 1, >   

Re: [Mesa-dev] [PATCH 04/47] clover/llvm: Collect #ifdef mess into a separate file.

2016-07-08 Thread Jan Vesely
On Fri, 2016-07-08 at 14:39 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > On Sun, 2016-07-03 at 17:51 -0700, Francisco Jerez wrote: > > > This gets rid of most ifdef's from the invocation.cpp code -- > > > Only a > > > couple of them are l

Re: [Mesa-dev] [PATCH 20/47] clover/llvm: Clean up codestyle of get_kernel_args().

2016-07-10 Thread Jan Vesely
On Sat, 2016-07-09 at 14:32 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > On Mon, 2016-07-04 at 12:31 -0700, Francisco Jerez wrote: > > > Jan Vesely writes: > > > > > > > On Sun, 2016-07-03 at 17:51 -0700, Francisco Jerez

Re: [Mesa-dev] [PATCH 04/47] clover/llvm: Collect #ifdef mess into a separate file.

2016-07-12 Thread Jan Vesely
On Tue, 2016-07-12 at 21:19 +0200, Vedran Miletić wrote: > 09.07.2016 u 00:10, Jan Vesely je napisao/la: > > we still get 'macro redefined' complains from the compiler. and if > > anyone adds ifdef DEBUG code in the future it will cause unexpected > > behaviour. &g

Re: [Mesa-dev] [PATCH 1/2] clover: Add missing include

2016-07-19 Thread Jan Vesely
t; >  #include > >  #include > >  #include > > -- > > 2.7.4 > > > > ___ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev &

Re: [Mesa-dev] mesa clover from git fails to compile

2016-07-25 Thread Jan Vesely
; 'clover::llvm::compat::raw_ostream_to_emit_file {aka  > llvm::raw_svector_ostream&}' from an rvalue of type ' initializer list>' >   compat::raw_ostream_to_emit_file fos { os }; > ^ &g

Re: [Mesa-dev] [PATCH 1/3] gallium/os: add os_get_process_cmd_line

2016-07-30 Thread Jan Vesely
is not enough > > free > > RAM for the forked copy, which is not that unlikely with games as > > they > > tend to be resource heavy. > > Are you sure it makes a copy of the current process? The affected > code > already use

Re: [Mesa-dev] OpenCL for radeon Hawaii?

2016-08-03 Thread Jan Vesely
mewhat tangentially, if OpenCL support is really not a possibility > anytime soon, could somebody please point me in the direction of a > way > to use this card programmatically for something like matrix/matrix > multiplication? (I'm prepared to go re

Re: [Mesa-dev] OpenCL for radeon Hawaii?

2016-08-04 Thread Jan Vesely
PE_ACCELERATOR) No devices > found in platform > clCreateContextFromType(NULL, CL_DEVICE_TYPE_CUSTOM) No devices found > in platform > clCreateContextFromType(NULL, CL_DEVICE_TYPE_ALL) Success (1) > Platform Name Clover > Device Name AMD HAWAII (DRM 2.43.0 / 4.6.4-1-ARCH, LLVM 3.8.

Re: [Mesa-dev] [PATCH] src: replace RTLD_NOW with RTLD_LAZY

2016-08-05 Thread Jan Vesely
>   InfoMessageF("OpenDriver: trying %s\n", realDriverName); > - handle = dlopen(realDriverName, RTLD_NOW | RTLD_GLOBAL); > + handle = dlopen(realDriverName, RTLD_LAZY | RTLD_GLOBAL); >    } this is IMO micro-optimization in the wrong place. RTLD_NOW also guarantees that symbols were successfully resolved. Changing it to lazy may hide bugs by deferring failure to future point in the execution. Jan >   >    if (handle != NULL) > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] build: remove forced -fno-rtti

2013-10-16 Thread Jan Vesely
llvm_replace_compiler_option(CMAKE_CXX_FLAGS "/GR" "/GR-") > > > > > endif() > > > > > endif() > > > > > > > > > > from function(llvm_process_sources OUT_VAR) from > > > > > cmake/modules/LLVMP

Re: [Mesa-dev] [PATCH] build: remove forced -fno-rtti

2013-10-17 Thread Jan Vesely
> The fact that Johannes's llvm was built with -fno-rtti and doesn't > > > > report it in llvm-config it is the real issue. We need more info here so > > > > I can try to reproduce it. > > > > > > Please read exactly what I wrote. I already p

[Mesa-dev] [PATCH] clover: Refuse to create context with invalid properties

2013-10-21 Thread Jan Vesely
the specs say that clCreateContext reutrns error "if platform value specified in properties is not a valid platform" The orignal approach fials if invalid valu other than NULL pointer is provided. Fixes piglit cl-api-create-context. Signed-off-by: Jan Vesely --- src/gallium/stat

Re: [Mesa-dev] [PATCH] clover: Refuse to create context with invalid properties

2013-10-22 Thread Jan Vesely
On Mon, 2013-10-21 at 22:20 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > the specs say that clCreateContext reutrns error > > "if platform value specified in properties is not a valid platform" > > > > The orignal approach fials if

Re: [Mesa-dev] [PATCH] clover: Refuse to create context with invalid properties

2013-10-24 Thread Jan Vesely
On Tue, 2013-10-22 at 13:38 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > On Mon, 2013-10-21 at 22:20 -0700, Francisco Jerez wrote: > >> Jan Vesely writes: > >> > >> > the specs say that clCreateContext reutrns error > >> > &qu

[Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Jan Vesely
d-off-by: Jan Vesely CC: Bruno Jimenez --- This fixes hang in gegl colors.xml test src/gallium/drivers/r600/compute_memory_pool.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c b/src/gallium/drivers/r600/compute_memor

[Mesa-dev] [PATCH 2/2] r600: Handle failures in compute_memory_pool_finalize

2014-06-19 Thread Jan Vesely
Signed-off-by: Jan Vesely CC: Bruno Jimenez --- The failure now hits assertion compute_memory_pool.c:408, instead of u_inlines.h:275:pipe_buffer_map_range: Assertion `offset < buffer->width0' src/gallium/drivers/r600/evergreen_compute.c | 9 +++-- 1 file changed, 7 inser

Re: [Mesa-dev] [PATCH 2/2] r600: Handle failures in compute_memory_pool_finalize

2014-06-19 Thread Jan Vesely
with R600_DEBUG=compute if it helps. regards, Jan > > Thanks! > Bruno > > On Thu, 2014-06-19 at 10:21 -0400, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > CC: Bruno Jimenez > > --- > > > > The failure now hits assertion compute_memory_

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Jan Vesely
gegl git[0] on mesa/clover/r600. you 'll need babl git[1] too. Let me know if I can help with setting it up. Sry, I don't have any smaller reproducer. Jan [0] git://git.gnome.org/gegl [1] git://git.gnome.org/babl > > On Thu, 2014-06-19 at 10:21 -0400, Jan Vesely wrote: &

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Jan Vesely
On Thu, 2014-06-19 at 08:27 -0700, Tom Stellard wrote: > On Thu, Jun 19, 2014 at 10:21:32AM -0400, Jan Vesely wrote: > > The important part is the change of the condition to <= 0. Otherwise the > > loop > > gets stuck never actually growing the pool. > >

Re: [Mesa-dev] [PATCH 2/2] r600: Handle failures in compute_memory_pool_finalize

2014-06-19 Thread Jan Vesely
On Thu, 2014-06-19 at 08:34 -0700, Tom Stellard wrote: > On Thu, Jun 19, 2014 at 11:22:28AM -0400, Jan Vesely wrote: > > On Thu, 2014-06-19 at 17:12 +0200, Bruno Jimenez wrote: > > > Hi, > > > > > > To which failure are you refering? Could you please send me a

Re: [Mesa-dev] [PATCH 1/2] r600: Fix possible endless loop in compute_memory_pool allocations.

2014-06-19 Thread Jan Vesely
On Thu, 2014-06-19 at 18:22 +0200, Bruno Jimenez wrote: > On Thu, 2014-06-19 at 11:58 -0400, Jan Vesely wrote: > > On Thu, 2014-06-19 at 08:27 -0700, Tom Stellard wrote: > > > On Thu, Jun 19, 2014 at 10:21:32AM -0400, Jan Vesely wrote: > > > > The important part is

Re: [Mesa-dev] Testing OpenCL with gegl

2014-06-20 Thread Jan Vesely
env var to select device type. the accepted values are 'yes' (default), 'no'(hard-disable), 'cpu', 'gpu', 'accelerator' HTH, let me know if you have further questions Jan > > Thanks in advance! > Bruno > -- Jan Vesely signat

Re: [Mesa-dev] Testing OpenCL with gegl

2014-06-20 Thread Jan Vesely
On Fri, 2014-06-20 at 19:46 +0200, Bruno Jimenez wrote: > On Fri, 2014-06-20 at 09:31 -0400, Jan Vesely wrote: > > On Fri, 2014-06-20 at 10:27 +0200, Bruno Jimenez wrote: > > > Hi, > > > > Hi Bruno, > > I have added mesa list to CC as others might be interested

Re: [Mesa-dev] Testing OpenCL with gegl

2014-06-21 Thread Jan Vesely
I readded the mesa list again, as the info might be interesting to others. On Sat, 2014-06-21 at 11:50 +0200, Bruno Jimenez wrote: > On Fri, 2014-06-20 at 17:01 -0400, Jan Vesely wrote: > > On Fri, 2014-06-20 at 21:58 +0200, Bruno Jimenez wrote: > > > [snip] > > I a

Re: [Mesa-dev] Testing OpenCL with gegl

2014-06-21 Thread Jan Vesely
;> ARUBA). Simple opencl tests work. > >> > >> Using gimp (built from git) i have the same undefined symbol error in > >> the console and all operations use 1 CPU core, the GPU doesnt seem to be > >> used at all. If i make all tests, all opencl tests are skipped and one > >> (non-opencl i suppose) even fails (gegl.xml). > >> Any ideas how i could use opencl? > >> > > > > > -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/1] r600: Fix use after free in compute_memory_promote_item.

2014-06-23 Thread Jan Vesely
The dst pointer needs to be initialized after any calls to compute_memory_grow_pool, as the function might change the pool->vbo pointer. This fixes crashes and assertion failures in two gegl tests. Signed-off-by: Jan Vesely CC: Bruno Jimenez CC: Tom Stellard --- src/gallium/drivers/r

Re: [Mesa-dev] [PATCH 1/1] r600: Fix use after free in compute_memory_promote_item.

2014-06-24 Thread Jan Vesely
On Mon, 2014-06-23 at 17:15 +0200, Bruno Jimenez wrote: > On Mon, 2014-06-23 at 10:39 -0400, Jan Vesely wrote: > > The dst pointer needs to be initialized after any calls to > > compute_memory_grow_pool, as the function might change the pool->vbo > > pointer. > >

  1   2   3   4   5   6   >