On 08/26/2015 10:11 PM, Jason Ekstrand wrote:
> On Wed, Aug 26, 2015 at 10:20 AM, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> Signed-off-by: Ian Romanick
>> ---
>> src/glsl/nir/nir_constant_expressions.py | 13 +
>> 1 file changed, 5 i
on
>
> On Wed, Aug 26, 2015 at 10:19 AM, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> Signed-off-by: Ian Romanick
>> ---
>> src/glsl/nir/nir_constant_expressions.py | 40
>>
>> 1 file changed, 20 insertions(+),
On 08/27/2015 06:41 AM, Jason Ekstrand wrote:
>
> On Aug 27, 2015 4:08 AM, "Ian Romanick" <mailto:i...@freedesktop.org>> wrote:
>>
>> On 08/26/2015 10:11 PM, Jason Ekstrand wrote:
>> > On Wed, Aug 26, 2015 at 10:20 AM, Ian Romanick <mailto:i...@
ping. :)
On 08/10/2015 11:48 AM, Matt Turner wrote:
> On Mon, Aug 10, 2015 at 10:12 AM, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> On many CPU-limited applications, this is *the* hot path. The idea is
>> to generate per-API versions of brw_draw_prims that elide
On 08/31/2015 04:21 PM, Ilia Mirkin wrote:
> On Mon, Aug 31, 2015 at 7:06 PM, Ian Romanick wrote:
>> ping. :)
>>
>> On 08/10/2015 11:48 AM, Matt Turner wrote:
>>> On Mon, Aug 10, 2015 at 10:12 AM, Ian Romanick wrote:
>>>> From: Ian Romanick
>>&
From: Ian Romanick
Previously we would allow glUniformMatrix4fv on a dmat4 and
glUniformMatrix4dv on a mat4. Both are illegal. That later also
overwrites the storage for the mat4 and causes bad things to happen.
Should fix the (new) arb_gpu_shader_fp64-wrong-type-setter piglit test.
Signed
From: Ian Romanick
This matches _mesa_uniform, and it enables the bug fix in the next
patch.
Signed-off-by: Ian Romanick
Cc: Dave Airlie
Cc: "10.6 11.0 "
---
src/mesa/main/uniform_query.cpp | 10 +++---
src/mesa/main/uniforms.c| 72 -
From: Ian Romanick
Signed-off-by: Ian Romanick
---
src/compiler/glsl/standalone.cpp | 12
1 file changed, 12 insertions(+)
diff --git a/src/compiler/glsl/standalone.cpp b/src/compiler/glsl/standalone.cpp
index a7e6254..6b1c2ce 100644
--- a/src/compiler/glsl/standalone.cpp
+++ b
From: Ian Romanick
At this point in the code, s must be visit_continue. If the child
returned visit_stop, visit_stop is the only correct thing to return.
Found by inspection.
Signed-off-by: Ian Romanick
Cc: mesa-sta...@lists.freedesktop.org
---
src/compiler/glsl/ir_hv_accept.cpp | 2 +-
1
From: Ian Romanick
We didn't bother with this in the regular compiler because it doesn't
change the generated code. In the stand-alone compiler, this can
clutter the output with useless variables. It's especially bad after
functions are inlined but the foo_retval declarations
From: Ian Romanick
For many expressions, this is different from the printable name. The
printable name for ir_binop_add is "+", but we want "add". This is
needed for ir_builder_print_visitor.
Signed-off-by: Ian Romanick
---
src/compiler/glsl/ir.h
From: Ian Romanick
Signed-off-by: Ian Romanick
---
src/compiler/glsl/main.cpp | 1 +
src/compiler/glsl/standalone.cpp | 12
src/compiler/glsl/standalone.h | 1 +
3 files changed, 14 insertions(+)
diff --git a/src/compiler/glsl/main.cpp b/src/compiler/glsl/main.cpp
index
From: Ian Romanick
max_unroll_iterations was moved into options a long, long time ago.
Signed-off-by: Ian Romanick
---
src/compiler/glsl/glsl_parser_extras.cpp | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/compiler/glsl/glsl_parser_extras.cpp
b/src/compiler
From: Ian Romanick
This enables the support added by the previous two patches in
do_common_optimization. This will be used by the stand-alone compiler.
Signed-off-by: Ian Romanick
---
src/compiler/glsl/glsl_parser_extras.cpp | 12
src/compiler/glsl/ir_optimization.h
From: Ian Romanick
This just makes the output of the standalone compiler a little more
compact.
Signed-off-by: Ian Romanick
---
src/compiler/glsl/standalone.cpp | 34 ++
1 file changed, 34 insertions(+)
diff --git a/src/compiler/glsl/standalone.cpp b/src
This series makes the stand-alone GLSL compiler useful for something.
It adds an option to generate C++ code that uses ir_builder to recreate
the compiled GLSL shader. I intend to use this for various lowering
code for GL_ARB_gpu_shader_int64 and GL_ARB_gpu_shader_fp64 (on
platforms that don't act
From: Ian Romanick
If the user did not request full linking, link the shader with the
built-in functions, inline them, and eliminate them. Previous to this
you'd see all these calls to "dot" and "max" in the output. This
prevented a lot of expected optimizations and c
From: Ian Romanick
Otherwise extensions to 1.40 that are only for core profile won't work.
Signed-off-by: Ian Romanick
---
src/compiler/glsl/standalone.cpp | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/compiler/glsl/standalone.cpp b/src/compiler
From: Ian Romanick
This will be used in the stand-alone compiler.
Signed-off-by: Ian Romanick
---
src/compiler/glsl/glsl_parser_extras.cpp | 2 +-
src/compiler/glsl/ir_optimization.h | 2 +-
src/compiler/glsl/opt_dead_functions.cpp | 11 +++
src/compiler/glsl/test_optpass.cpp
From: Ian Romanick
Signed-off-by: Ian Romanick
---
src/compiler/glsl/ir_builder.cpp | 6 ++
src/compiler/glsl/ir_builder.h | 1 +
2 files changed, 7 insertions(+)
diff --git a/src/compiler/glsl/ir_builder.cpp b/src/compiler/glsl/ir_builder.cpp
index d68647f..f430100 100644
--- a/src
From: Ian Romanick
This is only in libstandalone currently because it will only be used in
the stand-alone compiler.
Signed-off-by: Ian Romanick
---
src/compiler/Makefile.sources | 2 +
src/compiler/glsl/ir_builder_print_visitor.cpp | 753 +
src
From: Ian Romanick
This will be used in the stand-alone compiler.
Signed-off-by: Ian Romanick
---
src/compiler/glsl/glsl_parser_extras.cpp| 2 +-
src/compiler/glsl/ir_optimization.h | 2 +-
src/compiler/glsl/opt_function_inlining.cpp | 12 +++-
src/compiler/glsl
From: Ian Romanick
This enables a sort of par-linking. The primary use for this feature is
resolving built-in functions in the stand-alone compiler.
Signed-off-by: Ian Romanick
---
src/compiler/glsl/linker.cpp | 28 +---
src/compiler/glsl/linker.h | 9 +
2
On 09/15/2016 03:12 PM, Ian Romanick wrote:
> This series makes the stand-alone GLSL compiler useful for something.
> It adds an option to generate C++ code that uses ir_builder to recreate
> the compiled GLSL shader. I intend to use this for various lowering
> code for GL_ARB_gpu_
On 09/16/2016 06:57 AM, Nicolai Hähnle wrote:
> Hi all,
>
> as the title says. The implementation uses a compute shader to summarize
> data from the query buffers. As long as only one query buffer is in flight
> (the normal case), that compute shader is launched exactly once, on a
> single thread.
On 09/16/2016 06:48 AM, Nicolai Hähnle wrote:
> Hi all,
>
> this is really Dave's work, with a few touch-ups from me that I think make
> sense. I've kept those separate with the intention to squash. I'd like to
> land these in master even before the main ARB_gpu_shader_int64 stuff lands
> (that is
Reviewed-by: Ian Romanick
On 09/10/2016 12:43 AM, Eric Anholt wrote:
> VC4 was running into a major performance regression from enabling control
> flow in the glmark2 conditionals test, because of short if statements
> containing an ffract.
>
> This pass seems like it was was t
On 09/21/2016 10:20 PM, Kenneth Graunke wrote:
> Hello,
>
> This series reworks the GLSL compiler to inline built-in functions
> immediately, at compile time, rather than importing prototypes and
> linking against an extra shader later on.
>
> Without this, compile time optimizations are nearly u
t. Pending patch 2, this
patch is
Reviewed-by: Ian Romanick
> Signed-off-by: Kenneth Graunke
> ---
> src/compiler/glsl/link_functions.cpp | 32 +++
> src/compiler/glsl/linker.cpp | 42
> +++-
> 2 files chan
Pending patch 2, this patch is
Reviewed-by: Ian Romanick
On 09/21/2016 10:20 PM, Kenneth Graunke wrote:
> This is now handled directly by ast_function.cpp.
>
> Signed-off-by: Kenneth Graunke
> ---
> src/compiler/glsl/builtin_functions.cpp | 30 --
&g
On 09/21/2016 10:29 PM, Kenneth Graunke wrote:
> Hi Ian,
>
> I just sent out a four patch series that I think will accomplish a lot
> of what you were trying to do with the "do post-link optimizations, but
> only for built-ins" patches. But it deletes code.
>
> https://lists.freedesktop.org/arch
On 09/21/2016 10:20 PM, Kenneth Graunke wrote:
> In the past, we imported the prototypes of built-in functions, generated
> calls to those, and waited until link time to resolve the calls and
> import the actual code for the built-in functions.
I thought part of the reason we did this was to accou
This is much simpler. This patch is
Reviewed-by: Ian Romanick
On 09/21/2016 10:20 PM, Kenneth Graunke wrote:
> We want to check prior to optimization - otherwise we might fail to
> detect cases where barrier() is in control flow which is always taken
> (and therefore gets optim
On 09/22/2016 06:54 PM, Kenneth Graunke wrote:
> On Thursday, September 22, 2016 1:54:44 PM PDT Ian Romanick wrote:
>> On 09/21/2016 10:20 PM, Kenneth Graunke wrote:
>>> In the past, we imported the prototypes of built-in functions, generated
>>> calls to those, an
On 09/26/2016 12:41 AM, Tapani Pälli wrote:
> This fixes a crash in egl-create-msaa-pbuffer-surface Piglit test
> and same crash in many dEQP EGL tests.
>
> I also found that some Qt example did a workaround because of this
> crash: https://bugreports.qt.io/browse/QTBUG-47509
Eh... I would have t
On 09/16/2016 06:21 PM, Tapani Pälli wrote:
> Changes make copy_propagation_elements pass faster, reducing link
> time spent in test case of bug 94477. Does not fix the actual issue
> but brings down the total time. No regressions seen in CI.
How does this affect the time of a full shader-db run?
On 09/29/2016 12:17 AM, Tapani Pälli wrote:
>
> On 09/28/2016 06:14 PM, Ian Romanick wrote:
>> On 09/16/2016 06:21 PM, Tapani Pälli wrote:
>>> Changes make copy_propagation_elements pass faster, reducing link
>>> time spent in test case of bug 94477. Does not fix t
On 09/30/2016 06:23 AM, Brian Paul wrote:
> On 09/30/2016 04:59 AM, Emil Velikov wrote:
>> On 30 September 2016 at 03:31, Timothy Arceri
>> wrote:
>>> On Thu, 2016-09-29 at 19:17 -0700, Jason Ekstrand wrote:
>>>
>>> On Sep 29, 2016 5:14 PM, "Timothy Arceri"
>>> wrote:
On Thu, 2016-09-29
.
Signed-off-by: Tapani Pälli
Signed-off-by: Ian Romanick
---
This is tested with shader-db. There's a bit more cleaning and testing
to do. I was going to send this out last night but, long story short,
my desk collapsed, and I had to deal with that instead. :(
...
Reviewed-by: Ian Romanick
On 09/29/2016 11:37 PM, Timothy Arceri wrote:
> The warning was also the wrong location, it should have been
> in the else.
> ---
> src/mesa/drivers/dri/i915/intel_fbo.h | 4 +---
> src/mesa/drivers/dri/i965/intel_fbo.h | 4 +---
> 2 files changed,
(idr): Delete unused copy constructor. Use while(pop_head) instead
of foreach() { remove }.
Signed-off-by: Tapani Pälli
Signed-off-by: Ian Romanick
---
Ugh... I had these uncommitted changes sitting in my tree when I sent
the other patch out. Sorry for the chaos.
.../glsl
oseFBConfig style.
That is weird. I did a lot of archaeology on this... and I can't see
that this parameter was *ever* passed anything other than GL_TRUE. The
other places that call init_fbconfig_for_chooser and
__GlXInitializeVisualConfigFromTags also pass literal values for the
last parame
//bugreports.qt.io/browse/QTBUG-47509
>> +*/
>> + if (base.Samples) {
>> + surface_type &= ~EGL_PBUFFER_BIT;
>> + }
>> +
> I'm slightly cautious if this won't cause unexpected side effects (due
> to _eglFilterArray() and/or other interaction),
Reviewed-by: Ian Romanick
On 09/26/2016 11:23 AM, Kenneth Graunke wrote:
> In core profile, we support up to 16 viewports. However, in the
> majority of cases, only 1 of them is actually used - we only need
> the others if the last shader stage prior to the rasterizer writes
> gl_V
From: Ian Romanick
st_glsl_to_tgsi only calls lower_instructions once (instead of in a
loop), so the ir_binop_carry generated would not get lowered. Fixes
assertion failure
state_tracker/st_glsl_to_tgsi.cpp:2265: void
glsl_to_tgsi_visitor::visit_expression(ir_expression*, st_src_reg
From: Ian Romanick
Signed-off-by: Ian Romanick
Cc: Timothy Arceri
---
src/compiler/glsl/tests/cache_test.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/compiler/glsl/tests/cache_test.c
b/src/compiler/glsl/tests/cache_test.c
index 1b0403c..724dfcd 100644
--- a/src/compiler/glsl
Heh... I'm not there... well done.
Reviewed-by: Ian Romanick
On 10/06/2016 12:37 PM, Adam Jackson wrote:
> Signed-off-by: Adam Jackson
> ---
> REVIEWERS | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/REVIEWERS b/REVIEWERS
> index f7574b3..f82242
On 10/06/2016 06:22 AM, Martina Kollarova wrote:
> The OpenGL 4.5 spec updated the section on primitive restart, and now it
> doesn't have to be performed on drawing commands not taking a parameter,
> regardless of whether PRIMITIVE_RESTART_FIXED_INDEX is enabled or not.
>
> Bugzilla: https://bugs
On 10/05/2016 05:42 PM, Brian Paul wrote:
> To inform drivers of texture buffer offset/size changes, as we do for
> other texture object parameters.
> ---
> src/mesa/main/teximage.c | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/te
From: Ian Romanick
Trivial.
Signed-off-by: Ian Romanick
---
src/mesa/drivers/dri/i965/intel_extensions.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa/drivers/dri/i965/intel_extensions.c
index eef81e2
From: Ian Romanick
This was found partially by inspection and partially by hitting a
problem while working on nir_op_pack_int64_2x32_split. The code
previously would 'continue' if (instr->src[i].src.is_ssa), but the code
immediately following in the loop treats instr->src[i]
On 10/08/2016 09:33 AM, Eduardo Lima Mitev wrote:
> On 10/08/2016 02:12 AM, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> This was found partially by inspection and partially by hitting a
>> problem while working on nir_op_pack_int64_2x32_split. The code
>&g
From: Ian Romanick
Signed-off-by: Ian Romanick
---
src/compiler/glsl/ir.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/src/compiler/glsl/ir.h b/src/compiler/glsl/ir.h
index 83b810b..7e06d42 100644
--- a/src/compiler/glsl/ir.h
+++ b/src/compiler/glsl/ir.h
@@ -2357,9 +2357,6
From: Ian Romanick
brw_link.cpp:76:44: warning: unused parameter ‘shader_type’ [-Wunused-parameter]
gl_shader_stage shader_type,
^
brw_nir.c: In function ‘brw_nir_lower_vs_inputs’:
brw_nir.c:194:55: warning: unused parameter
From: Ian Romanick
Once upon a time, this was used to extract prototypes from the shader
containing GLSL built-in functions. This was removed by f5692f45 in
November 2010 for Mesa 7.10.
Signed-off-by: Ian Romanick
Cc: Kenneth Graunke
---
src/compiler/Makefile.sources | 1
From: Ian Romanick
Signed-off-by: Ian Romanick
---
src/compiler/glsl/ir_print_visitor.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/compiler/glsl/ir_print_visitor.cpp
b/src/compiler/glsl/ir_print_visitor.cpp
index c238c16..1299bfb 100644
--- a/src/compiler/glsl
, I've seen so many "silence warning" commits at $DAYJOB that
> this has become a pet peeve of mine)
>
> One suggestion below, but the series looks good:
> Reviewed-by: Eric Engestrom
>
>
> On Fri, Oct 14, 2016 at 11:59:47AM -0700, Ian Romanick wrote:
>> From:
On 08/05/2016 07:05 PM, ⚛ wrote:
> On Sat, Aug 6, 2016 at 3:37 AM, Jan Vesely wrote:
>> On Sat, 2016-08-06 at 02:42 +0200, Jan Ziak wrote:
>>> Mesa source code prior to this patch uses both RTLD_NOW and
>>> RTLD_LAZY.
>>> This patch removes all RTLD_NOW in favor of RTLD_LAZY.
>>>
>>> In comparison
On 08/01/2016 07:52 PM, Kenneth Graunke wrote:
> On Monday, August 1, 2016 7:06:14 PM PDT Ilia Mirkin wrote:
>> I'm looking at these on my phone, so perhaps I missed it - do you ever end
>> up turning them on, or is that left to later series?
>
> No...not yet. This series gets almost all of dEQP
On 08/01/2016 10:29 AM, Kenneth Graunke wrote:
> Signed-off-by: Kenneth Graunke
> ---
> src/compiler/glsl/glsl_parser_extras.h | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/src/compiler/glsl/glsl_parser_extras.h
> b/src/compiler/glsl/glsl_parser_extras.h
> index 991cfc6.
This is also a problem for desktop, yeah? Cc stable?
On 08/01/2016 10:29 AM, Kenneth Graunke wrote:
> Signed-off-by: Kenneth Graunke
> ---
> src/compiler/glsl/ast_to_hir.cpp | 4
> src/compiler/glsl/glsl_parser.yy | 11 +++
> src/compiler/glsl/glsl_parser_extras.cp
It looks like only part of this series has landed?
Patches 1 through 7 and 9 through 12 are
Reviewed-by: Ian Romanick
On 08/01/2016 10:29 AM, Kenneth Graunke wrote:
> The OES_tessellation_shader and EXT_tessellation_shader specifications
> have suffixed names. These are identical to th
I'm pretty sure this breaks ABI. Did you try using an unpatched libGL
with a patched *_dri.so (and vice-versa)?
On 08/01/2016 06:21 AM, Jan Ziak wrote:
> Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com>
> ---
> src/egl/drivers/dri2/egl_dri2.h | 19 ++-
On 08/01/2016 10:29 AM, Kenneth Graunke wrote:
> This error condition is not implementable when using tessellation or
> geometry shaders. The text was also removed from the ES 3.2 spec.
> I believe the intended behavior is to remove the error condition
> when either OES_geometry_shader or OES_tess
On 08/08/2016 09:38 AM, ⚛ wrote:
> On Mon, Aug 8, 2016 at 6:22 PM, Ian Romanick wrote:
>> I'm pretty sure this breaks ABI. Did you try using an unpatched libGL
>> with a patched *_dri.so (and vice-versa)?
>
> Can you be more specific?
Eh... build Mesa. Save the
.
No... we go to great lengths to make *_dri.so query libGL to know where
a new function goes in the dispatch table. If libGL doesn't know a
location for the new function, it dynamically assigns one. That's what
all the remap table stuff is.
> BR,
> -R
>
> On Mon, Aug 8
On 08/08/2016 09:52 AM, Jan Vesely wrote:
> On Mon, 2016-08-08 at 08:54 -0700, Ian Romanick wrote:
>> On 08/05/2016 07:05 PM, ⚛ wrote:
>>>
>>> On Sat, Aug 6, 2016 at 3:37 AM, Jan Vesely
>>> wrote:
>>>>
>>>> On Sat, 2016-08-06 at 02:42
On 08/04/2016 04:14 PM, Kenneth Graunke wrote:
> Just avoid whacking GL_FRAMEBUFFER_SRGB altogether, so we respect
> the application's setting. This appears to work.
>
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/drivers/common/meta_blit.c | 80
> +
> 1
Patches 1 through 5 and 7 through 9 are
Reviewed-by: Ian Romanick
I sent one trivial comment on patch 9.
On 08/04/2016 04:14 PM, Kenneth Graunke wrote:
> Hello,
>
> This combined patch series updates both Piglit and Mesa to implement
> the modern GL 4.4+ rules for sRGB encoding
From: Ian Romanick
Signed-off-by: Ian Romanick
Cc: mesa-sta...@lists.freedesktop.org
---
src/compiler/glsl/glcpp/glcpp-parse.y | 10 +-
src/compiler/glsl/glcpp/glcpp.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/compiler/glsl/glcpp/glcpp-parse.y
b
From: Ian Romanick
Section 3.4 (Preprocessor) of the GLSL ES 3.00 spec says:
It is an error to undefine or to redefine a built-in (pre-defined)
macro name.
The GLSL ES 1.00 spec does not contain this text.
Section 3.3 (Preprocessor) of the GLSL 1.30 spec says:
#define and #undef
On 08/09/2016 10:17 AM, Eric Anholt wrote:
> Improves glretrace -b servo.trace (a trace of Mozilla's servo rendering
> engine booting, rendering a page, and exiting) from 1.8s to 1.1s. It uses
> a large uniform array of structs, making a huge number of separate program
> resources, and the fixed-s
With the one comment on patch 3 resolved, this series is
Reviewed-by: Ian Romanick
On 08/09/2016 10:17 AM, Eric Anholt wrote:
> ---
> src/compiler/nir/nir_lower_samplers.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/compiler/nir/nir_lower_samplers.c
>
a, b))),
> (('fsat', ('fadd', ('b2f', a), ('b2f', b))), ('b2f', ('ior', a, b))),
> (('iand', 'a@bool', 1.0), ('b2f', a)),
> + (('ineg', ('b2i', 'a@bool')), a),
n't get any
benefit. I also had tests for a couple other relational operators with
0 that didn't see benefit. Maybe one of us should try to revive my old,
more generic series at some point.
For now, this patch is
Reviewed-by: Ian Romanick
> Signed-off-by: Kenneth Graunke
> ---
&g
On 08/09/2016 07:30 PM, Kenneth Graunke wrote:
> On Haswell (GL 3.3):
>
> total instructions in shared programs: 6208759 -> 6203860 (-0.08%)
> instructions in affected programs: 856541 -> 851642 (-0.57%)
> helped: 3157
> HURT: 113
> LOST: 7
> GAINED: 15
>
> On Broadwell (GL 4.4):
>
> total ins
On 08/09/2016 07:30 PM, Kenneth Graunke wrote:
> On Haswell (GL 3.3):
>
> total instructions in shared programs: 6211427 -> 6210079 (-0.02%)
> instructions in affected programs: 219356 -> 218008 (-0.61%)
> helped: 567
> HURT: 132
>
> No spill/fill changes.
>
> LOST: 0
> GAINED: 4
>
> On Broad
*/
> +}
> +
> +static bool
> +move_comparisons(nir_block *block)
> +{
> + bool progress = false;
> +
> + /* We use a simple approach: walk instructions backwards.
> +*
> +* If the instruction's source is a comparison from the same block
On 08/10/2016 11:24 AM, Kenneth Graunke wrote:
> On Wednesday, August 10, 2016 10:02:12 AM PDT Erik Faye-Lund wrote:
>> On Wed, Aug 10, 2016 at 4:30 AM, Kenneth Graunke
>> wrote:
>>> On Haswell (GL 3.3):
>>>
>>> total instructions in shared programs: 6208759 -> 6203860 (-0.08%)
>>> instructions i
On 08/10/2016 12:50 PM, Eric Anholt wrote:
> Connor Abbott writes:
>
>> On Wed, Aug 10, 2016 at 1:53 PM, Eric Anholt wrote:
>>> Kenneth Graunke writes:
>>>
On Haswell (GL 3.3):
total instructions in shared programs: 6208759 -> 6203860 (-0.08%)
instructions in affected progra
ping
On 07/19/2016 10:37 PM, Ian Romanick wrote:
> From: Ian Romanick
>
> Some shaders include code that looks like:
>
>uniform int i;
>uniform vec4 bones[...];
>
>foo(bones[i * 3], bones[i * 3 + 1], bones[i * 3 + 2]);
>
> CSE would do some w
This seems okay... let me run it through our CI first. I should have
results later today. I'm going to step out for a bit.
On 08/09/2016 05:43 PM, Ilia Mirkin wrote:
> ping? do we want this? should i drop it?
>
> On Wed, Jul 13, 2016 at 3:37 PM, Ilia Mirkin wrote:
>> Thanks for confirming, Cor
On 08/11/2016 10:11 AM, Chad Versace wrote:
> It always returns non-null, even if the number is an invalid enum.
>
> Cc: Haixia Shi
> Change-Id: I26e8843c96130be972e66f48a49e362442e1bf97
> ---
> src/mapi/glapi/gen/gl_enums.py | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/mapi
On 08/11/2016 10:11 AM, Chad Versace wrote:
> If check_textarget() determined that textarget was incorrect, it emitted
> GL_INVALID_OPERATION. This is the correct behavior when textarget is
> a valid GLenum but an invalid parameter to the current variant of
> glFramebufferTexture*().
>
> However,
On 08/11/2016 10:22 AM, Ian Romanick wrote:
> On 08/11/2016 10:11 AM, Chad Versace wrote:
>> It always returns non-null, even if the number is an invalid enum.
>>
>> Cc: Haixia Shi
>> Change-Id: I26e8843c96130be972e66f48a49e362442e1bf97
>> ---
>> src/ma
On 08/11/2016 10:11 AM, Chad Versace wrote:
> The new function is identical to _mesa_enum_to_string(), except that it
> returns false if the given number is an invalid enum. Bundling
> validation and lookup into a single function allows us to do both with
> a single lookup into the enum table.
>
>
Or not. :( The patch no longer applies, and I wasn't able to trivially
make it apply. I suspect one of Timothy's recent patches is to blame.
On 08/11/2016 10:06 AM, Ian Romanick wrote:
> This seems okay... let me run it through our CI first. I should have
> results later toda
On 08/11/2016 11:54 AM, Thomas Helland wrote:
> 2016-08-11 18:19 GMT+02:00 Ian Romanick :
>> ping
>>
>> On 07/19/2016 10:37 PM, Ian Romanick wrote:
>>> From: Ian Romanick
>>>
>>> Some shaders include code that looks like:
>>>
>>>
On 08/17/2016 05:00 PM, Tim Rowley wrote:
> Increases the performance of legacy geometry-heavy apps
> still using display lists.
Do you have any data or at least names of some affected apps? This is
valuable for the next person that has to change this code... imagine
someone who needs to change t
From: Ian Romanick
and GL_KHR_blend_equation_advanced_coherent.
Signed-off-by: Ian Romanick
---
docs/GL3.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index b27c550..c769f69 100644
--- a/docs/GL3.txt
+++ b/docs/GL3.txt
@@ -253,7 +253,7
From: Ian Romanick
Every driver that supports one also supports the other. This is
phenomenally unlikely to change.
Signed-off-by: Ian Romanick
---
src/mesa/drivers/dri/i915/intel_extensions.c | 1 -
src/mesa/drivers/dri/i965/intel_extensions.c | 1 -
src/mesa/drivers/dri/nouveau
The majority of this series came while I was trying to fight jet lag
during Khronos face-to-face meetings. I had to do something, and I
didn't feel capable of doing anything "real." :)
The series also includes previously sent up dates to the file previously
known as GL3.txt.
From: Ian Romanick
The checks in _mesa_has_shader_subroutine are slightly different than
_mesa_has_ARB_shader_subroutine, but they're not different in a way
that matters. The only way to have ctx->Version >= 40 is if
ctx->Extensions.ARB_shader_subroutine is set.
Signed-off-by
From: Ian Romanick
Signed-off-by: Ian Romanick
---
src/mesa/main/texenv.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/src/mesa/main/texenv.c b/src/mesa/main/texenv.c
index 3f3adba..ba22301 100644
--- a/src/mesa/main/texenv.c
+++ b/src/mesa/main
From: Ian Romanick
Signed-off-by: Ian Romanick
---
src/mesa/main/texenv.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/mesa/main/texenv.c b/src/mesa/main/texenv.c
index ba22301..d709a7d 100644
--- a/src/mesa/main/texenv.c
+++ b/src/mesa/main/texenv.c
From: Ian Romanick
Signed-off-by: Ian Romanick
---
docs/GL3.txt | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index 084c17e..b27c550 100644
--- a/docs/GL3.txt
+++ b/docs/GL3.txt
@@ -136,17 +136,17 @@ GL 4.0, GLSL 4.00 --- all
From: Ian Romanick
Signed-off-by: Ian Romanick
---
src/mesa/main/texenv.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/src/mesa/main/texenv.c b/src/mesa/main/texenv.c
index 3d6a219..3f3adba 100644
--- a/src/mesa/main/texenv.c
+++ b/src/mesa/main
From: Ian Romanick
Signed-off-by: Ian Romanick
Suggested-by: Ilia Mirkin
---
docs/GL3.txt | 335 --
docs/features.txt | 335 ++
2 files changed, 335 insertions(+), 335 deletions
From: Ian Romanick
Fixes long standing bug on NV10 and NV20 where using a non-1x RGB or A
post-scale with GL_DOT3_RGB or GL_DOT3_RGBA texture environment would
not work.
The old combiner math uses HALF_BIAS_NORMAL and HALF_BIAS_NEGATE. The
GL_NV_register_combiners defines these as
From: Ian Romanick
Signed-off-by: Ian Romanick
---
src/mesa/main/texenv.c | 29 +++--
1 file changed, 11 insertions(+), 18 deletions(-)
diff --git a/src/mesa/main/texenv.c b/src/mesa/main/texenv.c
index c7403d9..1ab4708 100644
--- a/src/mesa/main/texenv.c
+++ b/src
401 - 500 of 7867 matches
Mail list logo
