t XXX/TODO/NOTE or alike.
As a fall-back, set the LIBSENSORS_{CFLAGS,LIBS} here and use both of
those throughout.
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
of the overall NIC speed.
>>> 3. lmsensor power, voltage and temperature sensors.
>>>
>> I'm not sure if these should be in the driver itself. In practise
>> these do not have direct (co-)relation to the performance and/or
>> experience thus they may be bett
On 12 September 2016 at 23:19, Adam Jackson wrote:
> Signed-off-by: Adam Jackson
This should be fine for stable, correct ?
Cc: mesa-sta...@lists.freedesktop.org
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
ht
ter the variable declaration.
(More important) note:
Keeping the _eglLockDisplay() in the top level (EGL API) while the
unlock in the lower level (fooCommon) will come to bite us. We could
update the RETURN_EGL_ERROR and co + all the call sites yet it's not
something we have to do atm.
-Emil
rrentContext (B)
- surface - eglSwapInterval (B), eglGetCurrentSurface(B)
- image - ok
- sync - ok
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
t; + _EGL_FUNC_START(NULL, EGL_NONE, NULL, EGL_BAD_ALLOC);
> +
> + mtx_lock(_eglGlobal.Mutex);
> + if (attribute >= EGL_DEBUG_MSG_CRITICAL_KHR &&
> + attribute <= EGL_DEBUG_MSG_INFO_KHR) {
> + if (_eglGlobal.debugTypesEnabled & DebugBitFromType(at
On 13 September 2016 at 15:39, Emil Velikov wrote:
> On 12 September 2016 at 23:19, Adam Jackson wrote:
> (More important) note:
> Keeping the _eglLockDisplay() in the top level (EGL API) while the
> unlock in the lower level (fooCommon) will come to bite us. We could
others do.
Patches 13 + 14 have a few bugs alongside the coding style issues.
Everything else (1-12 incl.) is
Reviewed-by: Emil Velikov
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
this.
>>
>> Totally untested/thought through, but maybe the env should default to on?
>
>
> Agree, can you come up a patch for that?
>
> Also any outstanding patches for VA-API encode from you was reviewed, but
> not committed?
> if any, sent to me, I can push them.
On 13 September 2016 at 18:55, Adam Jackson wrote:
> On Tue, 2016-09-13 at 17:17 +0100, Emil Velikov wrote:
>
>> > + } else {
>> > + _eglDebugReportFull(EGL_BAD_ALLOC, __func__, __func__,
>> > + EGL_DEBUG_MSG_CRITICAL_KHR, N
On 13 September 2016 at 19:14, Adam Jackson wrote:
> On Tue, 2016-09-13 at 17:22 +0100, Emil Velikov wrote:
>
>> Actually, current code has a bunch of such bugs which this series addresses.
>> Considering there's only a couple of those and they are pretty hard to
>
On 13 September 2016 at 19:22, Adam Jackson wrote:
> On Tue, 2016-09-13 at 19:18 +0100, Emil Velikov wrote:
>
>> For the series as a whole ?
>> Two words which contradict any software's stable scheme - new feature.
>
> Disagree, but I'm not the one running Mes
On 13 September 2016 at 17:46, Adam Jackson wrote:
> On Tue, 2016-09-13 at 16:54 +0100, Emil Velikov wrote:
>> Going through table 13.2 and the below there are some discrepancies.
>>
>> AFAICT some of those can be seen as spec bugs (B), while others seem
>> to
On 13 September 2016 at 21:05, Eric Anholt wrote:
> Ilia Mirkin writes:
>
>> On Mon, Sep 12, 2016 at 11:55 AM, Emil Velikov
>> wrote:
>>> On 12 September 2016 at 15:35, Ilia Mirkin wrote:
>>>> On Mon, Sep 12, 2016 at 10:10 AM, Emil Velikov
>&g
On 14 September 2016 at 13:36, Adam Jackson wrote:
> On Wed, 2016-09-14 at 11:15 +0100, Emil Velikov wrote:
>
>> Nice one... I wonder if your view will be the same if you were never
>> involved in distribution packaging? Guess we'll never know :-\
>> In case you'
On 13 September 2016 at 17:31, Eric Engestrom wrote:
> From: Brendan King
>
> The Wayland Scanner pkg-config file is called wayland-scanner.pc.
>
Nice one, thanks.
Added the stable tag and pushed alongside the GBM cleanup patch.
Emil
ai Hähnle
>> Signed-off-by: Martina Kollarova
>
> Good cleanup :)
> Reviewed-by: Eric Engestrom
>
> By the way, I noticed this hasn't landed, after almost a week.
> Would anyone care to push it? Nicolai?
>
Just did. Thanks for the reminder !
Emil
___
s the fd.
Imho it might be worth going through the code paths adding comments
about the fd ownership at different stages while fixing any leaks that
you/others come across.
Note: Multiple displays/Xinerama and GL-VDPAU interop are sensitive on
the area, so I'd suggest testing things caref
On 14 September 2016 at 15:00, Adam Jackson wrote:
> On Wed, 2016-09-14 at 12:08 +0100, Emil Velikov wrote:
>
>> Thanks for reminding me - eglQueryAPI should never throw an error,
>> indeed. Since EGL_KHR_debug is applicable for functions_do_ throw an
>> error, one should
gt;
Just to double-check - by "breakage" and "unusable" you mean that it's
"awfully slow" correct ?
Do you/others have any plan to update the state-tracker and/or nouveau
to brings things back on par ?
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Hi all,
Mesa 12.0.3 is now available.
This is an emergency release addressing a number of regressions across all
devices using the i965 driver.
Emil Velikov (4):
docs: add sha256 checksums for 12.0.2
Revert "i965/miptree: Stop multiplying cube depth by 6 in HiZ
calcula
On 15 September 2016 at 10:56, Emil Velikov wrote:
> On 15 September 2016 at 02:54, Ilia Mirkin wrote:
>> On Wed, Sep 14, 2016 at 9:52 PM, Ilia Mirkin wrote:
>>> Recent changes have been made to the VDPAU state tracker to make it
>>> unusable with nouveau. Don'
ows/Makefile
> + src/glx/windows/windowsdriproto.pc
So this is where windowsdriproto is. Can I suggest moving that into
separate package/repo analogous to xf86driproto/dri2proto/dri3proto.
Having it in ~jturney/ would be fine as a start, until an admin
creates a repo in xorg
From: Emil Velikov
Analogous to the earlier android and wayland patches. As we're here we
can drop exposing the old version of the extension.
Any dri loader/driver interface use lower bound checking thus exposing
dri2 loader v3 to a v2 capable driver is perfectly normal.
v2: Preserve c
From: Emil Velikov
Remove the error prone fixed size array.
While we're here also rename to loader_extensions like in the GLX code.
v2: Rebase. Keep image_loader_extension within the wayland_drm
dri2_loader_extensions list.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_d
From: Emil Velikov
Will allow us to reuse the function for optional extensions and fold a
bit of code.
v2: Make dri2_bind_extensions::optional flag an argument to
dri2_bind_extensions (Kristian).
Cc: Rob Clark
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.c | 24
From: Emil Velikov
v2: dri2_bind_extensions() now takes optional as an argument.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.c | 28 ++--
1 file changed, 10 insertions(+), 18 deletions(-)
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers
From: Emil Velikov
v2: Rebase.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
index d2ae25a..75070da 100644
--- a/src/egl
From: Emil Velikov
Introduce a helper and use it throughout the platform code. This allows
us to reduce the amount of ifdef(s) and (potentially) use
kms_swrast_dri.so for !drm platforms (namely wayland and x11).
Note: in the future as other platforms (android, surfaceless) support
the extension
On 25 August 2016 at 17:18, Emil Velikov wrote:
> Hi all,
>
> With the resent noise in the egl area I decided to do some of the long
> planned cleanup in the area. It spans across the following:
>
> - glapi missing glFlush and non-shared glapi are not an option
> - enca
From: Emil Velikov
Currently we print a debug message if the total configs is non-zero only
to do the same (at an error level) as we return from the function.
Rework the message to print if we're missing a config for the given
format.
Signed-off-by: Emil Velikov
Reviewed-by: Gurchetan
From: Emil Velikov
Factor out and rework the existing code so that it prints a debug
message if we have zero configs for any visual.
As a nice side effect we now provide a correct (sequential ID) when
creating a config (via dri2_add_config).
v2: Use correct comparison in loop conditional (Eric
From: Emil Velikov
Iterate over the driver_configs first in order to cut down the number of
getConfigAttrib() calls by a factor of 5.
While we're here, also drop the sentinel of the visuals array. We
already know its size so we can use that and save a few bytes.
v2: Use correct comparis
From: Emil Velikov
Analogous to previous commit.
v2: Use correct comparison in loop conditional (Eric)
Use valid C initializer (Gurchetan)
Signed-off-by: Emil Velikov
Reviewed-by: Gurchetan Singh
---
src/egl/drivers/dri2/platform_surfaceless.c | 15 ---
1 file changed, 8
From: Emil Velikov
... in dri2_x11_add_configs_for_visuals().
Currently the latter does not consider that, thus in such cases it adds
"empty" configs in the list.
Properly account for things and as we do that we can reuse count,
instead of calling _eglGetArraySize to deterime if w
From: Emil Velikov
Analogous to previous commits - with an extra bonus.
Current code, apart from not attributing the lack of 'per visual'
and overall configs also overwrites the newly added config.
Namely if the dpy supports two or more of the supported formats
(XRGB, ARGB
From: Emil Velikov
v2: Remove gratuitous newline/semicolon (Eric)
Signed-off-by: Emil Velikov
Reviewed-by: Eric Engestrom
---
src/egl/drivers/dri2/platform_drm.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_drm.c
b
n _eglSetFuncName
> - Pass draw surface (if any) to _EGL_FUNC_START in eglSwapInterval
>
> v3:
> - Set dummy thread's CurrentAPI to EGL_OPENGL_ES_API not zero
Maybe (only maybe) we want this as a one-line fix for stable.
But regardless, this and v2 14/14 look a lot better and are
R
0+ entrypoints ... right ?
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
ext in
vl_dri3_screen_destroy and proper handling if context_create fails
seems to be missing.
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 19 September 2016 at 16:38, Jason Ekstrand wrote:
> It all looks fine to me. Feel free to add a
>
> Reviewed-by: Jason Ekstrand
>
> That said, my knowledge of the details of the DRI vfuncs is very limited so
> I'd like to see Emil or Axel sign off on it too, especiall
On 20 September 2016 at 09:32, Weng, Chuanbo wrote:
> Hi Emil,
> What you mentioned about style issue in last round is:
> Please move the variable declaration in local scope and add
> space between ){
> I think I have fixed these issue in this v
From: Emil Velikov
---
include/EGL/eglplatform.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/EGL/eglplatform.h b/include/EGL/eglplatform.h
index 16765fb..dc4a3e2 100644
--- a/include/EGL/eglplatform.h
+++ b/include/EGL/eglplatform.h
@@ -133,6 +133,7 @@ typedef Pixmap
From: Emil Velikov
---
XXX: This is the upstream/Khronos definition of it, although I'm not
perfectly sure if/how many users depend on it.
XXX: Worth folding with the original commit which introduces the EGL_USE
PLATFORM... lot ?
---
include/EGL/eglplatform.h | 6 ++
1 file chang
This reverts commit 1a7275de9a0088cedab17131eec82bd2cada26c3.
No longer required/needed as-of last commit.
Conflicts:
configure.ac
---
configure.ac | 7 ---
1 file changed, 7 deletions(-)
diff --git a/configure.ac b/configure.ac
index 0604ad9..d16447f 100644
--- a/configure.ac
+++ b
From: Emil Velikov
With the previous EGL_USE_PLATFORM_*_KHR in place one no longer needs
any of this fragile and somewhat buggy heuristics.
Users are responsible for requesting their preferred platform, with
adding a default to none/native types.
---
XXX: Similar to previous patch - something
From: Emil Velikov
In order to avoid the current, somewhat fragile detection in
eglplatform.h introduce explicit platform selection.
The approach is based on the one used in Vulkan and allows one to
explicitly "request" the platform they will be using without the need of
local hacks
From: Emil Velikov
There is no concept of display on XCB thus the connection is used
instead.
---
XXX: Pure XCB/Xlib-free implementation anyone ?
---
include/EGL/eglplatform.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/EGL/eglplatform.h b/include/EGL/eglplatform.h
index
From: Emil Velikov
This commit effectively reverts the following:
7d642442d9339e5b65c30802c44091816cdf18be
400b833592d9aad7b2c4627a897380642d52189f
2c6186390c48e0d1f2b4d4136c11eb0bedfd1aec
eddcecbf74da26716509c047b95e85b00c12bab4
c0f8c9911c82c576cdd82dabad4a2370ac53565c
perfect
world" solution, admittedly with the last 1-3 being rather debatable.
Any and all input would be greatly appreciated !
Thanks
Emil
** If we agree that we can remove the detection heuristics
Emil Velikov (7):
eglplatform.h: introduce and use EGL_USE_PLATFORM_*_KHR
eglp
+---
> src/gbm/main/gbm.c| 3 ++-
Thanks for the patches. I've split this into two (loader src/gbm and
"driver" src/gallium...) fixes, tagged for stable, applied some coding
style polish and pushed the series to master.
-Emil
__
I've Cc'd Roland
(the author of the commit 'breaking' this) and Stéphane (the author of
this driver).
Gents, any input on the above ?
That said, please drop the unneeded brackets and add the following
line in the commit message for v2.
Cc: mesa-sta...@lists.freedesktop.org
Thanks,
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
API is exported we might as well do
the same for GLES 3.2.
It's a bit shame on the (broken?) ABI side of things, but well we
cannot do much at this point. I'm still finding my way around in
Khronos, but I have a few ideas how one can update things going
forward (GLES 3.3 anyone?).
Regards,
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 14 September 2016 at 15:04, Emil Velikov wrote:
> Hi Lukasz,
>
> On 5 September 2016 at 17:48, Lukasz Spintzyk
> wrote:
>> This closes filedescriptor owned by kms_dri_sw_winsys struct. It fixes issue
>> where removal of udl or evdi module used by DisplayLink devices w
n with the actual (present or not) winsys layer.
There's nothing specific in the spec that needs addressing just a
couple maybe nice ideas:
- Consider exposing the extension on EGL_EXT_client_extensions +
EGL_EXT_platform_base aware implementations
- Worth adding a small example alike the other
>rc = PIPE_H264_ENC_RATE_CONTROL_METHOD_DISABLE;
>}
> + if (attrib_list[i].type == VAConfigAttribRTFormat) {
> + if (attrib_list[i].value & VA_RT_FORMAT_YUV420) {
s/&/==/ ?
Regards,
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
e_id, matrix_id;
> +
> + for (size_id = 0; size_id < 4; ++size_id) {
Why would one loop over size_id, if close of everything in the loop is
special cased on the size_id ?
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 23 September 2016 at 17:32, Leo Liu wrote:
> So that it will pass correct size to width(height)_in_samples in
> uvd message buffer.
>
The st code is device agnostic. s/uvd/hardware/ perhaps ?
-Emil
___
mesa-dev mailing list
faict 3-5 are bugfixes so please add a bit more context in the commit
message and
Cc: mesa-sta...@lists.freedesktop.org
Reviewed-by: Emil Velikov
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Since Leo is on vacation I will probably collect all remaining mesa patches
> and commit them later today.
>
Christian please s/v2 st/va /st/va: / the commit message and add
Cc: mesa-sta...@lists.freedesktop.org
Thanks
Emil
Andy: git format-patch
?
Can you apply a minor polish to the comment - "XXX/TODO: pbuffer +
MSAA does not work + QT bugreport" or alike.
Cc: mesa-sta...@lists.freedesktop.org
Reviewed-by: Emil Velikov
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Used/applicable to only dri1 drivers.
Signed-off-by: Emil Velikov
---
If anyone wants to go ahead and start moving the DRI1 only functionality
to src/glx/dri[1] that'll be appreciated.
---
src/glx/dri2_glx.c | 2 --
src/glx/dri3_glx.c | 1 -
src/glx/drisw_glx.c | 1 -
3 files chang
From: Emil Velikov
Otherwise one can overflow the signed variable and (attempt to) cause
all sorts of strange behaviour.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.c | 2 +-
src/egl/main/eglconfig.c| 3 ++-
src/egl/main/eglcontext.c | 3 ++-
src/egl/main
On 25 September 2016 at 00:17, Eric Engestrom wrote:
> On Thu, Sep 22, 2016 at 09:38:06AM +0100, Emil Velikov wrote:
>> From: Emil Velikov
>>
>> In order to avoid the current, somewhat fragile detection in
>> eglplatform.h introduce explicit platform selection.
>>
On 27 September 2016 at 13:13, Christian König wrote:
> Hi Indrajit,
>
> please send this patch once more as text mail. I can't commit it like this.
>
Having a commit message is strongly recommended. A fixes and/or stable
tag would be even better
On 27 September 2016 at 16:18, Eric Engestrom wrote:
> On Tue, Sep 27, 2016 at 04:10:53PM +0200, Nicolai Hähnle wrote:
>> On 27.09.2016 14:40, Emil Velikov wrote:
>> > From: Emil Velikov
>> >
>> > Otherwise one can overflow the signed variable and (attempt
e complete. Devs, let me know if there's a "must have"
feature that we want in 12.1.
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
or all Mesa code
> would be more robust.
>
... this doesn't is not a wise move.
Don't force jemalloc onto everyone without having an explicit ACK from
a wide audience, please ? Considering the static/shared link (or w/o
jemalloc all together) distributions will have their
preferences/policies which won't align with my/your view.
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 27 September 2016 at 13:47, Marek Olšák wrote:
> On Tue, Sep 27, 2016 at 2:34 PM, Emil Velikov
> wrote:
>> On 26 September 2016 at 08:41, Tapani Pälli wrote:
>>> This fixes a crash in egl-create-msaa-pbuffer-surface Piglit test
>>> and same crash in many dEQP E
eof(int_list[0]) !=
sizeof(attrib_list[0]).
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
he following. No regressions found. Ratios are pass/fail.
>
> BEFORE AFTER
> dEQP-EGL.functional.fence_sync.* deadlock 27/0
> dEQP-EGL.functional.reusable_sync.* : 8/17 8/17
> piglit egl_khr_fence_sync pass pass
>
Wi
t used afaics) and b) we'll error out if the user provides an
empty/null list (not the most useful thing to do, but still).
Afaics all the EGL 1.5 entry points either explicitly state that
attrib_list can be null or empty or say that all the unspecified
attribs will be set to their defa
On 29 September 2016 at 18:48, Marek Olšák wrote:
> On Thu, Sep 29, 2016 at 4:56 PM, Emil Velikov
> wrote:
>> On 29 September 2016 at 11:48, Marek Olšák wrote:
>>> On Thu, Sep 29, 2016 at 11:20 AM, Nicolai Hähnle wrote:
>>>> On 28.09.2016 18:49, Marek Olš
From: Emil Velikov
The comment/spec says - only for pbuffer drawables, while the code
clears the window/pixmap bit. Practise what you preach and apply the
trivial tweak. In practise this should not cause functional change.
Signed-off-by: Emil Velikov
---
src/glx/glxext.c | 2 +-
1 file
From: Emil Velikov
Return GL_FALSE if we fail to find any fb/visual configs, otherwise we
end up with all sorts of chaos further down the GLX stack.
Signed-off-by: Emil Velikov
---
src/glx/glxext.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/glx/glxext.c b
From: Emil Velikov
The function deals with fb (style) configs, thus using "visual"
in the name is misleading. Which in itself had led to the use of
fbconfig_style_tags argument.
Rename the function to reflect what it does and drop the unneeded
argument.
Signed-off-by: Emil Velikov
On 30 September 2016 at 02:31, Dave Airlie wrote:
> On 30 September 2016 at 01:07, Jason Ekstrand wrote:
>> On Sep 29, 2016 7:56 AM, "Emil Velikov" wrote:
>>>
>>> On 28 September 2016 at 19:53, Marek Olšák wrote:
>>> > Hi,
>>> >
>
On 30 September 2016 at 03:31, Timothy Arceri
wrote:
> On Thu, 2016-09-29 at 19:17 -0700, Jason Ekstrand wrote:
>
> On Sep 29, 2016 5:14 PM, "Timothy Arceri"
> wrote:
>>
>> On Thu, 2016-09-29 at 15:56 +0100, Emil Velikov wrote:
>> > On 28
From: Emil Velikov
Currently we only saved the id to memcpy the whole _EGLConfig to write
back the exact same id value.
Remove the unneeded and confusing/misleading code.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src
509
>
> v2: Ian pointed out that v1 removed support for all multisample
> configs, including window ones. This one removes pbuffer bit
> when adding configs, now only pbuffer+msaa gets rejected and
> window+msaa continues to work. Fixed also comment (Emil)
>
> Signed-
p a bit, even though it's quite trivial fix.
Please do either - one per subsystem (file effectively) or egl,
gallium/auxiliary, st/dri, st/xa & gallium/winsys ?
Thanks again !
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
gt; +Version 9.0 of Mesa also included the first release of the Clover state
> +tracker for OpenCL.
> +
>
Mentioning Clover whist omitting VDPAU/OMX and others is a bit meh.
Either way, thanks for the update Brian.
Reviewed-by: Emil Velikov
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
test "x$enable_lmsensors" = xyes)
> +if test "x$enable_lmsensors" = xyes ; then
> +DEFINES="${DEFINES} -DHAVE_LIBSENSORS=1"
> +LIBSENSORS_LDFLAGS="-lsensors"
> +else
> +LIBSENSORS_LDFLAGS=""
> +fi
> +AC_SUBST(LIBS
On 30 September 2016 at 15:57, Ian Romanick wrote:
> On 09/30/2016 06:23 AM, Brian Paul wrote:
>> On 09/30/2016 04:59 AM, Emil Velikov wrote:
>>> On 30 September 2016 at 03:31, Timothy Arceri
>>> wrote:
>>>> On Thu, 2016-09-29 at 19:17 -0700, Jason Ekstran
clear that this header should not be installed.
Then again looking at our current wildcard installing ... seems like
it was.
Please drop this file from the install stage ?
> +endif
> +endif
> +
> +if HAVE_COMMON_OSMESA
> +osmesadir = $(includedir)/GL
> +osmesa_HEADERS = $(top
On 25 September 2016 at 04:24, Eric Engestrom wrote:
> On Thu, Aug 25, 2016 at 05:18:32PM +0100, Emil Velikov wrote:
>> From: Emil Velikov
>>
>> Duplicate a few lines at the expense of making the code-flow clearer
>> while adding a few extra comments ;-)
>&g
From: Emil Velikov
Fold duplicate conditional blocks and add a few extra comments ;-)
v2: Bring back the explicit "unbind" logic (Eric), remove NULL derefs.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.c | 72 -
1 file c
On 4 October 2016 at 02:05, Rob Clark wrote:
> On Thu, Sep 29, 2016 at 10:56 AM, Emil Velikov
> wrote:
>> On 28 September 2016 at 19:53, Marek Olšák wrote:
>>> Hi,
>>>
>>> It's been almost 4 months since the 12.0 branch was created, and soon
>&g
hey deserve more cleaning and testing, but if it's Oct 7, we'll try be on
> time.
>
14th it is. As mentioned before: _don't_ wait for the last week to get
things merged. Once you're reasonably happy just send the new work
review and commit it.
Same applies for bugfixes :-)
T
er.cpp
ac_llvm_util.c
ac_llvm_util.h
ac_nir_to_llvm.c
ac_nir_to_llvm.h
ac_radeon_winsys.h
> +#pragma once
> +
Please don't use pragma once, but ifdef FOO/define FOO guards.
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
It'll be worth when porting newer anv changes.
As a follow up we might want to check that the common headers don't
get overwritten at install stage (factor out the vulkan_include*
and/or move to reuse the Khronos ones).
Well done and keep up the nice work :-)
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
eral is using pragma's
> over usual header guards.. You guys likely did this for rapid dev but I
> think we should fix them to be guards before merge.
>
Seems like ANV is doing the same, so one shouldn't point fingers at RADV.
That said, gents can
src/util/u_atomic.h | 21 +
> 2 files changed, 32 insertions(+)
>
On the build side the patch looks great, I haven't looked at the
atomic specifics.
Reviewed-by: Emil Velikov
-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 4 October 2016 at 15:57, Rob Herring wrote:
> On Tue, Oct 4, 2016 at 5:26 AM, Emil Velikov wrote:
>> On 4 October 2016 at 02:05, Rob Clark wrote:
>>> On Thu, Sep 29, 2016 at 10:56 AM, Emil Velikov
>>> wrote:
>>>> On 28 September 2016 at 19:53, Marek O
On 4 October 2016 at 22:31, Chad Versace wrote:
> On Thu 29 Sep 2016, Emil Velikov wrote:
>> On 28 September 2016 at 07:28, Chad Versace wrote:
>> > Pre-patch, there were two code paths for parsing EGLSync attribute
>> > lists: one path for old-style EGLint list
it.
>> As a follow up we might want to check that the common headers don't
>> get overwritten at install stage (factor out the vulkan_include*
>> and/or move to reuse the Khronos ones).
>
> This would be a problem with anv now wouldn't it?
>
Sort of... it depends on a number of factors.
Thanks again,
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
make the LLVM requirement implicit as requesting a
driver which uses LLVM.
Even then, some modules can optionally make use of it (LLVM) for which
we'll still need the toggle :-\
Afaict RADV does not use the gallium aux module so the above should
not be needed, no ?
-Emil
__
that should be fixed in
LLVM. Namely: if a library sets up a state it should cleanup after
itself.
That aside, does the radv vulkan driver have unresolved/undefined
symbols (check via $ldd -r libvulkan_foo.so) with your workaround ? If
not we {c,sh}ould drop the library from the link chain. Alterna
ription of the bug is greatly recommended.
Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 5 October 2016 at 21:08, Axel Davy wrote:
> Uses the new defines introduced in previous commit.
>
Please describe why the newly introduced flags are used over the
present ones. Worth copying some of the in-source comment or
referencing it ?
1101 - 1200 of 8586 matches
Mail list logo
