Signed-off-by: Dylan Baker
---
meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index c568fdb8785..52f2c1cb0d0 100644
--- a/meson.build
+++ b/meson.build
@@ -707,7 +707,7 @@ if with_gallium_freedreno
endif
llvm_modules
during
the initial meosn pass, and removing some code duplication.
Dylan Baker (6):
meson: Remove duplicate _GNU_SOURCE
meson: Convert platform to auto
meson: convert llvm option to tristate
meson: Fix LLVM requires for radeonsi
meson: add logic to select apple and windows dri
meson
for the series:
Reviewed-by: Dylan Baker
Quoting Eric Engestrom (2017-11-21 07:09:40)
> Signed-off-by: Eric Engestrom
> ---
> src/mapi/glapi/meson.build | 2 ++
> src/mapi/meson.build | 2 +-
> src/meson.build| 1 -
> 3 files changed, 3 insertions(+), 2 dele
Quoting Eric Engestrom (2017-11-21 02:39:44)
> On Monday, 2017-11-20 11:09:39 -0800, Dylan Baker wrote:
> > Which is required for the gallium media state trackers.
> >
> > v4: - Make the full version the hard link and the partial so versiions
> > the symlinks
>
Thanks for making that change.
Reviewed-by: Dylan Baker
Quoting Juan A. Suarez Romero (2017-11-21 03:40:51)
> v2: generate target conditionally (Dylan)
> ---
> src/gallium/targets/dri/meson.build | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/targets/dr
Quoting Eric Engestrom (2017-11-21 06:06:33)
> On Monday, 2017-11-20 15:12:51 -0800, Dylan Baker wrote:
> > Because meson won't put it in that folder.
> >
> > Signed-off-by: Dylan Baker
> > ---
> > src/mapi/glapi/tests/check_table.cpp | 2 +-
> &g
This is still not fully correct (haiku and BSD is notably probably not
correct), but Linux is not regressed and this should be correct for
macOS and Windows.
v2: - set the dri_platform to windows on Cygwin as well (Jon)
Signed-off-by: Dylan Baker
---
meson.build | 15 +--
1 file
Quoting Eric Engestrom (2017-11-21 10:38:25)
> On Tuesday, 2017-11-21 10:21:07 -0800, Dylan Baker wrote:
> > This is still not fully correct (haiku and BSD is notably probably not
> > correct), but Linux is not regressed and this should be correct for
> > macOS and Windows.
&
Oops, that's what I get for not copy-n-pasting.
Reviewed-by: Dylan Baker
Quoting Eric Engestrom (2017-11-21 06:26:03)
> Fixes: d1992255bb29054fa5176 "meson: Add build Intel "anv" vulkan driver"
> Signed-off-by: Eric Engestrom
> ---
> meson.build | 2 +-
Quoting Eric Engestrom (2017-11-22 03:16:17)
> On Tuesday, 2017-11-21 10:50:29 -0800, Dylan Baker wrote:
> > Quoting Eric Engestrom (2017-11-21 10:38:25)
> > > On Tuesday, 2017-11-21 10:21:07 -0800, Dylan Baker wrote:
> > > > This is still not fully correct (haiku a
With the one thing Eric pointed out changed, this patch and the next one are:
Reviewed-by: Dylan Baker
Thanks for making those changes for me.
Quoting Ian Romanick (2017-11-20 17:24:09)
> From: Ian Romanick
>
> v2: Clean ups. Remove some functions that never ended up being used
Quoting Emil Velikov (2017-11-23 11:04:34)
> On 20 November 2017 at 23:12, Dylan Baker wrote:
> > This doesn't actually accomplish what it's meant to do, as extern C
> > doesn't undefine __cplusplus, so the included headers define a template
> > (because __
This seems reasonable,
Reviewed-by: Dylan Baker
Quoting Emil Velikov (2017-11-24 06:25:03)
> From: Emil Velikov
>
> Analogous to the other build systems.
>
> Cc: Eric Engestrom
> Cc: Dylan Baker
> Signed-off-by: Emil Velikov
> ---
> meson.build | 4 ++--
>
Quoting Jon Turney (2017-11-27 05:58:32)
> ---
> src/glx/meson.build | 25 +--
> src/glx/windows/meson.build | 48
> +
> 2 files changed, 63 insertions(+), 10 deletions(-)
> create mode 100644 src/glx/windows/meson.build
>
I had a few comments on the "build src/glx/windows" patch, but the rest of the
patches are:
Reviewed-by: Dylan Baker
Quoting Jon Turney (2017-11-27 05:58:27)
> This series lets me build a mesa for Cygwin configured with:
>
> -Ddri-drivers=swrast -Dgallium-drivers= -Dplatfo
Although now that I think about it, meson does have a b_undef option, so
actually the right way to do this is to add
'b_undef=true' to the default options in the project() call.
Sorry for the confusion,
Dylan
Quoting Dylan Baker (2017-11-27 10:22:40)
> This seems reasonable,
Quoting Dylan Baker (2017-11-27 10:40:18)
> Although now that I think about it, meson does have a b_undef option, so
> actually the right way to do this is to add
> 'b_undef=true' to the default options in the project() call.
>
> Sorry for the confusion,
>
Quoting Eric Engestrom (2017-11-27 09:46:57)
> On Saturday, 2017-11-25 18:45:14 +0100, Gert Wollny wrote:
> > Am Freitag, den 24.11.2017, 18:07 + schrieb Eric Engestrom:
> > > Signed-off-by: Eric Engestrom
> > > ---
> > > src/util/ralloc.c | 18 +-
> > > src/util/slab.c | 4
Quoting Emil Velikov (2017-11-27 06:31:35)
> IIRC Windows mandates binaries with unresolved symbols.
> Other platforms allow such behaviour.
>
> I think we want to set b_lundef=true, to catch these issues as part of
> the build process.
> We already do so in the autotools, android and at least par
So that state trackers, targets, and special winsys requirements are all
in a single if statement. This is a cosmetic only cleanup with no
functional changes.
Signed-off-by: Dylan Baker
---
src/gallium/meson.build | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git
This is a requirement of the next patch. Since meson does not have
forward declarations, and we're going to define the driver dependencies
in the drivers folder they need to be after the winsys so that the
winsys libs are defined first.
Signed-off-by: Dylan Baker
---
src/gallium/meson.
Signed-off-by: Dylan Baker
---
meson.build | 41 +-
meson_options.txt | 13 ++
src/gallium/meson.build | 7 ++-
src/gallium/state_trackers/va/meson.build | 39 +
src/gallium/targets/va
lot of code de-duplication between gallium
targets.
Signed-off-by: Dylan Baker
---
src/gallium/drivers/etnaviv/meson.build | 5 +
src/gallium/drivers/freedreno/meson.build | 5 +
src/gallium/drivers/i915/meson.build | 5 +
src/gallium/drivers/llvmpipe/meson.build | 8
Signed-off-by: Dylan Baker
---
src/gallium/targets/libgl-xlib/meson.build | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/src/gallium/targets/libgl-xlib/meson.build
b/src/gallium/targets/libgl-xlib/meson.build
index 825b7b4a0f1..c7e51a0f26d 100644
--- a/src
Signed-off-by: Dylan Baker
---
src/gallium/targets/dri/meson.build | 126
1 file changed, 26 insertions(+), 100 deletions(-)
diff --git a/src/gallium/targets/dri/meson.build
b/src/gallium/targets/dri/meson.build
index 323b337266f..42033a16211 100644
--- a
maining
drivers + media series, but now making use of the internal dependencies, and are
joined by the D3D "nine" state tracker.
Dylan Baker (14):
meson: Combine gallium target subdirs
meson: sort gallium drivers after winsys
meson: define driver dependencies
meson: use the dr
Signed-off-by: Dylan Baker
---
src/gallium/targets/osmesa/meson.build | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/src/gallium/targets/osmesa/meson.build
b/src/gallium/targets/osmesa/meson.build
index 72f77724e44..e8e8e4822d8 100644
--- a/src/gallium
Signed-off-by: Dylan Baker
---
meson.build | 22
meson_options.txt | 7
src/gallium/meson.build | 7 +++-
src/gallium/state_trackers/xa/meson.build | 45 +++
src/gallium/targets/xa
Signed-off-by: Dylan Baker
---
meson.build | 46 +-
meson_options.txt| 13 +
src/gallium/meson.build | 7 ++-
src/gallium/state_trackers/vdpau/meson.build | 32 +
src/gallium
This argument is the wrong approach for handling gallium media state
trackers, since it doesn't allow for an auto option. Instead we'll use
tristates, which do allow for auto.
This option has never been wired to anything anyway.
Signed-off-by: Dylan Baker
Reviewed-by: Eric
Which is required for the gallium media state trackers.
Signed-off-by: Dylan Baker
Reviewed-by: Eric Engestrom
---
bin/install_megadrivers.py | 8
1 file changed, 8 insertions(+)
diff --git a/bin/install_megadrivers.py b/bin/install_megadrivers.py
index a98d7dd177b..587a1f6726d
Signed-off-by: Dylan Baker
---
meson.build| 60 +-
meson_options.txt | 13 +
src/gallium/meson.build| 7 ++-
.../state_trackers/omx_bellagio/meson.build| 30
Signed-off-by: Dylan Baker
---
meson.build | 40 +-
meson_options.txt | 13 ++
src/gallium/meson.build | 7 +++-
src/gallium/state_trackers/xvmc/meson.build | 53 +++
src
Signed-off-by: Dylan Baker
---
include/meson.build| 8 ++
meson.build| 17 +++-
meson_options.txt | 12 +++
src/gallium/meson.build| 7 +-
.../gallium
Quoting Marek Olšák (2017-11-28 13:38:37)
> From: Marek Olšák
>
> ---
> src/gallium/drivers/radeon/Makefile.am | 1 +
> src/gallium/drivers/radeon/r600_query.c | 9 +++--
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/src/gallium/drivers/radeon/Makefile.am
> b/src/gal
Signed-off-by: Dylan Baker
---
meson.build | 11 +++
meson_options.txt | 7 +++
src/gallium/drivers/etnaviv/meson.build | 2 +-
src/gallium/drivers/freedreno/meson.build | 1 +
src/gallium/drivers/nouveau/meson.build | 2
Signed-off-by: Dylan Baker
---
meson.build | 4
meson_options.txt | 6 ++
2 files changed, 10 insertions(+)
diff --git a/meson.build b/meson.build
index e2ba3cb0524..e3c201d7b87 100644
--- a/meson.build
+++ b/meson.build
@@ -916,6 +916,10 @@ if with_platform_x11
endif
endif
They are the same thing, but this is more consistent with the rest of
the project.
Signed-off-by: Dylan Baker
---
src/gallium/drivers/freedreno/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/freedreno/meson.build
b/src/gallium/drivers
Quoting Eric Engestrom (2017-11-29 06:41:32)
> On Tuesday, 2017-11-28 16:56:38 -0800, Dylan Baker wrote:
> > Signed-off-by: Dylan Baker
> > ---
> > meson.build | 11 +++
> > meson_options.txt | 7 +
Quoting Eric Engestrom (2017-11-29 06:41:32)
> On Tuesday, 2017-11-28 16:56:38 -0800, Dylan Baker wrote:
> > Signed-off-by: Dylan Baker
> > ---
> > meson.build | 11 +++
> > meson_options.txt | 7 +
Quoting Jon Turney (2017-11-29 08:23:00)
> On 27/11/2017 18:35, Dylan Baker wrote:
> > Quoting Jon Turney (2017-11-27 05:58:32)
> >> ---
> >> src/glx/meson.build | 25 +--
> >>
Quoting Jon Turney (2017-11-29 08:22:54)
> On 28/11/2017 18:21, Dylan Baker wrote:
> > Quoting Emil Velikov (2017-11-27 06:31:35)
> >> IIRC Windows mandates binaries with unresolved symbols.
> >> Other platforms allow such behaviour.
> >>
> >> I think
Quoting Marc Dietrich (2017-11-29 03:59:30)
> Hi Dylan,
>
> Am Mittwoch, 29. November 2017, 00:30:27 CET schrieb Dylan Baker:
> > Signed-off-by: Dylan Baker
> > ---
> > src/gallium/targets/osmesa/meson.build | 13 +++--
> > 1 file changed, 3 insertions(
Quoting Marc Dietrich (2017-11-29 04:41:15)
> Am Mittwoch, 29. November 2017, 00:30:35 CET schrieb Dylan Baker:
> > Signed-off-by: Dylan Baker
> > ---
> > include/meson.build| 8 ++
> > meson.build
Quoting Marc Dietrich (2017-11-29 04:31:07)
> Hi Dylan,
>
> Am Mittwoch, 29. November 2017, 00:30:21 CET schrieb Dylan Baker:
> > This series is the gallium media state trackers, the "nine" Direct3D state
> > tracker, and an architectural change in the way gallium
Signed-off-by: Dylan Baker
---
src/gallium/targets/dri/meson.build | 126
1 file changed, 26 insertions(+), 100 deletions(-)
diff --git a/src/gallium/targets/dri/meson.build
b/src/gallium/targets/dri/meson.build
index 323b337266f..42033a16211 100644
--- a
So that state trackers, targets, and special winsys requirements are all
in a single if statement. This is a cosmetic only cleanup with no
functional changes.
Signed-off-by: Dylan Baker
---
src/gallium/meson.build | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git
This is a requirement of the next patch. Since meson does not have
forward declarations, and we're going to define the driver dependencies
in the drivers folder they need to be after the winsys so that the
winsys libs are defined first.
Signed-off-by: Dylan Baker
---
src/gallium/meson.
Which is required for the gallium media state trackers.
v2: - Make symlinks local instead of absolute
Signed-off-by: Dylan Baker
Reviewed-by: Eric Engestrom (v1)
---
bin/install_megadrivers.py | 14 ++
1 file changed, 14 insertions(+)
diff --git a/bin/install_megadrivers.py b/bin
v2: - Add this patch
Signed-off-by: Dylan Baker
---
src/gallium/targets/osmesa/meson.build | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/targets/osmesa/meson.build
b/src/gallium/targets/osmesa/meson.build
index 760703d418f..cbf0e3d096a 100644
--- a/src/gallium/targets
oduces are relative rather
than absolute.
Dylan Baker (15):
meson: Combine gallium target subdirs
meson: sort gallium drivers after winsys
meson: define driver dependencies
meson: use the driver dependencies for the gallium dri target
meson: Use driver dependencies for libgl-xlib target
Signed-off-by: Dylan Baker
---
meson.build | 40 +-
meson_options.txt | 13 ++
src/gallium/meson.build | 7 +++-
src/gallium/state_trackers/xvmc/meson.build | 53 +++
src
Signed-off-by: Dylan Baker
---
meson.build | 46 +-
meson_options.txt| 13 +
src/gallium/meson.build | 7 ++-
src/gallium/state_trackers/vdpau/meson.build | 32 +
src/gallium
Signed-off-by: Dylan Baker
---
meson.build| 60 +-
meson_options.txt | 13 +
src/gallium/meson.build| 7 ++-
.../state_trackers/omx_bellagio/meson.build| 30
Signed-off-by: Dylan Baker
---
meson.build | 22
meson_options.txt | 7
src/gallium/meson.build | 7 +++-
src/gallium/state_trackers/xa/meson.build | 45 +++
src/gallium/targets/xa
This argument is the wrong approach for handling gallium media state
trackers, since it doesn't allow for an auto option. Instead we'll use
tristates, which do allow for auto.
This option has never been wired to anything anyway.
Signed-off-by: Dylan Baker
Reviewed-by: Eric
v2: - Put driver_swrast in the correct field (dependencies)
- Remove unused osmesa_deps
Signed-off-by: Dylan Baker
---
src/gallium/targets/osmesa/meson.build | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/src/gallium/targets/osmesa/meson.build
b/src
Signed-off-by: Dylan Baker
---
meson.build | 41 +-
meson_options.txt | 13 ++
src/gallium/meson.build | 7 ++-
src/gallium/state_trackers/va/meson.build | 39 +
src/gallium/targets/va
v2: - set d3d_drivers_path instead of dri_drivers_path
- Fix nine guard to check for all relavent gallium drivers
- Link with libswdri and libswkmsdri when necessary
- Fix pkg-config generation
- Add missing comma
Signed-off-by: Dylan Baker
---
include/meson.build
v2: - put driver_swrast in the right field
- add dep_threads (dep_llvm requires threads, so it masked this
previously)
Signed-off-by: Dylan Baker
---
src/gallium/targets/libgl-xlib/meson.build | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/src
lot of code de-duplication between gallium
targets.
Signed-off-by: Dylan Baker
---
src/gallium/drivers/etnaviv/meson.build | 5 +
src/gallium/drivers/freedreno/meson.build | 5 +
src/gallium/drivers/i915/meson.build | 5 +
src/gallium/drivers/llvmpipe/meson.build | 8
This is a typo, gl32.h is installed twice.
Reported-by: Marc Dietrich
Signed-off-by: Dylan Baker
---
include/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/meson.build b/include/meson.build
index b5f533bd185..c6aa9248247 100644
--- a/include/meson.build
Another typo, the glext.h header was being install instead.
Reported-by: Marc Dietrich
Signed-off-by: Dylan Baker
---
include/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/meson.build b/include/meson.build
index c6aa9248247..35e7791507c 100644
--- a
Quoting Marc Dietrich (2017-11-29 05:47:55)
> gcc seems to always accept unsupported negative compiler warning options:
>
> echo "int i;" | gcc -c -xc -Wno-bob - # no error
> echo "int i;" | gcc -c -xc -Walice - # unsupported compiler option
>
> Inverting the options fixes the tests.
>
> Signed
Reviewed-by: Dylan Baker
Quoting Marc Dietrich (2017-11-29 13:25:05)
> gcc seems to always accept unsupported negative compiler warning options:
>
> echo "int i;" | gcc -c -xc -Wno-bob - # no error
> echo "int i;" | gcc -c -xc -Walice - # unsupported compiler o
Quoting Eric Engestrom (2017-11-29 07:19:02)
> On Wednesday, 2017-11-29 09:32:09 +0530, Gurkirpal Singh wrote:
> > These are the refactored commits related to the GSoC project involving
> > adding a st/omx state tracker using tizonia.
> > There are still some parts of code that i didn't refactor ye
Quoting Marc Dietrich (2017-11-30 01:12:42)
> Hi Dylan,
>
> Am Mittwoch, 29. November 2017, 19:14:37 CET schrieb Dylan Baker:
> > Quoting Marc Dietrich (2017-11-29 04:31:07)
> >
> > > Hi Dylan,
> > >
> > > Am Mittwoch, 29. November 2017, 00:30:21
Quoting Eric Engestrom (2017-11-29 07:44:08)
> On Tuesday, 2017-11-28 15:30:21 -0800, Dylan Baker wrote:
> > This series is the gallium media state trackers, the "nine" Direct3D state
> > tracker, and an architectural change in the way gallium drivers are linked
>
Reported-by: Marc Dietrich
Signed-off-by: Dylan Baker
---
include/meson.build | 4
1 file changed, 4 insertions(+)
diff --git a/include/meson.build b/include/meson.build
index 35e7791507c..bae6742c4d6 100644
--- a/include/meson.build
+++ b/include/meson.build
@@ -66,3 +66,7 @@ if with_egl
Signed-off-by: Dylan Baker
---
include/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/meson.build b/include/meson.build
index bae6742c4d6..424d89acc83 100644
--- a/include/meson.build
+++ b/include/meson.build
@@ -40,7 +40,7 @@ if with_gles2
)
endif
Quoting Emil Velikov (2017-11-30 10:49:19)
> s/headers/header/ in the title. With that the series is
> Reviewed-by: Emil Velikov
>
> -Emil
Thanks Emil.
Should we be installing the dri.pc when you build gallium drivers as dri
drivers, but no "pure" dri drivers?
Dylan
signature.asc
Description
Quoting Emil Velikov (2017-11-30 11:12:12)
> On 30 November 2017 at 18:58, Dylan Baker wrote:
> > Quoting Emil Velikov (2017-11-30 10:49:19)
> >> s/headers/header/ in the title. With that the series is
> >> Reviewed-by: Emil Velikov
> >>
> >> -E
Currently this pkg-config file is only installed if a classic dri driver
is built. This is wrong, it should be installed if any dri driver is
installed, which includes the gallium dri target.
Reported-by: Marc Dietrich
Signed-off-by: Dylan Baker
---
src/mesa/drivers/dri/meson.build | 18
As we discussed elsewhere, this should fix the linkage of the dri3 loader and
glx and egl.
Dylan Baker (3):
meson: Reformat meson code to match more common style
meson: fix underlinkage without dri3
meson: Fix overlinkage of dri3 loader
src/egl/meson.build| 2 +-
src/glx/meson.build
Generally in our meson build large arrays are formated in the form:
[
..., ..., ..., $
...,
]
So use that form
Signed-off-by: Dylan Baker
---
src/glx/meson.build | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/src/glx/meson.build b/src/glx/meson.build
This was covering for underinkage elsewhere. With that fixed these can
be removed.
Signed-off-by: Dylan Baker
---
src/loader/meson.build | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/loader/meson.build b/src/loader/meson.build
index 2f97cdc83bf..ce7e13c3542 100644
There are some case where the dri3 loader is covering for underlinkage
for GLX and EGL, provide the linkage that they actually need.
Signed-off-by: Dylan Baker
---
src/egl/meson.build | 2 +-
src/glx/meson.build | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/egl
Thanks for looking into this, I've gone ahead and pushed this to master.
Dylan
Quoting Marc Dietrich (2017-11-29 13:25:05)
> gcc seems to always accept unsupported negative compiler warning options:
>
> echo "int i;" | gcc -c -xc -Wno-bob - # no error
> echo "int i;" | gcc -c -xc -Walice - # un
Reviewed-by: Dylan Baker
Quoting Rob Clark (2017-12-04 05:44:59)
> Otherwise huge amount of spam from instr-a2xx.h.. gcc has no way to know
> that freedreno was never built with such an old gcc version to care
> about the bugs in old gcc ;-)
>
> Patch is really Eric Engestrom&
Quoting Emil Velikov (2017-12-04 05:20:03)
> On 29 November 2017 at 00:56, Dylan Baker wrote:
> > Signed-off-by: Dylan Baker
> > ---
> > meson.build | 11 +++
> > meson_options.txt | 7 +++
>
ends on vc4')
> +endif
There's a similar check for imx and etnaviv in the root meson.build, I think we
should either move that one or put this check in the root. I don't have a
preference either way, if you'd rather move the imx/etnaviv check that should be
it's o
Quoting Emil Velikov (2017-12-04 10:14:15)
> On 4 December 2017 at 18:06, Dylan Baker wrote:
> > Quoting Emil Velikov (2017-12-04 05:20:03)
> >> On 29 November 2017 at 00:56, Dylan Baker wrote:
> >> > Signed-off-by: Dylan Baker
> >> > ---
> >>
Quoting Emil Velikov (2017-12-04 09:28:19)
> On 1 December 2017 at 23:06, Dylan Baker wrote:
> > There are some case where the dri3 loader is covering for underlinkage
> > for GLX and EGL, provide the linkage that they actually need.
> >
> > Signed-off-by: Dylan
Fixes: 5e71efef44b992b5d70b ("meson: Add lmsensors support")
Signed-off-by: Dylan Baker
---
src/gallium/targets/libgl-xlib/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/targets/libgl-xlib/meson.build
b/src/gallium/targets/libgl-xlib/m
Quoting Eric Engestrom (2017-12-04 07:38:04)
> On Thursday, 2017-11-30 10:34:06 -0800, Dylan Baker wrote:
> > Quoting Eric Engestrom (2017-11-29 07:44:08)
> > > On Tuesday, 2017-11-28 15:30:21 -0800, Dylan Baker wrote:
> > > > This series is the gallium media state
Quoting Emil Velikov (2017-11-23 11:04:34)
> On 20 November 2017 at 23:12, Dylan Baker wrote:
> > This doesn't actually accomplish what it's meant to do, as extern C
> > doesn't undefine __cplusplus, so the included headers define a template
> > (because __
Quoting Emil Velikov (2017-12-05 07:36:25)
> On 4 December 2017 at 23:57, Dylan Baker wrote:
> > Quoting Emil Velikov (2017-11-23 11:04:34)
> >> On 20 November 2017 at 23:12, Dylan Baker wrote:
> >> > This doesn't actually accomplish what it's meant to
Signed-off-by: Dylan Baker
---
meson.build | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/meson.build b/meson.build
index 3e8ea7d17e0..bf6bd551f08 100644
--- a/meson.build
+++ b/meson.build
@@ -1107,9 +1107,9 @@ if with_platform_x11
dep_xcb_glx = dependency(
://bugs.freedesktop.org/show_bug.cgi?id=95530
Signed-off-by: Kenneth Graunke
Tested-by: Dylan Baker
---
src/mesa/drivers/dri/i965/brw_sampler_state.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_sampler_state.c
b/src/mesa/drivers/dri/i965/brw_sampler_state.c
Quoting Dylan Baker (2017-06-16 13:39:47)
> From: Kenneth Graunke
>
> This fixes both Europa Universalis IV and Steallirs rendering on i965.
^
I fixed this typo locally, I just forgot to commit it before I send this :/
> This was t
c inline void
{0}_pack(__attribute__((unused)) __gen_user_data *data,
{1}__attribute__((unused)) void * restrict dst,
{1}__attribute__((unused)) const struct {0} * restrict values)
{""").format(name, ' ' * (len(name
Either wa
Quoting Dylan Baker (2017-06-27 10:04:47)
> Quoting Ian Romanick (2017-06-26 16:22:34)
> > From: Ian Romanick
> >
> > v2: Use textwrap.dedent to make the source line a lot shorter.
> > Shortening (?) the line was requested by Jason.
> >
> > Signed-off-b
Gahh, we're seriously still supporting 2.6 for builds? 2.6 was EOL in 2013, and
2.7 was shiny and new in 2010. It's also going to make hybridizing for 3.x
incredibly painful. If possible I'd really like to not support 2.6, though I'm
sure that will cause pain for the RHEL guys...
Quoting Vinson Le
Reviewed-by: Dylan Baker
Quoting Vinson Lee (2017-07-05 11:38:36)
> Fix build error on CentOS 6.9 with Python 2.6.
>
> GENmain/format_fallback.c
> File "./main/format_fallback.py", line 42
> names = {fmt.name for fmt in formats}
>
oops! Okay, I'm thinking I'm going to write a linter for meson to help catch
these kind of mistakes because this isn't the first time that I've failed to
catch these kind of errors in code that I don't build locally.
Reviewed-by: Dylan Baker
Quoting Eric Enges
Reviewed-by: Dylan Baker
Thanks for making those changes.
Quoting Eric Engestrom (2017-12-07 03:25:58)
> src/gallium/winsys/pl111/drm/libpl111winsys.a(pl111_drm_winsys.c.o): In
> function `pl111_drm_screen_create':
> pl111_drm_winsys.c:(.text+0x33): undefine
Quoting Eric Engestrom (2017-12-07 04:17:58)
> On Tuesday, 2017-12-05 09:40:53 -0800, Dylan Baker wrote:
> > Signed-off-by: Dylan Baker
> > ---
> > meson.build | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/meson.bu
Quoting Emil Velikov (2017-12-07 08:40:27)
> On 7 December 2017 at 14:51, Eric Engestrom wrote:
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104141
> > Signed-off-by: Eric Engestrom
> > ---
> > src/broadcom/meson.build| 2 +-
> > src/gallium/auxiliary/meson.buil
Reviewed-by: Dylan Baker
Quoting Eric Engestrom (2017-12-07 06:51:41)
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104141
> Signed-off-by: Eric Engestrom
> ---
> src/broadcom/meson.build| 2 +-
> src/gallium/auxiliary/meson.build | 2 +-
I didn't look at these super closely after the vdpau one, but we use this logic
elsewhere in the meson build,
For the series,
Reviewed-by: Dylan Baker
Quoting Eric Engestrom (2017-12-07 08:52:17)
> Signed-off-by: Eric Engestrom
> ---
> me
601 - 700 of 2585 matches
Mail list logo