[Mesa-dev] [PATCH] meson: Use true and false instead of yes and no for tristate options

2017-10-30 Thread Dylan Baker
This allows a user to not care whether they're setting a tristate or a boolean option, which is a nice user facing feature, and something I've personally run into. Suggested-by: Adam Jackson Signed-off-by: Dylan Baker --- meson.build | 6 +++--- meson_options.txt | 6 +++--

[Mesa-dev] [PATCH 2/2] meson: set visibility flags on gbm

2017-10-30 Thread Dylan Baker
This is done in autotools, and is an oversight in the meson build. Signed-off-by: Dylan Baker --- src/gbm/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gbm/meson.build b/src/gbm/meson.build index fc1816cc17a..2fad2a2a8e3 100644 --- a/src/gbm/meson.build

[Mesa-dev] [PATCH 1/2] meson: Don't link gbm with threads

2017-10-30 Thread Dylan Baker
It's supposed to be linked with pthread-stubs (if the platform needs pthread-stubs). Pthread stubs support isn't (yet) implemented in the meson build, so add a TODO. Signed-off-by: Dylan Baker --- src/gbm/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] meson: implement default driver arguments

2017-10-30 Thread Dylan Baker
Quoting Eric Engestrom (2017-10-30 10:29:25) > On Monday, 2017-10-30 10:21:50 -0700, Dylan Baker wrote: > > This allows drivers to be set by OS/arch in a sane manner. > > > > Signed-off-by: Dylan Baker > > ---

Re: [Mesa-dev] [PATCH mesa 00/11] fix tests

2017-10-31 Thread Dylan Baker
I've pushed the gbm patch mentioned, and I'll look into the wayland symbols. for the series: Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-10-31 04:19:57) > a few issues being fixed here: > - symbol checks would silently pass when the lib is missing > - meson was fail

Re: [Mesa-dev] [PATCH 5/7] meson: build r600

2017-10-31 Thread Dylan Baker
working as intended, so you can add: > Tested-by: Aaron Watry > > If you want, I can dig an r300-based card out of the closet and give > that a whirl as well, but I won't bother unless you need me to. > > --Aaron > > On Thu, Oct 26, 2017 at 6:57 PM, Dylan Baker w

[Mesa-dev] [PATCH 1/3] meson: Set c visibility args for wayland-drm

2017-10-31 Thread Dylan Baker
Because otherwise gbm will expose wayland symbols that it shouldn't. Signed-off-by: Dylan Baker --- src/egl/wayland/wayland-drm/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/wayland/wayland-drm/meson.build b/src/egl/wayland/wayland-drm/meson.build index 12b49c

[Mesa-dev] [PATCH 3/3] fixup! es2api/ABI-check: Add es3.x symbols

2017-10-31 Thread Dylan Baker
This will be squashed before push, but was split out to make review easier. --- src/mapi/es2api/ABI-check | 248 +++--- 1 file changed, 124 insertions(+), 124 deletions(-) diff --git a/src/mapi/es2api/ABI-check b/src/mapi/es2api/ABI-check index 84e8a130601.

[Mesa-dev] [PATCH 2/3] es2api/ABI-check: Add es3.x symbols

2017-10-31 Thread Dylan Baker
exposing these symbols These are added to the top to ease review. cc: Ian Romanick Signed-off-by: Dylan Baker --- src/mapi/es2api/ABI-check | 117 ++ 1 file changed, 117 insertions(+) diff --git a/src/mapi/es2api/ABI-check b/src/mapi/es2api/ABI-check

Re: [Mesa-dev] [PATCH mesa] travis: build meson first for quicker feedback

2017-10-31 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-10-31 11:19:02) > Meson is much quicker to build Mesa, giving quicker feedback if > executed first. > > Cc: Dylan Baker > Cc: Emil Velikov > Signed-off-by: Eric Engestrom > --

Re: [Mesa-dev] [PATCH mesa] meson: bump libdrm version required by amdgpu

2017-10-31 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-10-31 09:29:08) > Fixes: f03b7c9ad92c1656a221 "winsys/amdgpu: Add R600_DEBUG flag to > reserve VMID per ctx." > Cc: Andrey Grodzovsky > Signed-off-by: Eric Engestrom > --- > meson.bu

[Mesa-dev] [PATCH] meson: Allow building glvnd with EGL and non-dri based GLX

2017-10-31 Thread Dylan Baker
Because meson mirrors the auototools logic, it needs the same changes to allow building glvnd based EGL without building any GLX. Signed-off-by: Dylan Baker --- Emil, This implements the same logic that you're implementing for meson: one or both of dri based GLX or EGL is required for

Re: [Mesa-dev] create src/wsi

2017-10-31 Thread Dylan Baker
Quoting Emil Velikov (2017-10-30 10:47:22) > On 30 October 2017 at 17:05, Dylan Baker wrote: > > So I think the consensus is this is okay? > > > > Emil, is the autotools right here? > > > > Without a clear separation or cleanup of the the existing code, thi

Re: [Mesa-dev] [PATCH 33/33] intel: add aubinator ui

2017-10-31 Thread Dylan Baker
Quoting Lionel Landwerlin (2017-10-30 09:58:46) [snip] > diff --git a/meson.build b/meson.build > index 24d997b3e0a..e5e691e276c 100644 > --- a/meson.build > +++ b/meson.build > @@ -43,6 +43,7 @@ pre_args = [ > with_vulkan_icd_dir = get_option('vulkan-icd-dir') > with_tests = get_option('build-te

[Mesa-dev] [PATCH v2] meson: implement default driver arguments

2017-10-31 Thread Dylan Baker
This allows drivers to be set by OS/arch in a sane manner. v2: - set _drivers to a list of drivers instead of manually assigning each with_* cc: Eric Engestrom Signed-off-by: Dylan Baker --- meson.build | 18 ++ meson_options.txt | 8 2 files changed, 22

Re: [Mesa-dev] [PATCH] meson: Allow building glvnd with EGL and non-dri based GLX

2017-11-01 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-01 06:36:35) > On Tuesday, 2017-10-31 13:57:25 -0700, Dylan Baker wrote: > > Because meson mirrors the auototools logic, it needs the same changes to > > allow building glvnd based EGL without building any GLX. > > > >

[Mesa-dev] [PATCH v2] meson: Allow building glvnd with EGL and non-dri based GLX

2017-11-01 Thread Dylan Baker
Because meson mirrors the auototools logic, it needs the same changes to allow building glvnd based egl. v2: - change if to elif (Eric) Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom --- meson.build | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a

Re: [Mesa-dev] [PATCH v2] meson: implement default driver arguments

2017-11-01 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-01 04:09:26) > On Tuesday, 2017-10-31 15:50:49 -0700, Dylan Baker wrote: > > This allows drivers to be set by OS/arch in a sane manner. > > > > v2: - set _drivers to a list of drivers instead of manually assigning > > each with_*

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Dylan Baker
xture.texture_buffer.render.as_vertex_array_as_vertex_texture_as_fragment_texture.range_size_513 > >>> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at > >>> gluContextInfo.cpp:229 > >>> > >>> on GL46 CTS (27 failures): >

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-11-01 Thread Dylan Baker
al.texture.texture_buffer.render.as_vertex_array_as_vertex_texture_as_fragment_texture.range_size_513 > >>> glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at > >>> gluContextInfo.cpp:229 > >>> > >>> on GL46 CTS (27 failures):

Re: [Mesa-dev] [PATCH v2] meson: Allow building glvnd with EGL and non-dri based GLX

2017-11-01 Thread Dylan Baker
Quoting Emil Velikov (2017-11-01 10:41:10) > On 1 November 2017 at 17:24, Dylan Baker wrote: > > Because meson mirrors the auototools logic, it needs the same changes to > > allow building glvnd based egl. > > > > v2: - change if to elif (Eric) > > > > Sign

Re: [Mesa-dev] create src/wsi

2017-11-01 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-01 07:05:02) > On Friday, 2017-10-20 18:00:13 -0700, Dylan Baker wrote: > > This very short series creates a new src/wsi folder, and moves wayland-drm > > into > > it. Basically wsi stuff is scattered about, and is needed by multiple > >

[Mesa-dev] [PATCH] meson: Add script to use VERSION file for getting version

2017-11-01 Thread Dylan Baker
meson to read the VERSION file. I chose to implement this in python since python is portable, and to keep the meson.build script clean. This is also complicated by the fact that the project() call *must* be the first non-comment,non-blank in the toplevel meson.build script. Signed-off-by: Dyla

Re: [Mesa-dev] [PATCH 33/33] intel: add aubinator ui

2017-11-01 Thread Dylan Baker
Quoting Scott D Phillips (2017-11-01 10:30:09) > Lionel Landwerlin writes: > > > On 31/10/17 21:11, Scott D Phillips wrote: > >>> +} > >> [snip imgui] > >> > >> imgui seems to be the first instance of someone pasting a sizeable third > >> party library into the repo. I'm not sure how everyone fe

Re: [Mesa-dev] [PATCH 33/33] intel: add aubinator ui

2017-11-01 Thread Dylan Baker
Quoting Lionel Landwerlin (2017-11-01 14:25:03) > On 01/11/17 20:30, Dylan Baker wrote: > > Quoting Scott D Phillips (2017-11-01 10:30:09) > >> Lionel Landwerlin writes: > >> > >>> On 31/10/17 21:11, Scott D Phillips wrote: > >>>>> +} >

Re: [Mesa-dev] More gratitude for Meson

2017-11-01 Thread Dylan Baker
Quoting Chad Versace (2017-11-01 14:43:28) > Wow. 10 seconds from a clean checkout to an installed Vulkan driver. > > I don't know how qualify my surprise... > > Wow. > > The Intel Vulkan driver is often all I need, so I was tempted to > investigate whether Meson allowed building and installing

[Mesa-dev] [PATCH 04/13] meson: build r600 driver

2017-11-01 Thread Dylan Baker
Signed-off-by: Dylan Baker Tested-by: Aaron Watry --- meson.build | 20 -- meson_options.txt| 2 +- src/gallium/drivers/r600/meson.build | 128 +++ src/gallium/meson.build | 4 +- src/gallium

[Mesa-dev] [PATCH 06/13] meson: build virgl driver

2017-11-01 Thread Dylan Baker
Build tested only. Signed-off-by: Dylan Baker --- meson.build| 12 ++--- meson_options.txt | 2 +- src/gallium/drivers/virgl/meson.build | 39 ++ src/gallium/meson.build| 8

[Mesa-dev] [PATCH 11/13] meson: build gallium omx state tracker

2017-11-01 Thread Dylan Baker
--- meson.build| 54 ++- meson_options.txt | 13 src/gallium/meson.build| 7 +- .../state_trackers/omx_bellagio/meson.build| 30 + src/gallium/targets/omx-bellagio

[Mesa-dev] [PATCH 00/13] meson: build remaining gallium drivers, media state trackers

2017-11-01 Thread Dylan Baker
build system scraping the headers for the versions. Please review. Dylan Baker (13): meson: add proper LLVM modules to check for RadeonSI as well meson: build i915g driver meson: build r300 driver meson: build r600 driver meson: build svga driver on linux meson: build virgl driver

[Mesa-dev] [PATCH 08/13] meson: drop gallium-media argument

2017-11-01 Thread Dylan Baker
This argument is the wrong approach for handling gallium media state trackers, since it doesn't allow for an auto option. Instead we'll use tristates, which do allow for auto. This option has never been wired to anything anyway. Signed-off-by: Dylan Baker --- meson.build

[Mesa-dev] [PATCH 03/13] meson: build r300 driver

2017-11-01 Thread Dylan Baker
This is build tested only Signed-off-by: Dylan Baker --- meson.build | 4 +- meson_options.txt| 2 +- src/gallium/drivers/r300/meson.build | 156 +++ src/gallium/meson.build | 4 +- src/gallium

[Mesa-dev] [PATCH 02/13] meson: build i915g driver

2017-11-01 Thread Dylan Baker
Build tested only. Signed-off-by: Dylan Baker --- meson.build | 7 +++- src/gallium/drivers/i915/meson.build| 70 + src/gallium/meson.build | 7 +++- src/gallium/targets/dri/meson.build | 5 +++ src/gallium

[Mesa-dev] [PATCH 13/13] meson: build gallium xa state tracker

2017-11-01 Thread Dylan Baker
--- meson.build | 21 + meson_options.txt | 7 +++ src/gallium/meson.build | 7 ++- src/gallium/state_trackers/xa/meson.build | 45 ++ src/gallium/targets/xa/meson.build| 77 ++

[Mesa-dev] [PATCH 10/13] meson: build gallium xvmc state tracker

2017-11-01 Thread Dylan Baker
--- meson.build | 34 +- meson_options.txt | 13 ++ src/gallium/meson.build | 7 ++- src/gallium/state_trackers/xvmc/meson.build | 52 + src/gallium/targets/xvmc/meson.build|

[Mesa-dev] [PATCH 12/13] meson: build gallium va state tracker

2017-11-01 Thread Dylan Baker
--- meson.build | 35 +- meson_options.txt | 13 ++ src/gallium/meson.build | 7 ++- src/gallium/state_trackers/va/meson.build | 39 src/gallium/targets/va/meson.build| 78

[Mesa-dev] [PATCH 01/13] meson: add proper LLVM modules to check for RadeonSI as well

2017-11-01 Thread Dylan Baker
Signed-off-by: Dylan Baker --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 6ad8c8bbf4b..bae3b5a02ef 100644 --- a/meson.build +++ b/meson.build @@ -654,7 +654,7 @@ if with_gallium_freedreno endif llvm_modules = ['bitw

[Mesa-dev] [PATCH 05/13] meson: build svga driver on linux

2017-11-01 Thread Dylan Baker
Build tested only. Signed-off-by: Dylan Baker --- meson.build | 2 + meson_options.txt | 2 +- src/gallium/drivers/svga/meson.build| 88 + src/gallium/meson.build | 7 ++- src/gallium

[Mesa-dev] [PATCH 09/13] meson: build gallium vdpau state tracker

2017-11-01 Thread Dylan Baker
--- meson.build | 40 - meson_options.txt| 13 + src/gallium/meson.build | 7 ++- src/gallium/state_trackers/vdpau/meson.build | 32 ++ src/gallium/targets/vdpau/meson.build| 87 +

[Mesa-dev] [PATCH 07/13] autotools: set XA versions in configure.ac and configure header file

2017-11-01 Thread Dylan Baker
r and more obvious. Tested with make distcheck. cc: Matt Turner Signed-off-by: Dylan Baker --- configure.ac| 17 - .../state_trackers/xa/{xa_tracker.h => xa_tracker.h.in} | 6 +++--- 2 files changed, 11 insertions(+), 12 d

Re: [Mesa-dev] More gratitude for Meson

2017-11-01 Thread Dylan Baker
Quoting Ilia Mirkin (2017-11-01 15:52:56) > On Wed, Nov 1, 2017 at 6:49 PM, Chad Versace wrote: > > On Wed 01 Nov 2017, Dylan Baker wrote: > >> Quoting Chad Versace (2017-11-01 14:43:28) > >> > Wow. 10 seconds from a clean checkout to an installed Vulkan driver. &

Re: [Mesa-dev] More gratitude for Meson

2017-11-01 Thread Dylan Baker
Quoting Ilia Mirkin (2017-11-01 16:05:17) > On Wed, Nov 1, 2017 at 7:03 PM, Dylan Baker wrote: > > Quoting Ilia Mirkin (2017-11-01 15:52:56) > >> On Wed, Nov 1, 2017 at 6:49 PM, Chad Versace > >> wrote: > >> > On Wed 01 Nov 2017, Dylan Baker wrote: > &g

[Mesa-dev] [PATCH] Revert "meson: bump libdrm version required by amdgpu"

2017-11-01 Thread Dylan Baker
."" Signed-off-by: Dylan Baker --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 6ad8c8bbf4b..d22d49535af 100644 --- a/meson.build +++ b/meson.build @@ -638,7 +638,7 @@ dep_libdrm_nouveau = [] dep_libdrm_etnaviv = []

Re: [Mesa-dev] [PATCH 2/3] gbm: Don't traverse backwards for includes

2017-11-02 Thread Dylan Baker
Quoting Emil Velikov (2017-11-02 06:21:09) > On 21 October 2017 at 02:00, Dylan Baker wrote: > > This is just a terrible idea, but it also needs to be fixed for the next > > patch to work, so let's fix it right. > > > Please rework the commit mes

Re: [Mesa-dev] Meson's default build type

2017-11-02 Thread Dylan Baker
Quoting Matt Turner (2017-11-02 10:06:43) > On Thu, Nov 2, 2017 at 9:51 AM, Michel Dänzer wrote: > > FWIW, my vote is for debugoptimized: Assertions are enabled and there's > > debugging information useful for bug reports, but performance should be > > decent. > > If debugoptimized turns on DEBUG

Re: [Mesa-dev] [PATCH 12/13] meson: build gallium va state tracker

2017-11-02 Thread Dylan Baker
Quoting Emil Velikov (2017-11-02 05:59:40) > On 1 November 2017 at 22:49, Dylan Baker wrote: > > --- > > meson.build | 35 +- > > meson_options.txt | 13 ++ > > src/gallium/meson.build

Re: [Mesa-dev] [PATCH 2/3] gbm: Don't traverse backwards for includes

2017-11-02 Thread Dylan Baker
Quoting Emil Velikov (2017-11-02 11:04:44) > On 2 November 2017 at 16:53, Dylan Baker wrote: > > Quoting Emil Velikov (2017-11-02 06:21:09) > >> On 21 October 2017 at 02:00, Dylan Baker wrote: > >> > This is just a terrible idea, but it also needs to be fixed for

Re: [Mesa-dev] [PATCH mesa 1/2] meson: standardize .so version to major.minor.patch

2017-11-02 Thread Dylan Baker
I'm also not sure that it matters, but I think consistency with autotools is important, Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-11-02 16:42:11) > This `version` field defines the filename for the .so. > The plan .so as well as .so.$major are always symlinks to this. >

[Mesa-dev] [PATCH 1/5] meson: add nir_builder_opcodes_h to gallium_auxiliary

2017-11-02 Thread Dylan Baker
This creates a dependency on this header being generated before trying to compile any of these targets, as well as passing the correct -I to the compiler to ensure it's included correctly. Signed-off-by: Dylan Baker --- src/gallium/auxiliary/meson.build | 2 +- 1 file changed, 1 insertion(

[Mesa-dev] [PATCH 2/5] meson: move wayland-egl into egl folder

2017-11-02 Thread Dylan Baker
This ensure that it's properly guarded, but also makes the code clearer by grouping related things together.. Signed-off-by: Dylan Baker --- src/egl/meson.build | 4 src/meson.build | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/egl/meson.build b/sr

[Mesa-dev] [PATCH 5/5] meson: build gallium-xlib based glx

2017-11-02 Thread Dylan Baker
Signed-off-by: Dylan Baker --- meson.build | 16 +++--- src/gallium/meson.build | 11 +++- src/gallium/state_trackers/glx/xlib/meson.build | 27 ++ src/gallium/targets/libgl-xlib/meson.build | 68

[Mesa-dev] [PATCH 0/5] meson glx-xlib (classic and gallium)

2017-11-02 Thread Dylan Baker
There's a few cleanups in here, but mostly it's just the logic for building xlib backed glx. Dylan Baker (5): meson: add nir_builder_opcodes_h to gallium_auxiliary meson: move wayland-egl into egl folder meson: move gl pkgconfig generation out of glx meson: add support fo

[Mesa-dev] [PATCH 3/5] meson: move gl pkgconfig generation out of glx

2017-11-02 Thread Dylan Baker
Because the same generation logic is required by xlib glx and gallium-xlib glx, it makes sense to pull it out. Signed-off-by: Dylan Baker --- src/glx/meson.build | 11 --- src/meson.build | 12 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/src/glx

[Mesa-dev] [PATCH 4/5] meson: add support for xlib glx

2017-11-02 Thread Dylan Baker
There is a bunch of churn in the main meson.build so that we can correctly set the auto tristate of GLX. In particular, don't build xlib-based glx when dri and gallium are disabled but vulkan is enabled, in that case just turn glx off. Signed-off-by: Dylan Baker --- meson.

Re: [Mesa-dev] [PATCH 3/5] meson: move gl pkgconfig generation out ofglx

2017-11-03 Thread Dylan Baker
Quoting Marc Dietrich (2017-11-03 02:24:46) > Hi Dylan, > > Am Freitag, 3. November 2017, 01:06:27 CET schrieb Dylan Baker: > > Because the same generation logic is required by xlib glx and > > gallium-xlib glx, it makes sense to pull it out. > > > > Signed-off-

Re: [Mesa-dev] [PATCH 11/13] meson: build gallium omx state tracker

2017-11-03 Thread Dylan Baker
Quoting Marc Dietrich (2017-11-03 03:06:17) > Am Mittwoch, 1. November 2017, 23:49:46 CET schrieb Dylan Baker: > > --- > > meson.build| 54 ++- > > meson_options.txt | 13 > &g

[Mesa-dev] [PATCH v3] meson: implement default driver arguments

2017-11-03 Thread Dylan Baker
swrast, as swrast is the actual option name cc: Eric Engestrom Signed-off-by: Dylan Baker --- meson.build | 38 ++ meson_options.txt | 12 ++-- 2 files changed, 44 insertions(+), 6 deletions(-) diff --git a/meson.build b/meson.build index d22d49

Re: [Mesa-dev] [PATCH v2 11/11] intel: add aubinator ui

2017-11-03 Thread Dylan Baker
Quoting Lionel Landwerlin (2017-11-01 11:12:18) [snip] > > +if with_intel_tools > + inc_imgui = include_directories('imgui') since aubinator_ui is the only consumer of this include, why don't we just put the call to include_directories in the argument to the executable? > + aubinator_ui = exe

Re: [Mesa-dev] Meson's default build type

2017-11-03 Thread Dylan Baker
Quoting Matt Turner (2017-11-03 15:05:24) [snip] > > Meson's debug build should correspond to --enable-debug. > debugoptimized vs release is a little less obvious. Perhaps > debugoptimized should default to -g -O2 but leave assertions enabled, > and release should default to -g -O2 -DNDEBUG? This

Re: [Mesa-dev] [PATCH mesa 1/2] meson: switch default build type to debugoptimized

2017-11-06 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-11-06 09:19:34) > Cc: Dylan Baker > Cc: Chad Versace > Cc: Emil Velikov > Cc: Ilia Mirkin > Cc: Andres Rodriguez > Cc: Michel Dänzer > Cc: Matt Turner > Cc: Christian Schmidbauer > Cc: Eero Tamminen >

Re: [Mesa-dev] [PATCH mesa 1/2] meson: standardize .so version to major.minor.patch

2017-11-06 Thread Dylan Baker
To clarify, with the one hunk in patch 2 moved to patch 1, both patches are: Reviewed-by: Dylan Baker Quoting Dylan Baker (2017-11-02 16:51:18) > I'm also not sure that it matters, but I think consistency with autotools is > important, > Reviewed-by: Dylan Baker > > Qu

Re: [Mesa-dev] [PATCH v3] meson: implement default driver arguments

2017-11-06 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-03 16:44:11) > On Friday, 2017-11-03 18:09:01 +0000, Dylan Baker wrote: > > This allows drivers to be set by OS/arch in a sane manner. > > > > v2: - set _drivers to a list of drivers instead of manually assigning > > each with_* &

Re: [Mesa-dev] [PATCH 12/13] meson: build gallium va state tracker

2017-11-06 Thread Dylan Baker
Quoting Aaron Watry (2017-11-03 19:51:49) > On an unrelated note, I also had to remove the LLVM minimum version > check temporarily, otherwise I get llvm version parsing errors from > 6.0.0svn at the following line: > > dep_llvm = dependency( > 'llvm', version : '>= 3.9.0', required : with_amd_

Re: [Mesa-dev] [PATCH 07/13] autotools: set XA versions in configure.ac and configure header file

2017-11-06 Thread Dylan Baker
Quoting Emil Velikov (2017-11-02 07:00:16) > On 1 November 2017 at 22:49, Dylan Baker wrote: > > Currently the versions are set in the header, and then sed is used to > > extract them, so that autotools can use them elsewhere. > > > > This is odd. Autotools is perfectly

Re: [Mesa-dev] [PATCH] nir: fix a typo

2017-11-06 Thread Dylan Baker
Thanks, I went ahead and pushed this with my r-b. Quoting Gwan-gyeong Mun (2017-11-06 15:28:25) > Signed-off-by: Mun Gwan-gyeong > --- > src/compiler/nir/nir.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h > index 87c725

Re: [Mesa-dev] Announcement: Meson build type change

2017-11-07 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-07 05:57:55) > On Tuesday, 2017-11-07 06:54:59 -0700, Brian Paul wrote: > > On 11/07/2017 05:25 AM, Eric Engestrom wrote: > > > Hi all, > > > > > > As a result of the discussion that started with this message: > > > https://lists.freedesktop.org/archives/mesa-dev/20

[Mesa-dev] [PATCH] docs: add documentation for building with meson

2017-11-07 Thread Dylan Baker
changes as suggested by Emil. v3: - Fix order of commands in example (Eric E.) - Add documentation for overriding LLVM version (Eric E.) v4: - Rebase on master - update default buildtype - add note about b_ndebug - Clarify meson configure a bit Signed-off-by: Dylan Baker Reviewe

Re: [Mesa-dev] [PATCH] amd/addrlib: update to latest version

2017-11-07 Thread Dylan Baker
It looks like the file deletions aren't applied to meson. Quoting Marek Olšák (2017-11-07 09:28:39) > Hi, > > This patch is too large for the mailing list: > > https://cgit.freedesktop.org/~mareko/mesa/commit/?h=addrlib&id=0e0f044268d3c1af2e78f161aaa2d92c30167cc1 > > The plan is to push this on

Re: [Mesa-dev] [PATCH] anv/meson: Generate dev_icd.json

2017-11-07 Thread Dylan Baker
e `host_machine` [1] ? > I don't see how one would do a canadian build of mesa though, so > host == target should always be true. That's my fault. There are (or were) a number of cases where I used target instead of host, that can also be a follow up. In any case: Acked-

Re: [Mesa-dev] [PATCH 07/18] radeon/vcn: add common encode part

2017-11-07 Thread Dylan Baker
Quoting boyuan.zh...@amd.com (2017-11-07 13:59:02) > From: Boyuan Zhang > > Signed-off-by: Boyuan Zhang > --- > src/gallium/drivers/radeon/Makefile.sources | 3 + > src/gallium/drivers/radeon/radeon_vcn_enc.c | 166 + > src/gallium/drivers/radeon/radeon_vcn_enc.h |

Re: [Mesa-dev] [PATCH] meson: Add threads dependencies to glsl_compiler executable

2017-11-07 Thread Dylan Baker
Quoting Dylan Baker (2017-10-27 11:22:09) > Fixes compiling the optional standalone glsl compiler. > > Reported-by: DrNick (on irc) > Signed-off-by: Dylan Baker > --- > > This is not compiled by default, but can be built by: > meson build > ninja -C build src/

Re: [Mesa-dev] [PATCH] meson: Add script to use VERSION file for getting version

2017-11-07 Thread Dylan Baker
Quoting Dylan Baker (2017-11-01 11:58:16) > Meson has up until this point set it's version in the root meson.build > script. While there are other build systems them creates "one more > thing" to duplicate between meson and every other build system, this > script is a

[Mesa-dev] non-shared glapi

2017-11-07 Thread Dylan Baker
Jason let me know today that non-shared glapi is broken in meson. The tests for non-shared glapi are broken in autotools and meson. Is anyone still using non-shared glapi, or can we delete it? signature.asc Description: signature ___ mesa-dev mailing li

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

2017-11-08 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-08 04:00:54) > On Tuesday, 2017-11-07 09:28:35 -0800, Dylan Baker wrote: > > v2: - Add information about CC, CXX, CFLAGS, and CXXFLAGS (Nicolai) > > - Add message at top that meson for mesa is still a work in progress > > - Add traili

Re: [Mesa-dev] [Mesa-maintainers] non-shared glapi

2017-11-08 Thread Dylan Baker
gt; > On Tuesday, 2017-11-07 16:33:57 -0800, Dylan Baker wrote: > >> Jason let me know today that non-shared glapi is broken in meson. The > >> tests for > >> non-shared glapi are broken in autotools and meson. Is anyone still using > >> non-shared glapi, or ca

Re: [Mesa-dev] [PATCH] meson: Add script to use VERSION file for getting version

2017-11-08 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-08 04:21:41) > On Wednesday, 2017-11-01 11:58:16 -0700, Dylan Baker wrote: > > Meson has up until this point set it's version in the root meson.build > > script. While there are other build systems them creates "one more > > thing&

Re: [Mesa-dev] [PATCH] meson: Add script to use VERSION file for getting version

2017-11-08 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-08 04:21:41) > On Wednesday, 2017-11-01 11:58:16 -0700, Dylan Baker wrote: > > Meson has up until this point set it's version in the root meson.build > > script. While there are other build systems them creates "one more > > thing&

Re: [Mesa-dev] [PATCH v2] meson: Allow building glvnd with EGL and non-dri based GLX

2017-11-08 Thread Dylan Baker
Quoting Emil Velikov (2017-11-08 08:03:42) > On 1 November 2017 at 18:22, Dylan Baker wrote: > > Quoting Emil Velikov (2017-11-01 10:41:10) > >> On 1 November 2017 at 17:24, Dylan Baker wrote: > >> > Because meson mirrors the auototools logic, it needs the same ch

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

2017-11-08 Thread Dylan Baker
'. :) Should probably > document that for us n00bs. That's in the v5 :) > > > On 11/07/2017 09:28 AM, Dylan Baker wrote: > >> v2: - Add information about CC, CXX, CFLAGS, and CXXFLAGS (Nicolai) > >> - Add message at top that meson for mesa is

Re: [Mesa-dev] [PATCH] meson: Add script to use VERSION file for getting version

2017-11-08 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-08 12:38:26) > > > On 8 November 2017 19:32:22 GMT, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-11-08 04:21:41) > > > On Wednesday, 2017-11-01 11:58:16 -0700, Dylan Baker wrote: > > > > Meson has up until thi

Re: [Mesa-dev] [PATCH 4/4] meson: Enable VC4's NEON assembly support.

2017-11-08 Thread Dylan Baker
iling, disabling asm') > +if meson.is_cross_build() and (host_machine.cpu_family() == 'x86' or > + host_machine.cpu_family() == 'x86_64') How about: if meson.is_cross_build() and host_machine.cpu_family().startswith('x86') Other th

Re: [Mesa-dev] [PATCH 1.2/8] spirv: Generate spirv_info.c

2017-07-18 Thread Dylan Baker
Quoting Jason Ekstrand (2017-07-17 10:42:05) > Generally available things tend to be painful in Python because you have to > set > the python path if you ever want to import anything that isn't in your > directory.  That doesn't mean we shouldn't do it, just that the pain may be > too > high.  Al

[Mesa-dev] [PATCH] radv: rebase radv_entrypoints_gen.py on anv_entrypoints_gen.py

2017-07-19 Thread Dylan Baker
and write files out directly. The only differences between the output is whitespace and comments. Signed-off-by: Dylan Baker --- src/amd/vulkan/Makefile.am | 12 +- src/amd/vulkan/radv_entrypoints_gen.py | 540 + 2 files changed, 282 insertions(+), 27

Re: [Mesa-dev] [PATCH] autogen.sh: set default sendemail.to

2017-04-24 Thread Dylan Baker
I agree with Jason, autogen.sh shouldn't be doing anything except configuring autotools. Perhaps a "initial-configuration.sh" script would be more appropriate. Just my two cents and not a hard NAK. Dylan Quoting Jason Ekstrand (2017-04-24 12:29:32) > This seems like something that would be more

[Mesa-dev] [PATCH] autotools: Set C++ visibility flags on Intel

2017-11-09 Thread Dylan Baker
These flags are set for C sources, but not C++. This causes symbol visibility leaks from the C++ parts of the Intel compiler. fixes: 700bebb958e93f4d ("i965: Move the back-end compiler to src/intel/compiler") Signed-off-by: Dylan Baker --- src/intel/Makefile.am | 3 +++ 1 file

Re: [Mesa-dev] [PATCH 5/5] meson: build gallium-xlib based glx

2017-11-09 Thread Dylan Baker
Quoting Eric Anholt (2017-11-08 13:26:12) > We shouldn't have to manually specify most of these deps, I think, since > they should be transitively pulled in by the static libraries using > them, right? It's fine either way, though. > > > + install : true, > > + version : '1.5.0', > > Looks lik

Re: [Mesa-dev] [PATCH 1/3] radv: Fix architecture in radeon_icd.{arch}.json

2017-11-09 Thread Dylan Baker
for the series: Reviewed-by: Dylan Baker Quoting Chad Versace (2017-11-09 15:45:00) > Use the host arch, not the target arch. In Meson and in recent > Autotools, the host arch is where the binary will be used. The target > arch is useful only when compiling a compiler. >

[Mesa-dev] [PATCH] meson: don't us build_by_default for specific gallium drivers

2017-11-10 Thread Dylan Baker
fault driver arguments") Signed-off-by: Dylan Baker --- src/gallium/drivers/freedreno/meson.build | 1 - src/gallium/drivers/llvmpipe/meson.build | 1 - src/gallium/drivers/nouveau/meson.build| 1 - src/gallium/drivers/radeon/meson.build | 1 - src/gallium/drivers/radeonsi/m

[Mesa-dev] [PATCH] gallium/xlib: remove GL_{MAJOR,MINOR,TINY}

2017-11-10 Thread Dylan Baker
as 0 since that's what the autotools build as been doing forever. This shouldn't change any behavior. cc: Brian Paul cc: Emil Velikov Signed-off-by: Dylan Baker --- src/gallium/targets/libgl-xlib/Makefile.am | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/

Re: [Mesa-dev] [PATCH] meson: don't us build_by_default for specific gallium drivers

2017-11-10 Thread Dylan Baker
If fixed the typo in the subject locally. Quoting Dylan Baker (2017-11-10 09:23:37) > Using build_by_default : false is convenient for dependencies that can > be pulled in by various diverse components of the build system, the > gallium hardware/software drivers and state trackers do not

Re: [Mesa-dev] [PATCH 1/4] configure.ac: Define HAVE_ZLIB if zlib is found

2017-11-10 Thread Dylan Baker
Quoting Jordan Justen (2017-11-10 10:24:36) > Cc: Emil Velikov > Cc: Dylan Baker > Signed-off-by: Jordan Justen > --- > configure.ac | 6 +- > meson.build | 6 +- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/confi

Re: [Mesa-dev] [PATCH 1/4] configure.ac: Define HAVE_ZLIB if zlib is found

2017-11-10 Thread Dylan Baker
Quoting Jordan Justen (2017-11-10 11:43:45) > On 2017-11-10 10:38:19, Dylan Baker wrote: > > Quoting Jordan Justen (2017-11-10 10:24:36) > > > Cc: Emil Velikov > > > Cc: Dylan Baker > > > Signed-off-by: Jordan Justen > > > --- > >

Re: [Mesa-dev] [PATCH] freedreno/meson: Only build the compiler if building freedreno

2017-11-11 Thread Dylan Baker
017 11:10:37 PM PST, Jason Ekstrand wrote: >Setting build_by_default to true makes it suddenly pull in freedreno >and >all of gallium unconditionally. > >Cc: Rob Clark >Cc: Dylan Baker >--- > src/gallium/drivers/freedreno/meson.build | 2 +- > 1 file changed, 1 inser

Re: [Mesa-dev] [PATCH v2] configure.ac: Define HAVE_ZLIB if zlib is found

2017-11-12 Thread Dylan Baker
On Fri, Nov 10, 2017, at 14:50, Emil Velikov wrote: > On 10 November 2017 at 22:18, Jordan Justen > wrote: > > v2: > > * Keep zlib required for autotools & meson (Emil) > > > > Cc: Emil Velikov > > Cc: Dylan Baker > > Signed-off-by

Re: [Mesa-dev] [PATCH] RFC: meson: Add a new build-dev-tools option

2017-11-13 Thread Dylan Baker
ilt and installed. > > Cc: Rob Clark > Cc: Dylan Baker > --- > meson.build | 5 + > meson_options.txt | 6 ++ > src/gallium/drivers/freedreno/meson.build | 3 ++- > src/intel/meson.build

Re: [Mesa-dev] [PATCH 2/2] meson: Move -Dvulkan-drivers handling higher in the file

2017-11-13 Thread Dylan Baker
Oops. I made a rebasing mistake in the GLX-XLIB series. That's my bad Reviewed-by: Dylan Baker Quoting Jason Ekstrand (2017-11-11 10:32:06) > The window-system auto-detection code (specifically for glx) relies on > with_any_vk being available. This fixes the Vulkan-only build. A

Re: [Mesa-dev] [PATCH 1/2] meson: Stop requiring platforms for Vulkan

2017-11-13 Thread Dylan Baker
I believe I copied this from autotools, does it have the same restriction? Quoting Jason Ekstrand (2017-11-11 10:32:05) > It should be perfectly valid to build a completely headless Vulkan > driver. We don't need to require a platform. > --- > meson.build | 3 --- > 1 file changed, 3 deletions(-

Re: [Mesa-dev] [PATCH] meson: if dep_dl is an empty list, it's not a dependency object

2017-11-13 Thread Dylan Baker
I thought I'd fixed this already, Reviewed-by: Dylan Baker Quoting Jon Turney (2017-11-13 02:28:27) > It's ok to use an empty list for dependencies:, but it's not ok to try to > use the found() method of it. > > See also https://github.com/mesonbuild/meson/issues/2

Re: [Mesa-dev] [PATCH 1/2] meson: Stop requiring platforms for Vulkan

2017-11-13 Thread Dylan Baker
I can't either, so: Reviewed-by: Dylan Baker Quoting Jason Ekstrand (2017-11-13 09:43:11) > My quick attempt at grepping configure.ac didn't turn anything up. > > On Mon, Nov 13, 2017 at 9:37 AM, Dylan Baker wrote: > > I believe I copied this from autotoo

Re: [Mesa-dev] [PATCH 09/10] spirv: Generate code to track SPIR-V capability dependencies

2017-11-13 Thread Dylan Baker
Quoting Ian Romanick (2017-11-10 14:32:49) [snip] > + > +def collect_data(spirv): > +for x in spirv["operand_kinds"]: > +if x["kind"] == "Capability": > +operands = x This makes me nervous. dict iteration order is not guaranteed to be repeatable in python. I think you shou

<    1   2   3   4   5   6   7   8   9   10   >