fine PRINTFLIKE(f, a) __attribute__ ((format(__printf__, f, a)))
For both, Reviewed-by: Brian Paul
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
IIRC, this is MacOS 9.x stuff.
---
include/GL/gl.h|7 ---
src/mesa/math/m_clip_tmp.h | 12 ++--
2 files changed, 6 insertions(+), 13 deletions(-)
diff --git a/include/GL/gl.h b/include/GL/gl.h
index 31a2813..1d21df7 100644
--- a/include/GL/gl.h
+++ b/include/GL/gl.h
WGLAPI was defined in glheader.h but wasn't used anywhere.
---
src/mesa/main/glheader.h | 16
1 file changed, 16 deletions(-)
diff --git a/src/mesa/main/glheader.h b/src/mesa/main/glheader.h
index e027218..7f7f9a3 100644
--- a/src/mesa/main/glheader.h
+++ b/src/mesa/main/glhead
---
src/mesa/main/compiler.h |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
index 61ce5db..2752ca8 100644
--- a/src/mesa/main/compiler.h
+++ b/src/mesa/main/compiler.h
@@ -36,11 +36,7 @@
#include
#include
-#if
---
include/GL/gl.h |2 +-
include/GL/osmesa.h |5 -
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/include/GL/gl.h b/include/GL/gl.h
index 0efa6ef..31a2813 100644
--- a/include/GL/gl.h
+++ b/include/GL/gl.h
@@ -69,7 +69,7 @@
# define GLAPIENTRY
#endif /* WIN32 &&
---
include/GL/gl.h |6 +-
src/mesa/main/compiler.h |2 +-
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/include/GL/gl.h b/include/GL/gl.h
index 1d21df7..d0710ba 100644
--- a/include/GL/gl.h
+++ b/include/GL/gl.h
@@ -40,15 +40,11 @@
#include /* to get so
* Create texture resources in texture validation
With the missing breaks,
Acked-by: Brian Paul
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
fines += ['_DEBUG']
if platform == 'windows':
cppdefines += ['PIPE_SUBSYSTEM_WINDOWS_USER']
-if platform == 'haiku':
-cppdefines += ['BEOS_THREADS']
if env['embedded']:
cp
) && defined(_IEEE_754)) || \
defined(__alpha__)
I believe that's Arm64, right? If so, it could go on the same line as
the __arm__ check. That would follow the pattern of preceding HP and
MIPS checks. But not a big deal.
Reviewed-b
DEFINES="$DEFINES -DHAVE_PTHREAD -DUSE_EXTERNAL_DXTN_LIB=1"
DEFINES="$DEFINES -DHAVE_ALIAS"
For the series:
Reviewed-by: Brian Paul
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
) || \
defined(__sh__) || defined(__m32r__) || \
(defined(__sun) && defined(_IEEE_754)) || \
defined(__alpha__)
Reviewed-by: Brian Paul
Thanks.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedes
t shifts).
Note that this has very limited scope for now, since this is only used with
per-pixel lod (otherwise we're avoiding the non-constant shift count by doing
per-quad shifts manually), and only 1d textures even then (though the latter
should change).
Since it's helpful to know why the shader did not compile.
Also, call fflush() for Windows.
---
src/mesa/main/shaderapi.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
index 7da860d..1d9aac3 100644
--- a/src/mesa/main/shaderapi.c
+++
On 11/06/2013 12:34 PM, burlen wrote:
When I build osmesa with --with-osmesa-bits=32 I notice that I get 31
bits by way of the compile line define -DDEFAULT_SOFTWARE_DEPTH_BITS=31.
What's the story with the number 31? Is 31 bits really better than 32?
IIRC, 32 bit Z never worked properly becaus
On 11/06/2013 04:59 PM, burlen wrote:
On 11/06/2013 12:58 PM, Brian Paul wrote:
On 11/06/2013 12:34 PM, burlen wrote:
When I build osmesa with --with-osmesa-bits=32 I notice that I get 31
bits by way of the compile line define -DDEFAULT_SOFTWARE_DEPTH_BITS=31.
What's the story with the n
On 11/07/2013 12:06 AM, Chris Forbes wrote:
Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series.
Signed-off-by: Chris Forbes
---
src/mesa/main/bufferobj.c| 14 ++
src/mesa/main/get.c | 4
src/mesa/main/get_hash_params.py | 2 ++
start");
I suspect we'd only hit this if we ran out of memory earlier and failed
to allocate the buffer. So, I'd probably report GL_OUT_OF_MEMORY here.
I think we do that in other places where mapping fails too.
The rest of the core Mesa chan
On 11/07/2013 09:09 AM, burlen wrote:
On 11/07/2013 06:42 AM, Brian Paul wrote:
On 11/06/2013 04:59 PM, burlen wrote:
On 11/06/2013 12:58 PM, Brian Paul wrote:
On 11/06/2013 12:34 PM, burlen wrote:
When I build osmesa with --with-osmesa-bits=32 I notice that I get 31
bits by way of the
On 11/07/2013 10:23 AM, Eric Anholt wrote:
Chris Forbes writes:
V2: Check for mapping failure (thanks Brian)
Signed-off-by: Chris Forbes
---
src/mesa/vbo/vbo_primitive_restart.c | 33 +
1 file changed, 33 insertions(+)
diff --git a/src/mesa/vbo/vbo_primiti
On 11/07/2013 11:29 AM, Eric Anholt wrote:
Brian Paul writes:
On 11/07/2013 10:23 AM, Eric Anholt wrote:
Chris Forbes writes:
V2: Check for mapping failure (thanks Brian)
Signed-off-by: Chris Forbes
---
src/mesa/vbo/vbo_primitive_restart.c | 33 +
1
Only loop over the actual number of color buffers supported, not
PIPE_MAX_COLOR_BUFS.
---
src/gallium/drivers/svga/svga_context.c |3 ++-
src/gallium/drivers/svga/svga_pipe_misc.c |5 +++--
src/gallium/drivers/svga/svga_screen.c| 10 ++
src/gallium/d
Grab the comments from commit message b84b7f19dfdc0 to explain
what the code is doing.
---
src/gallium/drivers/svga/svga_state_framebuffer.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/svga/svga_state_framebuffer.c
b/src/gallium/drivers
This helps fix an issue in the svga driver, and is just safer all-around.
---
src/gallium/auxiliary/util/u_framebuffer.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/util/u_framebuffer.c
b/src/gallium/auxiliary/util/u_framebuffer.c
index 7803ec6..
.
Uses Mesa demos Perf library to do the measurements.
It looks like the previous patch in the series added the shell script
which passes command line params. Shouldn't this patch come before that
feature?
I'm not too concerned though.
Acked-by:
--git a/src/perf/vertexrate.c b/src/perf/vertexrate.c
index b535552..833c2ba 100644
--- a/src/perf/vertexrate.c
+++ b/src/perf/vertexrate.c
@@ -91,7 +91,7 @@ InitializeVertexData(void)
/** Called from test harness/main */
void
-PerfInit(void)
+PerfInit(int argc, char *argv[])
{
InitializeV
OR IN
+ * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ */
+
I really only skimmed the rest. If the test does what you need that's
fine. But consider a more descriptive name.
Acked-by: Brian Paul
___
, dims, target, levels,
internalformat, width, height, depth)) {
return; /* error was recorded */
Reviewed-by: Brian Paul
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/ma
From: Brian Paul
To fix fall-out from recent commits.
---
.../state_trackers/dri/common/dri_context.h|1 +
src/glx/dri2.h |2 ++
src/glx/glxclient.h|2 +-
src/glx/query_renderer.c
On 11/08/2013 05:25 AM, Jose Fonseca wrote:
This change seems makes dri3proto a hard requirement to build with automake.
Is that strictly necessary? I tried to find ubuntu packages for it to install
on my build slave, but it doesn't seem they exist yet.
There's also a dependency on a new l
@ __glXInitialize(Display * dpy)
** (e.g., those called in AllocAndFetchScreenConfigs).
*/
if (glx_direct && glx_accel) {
+#if !defined(GLX_NO_DRI3)
if (!getenv("LIBGL_DRI3_DISABLE"))
dpyPriv->dri3Display = dri3_create_display(dpy);
+#endif
On 11/08/2013 07:10 AM, Jose Fonseca wrote:
Looks good to me AFAICT.
I had independently pushed a fix similar to the first chunk in your patch. I
think it matches your's verbatim so there should be no conflict when you rebase.
I'll push the swrast dri_create_context() patch. But for the
q
On 11/08/2013 08:49 AM, Courtney Goeltzenleuchter wrote:
enh = enhanced
Suggestions on something more descriptive?
teximage2?
bench_teximage?
teximage_perf?
Thanks for the feedback.
Does the existing teximage test do anything that your new test doesn't
do? If the old teximage test is obsole
From: Brian Paul
Not sure if this is supposed to be signed or unsigned. It's not
consistent as-is.
---
src/glx/glxclient.h |2 +-
src/glx/query_renderer.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/glx/glxclient.h b/src/glx/glxclient.h
index e2
On 11/08/2013 11:49 AM, Eric Anholt wrote:
Jose Fonseca writes:
This change seems makes dri3proto a hard requirement to build with
automake. Is that strictly necessary? I tried to find ubuntu
packages for it to install on my build slave, but it doesn't seem they
exist yet.
Well, we could b
On 11/08/2013 05:00 PM, Matt Turner wrote:
On Fri, Nov 8, 2013 at 3:06 PM, Armin K wrote:
This patch makes it possible to disable DRI3 if desired.
Reviewed-by: Matt Turner
Unless non-Linux users still need to be able to disable DRI3, by the
time Mesa 10.0 is released I think we want to requ
On 11/10/2013 06:16 AM, Petr Sebor wrote:
Without the rebind, the function enables generic vertex attributes 0 and 1 of
the
array object it does not own. This was causing crashes in Euro Truck Simulator
2,
since the enabled generic attribute 0 got precedence before vertex position
attribute
at
On 11/11/2013 10:14 AM, Matt Turner wrote:
On Mon, Nov 11, 2013 at 7:58 AM, Brian Paul wrote:
On 11/08/2013 11:49 AM, Eric Anholt wrote:
Jose Fonseca writes:
This change seems makes dri3proto a hard requirement to build with
automake. Is that strictly necessary? I tried to find ubuntu
before vertex position attribute at later time, leading to NULL
pointer dereference.
Signed-off-by: Petr Sebor
Reviewed-by: Brian Paul
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 11/11/2013 04:57 PM, Petr Sebor wrote:
Not having push access rights, I hope this fix gets merged soon.
Hopefully a stable release candidate as well.
I'll do so in a bit. I'll tag it for the 9.2 and 10.0 branches too.
-Brian
___
mesa-dev mailin
On 11/12/2013 02:51 AM, Fabio Pedretti wrote:
Cc: "10.0"
---
docs/relnotes/10.0.html | 1 +
1 file changed, 1 insertion(+)
diff --git a/docs/relnotes/10.0.html b/docs/relnotes/10.0.html
index eabe77f..bbb447f 100644
--- a/docs/relnotes/10.0.html
+++ b/docs/relnotes/10.0.html
@@ -55,6 +55,7 @
On 11/12/2013 02:51 AM, Fabio Pedretti wrote:
From: Cyril Brulebois
Thanks to Pino Toscano.
Patch from Debian package.
Cc: "10.0"
---
src/gallium/auxiliary/os/os_thread.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/gallium/auxiliary/os/os_thread.h
---
src/mesa/main/varray.h |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mesa/main/varray.h b/src/mesa/main/varray.h
index 8a9487c..ecfc6b6 100644
--- a/src/mesa/main/varray.h
+++ b/src/mesa/main/varray.h
@@ -73,8 +73,8 @@ _mesa_update_array_max_element(struct
We try to do all error checking before changing any GL state.
Cc: "10.0"
---
src/mesa/main/varray.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c
index d17d698..0f38270 100644
--- a/src/mesa/main/varray.c
+++ b/sr
And use a regular if statment to slightly improve readability.
---
src/mesa/main/varray.h |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/varray.h b/src/mesa/main/varray.h
index ecfc6b6..3b9f39a 100644
--- a/src/mesa/main/varray.h
+++ b/src/mesa/main/var
Looks good, just some minor clean-up suggestions below.
For patch 3, the idea of using loops sounds good.
Otherwise, Reviewed-by: Brian Paul
-Brian
On 11/11/2013 05:53 PM, Courtney Goeltzenleuchter wrote:
Needed test to measure texture upload speed under a variety
of modes (mipmap, source
On 11/11/2013 10:29 AM, Alexander von Gluck IV wrote:
I've been banging my head against a wall for a while now on this.
So the Haiku applications that call glViewport(.. for window
resizes,etc never actually execute the Driver's Viewport call.
(aka ctx->Driver.Viewport:
https://urldefense.proofp
will remain here to enable easier
cherry-picking from master, and everything stays on master so we can ship
a solid DRI3 in 3 months.
Looks good to me.
Reviewed-by: Brian Paul
Thanks, Eric.
-Brian
___
mesa-dev mailing list
mesa-dev@lists.freedeskto
retty well insulated from the rest of Mesa.
Acked-by: Brian Paul
-Brian
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 11/13/2013 09:47 AM, Alexander von Gluck IV wrote:
On Wed, 13 Nov 2013 08:38:59 -0700
Brian Paul wrote:
On 11/12/2013 10:49 PM, Alexander von Gluck IV wrote:
On Tue, Nov 12, 2013 at 11:46 PM, Alexander von Gluck IV
wrote:
* This is pretty small and upkeep
should be minimal.
Can you
On 11/13/2013 08:43 AM, Ferry Huberts wrote:
On 13/11/13 16:42, Ferry Huberts wrote:
The link in
https://urldefense.proofpoint.com/v1/url?u=http://cgit.freedesktop.org/mesa/mesa/diff/docs/index.html?id%3D9976a176ae62d53e8ad0c0f934d207e22ac41e85&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0
---
src/mesa/main/varray.h |6 --
1 file changed, 6 deletions(-)
diff --git a/src/mesa/main/varray.h b/src/mesa/main/varray.h
index 3b9f39a..bc820ed 100644
--- a/src/mesa/main/varray.h
+++ b/src/mesa/main/varray.h
@@ -110,12 +110,6 @@ extern void GLAPIENTRY
_mesa_VertexPointer(GLint size
To trim down the varray.c file so it's just vertex array functions.
---
src/mapi/glapi/gen/gl_genexec.py |1 +
src/mesa/Makefile.sources|1 +
src/mesa/SConscript |1 +
src/mesa/drivers/common/meta.c |1 +
src/mesa/main/draw.c |
---
src/gallium/auxiliary/indices/u_indices.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/src/gallium/auxiliary/indices/u_indices.c
b/src/gallium/auxiliary/indices/u_indices.c
index 30b54b9..1b33f41 100644
--- a/src/gallium/auxiliary/indices/u_indices.c
+++ b
The index translation code expects the number of indexes to be
consistent with the primitive type (ex: a multiple of 3 for
PIPE_PRIM_TRIANGLES). If it's not, we can write out of bounds
in the destination buffer.
Fixes failed assertions in the pipebuffer debug code found with
Piglit primitive-rest
To resolve missing symbol since the DRI driver rearchitecting.
---
src/gallium/targets/dri-vmwgfx/target.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/gallium/targets/dri-vmwgfx/target.c
b/src/gallium/targets/dri-vmwgfx/target.c
index e01e465..b4aaf0a 100644
--- a/
On 11/13/2013 10:37 AM, jfons...@vmware.com wrote:
From: José Fonseca
It is similar to tgsi_exec.c's DEBUG_EXECUTION compile flag.
I had prototyped this for a while while debugging an issue, but finally
cleaned this up and added a few more bells and whistles.
Here is a sample output.
CONST[0
And simplify the code.
---
src/gallium/drivers/svga/svga_draw_elements.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/src/gallium/drivers/svga/svga_draw_elements.c
b/src/gallium/drivers/svga/svga_draw_elements.c
index fb5f1c9..117f2b0 100644
--- a/src/gall
On 11/13/2013 03:32 PM, Jose Fonseca wrote:
- Original Message -
On 11/13/2013 10:37 AM, jfons...@vmware.com wrote:
From: José Fonseca
It is similar to tgsi_exec.c's DEBUG_EXECUTION compile flag.
I had prototyped this for a while while debugging an issue, but finally
cleaned this up
TATE_VAR, PROGRAM_LOCAL_PARAM, or PROGRAM_ENV_PARAM.
+* One of PROGRAM_STATE_VAR or PROGRAM_CONSTANT.
*/
unsigned param_binding_type;
For the series, Reviewed-by: Brian Paul
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.
For DX9-level shaders, there's only limited support for indirect
indexing of registers (with the loop counter register, not the
general address register.)
---
src/gallium/drivers/svga/svga_tgsi_insn.c |4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/drivers/svga/svga_tgsi_ins
After we blit/copy to a dest texture image we need to mark it as
being defined. This fixes broken mipmap generation for quite a
few texture formats. Mipgen involves making texture views and
svga_texture_view_surface() skips texture images that are undefined.
---
src/gallium/drivers/svga/svga_pip
On 11/14/2013 04:14 PM, Ian Romanick wrote:
On 11/13/2013 10:38 AM, Brian Paul wrote:
To trim down the varray.c file so it's just vertex array functions.
Is that the only motivation?
For now, yes. I'm just trying to de-clutter varray.[ch]
This will prevent us from opti
Needs to be larger than 6 to accomodate 3D textures and array textures.
Fixes a few piglit tests (fbo-3d, copyteximage 3D).
---
src/gallium/drivers/svga/svga_resource_texture.c |9 +
src/gallium/drivers/svga/svga_resource_texture.h | 41 --
2 files changed, 32 inserti
---
src/gallium/auxiliary/postprocess/pp_init.c | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/src/gallium/auxiliary/postprocess/pp_init.c
b/src/gallium/auxiliary/postprocess/pp_init.c
index a49a23d..bbebb5c 100644
--- a/src/gallium/auxiliary/p
Move private data structures and function prototypes out of the
public postprocess.h header file.
Create a pp_private.h for the shared, private data structures, functions.
Remove pp_program.h header.
---
src/gallium/auxiliary/postprocess/postprocess.h | 45 ++
src/gallium/auxiliary/postp
They're not needed in postprocess.h
---
src/gallium/auxiliary/postprocess/filters.h |4
src/gallium/auxiliary/postprocess/postprocess.h |3 ---
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/gallium/auxiliary/postprocess/filters.h
b/src/gallium/auxiliary/postp
To match the pp_ namespace convention.
---
src/gallium/auxiliary/postprocess/postprocess.h |4 ++--
src/gallium/auxiliary/postprocess/pp_colors.c |2 +-
src/gallium/auxiliary/postprocess/pp_filters.h | 14 +++---
src/gallium/auxiliary/postprocess/pp_init.c |2 +-
src/g
---
src/gallium/auxiliary/postprocess/postprocess.h |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/postprocess/postprocess.h
b/src/gallium/auxiliary/postprocess/postprocess.h
index 1db581c..c72f2c4 100644
--- a/src/gallium/auxiliary/postproces
Add new OSMesaPostprocess() function to allow using the gallium
postprocessing filters. This only works for OSMesa with gallium
drivers, not the legacy swrast OSMesa.
Bump OSMESA_MAJOR/MINOR_VERSION numbers to 10.0
---
include/GL/osmesa.h| 19 +-
src/gallium/state_t
We were always passing PIPE_TEXTURE_2D, but not all formats are
supported for all types of textures. In particular, the driver may
not supported texture compression for all types of textures.
---
src/mesa/state_tracker/st_format.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
di
---
src/gallium/drivers/svga/svga_screen.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/src/gallium/drivers/svga/svga_screen.c
b/src/gallium/drivers/svga/svga_screen.c
index 3c013ea..ebcad2c 100644
--- a/src/gallium/drivers/svga/svga_screen.c
+++ b/src/gallium/drivers/svga/svga_sc
ot;Vertex program %u __\n", program->Base.Id);
With those changes the piglit ARB_vertex/fragment_program crashes are fixed.
If you update the patch:
Tested-by: Brian Paul
Reviewed-by: Brian Paul
-Brian
__
On 11/18/2013 04:25 PM, Brian Paul wrote:
On 11/18/2013 11:07 AM, Eric Anholt wrote:
i965 passed piglit, but swrast and gallium both segfaulted without this.
i965 happened to work because it never ran _mesa_load_state_parameters()
on the new program before the test called
This is basically a a respin of f1dfcf4bce35e6796f873d9a00103b280da81e4c
per Jose's suggestion.
Just set the SVGA3dSurfaceFormatCaps flags for 3D and cube textures
when checking the texture format capabilities. This will filter out
unsupported combinations like 3D+DXT.
---
src/gallium/drivers/sv
5 files changed, 19 insertions(+), 6 deletions(-)
Reviewed-by: Brian Paul
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
We need to check the drawbuffer's orientation before inverting Y
coordinates. Fixes piglit feedback tests when running with the
-fbo option.
Cc: "9.2" "10.0"
---
src/mesa/state_tracker/st_cb_feedback.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mesa/state_t
r->Viewport call for Gallium?
For multiple viewports, I think you only have to be concerned with the
st_atom_viewport.c code. Have you looked at that?
-Brian
Courtney
On Mon, Nov 4, 2013 at 12:31 PM, Brian Paul mailto:bri...@vmware.com>> wrote:
On 11/04/2013 11:43 AM
On 11/18/2013 08:57 PM, Michel Dänzer wrote:
On Mon, 2013-11-18 at 17:27 -0800, Eric Anholt wrote:
i965 passed piglit, but swrast and gallium both segfaulted without this.
i965 happened to work because it never ran _mesa_load_state_parameters()
on the new program before the test called glProgram
" and
"glsl: Use more portable bash invocation construct." look ok to me.
Reviewed-by: Brian Paul
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
LL, allowDirect);
- }
+ } else
+ visinfo = NULL;
- if (!visinfo) {
+ if (!visinfo && !coreProfile) {
fprintf(stderr, "Error: couldn't find RGB GLX visual or fbconfig\n");
return False;
}
This and the other glxinfo patch lo
Not actually needed. Fixes piglit ARB_fragment_program/kil-swizzle test.
---
src/gallium/drivers/svga/svga_tgsi_insn.c | 24 ++--
1 file changed, 2 insertions(+), 22 deletions(-)
diff --git a/src/gallium/drivers/svga/svga_tgsi_insn.c
b/src/gallium/drivers/svga/svga_tgsi_in
window. This demo has no dependencies on
+ * any utility code, just the graw interface and gallium.
I think the comment needs to be fixed.
Reviewed-by: Brian Paul
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org
---
src/mesa/state_tracker/st_mesa_to_tgsi.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/state_tracker/st_mesa_to_tgsi.c
b/src/mesa/state_tracker/st_mesa_to_tgsi.c
index 7d79c62..1c2abc1 100644
--- a/src/mesa/state_tracker/st_mesa_to_tgsi.c
+++ b/src/mesa/state
And use a better assertion.
---
src/mesa/main/ffvertex_prog.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/src/mesa/main/ffvertex_prog.c b/src/mesa/main/ffvertex_prog.c
index be6ac0f..074fbf9 100644
--- a/src/mesa/main/ffvertex_prog.c
+++ b/src
The patch looks fine, but I'm not sure I understand the comment with
respect to the code change. I'd probably just call it something like
"tgsi: rework calls to ureg_emit_insn()"
But not a big deal.
Reviewed-by: Brian Paul
On 11/21/2013 07:01 AM, jfons...@vmware.co
On 11/21/2013 11:03 AM, jfons...@vmware.com wrote:
From: José Fonseca
Several links contributed by Keith Whitwell and Roland Scheidegger.
---
Nice.
Reviewed-by: Brian Paul
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http
line in case someone
wanted to put a breakpoint on that event.
Reviewed-by: Brian Paul
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
src/mesa/main/textureview.h
For patches 1-4, 8: Reviewed-by: Brian Paul
For patches 5-7: minor comments
Nice work.
-Brian
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 11/19/2013 04:16 PM, Courtney Goeltzenleuchter wrote:
Signed-off-by: Courtney Goeltzenleuchter
---
src/mesa/drivers/common/driverfuncs.c | 3 +++
src/mesa/main/dd.h| 5 +
2 files changed, 8 insertions(+)
diff --git a/src/mesa/drivers/common/driverfuncs.c
b/src/m
On 11/19/2013 04:16 PM, Courtney Goeltzenleuchter wrote:
Add helper function to set texture_view state from TexStorage calls.
Signed-off-by: Courtney Goeltzenleuchter
---
src/mesa/main/textureview.c | 59 +
src/mesa/main/textureview.h | 4 +++
2
I'd rename this summary as something like "mesa: implement the
_mesa_TextureView() function"
On 11/19/2013 04:16 PM, Courtney Goeltzenleuchter wrote:
Add Mesa TextureView logic.
Incorporate feedback on ARB_texture_view
Signed-off-by: Courtney Goeltzenleuchter
---
src/mesa/main/textureview.
On 11/22/2013 10:30 AM, Eric Anholt wrote:
Kenneth Graunke writes:
On 11/22/2013 12:21 AM, Eric Anholt wrote:
The canary is basically just to give a better debugging message when you
ralloc_free() something that wasn't rallocated. Reduces maximum memory
usage of apitrace replay of the dota2
The flags value is a bitfield so use the union's 'bf' field, not 'e'
(enum) field. There's no actual change in behavior here since both
fields of the union are the same size.
---
src/mesa/main/dlist.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/dlist.c b/s
Now, sizeof(gl_dlist_node)==4 even on 64-bit systems. This can
halve the memory used by some display lists on 64-bit systems.
---
src/mesa/main/dlist.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c
index 786
This is a first step in reducing memory used by display lists on
64-bit systems. On 64-bit systems, the gl_dlist_node union type
is 8 bytes because of the 'data' and 'next' fields. This causes
every display list node/token to occupy 8 bytes instead of 4 as
originally designed. This basically dou
---
src/mesa/main/convolve.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/src/mesa/main/convolve.c b/src/mesa/main/convolve.c
index f44031a..b13b895 100644
--- a/src/mesa/main/convolve.c
+++ b/src/mesa/main/convolve.c
@@ -45,7 +45,7 @@ _mesa_Conv
---
src/mesa/main/dlist.c | 21 +
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c
index 138f272..d1e2035 100644
--- a/src/mesa/main/dlist.c
+++ b/src/mesa/main/dlist.c
@@ -555,9 +555,9 @@ union uint64_pair
/**
---
src/mesa/main/dlist.c |4
1 file changed, 4 insertions(+)
diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c
index 74800da..83c56a7 100644
--- a/src/mesa/main/dlist.c
+++ b/src/mesa/main/dlist.c
@@ -6845,6 +6845,10 @@ save_error(struct gl_context *ctx, GLenum error, const
ch
As is done for the old histogram functions.
---
src/mesa/main/colortab.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/mesa/main/colortab.c b/src/mesa/main/colortab.c
index 81e92d7..a8edb03 100644
--- a/src/mesa/main/colortab.c
+++ b/src/mesa/main
Trying to compile any of these functions into a display list
now just generates a GL_INVALID_OPERATION error.
---
src/mesa/main/dlist.c | 551 -
1 file changed, 551 deletions(-)
diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c
index 59564
901 - 1000 of 7562 matches
Mail list logo
