Re: [Mesa-dev] [PATCH] glx: block attempt to swapbuffer on pixmap. (v2)

2011-12-19 Thread Adam Jackson
On Mon, 2011-12-19 at 16:45 +0100, Michel Dänzer wrote: > On Mon, 2011-12-19 at 10:14 -0500, Adam Jackson wrote: > > > The server is the only thing that knows how to handle this scenario, and > > it _can_ get this request, so you have to fix it there anyway. > > Actually

[Mesa-dev] [PATCH] drisw: Fix drawable creation against non-default screens

2012-01-03 Thread Adam Jackson
There's no reason to only force the visual to be on the default screen, and in fact good reason not to. Signed-off-by: Adam Jackson --- src/glx/drisw_glx.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/glx/drisw_glx.c b/src/glx/drisw_glx.c index 2d83a50..83

Re: [Mesa-dev] [PATCH] drisw: Fix drawable creation against non-default screens

2012-01-03 Thread Adam Jackson
On 1/3/12 3:48 PM, Ian Romanick wrote: On 01/03/2012 11:40 AM, Adam Jackson wrote: There's no reason to only force the visual to be on the default screen, and in fact good reason not to. Is the visual ID enough information to uniquely identify it? I may be mistaken (and horribly ignora

Re: [Mesa-dev] [PATCH] drisw: Fix drawable creation against non-default screens

2012-01-04 Thread Adam Jackson
On Tue, 2012-01-03 at 19:14 -0800, Ian Romanick wrote: > Okay. If some of that gets captured in the commit message, the change is > > Reviewed-by: Ian Romanick Pushed with better commit message, thanks. - ajax signature.asc Description: This is a digitally signed message part __

Re: [Mesa-dev] [PATCH] swrast: use memmove() instead of memcpy() in the SHIFT_ARRAY macro

2012-01-05 Thread Adam Jackson
n was clipped by the left side of > the window. Reviewed-by: Adam Jackson - ajax signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] xlib: use X error handler to catch XShmQueryVersion() failure

2012-01-11 Thread Adam Jackson
On Tue, 2012-01-10 at 19:46 -0700, Brian Paul wrote: > From: Brian Paul > > This is a follow-on to the previous commits. It seems that > XShmQueryVersion() can trigger an X error after the first X > connection is closed and we start using a new connection. I assume this is when you switch which

Re: [Mesa-dev] [PATCH 3/3] xlib: use X error handler to catch XShmQueryVersion() failure

2012-01-11 Thread Adam Jackson
On Wed, 2012-01-11 at 08:43 -0700, Brian Paul wrote: > On 01/11/2012 08:13 AM, Adam Jackson wrote: > > On Tue, 2012-01-10 at 19:46 -0700, Brian Paul wrote: > >> From: Brian Paul > >> > >> This is a follow-on to the previous commits. It seems that > >&

Re: [Mesa-dev] [PATCH] Do not use sched_yield() on Linux

2012-01-31 Thread Adam Jackson
On 1/31/12 12:30 PM, Alan Swanson wrote: As discussed back in 2003, sched_yield() on Linux is no longer equivalent to other POSIX variations. From a LWN article; "This call used to simply move the process to the end of the run queue; now it moves the process to the "expired" queue, effectively ca

Re: [Mesa-dev] DEATH to old drivers!

2011-09-06 Thread Adam Jackson
On Thu, 2011-08-25 at 07:38 -0700, Kenneth Graunke wrote: > On 08/25/2011 07:03 AM, Ian Romanick wrote: > > That's a fair point. Since we have a clean mechanism to improve those > > interfaces (e.g., DRI2!), there's relatively little cost in keeping that > > code around. > > > > I'd usually be pr

Re: [Mesa-dev] [PATCH] mesa: Don't expose compressed paletted formats via GL_{NUM_, }COMPRESSED_TEXTURE_FORMATS

2011-09-19 Thread Adam Jackson
On 9/19/11 1:08 PM, Ian Romanick wrote: From: Ian Romanick Fixes a bug introduced by commit faf5d65. These formats should only be exposed in OpenGL ES 1.x. Reviewed-by: Adam Jackson - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 4/7] mesa: implement glGet(GL_TIMESTAMP)

2012-06-27 Thread Adam Jackson
On Wed, 2012-06-27 at 09:29 +0200, Michel Dänzer wrote: > On Mit, 2012-06-27 at 03:49 +0200, Marek Olšák wrote: > > > > +GLuint64 > > +_mesa_get_cpu_timestamp(void) > > +{ > > +#ifndef _WIN32 > > + struct timeval tv; > > + > > + gettimeofday(&tv, 0); > > + return (GLuint64)tv.tv_sec * 1

Re: [Mesa-dev] [PATCH 4/7] mesa: implement glGet(GL_TIMESTAMP)

2012-06-27 Thread Adam Jackson
On Wed, 2012-06-27 at 17:16 +0200, Marek Olšák wrote: > I am working in nanoseconds and precision is quite important. I don't > think I can use CLOCK_MONOTONIC_COARSE. CLOCK_MONOTONIC might be fine. My mistake, read the math the wrong way around. - ajax signature.asc Description: This is a dig

Re: [Mesa-dev] Can --enable-shared-glapi die?

2012-07-24 Thread Adam Jackson
On 7/24/12 1:45 PM, Ian Romanick wrote: On 07/23/2012 12:59 PM, Ian Romanick wrote: Perhaps someone can refresh my memory as to what exactly this option does? Can we make this the default and remove the option from configure? Thanks to all for the refresher. Off-list someone raised another i

Re: [Mesa-dev] 761131ce4591e5f55f38d13f2c4d2194bc9cb0fd build regression with llvm 2.8

2012-07-26 Thread Adam Jackson
On 7/21/12 5:53 AM, Jose Fonseca wrote: - Original Message - Hi guys LLVM 2.8 doesn't appear to have mcjit, so we end up with no llvm libs defined, Yes, mcjit is only used/necessary from llvm-3.1 onwards, so the autoconf code should check conditiionally. BTW, I'll soon commit a chan

Re: [Mesa-dev] 761131ce4591e5f55f38d13f2c4d2194bc9cb0fd build regression with llvm 2.8

2012-07-26 Thread Adam Jackson
On 7/26/12 10:52 AM, Jose Fonseca wrote: - Original Message - Are the problems of mcjit simply a superset of the problems with the old jit? The only reason we started to look at mcjit was because old jit didn't support avx. But on current trunk (ie llvm-3.2) it does. To be honest, ap

[Mesa-dev] [PATCH] linux: Default to dri not xlib on all arches

2012-08-01 Thread Adam Jackson
Even on s390{,x} where there's no video card, you still want this so GLX protocol works. Signed-off-by: Adam Jackson --- configure.ac |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index b01b192..258c8ba 100644 --- a/configure.ac

Re: [Mesa-dev] [PATCH 3/3] configure.ac: Don't duplicate CFLAGS

2012-08-01 Thread Adam Jackson
like -fno-strict-aliasing. s/like/line/ in the first sentence. Otherwise for the series, Reviewed-by: Adam Jackson - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Mesa (master): linux: Default to dri not xlib on all arches

2012-08-01 Thread Adam Jackson
On 8/1/12 1:01 PM, Jose Fonseca wrote: I think that there's one ';;' too many. This is from my build daemon: checking for posix_memalign... yes ./configure: line 18498: syntax error near unexpected token `;;' ./configure: line 18498: `;;' There was, yes, sorry. Matt fixed it in

Re: [Mesa-dev] [PATCH] linux: Default to dri not xlib on all arches

2012-08-01 Thread Adam Jackson
On 8/1/12 11:52 AM, Matt Turner wrote: On Wed, Aug 1, 2012 at 8:45 AM, Adam Jackson wrote: Even on s390{,x} where there's no video card, you still want this so GLX protocol works. Yes, please. Too many bad defaults in configure.ac. My alpha with an R350 thanks you. Reviewed-by: Matt T

[Mesa-dev] [PATCH] glx: Verify that drawable creation on the client side actually worked

2011-05-04 Thread Adam Jackson
... and clean up if it didn't. Signed-off-by: Adam Jackson --- src/glx/glx_pbuffer.c | 76 - src/glx/glxcmds.c | 74 +++- 2 files changed, 98 insertions(+), 52 deletions(-) diff --git a/sr

Re: [Mesa-dev] shared LLVM library causes program abortion

2011-05-17 Thread Adam Jackson
On 5/17/11 3:24 PM, Jose Fonseca wrote: I believe the best alternative here is to build *_dri.so with -z nodelete when linking against a shared libLLVM*. That should work, even though it's incredibly unpleasant. I would think LLVM would want to be robust against multiple users within the sa

[Mesa-dev] [PATCH] mesa: Fix return type of _mesa_get_format_bytes() (#37351)

2011-05-19 Thread Adam Jackson
on to unsigned. Since stride can be negative, this is disastrous. Fixes at least the following piglit tests on Ironlake: fbo/fbo-blit-d24s8 spec/ARB_depth_texture/fbo-clear-formats spec/EXT_packed_depth_stencil/fbo-clear-formats Signed-off-by: Adam Jackson --- src/mesa/main/form

Re: [Mesa-dev] [PATCH] mesa: Use signed math for possibly negative values

2011-05-19 Thread Adam Jackson
On Thu, 2011-05-19 at 14:13 +0200, Ian Romanick wrote: > From: Ian Romanick > > Since RowStride might be negative, we want a signed result. On 64-bit > platforms, an unsigned 32-bit result added to a 64-bit pointer will > give the wrong answer. Hah, saw this just as I sent my patch. Let's hear

Re: [Mesa-dev] [PATCH] mesa: Fix return type of _mesa_get_format_bytes() (#37351)

2011-05-23 Thread Adam Jackson
On 5/20/11 8:50 PM, Jose Fonseca wrote: I don't care which approach we go with. This will likely fix it everywhere, but I'd like there to be a comment explaining why the return type must not be unsigned. Otherwise someone will come along in the future and make it unsigned in the name of "code

[Mesa-dev] [PATCH] glx/dri2: Paper over errors in DRI2Connect when indirect (#28125)

2011-05-24 Thread Adam Jackson
DRI2 will throw BadRequest for this when the client is not local, but DRI2 is an implementation detail and not something callers should have to know about. Silently swallow errors in this case, and just propagate the failure through DRI2Connect's return code. Signed-off-by: Adam Ja

Re: [Mesa-dev] [PATCH] glx/dri2: Paper over errors in DRI2Connect when indirect (#28125)

2011-05-26 Thread Adam Jackson
On Thu, 2011-05-26 at 17:39 -0400, Kristian Høgsberg wrote: > On Tue, May 24, 2011 at 6:10 PM, Adam Jackson wrote: > > DRI2 will throw BadRequest for this when the client is not local, but > > DRI2 is an implementation detail and not something callers should have > > to

[Mesa-dev] [PATCH 1/2] glx: Fix another case of using req outside of the display lock

2011-06-01 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/glx/glxcmds.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index dbfa0ed..8b4151d 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -644,13 +644,13 @@ glXCreateGLXPixmap(Display * dpy

[Mesa-dev] [PATCH 2/2] glx: Remove (unused, broken) fastImageUnpack fast path

2011-06-01 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/glx/glxclient.h|8 src/glx/indirect_glx.c |3 - src/glx/renderpix.c| 98 +++- 3 files changed, 39 insertions(+), 70 deletions(-) diff --git a/src/glx/glxclient.h b/src/glx/glxclient.h index

Re: [Mesa-dev] [PATCH 2/2] glx: Remove (unused, broken) fastImageUnpack fast path

2011-06-02 Thread Adam Jackson
On Thu, 2011-06-02 at 09:19 -0600, Brian Paul wrote: > On 06/01/2011 11:44 AM, Adam Jackson wrote: > > - /* Apply pixel store unpack modes to copy data into buf */ > > - if (src != NULL) { > > - (*gc->fillImage) (gc, dim, width, hei

[Mesa-dev] [PATCH] llvmpipe: SSE2 fastpaths for b8g8r8x8 {un, }swizzle

2011-06-13 Thread Adam Jackson
Copy-and-paste from the bgra cases. The C paths attempt to avoid copying the 'x' channel, but it's harmless, you might as well. Good for about 5% in glxgears (740 to 780 fps). Signed-off-by: Adam Jackson --- src/gallium/drivers/llvmpipe/lp_tile_soa.py | 68 +++

[Mesa-dev] [PATCH] glx: Alias glXFreeContextEXT to glXDestroyContext

2011-06-13 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/glx/glxcmds.c | 20 ++-- 1 files changed, 6 insertions(+), 14 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index ab6b61a..e4356dd 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -354,8 +354,9

Re: [Mesa-dev] [PATCH] glx: implement drawable refcounting.

2011-06-17 Thread Adam Jackson
round trips to the X server at getbuffers() time) or implement proper drawable refcounting. This patch implements the latter. Signed-off-by: Antoine Labour Signed-off-by: Stéphane Marchesin Reviewed-by: Adam Jackson - ajax ___ mesa-dev mailing list mesa

[Mesa-dev] [PATCH] llvmpipe: Optimize new fs state setup

2011-06-29 Thread Adam Jackson
file; more importantly, ipers goes from 10 to 14fps and gears goes from 790 to 830fps. Signed-off-by: Adam Jackson --- src/gallium/drivers/llvmpipe/lp_setup.c | 61 ++- 1 files changed, 27 insertions(+), 34 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_setu

Re: [Mesa-dev] [PATCH] llvmpipe: Optimize new fs state setup

2011-06-30 Thread Adam Jackson
On Thu, 2011-06-30 at 03:36 +0200, Roland Scheidegger wrote: > Ok in fact there's a gcc bug about memcmp: > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43052 > In short gcc's memcmp builtin is totally lame and loses to glibc's > memcmp (including call overhead, no knowledge about alignment etc.) ev

Re: [Mesa-dev] Woes of --enable-32-bit on x86-64 Fedora 15

2012-03-30 Thread Adam Jackson
On 3/30/12 12:31 PM, Ian Romanick wrote: Building the i965 driver with --enable-32-bit is just broken on Fedora 15. It seems to work for folks on other distros, but I get a lot of failure during linking i965_dri.so. Linking i915_dri.so works, and the difference seems to be the presence of C++ fil

Re: [Mesa-dev] Mesa-8.0.2 libGL.so: undefined reference to `XGetXCBConnection'

2012-04-17 Thread Adam Jackson
On Mon, 2012-04-16 at 22:15 +1000, jupiter@gmail.com wrote: > I've just built Mesa-8.0.2 in a Linux box. Then there were errors of > "libGL.so: > undefined reference to `XGetXCBConnection'" % nm -aD --defined /usr/lib/libX11-xcb.so.1 | grep XCB 473ef560 T XGetXCBConnection > and "libGL.so:

Re: [Mesa-dev] [PATCH 01/10] glx: Use AM_CPPFLAGS to pass -I and -D to both C and C++ compiles.

2012-04-17 Thread Adam Jackson
NC) $(X11_CFLAGS) > + -I$(top_builddir)/src/glx \ > + $(X11_CFLAGS) > > if HAVE_XCB_GLX_CREATE_CONTEXT > TESTS = glx_unittest Reviewed-by: Adam Jackson - ajax signature.asc Description: This is a digitally signed message part ___

Re: [Mesa-dev] Mesa-8.0.2 libGL.so: undefined reference to `XGetXCBConnection'

2012-04-18 Thread Adam Jackson
On Tue, 2012-04-17 at 23:53 +1000, jupiter@gmail.com wrote: > On 2012-04-17 09:34-0400, Adam Jackson wrote: > >Note that neither one of the above libraries is mentioned in your ldd > >output, which means libGL was linked incorrectly. What method did you > >use to build M

Re: [Mesa-dev] [PATCH] intel: Change vendor string to "Intel® Open Source Technology Center".

2012-06-01 Thread Adam Jackson
On 6/1/12 3:33 AM, Oliver McFadden wrote: Furthermore it actually doesn't render correctly with my encodings (en_GB and en_US: UTF-8 and ISO-8859-1, and various Finnish and Swedish ones left out for brevity. Okay, problem on my end, but I'm probably not the only one (or maybe I am just an idiot

Re: [Mesa-dev] [PATCH] intel: Change vendor string to "Intel® Open Source Technology Center".

2012-06-01 Thread Adam Jackson
On 6/1/12 2:06 PM, Oliver McFadden wrote: On Fri, Jun 01, 2012 at 11:23:17AM -0400, Adam Jackson wrote: On 6/1/12 3:33 AM, Oliver McFadden wrote: Wouldn't "Intel(R) Open Source ..." be sufficient? Wouldn't "Intel Open Source ..." be sufficient? I am not a law

Re: [Mesa-dev] [PATCH] Set OSMESA_VERSION=8.

2012-09-07 Thread Adam Jackson
On 9/1/12 7:35 PM, Johannes Obermayr wrote: VERSION_NUMBER is not required anymore. So it will be removed. Applied, thanks. - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Proposal for an Updated Linux OpenGL ABI

2012-09-17 Thread Adam Jackson
On Fri, 2012-09-14 at 16:46 -0700, Andy Ritger wrote: > On Thu, Sep 13, 2012 at 03:19:44PM -0700, Brian Paul wrote: > > BTW, this wouldn't part of the ABI proper, but if we're making > > suggestions for Linux distros, maybe we can suggest that they ship > > helpful utilities like glxinfo and egli

Re: [Mesa-dev] [PATCH 2/2] build: Link libglapi with pthreads

2012-09-24 Thread Adam Jackson
On Mon, 2012-09-24 at 09:48 -0700, Matt Turner wrote: > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=839060 > https://bugs.gentoo.org/show_bug.cgi?id=435152 For the series: Reviewed-by: Adam Jackson - ajax signature.asc Description: This is a digitally signed messag

[Mesa-dev] [PATCH] glx: Add GLXBadProfileARB to the error string list

2012-10-17 Thread Adam Jackson
Note: This is a candidate for the stable branches. Signed-off-by: Adam Jackson --- src/glx/glxext.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glx/glxext.c b/src/glx/glxext.c index 4d59a06..e55c1c1 100644 --- a/src/glx/glxext.c +++ b/src/glx/glxext.c @@ -81,6 +81,7 @@ static

Re: [Mesa-dev] [PATCH] glx: Add GLXBadProfileARB to the error string list

2012-10-17 Thread Adam Jackson
On 10/17/12 2:52 PM, Brian Paul wrote: On 10/17/2012 12:38 PM, Adam Jackson wrote: Note: This is a candidate for the stable branches. Signed-off-by: Adam Jackson --- src/glx/glxext.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glx/glxext.c b/src/glx/glxext.c index 4d59a06

Re: [Mesa-dev] [PATCH 0/8] sRGB fixes

2012-10-25 Thread Adam Jackson
On Wed, 2012-10-24 at 10:08 -0700, Ian Romanick wrote: > This series contains a bunch of Mesa and GLX fixes releated to sRGB > drawables. It should contain all of the work necessary to allow drivers to > advertise sRGB fbconfigs. > > What is missing is a 9th patch to actually add some sRGB fbconf

Re: [Mesa-dev] [PATCH 0/8] sRGB fixes

2012-10-25 Thread Adam Jackson
On Thu, 2012-10-25 at 11:33 -0700, Ian Romanick wrote: > On 10/25/2012 07:37 AM, Adam Jackson wrote: > > I don't see why that's true. You don't get sRGB rendering until you've > > called glEnable(GL_FRAMEBUFFER_SRGB). Just flag all your fbconfigs as > > s

Re: [Mesa-dev] auto generated glx code in X server

2011-03-16 Thread Adam Jackson
On Tue, 2011-03-15 at 13:52 +1000, Dave Airlie wrote: > On Fri, Mar 4, 2011 at 11:24 AM, Dave Airlie wrote: > > Hi guys, > > > > I know this used to work, but it seems to be well busted now. > > > > If you made glx changes in mesa you could just set XORG_BASE and run > > make and it would regenera

<    1   2   3   4   5