Re: [Mesa-dev] [PATCH 2/4] nv50ir: fix unnecessary parentheses warning

2019-09-22 Thread Rhys Kidd
On Sat, 21 Sep 2019 at 04:27, Karol Herbst wrote: > Signed-off-by: Karol Herbst > Reviewed-by: Rhys Kidd > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_util.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_util.h > b

[Mesa-dev] [PATCH 3/3] android: aco: add support for libmesa_aco

2019-09-22 Thread Mauro Rossi
Android building rules are added in src/amd/Android.compiler.mk libmesa_aco static library is built conditionally to radeonsi as done for vulkan.radv module This will prevent Android build errors for non x86 systems filter-out compiler/aco_instruction_selection_setup.cpp source, as already includ

[Mesa-dev] [PATCH 2/3] android: compiler/nir: build nir_divergence_analysis.c

2019-09-22 Thread Mauro Rossi
Prerequisite to avoid following radv linking error happening with aco FAILED: out/target/product/x86_64/obj_x86/SHARED_LIBRARIES/vulkan.radv_intermediates/LINKED/vulkan.radv.so ... external/mesa/src/amd/compiler/aco_instruction_selection_setup.cpp:178: error: undefined reference to 'nir_divergenc

Re: [Mesa-dev] [PATCH 3/4] nv50ir/nir: comparison of integer expressions of different signedness warning

2019-09-22 Thread Rhys Kidd
On Sat, 21 Sep 2019 at 04:27, Karol Herbst wrote: > Signed-off-by: Karol Herbst > Reviewed-by: Rhys Kidd > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from

Re: [Mesa-dev] [PATCH 1/3] panfrost: Make sure a clear does not re-use a pre-existing batch

2019-09-22 Thread Boris Brezillon
On Fri, 20 Sep 2019 15:45:33 -0400 Alyssa Rosenzweig wrote: > To be clear, if we have a batch and do the following operations: > > clear red > draw 1 > clear green > draw 2 > flush > > All we should see is #2 on a green background, which this patch handles > by the

Re: [Mesa-dev] [PATCH v3 01/17] panfrost: Extend the panfrost_batch_add_bo() API to pass access flags

2019-09-22 Thread Boris Brezillon
On Fri, 20 Sep 2019 16:53:49 -0400 Alyssa Rosenzweig wrote: > > @@ -1121,7 +1134,11 @@ panfrost_emit_for_draw(struct panfrost_context *ctx, > > bool with_vertex_data) > > > > struct panfrost_shader_state *ss = > > &all->variants[all->active_variant]; > > > > -

[Mesa-dev] [PATCH 1/3] android: aco: fix undefined template 'std::__1::array' build errors

2019-09-22 Thread Mauro Rossi
Fixes a few building errors similar to the following: In file included from external/mesa/src/amd/compiler/aco_instruction_selection.cpp:26: In file included from external/libcxx/include/algorithm:639: external/libcxx/include/utility:321:9: error: implicit instantiation of undefined template 'std

Re: [Mesa-dev] [PATCH 1/4] nv50ir: fix memset on non trivial types warning

2019-09-22 Thread Rhys Kidd
On Sat, 21 Sep 2019 at 04:27, Karol Herbst wrote: > Signed-off-by: Karol Herbst > Reviewed-by: Rhys Kidd > --- > src/gallium/drivers/nouveau/codegen/nv50_ir.cpp| 4 +--- > src/gallium/drivers/nouveau/codegen/nv50_ir.h | 2 +- > src/gallium/drivers/nouveau/codegen/nv50_ir_ta

Re: [Mesa-dev] [PATCH v3 01/17] panfrost: Extend the panfrost_batch_add_bo() API to pass access flags

2019-09-22 Thread Alyssa Rosenzweig
> > Although actually I am not at all sure what this batch_add_bo is doing > > at all? > > > > I think this batch_add_bo should probably dropped altogether? This loop > > is dealing with constant buffers; the shaders themselves were added > > I'll double check. I couldn't find where BOs containin

Re: [Mesa-dev] [PATCH 1/3] panfrost: Make sure a clear does not re-use a pre-existing batch

2019-09-22 Thread Alyssa Rosenzweig
> > To be clear, if we have a batch and do the following operations: > > > > clear red > > draw 1 > > clear green > > draw 2 > > flush > > > > All we should see is #2 on a green background, which this patch handles > > by the second clear invalidating all the clears/draws that

Re: [Mesa-dev] [PATCH v3 01/17] panfrost: Extend the panfrost_batch_add_bo() API to pass access flags

2019-09-22 Thread Boris Brezillon
+your collabora address On Sun, 22 Sep 2019 08:31:40 -0400 Alyssa Rosenzweig wrote: > > > Although actually I am not at all sure what this batch_add_bo is doing > > > at all? > > > > > > I think this batch_add_bo should probably dropped altogether? This loop > > > is dealing with constant buffe

Re: [Mesa-dev] [PATCH 1/3] panfrost: Make sure a clear does not re-use a pre-existing batch

2019-09-22 Thread Boris Brezillon
On Sun, 22 Sep 2019 08:38:30 -0400 Alyssa Rosenzweig wrote: > > > To be clear, if we have a batch and do the following operations: > > > > > > clear red > > > draw 1 > > > clear green > > > draw 2 > > > flush > > > > > > All we should see is #2 on a green background, which this patch

Re: [Mesa-dev] [PATCH v3 01/17] panfrost: Extend the panfrost_batch_add_bo() API to pass access flags

2019-09-22 Thread Alyssa Rosenzweig
> +your collabora address Thank you > > > > I think this batch_add_bo should probably dropped altogether? This loop > > > > is dealing with constant buffers; the shaders themselves were added > > > > > > I'll double check. I couldn't find where BOs containing shader programs > > > were added l

Re: [Mesa-dev] [PATCH v3 01/17] panfrost: Extend the panfrost_batch_add_bo() API to pass access flags

2019-09-22 Thread Boris Brezillon
On Sun, 22 Sep 2019 09:26:45 -0400 Alyssa Rosenzweig wrote: > > +your collabora address > > Thank you > > > > > > I think this batch_add_bo should probably dropped altogether? This > > > > > loop > > > > > is dealing with constant buffers; the shaders themselves were added > > > > > > >

Re: [Mesa-dev] [PATCH 1/3] panfrost: Make sure a clear does not re-use a pre-existing batch

2019-09-22 Thread Boris Brezillon
On Sun, 22 Sep 2019 15:24:10 +0200 Boris Brezillon wrote: > On Sun, 22 Sep 2019 08:38:30 -0400 > Alyssa Rosenzweig wrote: > > > > > To be clear, if we have a batch and do the following operations: > > > > > > > > clear red > > > > draw 1 > > > > clear green > > > >