[Mesa-dev] [PATCH] radv: do not emit VGT_FLUSH on GFX10

2019-07-08 Thread Samuel Pitoiset
We don't need it. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 5a92e5276d9..09614067a4a 100644 --- a/src/amd/vulkan/radv_device.c +++ b/

Re: [Mesa-dev] [PATCH] radv: do not emit VGT_FLUSH on GFX10

2019-07-08 Thread Bas Nieuwenhuizen
r-b On Mon, Jul 8, 2019 at 1:45 PM Samuel Pitoiset wrote: > > We don't need it. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_device.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c > i

Re: [Mesa-dev] [MR] Update README to recommend MRs instead of `git send-email`

2019-07-08 Thread Eric Engestrom
On Saturday, 2019-07-06 13:39:16 -0400, Ilia Mirkin wrote: > I see this as driving away contributions, esp from new people. MR's > are annoying to create, since they require dealing with the hosting > provider, getting it to host clones, etc. Everyone has email. MRs have a one-time cost of having

Re: [Mesa-dev] [MR] Update README to recommend MRs instead of `git send-email`

2019-07-08 Thread Ernst Sjöstrand
git send-email with a gmail account is quite messy IMHO, I'd much rather do a pull request. Regards //Ernst Den mån 8 juli 2019 kl 15:32 skrev Eric Engestrom : > > On Saturday, 2019-07-06 13:39:16 -0400, Ilia Mirkin wrote: > > I see this as driving away contributions, esp from new people. MR's >

[Mesa-dev] [PATCH 03/42] panfrost: Extend clear colour packing

2019-07-08 Thread Alyssa Rosenzweig
Eventually, this will allow packing clear colours for all formats, including floating-point framebuffers, pure integer buffers, and special formats. Currently, a few of these formats are supported, and many more are handled through a generic Gallium colour packing path (which is not a perfect fit f

[Mesa-dev] [PATCH 01/42] panfrost: Prepare some code for MRT

2019-07-08 Thread Alyssa Rosenzweig
Full MRT support is a while away, but in the mean time, we can remove code that explicitly assumes nr_cbufs <= 0, to minimize the obstacles we'll face later when we add the whole thing. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 39 -- 1

[Mesa-dev] [PATCH 09/42] panfrost/midgard: Move blend type conversion into NIR

2019-07-08 Thread Alyssa Rosenzweig
Now that we have u2u8 implemented, we can move everything up into NIR and eliminate the silly "blend epilogue" (no such thing; it's just a fragment epilogue). Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 63 +-- .../panfrost/midgard/nir_low

[Mesa-dev] [PATCH 02/42] panfrost/mfbd: Include codes for float framebuffers

2019-07-08 Thread Alyssa Rosenzweig
We see the hardware doesn't actually support float framebuffers in the native sense -- rather, it just allows higher bpp framebuffers and lets a blend shader / additional clear_color fields sort out the formats. This will be.. interesting. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers

[Mesa-dev] [PATCH 00/42] panfrost: Render target stuff

2019-07-08 Thread Alyssa Rosenzweig
This series is focused on rendering to more render target formats, particularly ones that require the use of a blend shader. As an aside in the middle, this leads us to implement preliminary fp16/i16 support in the Midgard compiler. Depends on the accompanying NIR and Gallium patches. Alyssa Rose

[Mesa-dev] [PATCH 04/42] panfrost/midgard: Passthrough nir_lower_framebuffer

2019-07-08 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/meson.build | 1 + .../panfrost/midgard/nir_lower_blend.h| 3 + .../panfrost/midgard/nir_lower_framebuffer.c | 102 ++ .../drivers/panfrost/pan_blend_shaders.c | 2 + 4 files changed, 108 in

[Mesa-dev] [PATCH 06/42] panfrost/midgard: Rewrite to use new blend intrinsic

2019-07-08 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/midgard/midgard_compile.c| 11 +++ .../panfrost/midgard/nir_lower_framebuffer.c | 15 --- 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c

[Mesa-dev] [PATCH 08/42] panfrost/midgard: Use nir_dest_num_components

2019-07-08 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c index 32cc55c52ee..dba6c

[Mesa-dev] [PATCH 07/42] panfrost/midgard: Implement integer downsize ops

2019-07-08 Thread Alyssa Rosenzweig
Oh, dear. No turning back now. We begin implementing non-32-bit types, using downsizing integer type conversions as the initial instructions. We implement them naively as type-converting moves; substantially more efficient operation is possible by copypropping the type conversion modifier, but thi

[Mesa-dev] [PATCH 05/42] panfrost/midgard: Move scale from MIR to NIR

2019-07-08 Thread Alyssa Rosenzweig
This begins the process of removing blend shader specific MIR into a more general NIR lowering pass for formats. Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/midgard/midgard_compile.c | 13 + .../panfrost/midgard/nir_lower_framebuffer.c| 4 ++-- 2 files cha

[Mesa-dev] [PATCH 11/42] panfrost/midgard: Implement upscaling type converts

2019-07-08 Thread Alyssa Rosenzweig
Rather than using a dest_override, we upscale integers by using a half field with a sign-extend bit. A variant of this trick should also work for floats, but one step at a time! Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 73 +++ 1 file ch

[Mesa-dev] [PATCH 12/42] panfrost/midgard: Fix blend constant scheduling bug

2019-07-08 Thread Alyssa Rosenzweig
Blend constant conflicts run in two directions. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_schedule.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_schedule.c b/src/gallium/drivers/panfrost/midgard/mid

[Mesa-dev] [PATCH 10/42] panfrost/midgard: Route blend load intrinsic

2019-07-08 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 17 +++--- .../panfrost/midgard/nir_lower_framebuffer.c | 33 +-- 2 files changed, 36 insertions(+), 14 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/sr

[Mesa-dev] [PATCH 18/42] panfrost/midgard: Allow fp16 in scalar ALU

2019-07-08 Thread Alyssa Rosenzweig
The packing is a little different, so implement that. Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/midgard/midgard_emit.c | 47 ++- .../panfrost/midgard/midgard_schedule.c | 21 +++-- 2 files changed, 52 insertions(+), 16 deletions(-) diff --git a/src/ga

[Mesa-dev] [PATCH 13/42] panfrost/midgard: Move blend shader loads to NIR

2019-07-08 Thread Alyssa Rosenzweig
The scale and type-convert can now be expressed in NIR, rather than MIR, which is significantly more maintainable and demonstrates correctness of the type conversion patches. Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 52 --- .../panfrost

[Mesa-dev] [PATCH 16/42] panfrost/midgard: Implement f2f16/f2f32

2019-07-08 Thread Alyssa Rosenzweig
These conversions handle half-floats within the shader. Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/midgard/midgard_compile.c | 18 ++ .../panfrost/midgard/midgard_nir_algebraic.py | 5 - .../panfrost/midgard/nir_lower_framebuffer.c | 7 +-- 3 files cha

[Mesa-dev] [PATCH 14/42] panfrost/midgard: Simplify blend read

2019-07-08 Thread Alyssa Rosenzweig
It's not clear where the extra indirection was from (older hardware or just older blobs?) Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 28 --- 1 file changed, 5 insertions(+), 23 deletions(-) diff --git a/src/gallium/drivers/panfrost/midga

[Mesa-dev] [PATCH 21/42] panfrost/midgard: Eliminate redundant type convert

2019-07-08 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_nir_algebraic.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_nir_algebraic.py b/src/gallium/drivers/panfrost/midgard/midgard_nir_algebraic.py index 871195b48c

[Mesa-dev] [PATCH 19/42] panfrost/midgard: Hoist mask field

2019-07-08 Thread Alyssa Rosenzweig
Share a single mask field in midgard_instruction with a unified format, rather than using separate masks for each instruction tag with hardware-specific formats. Eliminates quite a bit of duplicated code and will enable vec8/vec16 masks as well (which don't map as cleanly to the hardware as we migh

[Mesa-dev] [PATCH 15/42] panfrost/midgard: Verify src_bitsize == dst_bitsize

2019-07-08 Thread Alyssa Rosenzweig
We can handle differing, but we'd prefer not to because there are restrictions on sizing which aren't accounted for yet. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/ga

[Mesa-dev] [PATCH 22/42] panfrost/midgard: Handle fp16 in embedded_to_inline_constants

2019-07-08 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c index de40eeafdd

[Mesa-dev] [PATCH 30/42] panfrost/midgard: Skip blend for REPLACE (shader)

2019-07-08 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/nir_lower_blend.c| 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/gallium/drivers/panfrost/midgard/nir_lower_blend.c b/src/gallium/drivers/panfrost/midgard/nir_lower_blend.c index af0a7ac31cf..0fadeba66

[Mesa-dev] [PATCH 28/42] panfrost: Route format through fixed-function blending

2019-07-08 Thread Alyssa Rosenzweig
Not all framebuffer formats are supported by the fixed-function blender. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_blending.c | 41 - src/gallium/drivers/panfrost/pan_blending.h | 7 +++- src/gallium/drivers/panfrost/pan_context.c | 11 +++--- 3

[Mesa-dev] [PATCH 31/42] panfrost/midgard: Implement preliminary float converters

2019-07-08 Thread Alyssa Rosenzweig
We'll need some careful handling, but for now, get some baseline code out for handling float formats in a blend shader. Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/nir_lower_framebuffer.c | 40 +++ 1 file changed, 33 insertions(+), 7 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH 29/42] panfrost: Handle "blend disabled" blend shaders

2019-07-08 Thread Alyssa Rosenzweig
Normally, disabled blend can definitely be fixed-function'd away, but if a blend shader is used merely for format conversion rather than blending, this code path can be nevertheless hit. Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/pan_blend_shaders.c | 34 ---

[Mesa-dev] [PATCH 42/42] panfrost: Update supported formats

2019-07-08 Thread Alyssa Rosenzweig
Much of the format selection code was inherited from softpipe (!) of all places, and a lot of it is accordingly cruft. Later if-elses were added in random places to workaround missing formats at various points in history. Clean up some of this. Theoretically, any format we can texture from we can

[Mesa-dev] [PATCH 36/42] panfrost: Refactor blend infrastructure

2019-07-08 Thread Alyssa Rosenzweig
We would like to permit keying blend shaders against the framebuffer format, which requires some new blending abstractions. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/meson.build | 1 + src/gallium/drivers/panfrost/pan_blend.h | 109 +++ src/gallium/drivers

[Mesa-dev] [PATCH 39/42] panfrost/mfbd: Handle PIPE_FORMAT_B10G10R10A2_UNORM

2019-07-08 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_blending.c | 4 src/gallium/drivers/panfrost/pan_mfbd.c | 11 ++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/pan_blending.c b/src/gallium/drivers/panfrost/pan_

[Mesa-dev] [PATCH 34/42] panfrost/midgard: Handle pure int formats

2019-07-08 Thread Alyssa Rosenzweig
I'm not sure I'm totally comfortable with this, but conceptually neither float nor pure-int formats require any format conversion, except size conversion. Going from a shaderable format (fp32 or i16, for instance) into a blendable format (fp16) is a separate question, one we can defer momentarily w

[Mesa-dev] [PATCH 41/42] panfrost/mfbd: Cleanup format code selection

2019-07-08 Thread Alyssa Rosenzweig
Rather than have random variables flying around and a long if-else chain, use a switch. They're literally *designed* for this. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_blending.c | 5 + src/gallium/drivers/panfrost/pan_mfbd.c | 162 +++- 2 files

[Mesa-dev] [PATCH 27/42] panfrost: Pipe framebuffer format around

2019-07-08 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/nir_lower_blend.h| 3 ++- .../drivers/panfrost/midgard/nir_lower_framebuffer.c | 3 +-- src/gallium/drivers/panfrost/pan_blend_shaders.c | 8 ++-- src/gallium/drivers/panfrost/pan_blend_shaders.h

[Mesa-dev] [PATCH 40/42] panfrost/midgard: Cleanup blend switch

2019-07-08 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/nir_lower_framebuffer.c | 49 --- 1 file changed, 31 insertions(+), 18 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/nir_lower_framebuffer.c b/src/gallium/drivers/panfrost/midgard/nir_lower_framebuffer.c

[Mesa-dev] [PATCH 26/42] panfrost/midgard: Use Gallium framebuffer formats

2019-07-08 Thread Alyssa Rosenzweig
Ideally, we would keep Galliumisms far away from the compiler; unfortunately, Mesa hasn't standardized on system of format codes to be shared across APIs and across drivers, so using Gallium formats is our best bet in the short run. Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/nir_l

[Mesa-dev] [PATCH 20/42] panfrost/midgard: Fix fp16 embedded constants

2019-07-08 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_schedule.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_schedule.c b/src/gallium/drivers/panfrost/midgard/midgard_schedule.c index caa29b7a2e4..ebbabae

[Mesa-dev] [PATCH 24/42] panfrost/midgard: Remove opt_copy_prop_tex

2019-07-08 Thread Alyssa Rosenzweig
Eventually this should be replaced by proper tex RA / not emitting so many silly moves to begin with / better general copy prop. For now remove it since it breaks things. Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_compile.c| 50 --- 1 file changed,

[Mesa-dev] [PATCH 35/42] panfrost/midgard: Use unsigned blend patch offset

2019-07-08 Thread Alyssa Rosenzweig
We would like the offset field to be unsigned, letting 0 represent "no offset" and positive represent an offset. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/pan

[Mesa-dev] [PATCH 33/42] panfrost/mfbd: Handle pure int formats

2019-07-08 Thread Alyssa Rosenzweig
We see that the render target itself turns out to be typeless (surprise!) Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_mfbd.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_mfbd.c b/src/gallium/

[Mesa-dev] [PATCH 25/42] panfrost/midgard: Use fp16 exclusively while blending

2019-07-08 Thread Alyssa Rosenzweig
We now have some preliminary fp16 support available. We're not able to expose this for GLSL quite yet, but for internal blend shaders, we're able to do control bitness ourselves just fine. So let's fp16 that stuff! Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/midgard/nir_lower_blend

[Mesa-dev] [PATCH 37/42] panfrost: Implement ES3-format writeout

2019-07-08 Thread Alyssa Rosenzweig
We add support for writing out (via a blend shader): - RGBA4 - RGB10_A2_UNORM - RGB10_A2_UINT - RGB5_A1_UNORM - R11G11B10_FLOAT Signed-off-by: Alyssa Rosenzweig --- .../panfrost/midgard/midgard_nir_algebraic.py | 2 + .../panfrost/midgard/nir_lower_framebuffer.c | 113

[Mesa-dev] [PATCH 23/42] panfrost/midgard: Fix scalarification

2019-07-08 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- .../drivers/panfrost/midgard/midgard_emit.c | 3 ++- .../panfrost/midgard/midgard_schedule.c | 27 --- 2 files changed, 25 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_emit.c b/src/gallium/d

[Mesa-dev] [PATCH 17/42] panfrost/midgard: Implement f2u16 and friends

2019-07-08 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 5 + src/gallium/drivers/panfrost/midgard/nir_lower_framebuffer.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b

[Mesa-dev] [PATCH 32/42] panfrost: Set rt_count_2 for bpp>4 formats

2019-07-08 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_mfbd.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/panfrost/pan_mfbd.c b/src/gallium/drivers/panfrost/pan_mfbd.c index d14fb4269db..f262f6a592d 100644 --- a/src/gallium/drivers/panfrost/pan_m

[Mesa-dev] [PATCH 38/42] panfrost/midgard: Handle PIPE_FORMAT_B10G10R10A2_UNORM

2019-07-08 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/nir_lower_framebuffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/panfrost/midgard/nir_lower_framebuffer.c b/src/gallium/drivers/panfrost/midgard/nir_lower_framebuffer.c in

[Mesa-dev] [PATCH] nir/lower_io_to_temporaries: Fix hash table leak

2019-07-08 Thread Connor Abbott
Fixes: c45f5db527252384395e55fb1149b673ec7b5fa8 ("nir/lower_io_to_temporaries: Handle interpolation intrinsics") --- Whoops... src/compiler/nir/nir_lower_io_to_temporaries.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/nir/nir_lower_io_to_temporaries.c b/src/compiler/nir/n

[Mesa-dev] [Bug 110735] Meson can't find 32-bit libXvMCW in non-standard path

2019-07-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110735 --- Comment #6 from Dylan Baker --- I started thinking about this over the weekend, and realized that all of this work-arounding a lack of a .pc file for libxvmcw is silly, we should just add a pkg-config file so this is less painful: https://gi

Re: [Mesa-dev] [PATCH] ac: select the GFX ring when halting waves with UMR on GFX10

2019-07-08 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, Jul 7, 2019 at 1:32 PM Samuel Pitoiset wrote: > GFX10 has two rings, so UMR want to know which one to halt. > Select the first one by default. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_debug.c | 9 ++--- > src/amd/co

Re: [Mesa-dev] [PATCH 3/3] android: amd/addrlib: add gfx10 support

2019-07-08 Thread Marek Olšák
For the series: Acked-by: Marek Olšák Marek On Sat, Jul 6, 2019 at 4:17 PM Mauro Rossi wrote: > Fix the following building error: > > external/mesa/src/amd/addrlib/src/gfx10/gfx10addrlib.cpp:35:10: > fatal error: 'gfx10_gb_reg.h' file not found > ^~~~ > 1 error generated.

Re: [Mesa-dev] [PATCH] gallium: remove boolean from state tracker APIs

2019-07-08 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallium: switch boolean -> bool at the interface definitions

2019-07-08 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] nvc0: remove nvc0_program.tp.input_patch_size

2019-07-08 Thread Karol Herbst
right now that's dead code Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h | 1 - src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 4 src/gallium/drivers/nouveau/nvc0/nvc0_program.h | 1 - 3 files changed, 6 deletions(-) diff --git a/src/gall

Re: [Mesa-dev] [PATCH] nvc0: remove nvc0_program.tp.input_patch_size

2019-07-08 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin The tcp input patch size is not a compile-time value, and even if it were, not sure where we'd use it. The tep input patch size is set at compile time, but in the code you're removing, we set it to ~0 anyways. On Mon, Jul 8, 2019 at 3:22 PM Karol Herbst wrote: > > right

[Mesa-dev] [AppVeyor] mesa use-utils-functions2 #11785 failed

2019-07-08 Thread AppVeyor
Build mesa 11785 failed Commit fc0a7b3663 by Dylan Baker on 9/14/2018 7:57 PM: remove final imports.h bits\n\nThis moves the fi_types to a new mesa_private.h and removes the\nimports.c file. The vast majority of this patch is just removing\npound includes of im

[Mesa-dev] [AppVeyor] mesa master #11786 completed

2019-07-08 Thread AppVeyor
Build mesa 11786 completed Commit 6271d16320 by Lionel Landwerlin on 7/8/2019 7:30 AM: vulkan: bump headers & registry to 1.1.114\n\nSigned-off-by: Lionel Landwerlin \nReviewed-by: Eric Engestrom Configure your notification preferences _

[Mesa-dev] [AppVeyor] mesa use-utils-functions2 #11787 failed

2019-07-08 Thread AppVeyor
Build mesa 11787 failed Commit 56ff535989 by Dylan Baker on 9/14/2018 7:57 PM: remove final imports.h bits\n\nThis moves the fi_types to a new mesa_private.h and removes the\nimports.c file. The vast majority of this patch is just removing\npound includes of im

[Mesa-dev] [AppVeyor] mesa master #11788 completed

2019-07-08 Thread AppVeyor
Build mesa 11788 completed Commit a72351cc76 by Lionel Landwerlin on 7/8/2019 1:00 PM: vulkan/overlay: fix crash on freeing NULL command buffer\n\nIt is legal to call vkFreeCommandBuffers() on NULL command buffers.\n\nThis fix requires eb41ce1b012f24 ("util/has

Re: [Mesa-dev] [PATCH] nir/lower_io_to_temporaries: Fix hash table leak

2019-07-08 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 9/7/19 2:20 am, Connor Abbott wrote: Fixes: c45f5db527252384395e55fb1149b673ec7b5fa8 ("nir/lower_io_to_temporaries: Handle interpolation intrinsics") --- Whoops... src/compiler/nir/nir_lower_io_to_temporaries.c | 2 ++ 1 file changed, 2 insertions(+) diff --

[Mesa-dev] [Bug 111039] [radv] - Persona 5 in RPCS3 emulator has glitches when using hardware fp16 (LLVM 9)

2019-07-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111039 --- Comment #1 from Andrew Sheldon --- Created attachment 144730 --> https://bugs.freedesktop.org/attachment.cgi?id=144730&action=edit Renderdoc capture Renderdoc capture. I'm not sure how helpful it will be since I can't reproduce the bug wh

[Mesa-dev] [Bug 111039] [radv] - Persona 5 in RPCS3 emulator has glitches when using hardware fp16 (LLVM 9)

2019-07-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111039 --- Comment #2 from Andrew Sheldon --- I should add that the bug doesn't occur with the ACO compiler. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

[Mesa-dev] [Bug 111039] [radv] - Persona 5 in RPCS3 emulator has glitches when using hardware fp16 (LLVM 9)

2019-07-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111039 --- Comment #3 from Andrew Sheldon --- I've been informed that ACO doesn't support this feature yet, so it doesn't actually "work" with that compiler, it's just falling back to the non-native form. -- You are receiving this mail because: You a

[Mesa-dev] [Bug 100789] Mesa (Padoka Pkppa), Textures become corrupt in counterstrike 1.6 and in steam overlay after indeterminate amount of time

2019-07-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100789 --- Comment #9 from Timothy Arceri --- I'm confused. Those new screen shots don't appear to have any problem. What are you trying to show? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH 1/4] radv: fix allocating USER SGPRs on GFX10

2019-07-08 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index b72d1aa0023..9644185f870 100644 --- a/src/amd/vulkan/radv_nir_to_ll

[Mesa-dev] [PATCH 4/4] radv: fix setting VGT_REUSE_OFF for TES on GFX10

2019-07-08 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 91ce108ef92..d2002dd904b 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/v

[Mesa-dev] [PATCH 2/4] radv: set max workgroup size to 128 for TES as NGG on GFX10

2019-07-08 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index 9644185f870..67630c4ee92 100644 --- a/src/amd/vulkan/radv_nir_to_llvm.c +++ b/src/a

[Mesa-dev] [PATCH 3/4] radv: fix computing the number of ES VGPRS for TES on GFX10

2019-07-08 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index b6270136643..ec68f51901f 100644 --- a/src/amd/vulkan/radv_shader.c +++ b/src/amd/vulkan/radv_shad

[Mesa-dev] [PATCH 3/6] radv: emit the geometry shader as NGG if enabled on GFX10

2019-07-08 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index bb6f877a6ee..703dbe54507 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd

[Mesa-dev] [PATCH 2/6] radv: keep track of whether NGG is used for GS on GFX10

2019-07-08 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 1 + src/amd/vulkan/radv_pipeline.c| 4 +++- src/amd/vulkan/radv_shader.h | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm

[Mesa-dev] [PATCH 6/6] radv: set correct number of VGPRs for GS on GFX10

2019-07-08 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index b6270136643..8298498fbdc 100644 --- a/src/amd/vulkan/radv_shader.c +++ b/src/amd/vulkan/radv_shader

[Mesa-dev] [PATCH 5/6] radv: fix VGT_ESGS_RING_ITEMSIZE for GS as NGG on GFX10

2019-07-08 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index ce315da47c3..147d72d146e 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/v

[Mesa-dev] [PATCH 1/6] radv: add radv_pipeline_generate_hw_gs() helper

2019-07-08 Thread Samuel Pitoiset
For legacy GS path. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 91ce108ef92..fc09bad5fe1 100644 --- a/src

[Mesa-dev] [PATCH 4/6] radv: emit VGT_GS_MAX_VERT_OUT for legacy and NGG paths for GS

2019-07-08 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 703dbe54507..ce315da47c3 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/vulka

[Mesa-dev] [Bug 107942] Isaac AntiBirth under wine has invisible entities tu to clipping plane issue

2019-07-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107942 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---