Re: [Mesa-dev] [PATCH V4 02/13] glsl: add texture gather changes

2013-09-30 Thread Ian Romanick
On 09/30/2013 12:08 PM, Kenneth Graunke wrote: > On 09/30/2013 11:03 AM, Ian Romanick wrote: >> On 09/30/2013 03:08 AM, Chris Forbes wrote: >>> From: Maxence Le Dore >>> >>> V2 [Chris Forbes]: >>>- Add new pattern, fixup parameter reading. >>> >>> V3: Rebase onto new builtins machinery >>> >>>

Re: [Mesa-dev] [PATCH] R600: Add a ldptr intrinsic to support MSAA.

2013-09-30 Thread Tom Stellard
On Mon, Sep 30, 2013 at 11:46:25PM +0200, Vincent Lejeune wrote: > --- > lib/Target/R600/R600ISelLowering.cpp | 6 +- > lib/Target/R600/R600Instructions.td | 4 > lib/Target/R600/R600Intrinsics.td| 1 + > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/lib/Target/R

Re: [Mesa-dev] [PATCH 1/4] r600g/llvm: fix sample cube shadow

2013-09-30 Thread Tom Stellard
On Mon, Sep 30, 2013 at 11:46:26PM +0200, Vincent Lejeune wrote: Could you go through and wrap some on the long lines that you are adding in the other patches. With that fix, the entire series is: Reviewed-by: Tom Stellard > --- > src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 3 ++- >

Re: [Mesa-dev] [PATCH 28/29] i965: Drop random 32-bit assembly implementation of memcpy().

2013-09-30 Thread Ian Romanick
On 09/30/2013 05:47 PM, Roland Mainz wrote: > On Tue, Oct 1, 2013 at 2:27 AM, Ian Romanick wrote: >> On 09/27/2013 04:46 PM, Kenneth Graunke wrote: >>> This was only used for uploading batchbuffer data, and only on 32-bit >>> systems. If this is actually useful, we might want to use it more >>> w

Re: [Mesa-dev] [PATCH 28/29] i965: Drop random 32-bit assembly implementation of memcpy().

2013-09-30 Thread Roland Mainz
On Tue, Oct 1, 2013 at 3:43 AM, Ian Romanick wrote: > On 09/30/2013 05:47 PM, Roland Mainz wrote: >> On Tue, Oct 1, 2013 at 2:27 AM, Ian Romanick wrote: >>> On 09/27/2013 04:46 PM, Kenneth Graunke wrote: This was only used for uploading batchbuffer data, and only on 32-bit systems. If

Re: [Mesa-dev] [PATCH] i965/hsw: approximate DDX with a uniform value across a subspan

2013-09-30 Thread Ian Romanick
On 09/11/2013 10:00 PM, Chia-I Wu wrote: > From: Chia-I Wu > > Replicate the gradient of the top-left pixel to the other three pixels in the > subspan, as how DDY is implemented. Before, different graidents were used for > pixels in the top row and pixels in the bottom row. > > This change resu

Re: [Mesa-dev] [PATCH 2/2] [v4] i965: Use IVB specific formula for depthbuffer

2013-09-30 Thread Ian Romanick
On 09/30/2013 05:45 PM, Ben Widawsky wrote: > After the last patch, we can replace the region allocated in the miptree > creation with a more straightforward (and hopefully smaller resulting) > buffer based on the bspec's allocation formula. > > Since I am relatively new to this part of the bspec,

Re: [Mesa-dev] [PATCH 1/2] [v2] i965: Extract region use from hiz depth buffer

2013-09-30 Thread Ian Romanick
On 09/30/2013 12:35 PM, Ben Widawsky wrote: > Starting with Ivybridge, the hierarchical had relaxed requirements for > its allocation. Following a "simple" formula in the bspec was all you > needed to satisfy the requirement. > > To prepare the code for this, extract all places where the miptree w

Re: [Mesa-dev] [PATCH 02/29] i965: Pull out INTEL_DEBUG handling into new intel_debug.[ch] files.

2013-09-30 Thread Kenneth Graunke
On 09/30/2013 05:11 PM, Ian Romanick wrote: > On 09/27/2013 04:45 PM, Kenneth Graunke wrote: >> Now that there isn't an intel_context structure, the split between >> brw_context.[ch] and intel_context.[ch] is rather awkward and arbitrary. >> Removing intel_context.[ch] seems desirable, but not ever

Re: [Mesa-dev] [PATCH] i965/hsw: approximate DDX with a uniform value across a subspan

2013-09-30 Thread Kenneth Graunke
On 09/30/2013 07:16 PM, Ian Romanick wrote: > On 09/11/2013 10:00 PM, Chia-I Wu wrote: >> From: Chia-I Wu >> >> Replicate the gradient of the top-left pixel to the other three pixels in the >> subspan, as how DDY is implemented. Before, different graidents were used >> for >> pixels in the top r

Re: [Mesa-dev] [PATCH 1/2] [v2] i965: Extract region use from hiz depth buffer

2013-09-30 Thread Ben Widawsky
On Mon, Sep 30, 2013 at 07:24:08PM -0700, Ian Romanick wrote: > On 09/30/2013 12:35 PM, Ben Widawsky wrote: > > Starting with Ivybridge, the hierarchical had relaxed requirements for > > its allocation. Following a "simple" formula in the bspec was all you > > needed to satisfy the requirement. > >

Re: [Mesa-dev] [PATCH 2/2] [v4] i965: Use IVB specific formula for depthbuffer

2013-09-30 Thread Ben Widawsky
On Mon, Sep 30, 2013 at 07:22:54PM -0700, Ian Romanick wrote: > On 09/30/2013 05:45 PM, Ben Widawsky wrote: > > After the last patch, we can replace the region allocated in the miptree > > creation with a more straightforward (and hopefully smaller resulting) > > buffer based on the bspec's allocat

Re: [Mesa-dev] [PATCH 12/29] i965: Move device quirks to brw_device_info.

2013-09-30 Thread Kenneth Graunke
On 09/30/2013 05:16 PM, Ian Romanick wrote: > On 09/27/2013 04:45 PM, Kenneth Graunke wrote: >> Signed-off-by: Kenneth Graunke >> --- >> src/mesa/drivers/dri/i965/brw_context.c | 10 +++--- >> src/mesa/drivers/dri/i965/brw_device_info.c | 9 - >> src/mesa/drivers/dri/i965/brw_dev

Re: [Mesa-dev] Janitorial work: no more intel_context.[ch]; tidying

2013-09-30 Thread Kenneth Graunke
On 09/27/2013 06:24 PM, Emil Velikov wrote: > On 28/09/13 00:45, Kenneth Graunke wrote: >> This series combines brw_context.[ch] and intel_context.[ch], >> and cleans up our context creation code quite a bit. A bunch of >> functionality was awkwardly split between the two sets of files; >> now it'

[Mesa-dev] [PATCH] i965: compute DDX in a subspan based only on top row

2013-09-30 Thread Chia-I Wu
From: Chia-I Wu Consider only the top-left and top-right pixels to approximate DDX in a 2x2 subspan, unless the application requests a more accurate approximation via GL_FRAGMENT_SHADER_DERIVATIVE_HINT or this optimization is disabled from the new driconf option disable_derivative_optimization.

Re: [Mesa-dev] [PATCH] i965/hsw: approximate DDX with a uniform value across a subspan

2013-09-30 Thread Chia-I Wu
On Tue, Oct 1, 2013 at 12:16 PM, Kenneth Graunke wrote: > On 09/30/2013 07:16 PM, Ian Romanick wrote: >> On 09/11/2013 10:00 PM, Chia-I Wu wrote: >>> From: Chia-I Wu >>> >>> Replicate the gradient of the top-left pixel to the other three pixels in >>> the >>> subspan, as how DDY is implemented.

Re: [Mesa-dev] [PATCH] i965: compute DDX in a subspan based only on top row

2013-09-30 Thread Kenneth Graunke
On 09/30/2013 10:54 PM, Chia-I Wu wrote: > From: Chia-I Wu > > Consider only the top-left and top-right pixels to approximate DDX in a 2x2 > subspan, unless the application requests a more accurate approximation via > GL_FRAGMENT_SHADER_DERIVATIVE_HINT or this optimization is disabled from the >

<    1   2