Re: libdrm_amdgpu being forked and merged into Mesa

On Mon, Oct 28, 2024 at 6:51 AM Michel Dänzer wrote: > > On 2024-10-28 11:27, Christian König wrote: > > Am 28.10.24 um 11:13 schrieb Michel Dänzer: > >> On 2024-10-25 19:07, Bas Nieuwenhuizen wrote: > >>> On Fri, Oct 25, 2024 at 6:57 PM Michel Dänzer >>> > wrot

Re: libdrm_amdgpu being forked and merged into Mesa

On Mon, Oct 28, 2024 at 11:51 AM Michel Dänzer wrote: > On 2024-10-28 11:27, Christian König wrote: > > Am 28.10.24 um 11:13 schrieb Michel Dänzer: > >> On 2024-10-25 19:07, Bas Nieuwenhuizen wrote: > >>> On Fri, Oct 25, 2024 at 6:57 PM Michel Dänzer < > michel.daen...@mailbox.org

Re: libdrm_amdgpu being forked and merged into Mesa

On 2024-10-28 11:27, Christian König wrote: > Am 28.10.24 um 11:13 schrieb Michel Dänzer: >> On 2024-10-25 19:07, Bas Nieuwenhuizen wrote: >>> On Fri, Oct 25, 2024 at 6:57 PM Michel Dänzer >> > wrote: >>> On 2024-10-25 17:57, Bas Nieuwenhuizen wrote: >>>

Re: libdrm_amdgpu being forked and merged into Mesa

Am 28.10.24 um 11:13 schrieb Michel Dänzer: On 2024-10-25 19:07, Bas Nieuwenhuizen wrote: On Fri, Oct 25, 2024 at 6:57 PM Michel Dänzer mailto:michel.daen...@mailbox.org>> wrote: On 2024-10-25 17:57, Bas Nieuwenhuizen wrote: > On Fri, Oct 25, 2024 at 4:36 PM Michel Dänzer mailto:michel

Re: libdrm_amdgpu being forked and merged into Mesa

On 2024-10-25 19:07, Bas Nieuwenhuizen wrote: > On Fri, Oct 25, 2024 at 6:57 PM Michel Dänzer > wrote: > On 2024-10-25 17:57, Bas Nieuwenhuizen wrote: > > On Fri, Oct 25, 2024 at 4:36 PM Michel Dänzer > mailto:michel.daen...@mailbox.org> >

Re: libdrm_amdgpu being forked and merged into Mesa

On Fri, Oct 25, 2024 at 6:57 PM Michel Dänzer wrote: > On 2024-10-25 17:57, Bas Nieuwenhuizen wrote: > > On Fri, Oct 25, 2024 at 4:36 PM Michel Dänzer < > michel.daen...@mailbox.org > wrote: > > On 2024-10-25 12:18, Bas Nieuwenhuizen wrote: > > > > > (no

Re: libdrm_amdgpu being forked and merged into Mesa

On 2024-10-25 17:57, Bas Nieuwenhuizen wrote: > On Fri, Oct 25, 2024 at 4:36 PM Michel Dänzer > wrote: > On 2024-10-25 12:18, Bas Nieuwenhuizen wrote: > > > (not to mention that it would mean that any users would need to use > libdrm_amdgpu. Given that

Re: libdrm_amdgpu being forked and merged into Mesa

On Fri, Oct 25, 2024 at 4:36 PM Michel Dänzer wrote: > On 2024-10-25 12:18, Bas Nieuwenhuizen wrote: > > On Fri, Oct 25, 2024 at 11:21 AM Michel Dänzer < > michel.daen...@mailbox.org > wrote: > > > > On 2024-10-24 17:08, Marek Olšák wrote: > > > We don't

Re: libdrm_amdgpu being forked and merged into Mesa

On 2024-10-25 12:18, Bas Nieuwenhuizen wrote: > On Fri, Oct 25, 2024 at 11:21 AM Michel Dänzer > wrote: > > On 2024-10-24 17:08, Marek Olšák wrote: > > We don't need to share the same VMID between ROCm and Mesa. We don't > > need to share the same dr

Re: libdrm_amdgpu being forked and merged into Mesa

On Fri, Oct 25, 2024 at 11:21 AM Michel Dänzer wrote: > On 2024-10-24 17:08, Marek Olšák wrote: > > We don't need to share the same VMID between ROCm and Mesa. We don't > > need to share the same driver FD between ROCm and Mesa either. It will > > be like having 2 different processes, and that sh

Re: libdrm_amdgpu being forked and merged into Mesa

On 2024-10-24 17:08, Marek Olšák wrote: > We don't need to share the same VMID between ROCm and Mesa. We don't > need to share the same driver FD between ROCm and Mesa either. It will > be like having 2 different processes, and that should always work. Per https://gitlab.freedesktop.org/mesa/mesa

Re: libdrm_amdgpu being forked and merged into Mesa

We don't need to share the same VMID between ROCm and Mesa. We don't need to share the same driver FD between ROCm and Mesa either. It will be like having 2 different processes, and that should always work. Alex told me in person 2 weeks ago that we can put libdrm_amdgpu into Mesa. Marek On Thu,

Re: libdrm_amdgpu being forked and merged into Mesa

On Thu, Oct 24, 2024 at 8:38 AM Christian König wrote: > > Completely agree, but that's a platform decision which Alex needs to make. + Felix Does buffer sharing with ROCm depend on the shared VA space? Alex > > Christian. > > Am 24.10.24 um 14:16 schrieb Marek Olšák: > > I don't think we need

Re: libdrm_amdgpu being forked and merged into Mesa

I'm not sure what this means. ROCm allocates all its virtual address space with mmap. That includes address space for BOs imported with the interop APIs. We are sharing the GPU virtual address space with Mesa since we're using the same render nodes. So if Mesa's GPU virtual address space manag

Re: libdrm_amdgpu being forked and merged into Mesa

Yeah that would really not work. We at least need the code to unify the render node file descriptor stay inside libdrm and be used by Mesa. Otherwise Mesa would start using a separate render node file descriptor. Regards, Christian. Am 24.10.24 um 16:19 schrieb Felix Kuehling: I'm not sure w

Re: libdrm_amdgpu being forked and merged into Mesa

Completely agree, but that's a platform decision which Alex needs to make. Christian. Am 24.10.24 um 14:16 schrieb Marek Olšák: I don't think we need to share VA space. APIs usually share one or two buffers. That's almost nothing compared to the size of the occupied VA space. They also likely

Re: libdrm_amdgpu being forked and merged into Mesa

I don't think we need to share VA space. APIs usually share one or two buffers. That's almost nothing compared to the size of the occupied VA space. They also likely map them again for themselves - APIs don't share any virtual addresses as far as I know. Marek On Thu, Oct 24, 2024, 08:12 Christia

Re: libdrm_amdgpu being forked and merged into Mesa

Am 22.10.24 um 06:06 schrieb Marek Olšák: Hi, The MR is up: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31756 It's good to go as long as there is no functional issue. Finally getting rid of all the mid-layering? What about shared VA-space? Regards, Christian. libdrm_amdgpu w

libdrm_amdgpu being forked and merged into Mesa

Hi, The MR is up: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31756 It's good to go as long as there is no functional issue. libdrm_amdgpu will still be relevant for PAL, ROCm, and xf86-video-amdgpu. Marek