Re: Moving code around, post classic

2021-12-18 Thread Kenneth Graunke
On Tuesday, December 7, 2021 12:26:29 PM PST Emma Anholt wrote: > On Mon, Dec 6, 2021 at 3:50 PM Dylan Baker wrote: > > > > Classic is gone, and the cleanups have begun, obviously. There is > > another cleanup that I had in mind, which is moving src/mesa into > > src/gallium/frontends/mesa. This m

Re: Moving code around, post classic

2021-12-09 Thread Jason Ekstrand
On Thu, Dec 9, 2021 at 11:24 AM Timur Kristóf wrote: > On Tue, 2021-12-07 at 08:19 -0500, Alyssa Rosenzweig wrote > > > > If it were just linked lists, I'd say someone should write the > > Coccinelle to transform the tree to use the one in util and call it a > > day. It's a bit more complicated t

Re: Moving code around, post classic

2021-12-09 Thread Timur Kristóf
On Tue, 2021-12-07 at 08:19 -0500, Alyssa Rosenzweig wrote > > If it were just linked lists, I'd say someone should write the > Coccinelle to transform the tree to use the one in util and call it a > day. It's a bit more complicated though, NIR depends on GLSL types. > Though that could probably c

Re: Moving code around, post classic

2021-12-07 Thread Marek Olšák
While the current directory structure is confusing, the new suggested directory structure might not be helpful because GL is more spread out anyway. mapi is libglapi, so it seems to be its own thing, not a gallium thing glx is libgl, same thing. egl is libegl, same thing. ... unless we want to mer

Re: Moving code around, post classic

2021-12-07 Thread Emma Anholt
On Mon, Dec 6, 2021 at 3:50 PM Dylan Baker wrote: > > Classic is gone, and the cleanups have begun, obviously. There is > another cleanup that I had in mind, which is moving src/mesa into > src/gallium/frontends/mesa. This makes the build system a little > cleaner, as currently we do some bending

Re: Moving code around, post classic

2021-12-07 Thread Dave Airlie
On Tue, 7 Dec 2021 at 09:51, Dylan Baker wrote: > > Classic is gone, and the cleanups have begun, obviously. There is > another cleanup that I had in mind, which is moving src/mesa into > src/gallium/frontends/mesa. This makes the build system a little > cleaner, as currently we do some bending ov

Re: Moving code around, post classic

2021-12-07 Thread Alexander von Gluck IV
December 6, 2021 5:51 PM, "Dylan Baker" wrote: > 4. What to do about the src/loader, src/glx, src/egl, src/mapi, > src/glapi > > These are all part of OpenGL, but not really part of gallium, but if > we don't move src/gallium/* to src/ does it make sense to leave them > in the root? > You can

Re: Moving code around, post classic

2021-12-07 Thread Timothy Arceri
On Tue, 2021-12-07 at 08:19 -0500, Alyssa Rosenzweig wrote: > > > > > 2. Move src/compiler/glsl into src/gallium/frontends/mesa as well > > > >     Given that there are now no? drivers that use GLSL-IR directly, > > it > >     might make sense to move the glsl compiler into the mesa > >     stat

Re: Moving code around, post classic

2021-12-07 Thread Alyssa Rosenzweig
> 1. Move src/mesa into src/gallium/frontends/mesa (I have patches for >this) > >Seems like a pretty obvoius thing to do, given that all of the other >gallium state trackers live there (OpenCL, video, d3d9, etc) Ack from me. > 2. Move src/compiler/glsl into src/gallium/frontends/mesa

Re: Moving code around, post classic

2021-12-07 Thread Alyssa Rosenzweig
>If we're going to do this, I wonder if we don't want to go even further >and get rid of src/gallium/drivers and move the respective folders to >src/vendor.** So, instead of src/gallium/drivers/(iris|crocus), we'd have >src/intel/gallium/iris and src/intel/gallium/crocus or maybe >

Re: Moving code around, post classic

2021-12-06 Thread Jason Ekstrand
On Mon, Dec 6, 2021 at 5:50 PM Dylan Baker wrote: > Classic is gone, and the cleanups have begun, obviously. There is > another cleanup that I had in mind, which is moving src/mesa into > src/gallium/frontends/mesa. This makes the build system a little > cleaner, as currently we do some bending o

Re: Moving code around, post classic

2021-12-06 Thread Marek Olšák
Hi, 1. If this happens, let's call it src/gallium/frontends/gl. 3. The src directory already has too much stuff. Marek On Mon, Dec 6, 2021 at 6:51 PM Dylan Baker wrote: > Classic is gone, and the cleanups have begun, obviously. There is > another cleanup that I had in mind, which is moving sr