Re: [Mesa-dev] s/bool/boolean/

2011-06-09 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/08/2011 07:54 AM, Jose Fonseca wrote: > Personally, I prefer the standard C bool type, given it's a) standard, b) > shorter. Furthermore Microsoft's windows.h already defines boolean: I'm with Jose on this one. -BEGIN PGP SIGNATURE- Ver

Re: [Mesa-dev] s/bool/boolean/

2011-06-08 Thread Kenneth Graunke
We've been (gradually) switching to (bool/true/false) in the Intel driver code. I definitely prefer that. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] s/bool/boolean/

2011-06-08 Thread Dave Airlie
On Thu, Jun 9, 2011 at 12:54 AM, Jose Fonseca wrote: > Personally, I prefer the standard C bool type, given it's a) standard, b) > shorter. Furthermore Microsoft's windows.h already defines boolean: > >  $ grep -r '\' /usr/i586-mingw32msvc/include/ >  /usr/i586-mingw32msvc/include/rpcndr.h:typede

Re: [Mesa-dev] s/bool/boolean/

2011-06-08 Thread Marek Olšák
Boolean is also more prone to bugs. I've got this habit from C++, I usually convert int to bool by a simple assignment (without the "!= 0" part). That doesn't work with boolean defined as char, because the upper bits are always truncated. Marek On Wed, Jun 8, 2011 at 4:54 PM, Jose Fonseca wrote:

Re: [Mesa-dev] s/bool/boolean/

2011-06-08 Thread Jakob Bornecrantz
On Wed, Jun 8, 2011 at 4:59 PM, Brian Paul wrote: > On 06/08/2011 08:54 AM, Jose Fonseca wrote: >> >> Personally, I prefer the standard C bool type, given it's a) standard, b) >> shorter. Furthermore Microsoft's windows.h already defines boolean: >> >>   $ grep -r '\' /usr/i586-mingw32msvc/include

Re: [Mesa-dev] s/bool/boolean/

2011-06-08 Thread Brian Paul
On 06/08/2011 08:54 AM, Jose Fonseca wrote: Personally, I prefer the standard C bool type, given it's a) standard, b) shorter. Furthermore Microsoft's windows.h already defines boolean: $ grep -r '\' /usr/i586-mingw32msvc/include/ /usr/i586-mingw32msvc/include/rpcndr.h:typedef unsigned ch

Re: [Mesa-dev] s/bool/boolean/

2011-06-08 Thread Jose Fonseca
Personally, I prefer the standard C bool type, given it's a) standard, b) shorter. Furthermore Microsoft's windows.h already defines boolean: $ grep -r '\' /usr/i586-mingw32msvc/include/ /usr/i586-mingw32msvc/include/rpcndr.h:typedef unsigned char boolean; which can create havoc depending on