I've looked and tested at your whole patch series.
As you said, condvars and barriers work now on windows albeit slowly;
which is a big improvement over not working at all as before.
However, after a more careful look to the pipebuffer change I realized
that it is counterproductive. The busy loop
*doh* :)
Awesome! Let me just go over those patches then.
Jose
On Tue, 2010-07-06 at 10:45 -0700, nobled wrote:
> Well, that's why I sent the "Implement pipe_condvar on win32" and "on
> Windows Vista" patches first. With the first patch, the pipebuffer
> code will do on Windows exactly what it a
Well, that's why I sent the "Implement pipe_condvar on win32" and "on
Windows Vista" patches first. With the first patch, the pipebuffer
code will do on Windows exactly what it already does right now on
Unix-- unlock the mutex, wait for other threads, then try to lock it
again. pipe_condvar on Wind
The patch looks good, but we don't support pipe_condvar on Windows yet.
I'd prefer to see the commit deferred until we do.
Any takers to implement pipe_condvar on Windows? There's even a nice
tutorial on http://locklessinc.com/articles/pthreads_on_windows/
Jose
On Mon, 2010-07-05 at 09:53 -0700,
