Re: [Mesa-dev] per-vertex array max_index

2011-04-16 Thread Christoph Bumiller
On 16.04.2011 02:29, Brian Paul wrote: > On 04/15/2011 03:33 PM, Marek Olšák wrote: >> Let's decompose the whole problem of computing max_index into several >> cases: >> >> 1) Is the vertex buffer a non-user buffer? >> - If stride == 0, max_index = 1. >> - Otherwise, max_index = (width0 - buffer_of

Re: [Mesa-dev] per-vertex array max_index

2011-04-16 Thread Jose Fonseca
essage - From: "Brian Paul" To: "José Fonseca" Cc: "mesa-dev" Sent: Saturday, April 16, 2011 1:29:34 AM Subject: Re: [Mesa-dev] per-vertex array max_index On 04/15/2011 02:17 PM, José Fonseca wrote: > On 04/15/2011 09:14 PM, José Fonseca wrote: >>

Re: [Mesa-dev] per-vertex array max_index

2011-04-15 Thread Brian Paul
On 04/15/2011 03:33 PM, Marek Olšák wrote: Hi Brian, The main reason for removal of pipe_vertex_buffer::max_index was its direct dependence on pipe_draw_info. The vertex buffer field was directly computed from the parameters of pipe_draw_info instead of being a completely independent state. So w

Re: [Mesa-dev] per-vertex array max_index

2011-04-15 Thread Brian Paul
On 04/15/2011 02:17 PM, José Fonseca wrote: On 04/15/2011 09:14 PM, José Fonseca wrote: On 04/15/2011 08:51 PM, Brian Paul wrote: On 04/15/2011 01:41 PM, José Fonseca wrote: On 04/15/2011 07:20 PM, Christoph Bumiller wrote: On 15.04.2011 18:04, Brian Paul wrote: Hi Marek, Back on Jan 10

Re: [Mesa-dev] per-vertex array max_index

2011-04-15 Thread Marek Olšák
Hi Brian, The main reason for removal of pipe_vertex_buffer::max_index was its direct dependence on pipe_draw_info. The vertex buffer field was directly computed from the parameters of pipe_draw_info instead of being a completely independent state. So we ended up doing this in st/mesa: set_vertex

Re: [Mesa-dev] per-vertex array max_index

2011-04-15 Thread José Fonseca
On 04/15/2011 09:14 PM, José Fonseca wrote: On 04/15/2011 08:51 PM, Brian Paul wrote: On 04/15/2011 01:41 PM, José Fonseca wrote: On 04/15/2011 07:20 PM, Christoph Bumiller wrote: On 15.04.2011 18:04, Brian Paul wrote: Hi Marek, Back on Jan 10 you removed the per-vertex ar

Re: [Mesa-dev] per-vertex array max_index

2011-04-15 Thread José Fonseca
On 04/15/2011 08:51 PM, Brian Paul wrote: On 04/15/2011 01:41 PM, José Fonseca wrote: On 04/15/2011 07:20 PM, Christoph Bumiller wrote: On 15.04.2011 18:04, Brian Paul wrote: Hi Marek, Back on Jan 10 you removed the per-vertex array max_index field (commit cdca3c58aa2d9549f

Re: [Mesa-dev] per-vertex array max_index

2011-04-15 Thread Brian Paul
On 04/15/2011 01:41 PM, José Fonseca wrote: On 04/15/2011 07:20 PM, Christoph Bumiller wrote: On 15.04.2011 18:04, Brian Paul wrote: Hi Marek, Back on Jan 10 you removed the per-vertex array max_index field (commit cdca3c58aa2d9549f5188910e2a77b438516714f). I believe this was a mistake. I n

Re: [Mesa-dev] per-vertex array max_index

2011-04-15 Thread José Fonseca
On 04/15/2011 07:20 PM, Christoph Bumiller wrote: On 15.04.2011 18:04, Brian Paul wrote: Hi Marek, Back on Jan 10 you removed the per-vertex array max_index field (commit cdca3c58aa2d9549f5188910e2a77b438516714f). I believe this was a mistake. I noticed today that the piglit draw-instance

Re: [Mesa-dev] per-vertex array max_index

2011-04-15 Thread Christoph Bumiller
On 15.04.2011 18:04, Brian Paul wrote: > > Hi Marek, > > Back on Jan 10 you removed the per-vertex array max_index field > (commit cdca3c58aa2d9549f5188910e2a77b438516714f). I believe this was > a mistake. > > I noticed today that the piglit draw-instanced-divisor test is > failing. A bisection p

[Mesa-dev] per-vertex array max_index

2011-04-15 Thread Brian Paul
Hi Marek, Back on Jan 10 you removed the per-vertex array max_index field (commit cdca3c58aa2d9549f5188910e2a77b438516714f). I believe this was a mistake. I noticed today that the piglit draw-instanced-divisor test is failing. A bisection points to Jose's commit 17bbc1f0425b3768e26473ecc