Re: [Mesa-dev] mesa draw-instance topic v. point-only rendering in VTK tests

2011-01-17 Thread Brian Paul
On Mon, Jan 17, 2011 at 9:55 AM, Brad King wrote: > On 01/17/2011 11:46 AM, Brian Paul wrote: >> Does the attached patch help? > > Yes, that fixes it.  The assertion no longer fails and the test passes. > Total resulting patch on top of ef3b8042 appears below. Great. I've committed the patches.

Re: [Mesa-dev] mesa draw-instance topic v. point-only rendering in VTK tests

2011-01-17 Thread Brad King
On 01/17/2011 11:46 AM, Brian Paul wrote: > Does the attached patch help? Yes, that fixes it. The assertion no longer fails and the test passes. Total resulting patch on top of ef3b8042 appears below. Thanks, -Brad diff --git a/src/mesa/tnl/t_draw.c b/src/mesa/tnl/t_draw.c index bdb893e..616ee

Re: [Mesa-dev] mesa draw-instance topic v. point-only rendering in VTK tests

2011-01-17 Thread Brian Paul
On Mon, Jan 17, 2011 at 9:33 AM, Brad King wrote: > On 01/17/2011 11:18 AM, Brian Paul wrote: >> On Mon, Jan 17, 2011 at 8:58 AM, Brad King wrote: >>> I think a63486ac is the first commit that exhibits the behavior. >> >> Have you tried reversing that change? > > I started at ef3b8042 and ran "gi

Re: [Mesa-dev] mesa draw-instance topic v. point-only rendering in VTK tests

2011-01-17 Thread Brad King
On 01/17/2011 11:18 AM, Brian Paul wrote: > On Mon, Jan 17, 2011 at 8:58 AM, Brad King wrote: >> I think a63486ac is the first commit that exhibits the behavior. > > Have you tried reversing that change? I started at ef3b8042 and ran "git revert a63486ac". I resolved one conflict (machine v. &m

Re: [Mesa-dev] mesa draw-instance topic v. point-only rendering in VTK tests

2011-01-17 Thread Brian Paul
On Mon, Jan 17, 2011 at 8:58 AM, Brad King wrote: > Hi Brian, > > One of your changes in commit range 21001d2b..652901e9 causes one of > the VTK tests to render an empty image: > >  http://www.cdash.org/CDash/testDetails.php?test=79911707&build=826979 > > I think a63486ac is the first commit that

[Mesa-dev] mesa draw-instance topic v. point-only rendering in VTK tests

2011-01-17 Thread Brad King
Hi Brian, One of your changes in commit range 21001d2b..652901e9 causes one of the VTK tests to render an empty image: http://www.cdash.org/CDash/testDetails.php?test=79911707&build=826979 I think a63486ac is the first commit that exhibits the behavior. This particular test renders only *point