Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

2016-01-21 Thread Andreas Boll
I've pushed this patch. Thanks, Andreas 2016-01-21 1:35 GMT+01:00 Jeremy Huddleston Sequoia : > Sorry, I thought I responded to this a while ago. > > Reviewed-by: Jeremy Huddleston Sequoia > Tested-by: Jeremy Huddleston Sequoia > > --Jeremy > >> On Jan 19, 2016, at 05:21, Andreas Boll wrote: >

Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

2016-01-20 Thread Jeremy Huddleston Sequoia
Sorry, I thought I responded to this a while ago. Reviewed-by: Jeremy Huddleston Sequoia Tested-by: Jeremy Huddleston Sequoia --Jeremy > On Jan 19, 2016, at 05:21, Andreas Boll wrote: > > Jeremy, did you have a chance to test this patch? > This patch would be still useful for OS X. For non-O

Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

2016-01-19 Thread Andreas Boll
Jeremy, did you have a chance to test this patch? This patch would be still useful for OS X. For non-OS X this patch [1] reduces the size of libGL.so further more. Thanks, Andreas [1] https://patchwork.freedesktop.org/patch/70372/ 2015-09-28 19:46 GMT+02:00 Jeremy Huddleston Sequoia : > I'll giv

Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

2015-09-28 Thread Jeremy Huddleston Sequoia
I'll give it a go. It is still needed on OS X (and I think Windows). It's just not used by the X server any more. --Jeremy > On Sep 28, 2015, at 10:26, Arlie Davis wrote: > > I tried building Mesa on OS X, but I'm not nearly as familiar with > development on OS X, so I wasn't able to get it

Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

2015-09-26 Thread Jeremy Huddleston Sequoia
Reviewing diffs of code that generates code is always ick. =( This *looks* right to me, but has it been given a beating for correctness? If not, let me know, and I'll give it a whirl when I have some cycles. Reviewed-by: Jeremy Huddleston Sequoia --- You're right that this used to be use in

Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

2015-09-22 Thread Ian Romanick
On 09/17/2015 03:19 PM, Arlie Davis wrote: > Ok, here's v2 of the change, with the suggested edits. So... I think this code is fine, and I admire the effort. I have a couple concerns. 1. We have no way to test this, so it's quite possible something was broken. 2. This function is only used in t

Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

2015-09-17 Thread Arlie Davis
Ok, here's v2 of the change, with the suggested edits. From 5f393faa058f453408dfc640eecae3fe6335dfed Mon Sep 17 00:00:00 2001 From: Arlie Davis Date: Tue, 15 Sep 2015 09:58:34 -0700 Subject: [PATCH] This patch significantly reduces the size of the libGL.so binary. It does not change the (extern

Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

2015-09-17 Thread Matt Turner
On Wed, Sep 16, 2015 at 9:42 AM, Arlie Davis wrote: > The null check is safe to remove, for two reasons. First, we're allocating > with calloc, so we know for sure that the entire structure is zero-filled. > Second, we're assigning every byte of the table, so we don't even need to > rely on zero-

Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

2015-09-16 Thread Arlie Davis
The null check is safe to remove, for two reasons. First, we're allocating with calloc, so we know for sure that the entire structure is zero-filled. Second, we're assigning every byte of the table, so we don't even need to rely on zero-filling it. (If this were a function that was frequently cal

Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

2015-09-16 Thread Matt Turner
On Tue, Sep 15, 2015 at 10:38 AM, Arlie Davis wrote: > > Hello! I noticed an inefficiency in libGL.so, so I thought I'd take a > stab at fixing it. This is my first patch submitted to mesa-dev, so > if I'm doing anything dumb, let me know. I can't use git send-email, > but I've formatted the pa

[Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

2015-09-15 Thread Arlie Davis
Hello! I noticed an inefficiency in libGL.so, so I thought I'd take a stab at fixing it. This is my first patch submitted to mesa-dev, so if I'm doing anything dumb, let me know. I can't use git send-email, but I've formatted the patch using git format-patch, which should hopefully produce simi