Re: [Mesa-dev] i965 SamplerUnits rework

2012-08-25 Thread Dave Airlie
On Sun, Aug 26, 2012 at 4:01 AM, Eric Anholt wrote: > Kenneth Graunke writes: > >> On 08/24/2012 10:21 AM, Ian Romanick wrote: >>> Patches 1 through 6 are >>> >>> Reviewed-by: Ian Romanick >>> >>> I probably won't have a chance to get through the rest, so don't wait on >>> me. >> >> Thanks for t

Re: [Mesa-dev] i965 SamplerUnits rework

2012-08-25 Thread Kenneth Graunke
On 08/25/2012 11:02 AM, Eric Anholt wrote: > Kenneth Graunke writes: > >> On 08/24/2012 10:07 AM, Eric Anholt wrote: >>> Kenneth Graunke writes: >>> Greetings! This series reworks how i965 deals with sampler indirections, changing it to use linker-assigned sampler variable ID

Re: [Mesa-dev] i965 SamplerUnits rework

2012-08-25 Thread Eric Anholt
Kenneth Graunke writes: > On 08/24/2012 10:07 AM, Eric Anholt wrote: >> Kenneth Graunke writes: >> >>> Greetings! >>> >>> This series reworks how i965 deals with sampler indirections, changing it >>> to use linker-assigned sampler variable IDs in SEND instructions rather >>> than baking in the

Re: [Mesa-dev] i965 SamplerUnits rework

2012-08-25 Thread Eric Anholt
Kenneth Graunke writes: > On 08/24/2012 10:21 AM, Ian Romanick wrote: >> Patches 1 through 6 are >> >> Reviewed-by: Ian Romanick >> >> I probably won't have a chance to get through the rest, so don't wait on >> me. > > Thanks for the review, Ian. Do you (or anyone else) know if other > driver

Re: [Mesa-dev] i965 SamplerUnits rework

2012-08-24 Thread Kenneth Graunke
On 08/24/2012 10:07 AM, Eric Anholt wrote: > Kenneth Graunke writes: > >> Greetings! >> >> This series reworks how i965 deals with sampler indirections, changing it >> to use linker-assigned sampler variable IDs in SEND instructions rather >> than baking in the ID of the texture unit they happen

Re: [Mesa-dev] i965 SamplerUnits rework

2012-08-24 Thread Kenneth Graunke
On 08/24/2012 10:21 AM, Ian Romanick wrote: > Patches 1 through 6 are > > Reviewed-by: Ian Romanick > > I probably won't have a chance to get through the rest, so don't wait on > me. Thanks for the review, Ian. Do you (or anyone else) know if other drivers besides i915 still need the ProgramSt

Re: [Mesa-dev] i965 SamplerUnits rework

2012-08-24 Thread Ian Romanick
On 08/24/2012 03:05 AM, Kenneth Graunke wrote: Greetings! This series reworks how i965 deals with sampler indirections, changing it to use linker-assigned sampler variable IDs in SEND instructions rather than baking in the ID of the texture unit they happen to be bound to. Instead, it now encod

Re: [Mesa-dev] i965 SamplerUnits rework

2012-08-24 Thread Eric Anholt
Kenneth Graunke writes: > Greetings! > > This series reworks how i965 deals with sampler indirections, changing it > to use linker-assigned sampler variable IDs in SEND instructions rather > than baking in the ID of the texture unit they happen to be bound to. > > Instead, it now encodes that ma

[Mesa-dev] i965 SamplerUnits rework

2012-08-24 Thread Kenneth Graunke
Greetings! This series reworks how i965 deals with sampler indirections, changing it to use linker-assigned sampler variable IDs in SEND instructions rather than baking in the ID of the texture unit they happen to be bound to. Instead, it now encodes that mapping in the binding, sampler state, a