Re: [Mesa-dev] i965: Batch emission refactoring

2015-04-29 Thread Francisco Jerez
"Pohjolainen, Topi" writes: > On Wed, Apr 29, 2015 at 06:54:34PM +0300, Francisco Jerez wrote: >> "Pohjolainen, Topi" writes: >> >> > On Tue, Apr 28, 2015 at 03:07:35PM -0700, Kenneth Graunke wrote: >> >> On Wednesday, April 22, 2015 11:47:20 PM Topi Pohjolainen wrote: >> >> > Currently batch e

Re: [Mesa-dev] i965: Batch emission refactoring

2015-04-29 Thread Pohjolainen, Topi
On Wed, Apr 29, 2015 at 06:54:34PM +0300, Francisco Jerez wrote: > "Pohjolainen, Topi" writes: > > > On Tue, Apr 28, 2015 at 03:07:35PM -0700, Kenneth Graunke wrote: > >> On Wednesday, April 22, 2015 11:47:20 PM Topi Pohjolainen wrote: > >> > Currently batch emission logic is bolted into using th

Re: [Mesa-dev] i965: Batch emission refactoring

2015-04-29 Thread Francisco Jerez
"Pohjolainen, Topi" writes: > On Tue, Apr 28, 2015 at 03:07:35PM -0700, Kenneth Graunke wrote: >> On Wednesday, April 22, 2015 11:47:20 PM Topi Pohjolainen wrote: >> > Currently batch emission logic is bolted into using the current >> > gl-state and currently bound user shader programs as input.

Re: [Mesa-dev] i965: Batch emission refactoring

2015-04-29 Thread Pohjolainen, Topi
On Tue, Apr 28, 2015 at 03:07:35PM -0700, Kenneth Graunke wrote: > On Wednesday, April 22, 2015 11:47:20 PM Topi Pohjolainen wrote: > > Currently batch emission logic is bolted into using the current > > gl-state and currently bound user shader programs as input. This > > series refactors the api t

Re: [Mesa-dev] i965: Batch emission refactoring

2015-04-28 Thread Kenneth Graunke
On Wednesday, April 22, 2015 11:47:20 PM Topi Pohjolainen wrote: > Currently batch emission logic is bolted into using the current > gl-state and currently bound user shader programs as input. This > series refactors the api to allow caller to give individual bits of > information needed explicitly

Re: [Mesa-dev] i965: Batch emission refactoring

2015-04-28 Thread Matt Turner
On Thu, Apr 23, 2015 at 11:56 AM, Matt Turner wrote: > I've looked through all 18 patches, and they look fine to me -- but > I'm not sure how much that's worth. > > I noted a bunch of whitespace mistakes (Is there a way to configure > git commit to warn you about things like this?) but not much el

Re: [Mesa-dev] i965: Batch emission refactoring

2015-04-23 Thread Pohjolainen, Topi
On Thu, Apr 23, 2015 at 11:56:31AM -0700, Matt Turner wrote: > I've looked through all 18 patches, and they look fine to me -- but > I'm not sure how much that's worth. > > I noted a bunch of whitespace mistakes (Is there a way to configure > git commit to warn you about things like this?) but not

Re: [Mesa-dev] i965: Batch emission refactoring

2015-04-23 Thread Matt Turner
I've looked through all 18 patches, and they look fine to me -- but I'm not sure how much that's worth. I noted a bunch of whitespace mistakes (Is there a way to configure git commit to warn you about things like this?) but not much else. I don't know if that's because the series is perfect or if

[Mesa-dev] i965: Batch emission refactoring

2015-04-22 Thread Topi Pohjolainen
Currently batch emission logic is bolted into using the current gl-state and currently bound user shader programs as input. This series refactors the api to allow caller to give individual bits of information needed explicitly instead of the emission logic deducing them from the current state. Thi