Re: [Mesa-dev] Removing R600_BIG_ENDIAN and using #ifdef instead

2016-03-07 Thread Oded Gabbay
On Mar 6, 2016 2:26 PM, "Marek Olšák" wrote: > > Hi Oded, > > I prefer "if" over #ifdef. The idea is that everybody should be able > to test if the compilation succeeds without a BE machine. #ifdef > disallows that. > > R600_BIG_ENDIAN can be moved to r600_pipe_common.h. > > Marek > OK, no problem

Re: [Mesa-dev] Removing R600_BIG_ENDIAN and using #ifdef instead

2016-03-06 Thread Marek Olšák
Hi Oded, I prefer "if" over #ifdef. The idea is that everybody should be able to test if the compilation succeeds without a BE machine. #ifdef disallows that. R600_BIG_ENDIAN can be moved to r600_pipe_common.h. Marek On Sun, Mar 6, 2016 at 9:01 AM, Oded Gabbay wrote: > Hi, > > Do you mind if

[Mesa-dev] Removing R600_BIG_ENDIAN and using #ifdef instead

2016-03-06 Thread Oded Gabbay
Hi, Do you mind if I totally remove R600_BIG_ENDIAN global variable and instead use in all places #ifdef PIPE_ARCH_BIG_ENDIAN ? It's just that: 1. Checking for R600_BIG_ENDIAN is an extra check which can be eliminated using #ifdef 2. Some files, e.g r600_texture.c, don't know R600_BIG_ENDIAN so