Re: [Mesa-dev] RFC uniform packing for gallium V2

2017-06-26 Thread Nicolai Hähnle
I had a chance to look at the patches in detail now. Thanks for working on this, it should be quite useful! With the remark on patch 1 addressed, patches 1, 2, and 4-9 are Reviewed-by: Nicolai Hähnle I've sent some more extensive comments on patch 3, and I already explained that I don't like

Re: [Mesa-dev] RFC uniform packing for gallium V2

2017-06-25 Thread Timothy Arceri
On Sun, Jun 25, 2017, at 12:30 AM, Nicolai Hähnle wrote: > On 25.06.2017 09:18, Nicolai Hähnle wrote: > > On 25.06.2017 03:31, Timothy Arceri wrote: > >> There are still a handful of piglit tests failing and I'm yet to test > >> that there are no regressions in the non-packed path, but I'd really >

Re: [Mesa-dev] RFC uniform packing for gallium V2

2017-06-25 Thread Timothy Arceri
On Sun, Jun 25, 2017, at 12:18 AM, Nicolai Hähnle wrote: > On 25.06.2017 03:31, Timothy Arceri wrote: > > There are still a handful of piglit tests failing and I'm yet to test > > that there are no regressions in the non-packed path, but I'd really > > like some feedback on the approach as Dave has

Re: [Mesa-dev] RFC uniform packing for gallium V2

2017-06-25 Thread Nicolai Hähnle
On 25.06.2017 09:18, Nicolai Hähnle wrote: On 25.06.2017 03:31, Timothy Arceri wrote: There are still a handful of piglit tests failing and I'm yet to test that there are no regressions in the non-packed path, but I'd really like some feedback on the approach as Dave has flagged it as a possible

Re: [Mesa-dev] RFC uniform packing for gallium V2

2017-06-25 Thread Nicolai Hähnle
On 25.06.2017 03:31, Timothy Arceri wrote: There are still a handful of piglit tests failing and I'm yet to test that there are no regressions in the non-packed path, but I'd really like some feedback on the approach as Dave has flagged it as a possible controversial tgsi change. In order to avo

[Mesa-dev] RFC uniform packing for gallium V2

2017-06-24 Thread Timothy Arceri
There are still a handful of piglit tests failing and I'm yet to test that there are no regressions in the non-packed path, but I'd really like some feedback on the approach as Dave has flagged it as a possible controversial tgsi change. In order to avoid complicated swizzling and array element ad

[Mesa-dev] RFC uniform packing for gallium

2017-06-19 Thread Timothy Arceri
I've been working on this on and off and wanted to get some feedback on the approach I've taken before putting to much time in fixing the remaining bugs. There are around 150 piglit tests still failing. The main goal of this series is to reduce the cpu overhead cause by _mesa_propagate_uniforms_to