Re: [Mesa-dev] RFC: reworked Gallium provoking vertex code

2010-05-05 Thread Brian Paul
José Fonseca wrote: On Wed, 2010-05-05 at 11:34 -0700, Brian Paul wrote: Commit ddb0e18f6c5582d4d2cc59ffd16ad9c4639ed059 changed some of the draw module code relating to provoking vertex. The change was in the right direction, but incomplete (and broke the glean clipFlat test). The attached

Re: [Mesa-dev] RFC: reworked Gallium provoking vertex code

2010-05-05 Thread José Fonseca
On Wed, 2010-05-05 at 11:34 -0700, Brian Paul wrote: > Commit ddb0e18f6c5582d4d2cc59ffd16ad9c4639ed059 changed some of the > draw module code relating to provoking vertex. The change was in the > right direction, but incomplete (and broke the glean clipFlat test). > > The attached patch reworks

Re: [Mesa-dev] RFC: reworked Gallium provoking vertex code

2010-05-05 Thread Keith Whitwell
On Wed, 2010-05-05 at 20:12 +0100, Keith Whitwell wrote: > Brian, > > My understanding is that gallium has chosen to simplfy itself slightly > and treat quad rasterization as always following GL flatshading > conventions. Does/could your change follow that convention? Ugh, I couldn't tell fro

Re: [Mesa-dev] RFC: reworked Gallium provoking vertex code

2010-05-05 Thread Keith Whitwell
Brian, My understanding is that gallium has chosen to simplfy itself slightly and treat quad rasterization as always following GL flatshading conventions. Does/could your change follow that convention? Keith On Wed, 2010-05-05 at 11:34 -0700, Brian Paul wrote: > Commit ddb0e18f6c5582d4d2cc59ffd

[Mesa-dev] RFC: reworked Gallium provoking vertex code

2010-05-05 Thread Brian Paul
Commit ddb0e18f6c5582d4d2cc59ffd16ad9c4639ed059 changed some of the draw module code relating to provoking vertex. The change was in the right direction, but incomplete (and broke the glean clipFlat test). The attached patch reworks the provoking vertex code and fixes the regressions. Thi