Re: [Mesa-dev] Pull request for 1.50 GS layout qualifiers

2013-06-14 Thread Fabian Bieler
Hello! I gave your series a try and found two small nitpicks: In "glsl: Parse the GLSL 1.50 GS layout qualifiers.": There are two debug printfs left in "ast_type_qualifier::merge_qualifier" max_vertices or VerticesOut is not checked against MaxGeometryOutputVertices. Fabian On 2013-06-14 03:15,

[Mesa-dev] Pull request for 1.50 GS layout qualifiers

2013-06-13 Thread Eric Anholt
Hey Paul! I got the layout qualifiers working. It's unblocked things so I can finish off a bunch of testcases I've been working on, so I'd like to get it in your gs branch so we can all enjoy testcases together. There's one not-for-upstream commit in here, and do note the TODO in the last commit