Re: [Mesa-dev] Please test the automake-gallium branch

2012-10-01 Thread Tom Stellard
On Wed, Sep 26, 2012 at 04:09:38PM -0700, Matt Turner wrote: > On Wed, Sep 26, 2012 at 2:50 PM, Török Edwin > wrote: > > On 09/26/2012 11:59 PM, Matt Turner wrote: > >> I've pushed an automake-gallium2 branch to my repo with a number of > >> fixes squashed-in. > >> > >> git://people.freedesktop.or

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-27 Thread Brian Paul
On 09/27/2012 12:19 AM, Kenneth Graunke wrote: On 09/26/2012 10:55 PM, Matt Turner wrote: On Wed, Sep 26, 2012 at 10:47 PM, Kenneth Graunke wrote: On 09/26/2012 04:09 PM, Matt Turner wrote: On Wed, Sep 26, 2012 at 2:50 PM, Török Edwin wrote: Another issue is that the yacc-generated files are

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-26 Thread Kenneth Graunke
On 09/26/2012 10:55 PM, Matt Turner wrote: > On Wed, Sep 26, 2012 at 10:47 PM, Kenneth Graunke > wrote: >> On 09/26/2012 04:09 PM, Matt Turner wrote: >>> On Wed, Sep 26, 2012 at 2:50 PM, Török Edwin wrote: Another issue is that the yacc-generated files are not removed by 'make clean',

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-26 Thread Matt Turner
On Wed, Sep 26, 2012 at 10:47 PM, Kenneth Graunke wrote: > On 09/26/2012 04:09 PM, Matt Turner wrote: >> On Wed, Sep 26, 2012 at 2:50 PM, Török Edwin wrote: >>> Another issue is that the yacc-generated files are not removed by 'make >>> clean', >>> but thats probably on purpose (do the generated

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-26 Thread Kenneth Graunke
On 09/26/2012 04:09 PM, Matt Turner wrote: > On Wed, Sep 26, 2012 at 2:50 PM, Török Edwin wrote: >> Another issue is that the yacc-generated files are not removed by 'make >> clean', >> but thats probably on purpose (do the generated files get shipped in the >> release tarball?), >> I should've r

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-26 Thread Matt Turner
On Wed, Sep 26, 2012 at 2:50 PM, Török Edwin wrote: > On 09/26/2012 11:59 PM, Matt Turner wrote: >> I've pushed an automake-gallium2 branch to my repo with a number of >> fixes squashed-in. >> >> git://people.freedesktop.org/~mattst88/mesa automake-gallium2 > > Nice progress! > > I was able to bui

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-26 Thread Török Edwin
On 09/26/2012 11:59 PM, Matt Turner wrote: > I've pushed an automake-gallium2 branch to my repo with a number of > fixes squashed-in. > > git://people.freedesktop.org/~mattst88/mesa automake-gallium2 Nice progress! I was able to build it after reversing the 'if' below. It doesn't load though: l

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-26 Thread Matt Turner
On Mon, Sep 24, 2012 at 2:52 PM, Matt Turner wrote: > This series of 105 patches finishes the automake conversion. > > I don't think the series needs to be reviewed patch by patch, since > large chunks are making nearly identical changes to different > directories. Plus, incorrect changes in the b

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-26 Thread Eric Anholt
Matt Turner writes: > On Tue, Sep 25, 2012 at 10:56 AM, Marcin Slusarz > wrote: >> On Tue, Sep 25, 2012 at 10:38:31AM -0700, Matt Turner wrote: >>> On Tue, Sep 25, 2012 at 10:31 AM, Marcin Slusarz >>> wrote: >>> >> Installation is part of the testing procedure, after all. >>> > >>> > No. People

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-25 Thread Matt Turner
On Tue, Sep 25, 2012 at 12:33 PM, Marcin Slusarz wrote: > On Mon, Sep 24, 2012 at 02:52:28PM -0700, Matt Turner wrote: >> This series of 105 patches finishes the automake conversion. >> >> I don't think the series needs to be reviewed patch by patch, since >> large chunks are making nearly identic

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-25 Thread Marcin Slusarz
On Mon, Sep 24, 2012 at 02:52:28PM -0700, Matt Turner wrote: > This series of 105 patches finishes the automake conversion. > > I don't think the series needs to be reviewed patch by patch, since > large chunks are making nearly identical changes to different > directories. Plus, incorrect changes

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-25 Thread Matt Turner
On Tue, Sep 25, 2012 at 11:47 AM, Marcin Slusarz wrote: > On Tue, Sep 25, 2012 at 11:00:23AM -0700, Matt Turner wrote: >> On Tue, Sep 25, 2012 at 10:56 AM, Marcin Slusarz >> wrote: >> > On Tue, Sep 25, 2012 at 10:38:31AM -0700, Matt Turner wrote: >> >> On Tue, Sep 25, 2012 at 10:31 AM, Marcin Slu

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-25 Thread Marcin Slusarz
On Tue, Sep 25, 2012 at 11:00:23AM -0700, Matt Turner wrote: > On Tue, Sep 25, 2012 at 10:56 AM, Marcin Slusarz > wrote: > > On Tue, Sep 25, 2012 at 10:38:31AM -0700, Matt Turner wrote: > >> On Tue, Sep 25, 2012 at 10:31 AM, Marcin Slusarz > >> wrote: > >> >> Installation is part of the testing p

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-25 Thread Matt Turner
On Tue, Sep 25, 2012 at 10:57 AM, Török Edwin wrote: > On 09/25/2012 12:52 AM, Matt Turner wrote: >> >> Please help me find problems now before it goes into master. Here's a >> branch. It's easy to test. If you don't test and I commit this in a >> week and break your stuff, I'm sorry, but you didn

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-25 Thread Matt Turner
On Tue, Sep 25, 2012 at 10:56 AM, Marcin Slusarz wrote: > On Tue, Sep 25, 2012 at 10:38:31AM -0700, Matt Turner wrote: >> On Tue, Sep 25, 2012 at 10:31 AM, Marcin Slusarz >> wrote: >> >> Installation is part of the testing procedure, after all. >> > >> > No. People test code, not build systems. >

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-25 Thread Tom Stellard
On Tue, Sep 25, 2012 at 08:57:20PM +0300, Török Edwin wrote: > On 09/25/2012 12:52 AM, Matt Turner wrote: > > > > Please help me find problems now before it goes into master. Here's a > > branch. It's easy to test. If you don't test and I commit this in a > > week and break your stuff, I'm sorry,

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-25 Thread Török Edwin
On 09/25/2012 12:52 AM, Matt Turner wrote: > > Please help me find problems now before it goes into master. Here's a > branch. It's easy to test. If you don't test and I commit this in a > week and break your stuff, I'm sorry, but you didn't test. > > http://cgit.freedesktop.org/~mattst88/mesa/lo

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-25 Thread Marcin Slusarz
On Tue, Sep 25, 2012 at 10:38:31AM -0700, Matt Turner wrote: > On Tue, Sep 25, 2012 at 10:31 AM, Marcin Slusarz > wrote: > >> Installation is part of the testing procedure, after all. > > > > No. People test code, not build systems. > > I invite you to reread the subject of this email. So you do

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-25 Thread Matt Turner
On Tue, Sep 25, 2012 at 10:31 AM, Marcin Slusarz wrote: >> Installation is part of the testing procedure, after all. > > No. People test code, not build systems. I invite you to reread the subject of this email. ___ mesa-dev mailing list mesa-dev@lists.

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-25 Thread Marcin Slusarz
On Tue, Sep 25, 2012 at 10:02:26AM -0700, Matt Turner wrote: > On Tue, Sep 25, 2012 at 9:46 AM, Marcin Slusarz > wrote: > > With this branch, top level lib directory is not created, so it's impossible > > to test mesa without installing it first. > > Indeed. This has been planned for a while. Ne

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-25 Thread Matt Turner
On Tue, Sep 25, 2012 at 9:46 AM, Marcin Slusarz wrote: > With this branch, top level lib directory is not created, so it's impossible > to test mesa without installing it first. Indeed. This has been planned for a while. Installation is part of the testing procedure, after all. Do DESTDIR=... ma

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-25 Thread Marcin Slusarz
On Mon, Sep 24, 2012 at 02:52:28PM -0700, Matt Turner wrote: > This series of 105 patches finishes the automake conversion. > > I don't think the series needs to be reviewed patch by patch, since > large chunks are making nearly identical changes to different > directories. Plus, incorrect changes

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-25 Thread Marcin Slusarz
On Tue, Sep 25, 2012 at 08:35:31AM -0600, Brian Paul wrote: > On Mon, Sep 24, 2012 at 3:52 PM, Matt Turner wrote: > > This series of 105 patches finishes the automake conversion. > > > > I don't think the series needs to be reviewed patch by patch, since > > large chunks are making nearly identica

Re: [Mesa-dev] Please test the automake-gallium branch

2012-09-25 Thread Brian Paul
On Mon, Sep 24, 2012 at 3:52 PM, Matt Turner wrote: > This series of 105 patches finishes the automake conversion. > > I don't think the series needs to be reviewed patch by patch, since > large chunks are making nearly identical changes to different > directories. Plus, incorrect changes in the b

[Mesa-dev] Please test the automake-gallium branch

2012-09-24 Thread Matt Turner
This series of 105 patches finishes the automake conversion. I don't think the series needs to be reviewed patch by patch, since large chunks are making nearly identical changes to different directories. Plus, incorrect changes in the build system should be detectable with testing. As such, I won'