Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-13 Thread Mathias Fröhlich
Hi, On Friday, 12 August 2016 12:15:52 CEST Nicolai Hähnle wrote: > I take it this means `git bisect` becomes unusable? At least it looks > like it after a bit of playing around with it. That seems like a > show-stopper :( git bisect skip does this job. But it's pretty surprising if you step on

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-12 Thread Nicolai Hähnle
Hi Mathias, thanks for the input! On 11.08.2016 06:49, Mathias Fröhlich wrote: For subtree-merge: There is a pair of visualisation teams that used to work for the same company until they both got sold to individual vendors but still wanted to share their basic framwork code. Those two applicat

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-12 Thread Nicolai Hähnle
On 11.08.2016 13:12, Enrico Weigelt, metux IT consult wrote: On 10.08.2016 15:19, Nicolai Hähnle wrote: It would be nice to have something more concrete to go on, like what are the problems _really_ :) Actually, I haven't understood who the other users of addrlib actually are - is it just AMDs

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-11 Thread Enrico Weigelt, metux IT consult
On 10.08.2016 15:19, Nicolai Hähnle wrote: > It would be nice to have something more concrete to go on, like what are > the problems _really_ :) Actually, I haven't understood who the other users of addrlib actually are - is it just AMDs proprietary driver ? > What pain do submodules give you tha

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-10 Thread Mathias Fröhlich
Hi, On Wednesday, 10 August 2016 15:19:06 CEST Nicolai Hähnle wrote: > On 09.08.2016 22:12, Dave Airlie wrote: > >> > >> tbh, git submodules are more annoying than they need to be, and I'm > >> not really terribly excited to use that for something that is a build > >> dependency. Maybe just move

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-10 Thread Nicolai Hähnle
On 10.08.2016 06:22, Edward O'Callaghan wrote: Well taking a step back here for a second. My initial thoughts are - what, conceptually, is the primary user of addrlib from an extremely high level view? If the case is mesa3d then perhaps mesa should be treated as the upstream from which other use

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-10 Thread Nicolai Hähnle
On 09.08.2016 22:12, Dave Airlie wrote: tbh, git submodules are more annoying than they need to be, and I'm not really terribly excited to use that for something that is a build dependency. Maybe just move it into libdrm instead? I've only had to use git submodules once with spice project, a

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Edward O'Callaghan
Hey guys, Well taking a step back here for a second. My initial thoughts are - what, conceptually, is the primary user of addrlib from an extremely high level view? If the case is mesa3d then perhaps mesa should be treated as the upstream from which other users pull. If the case is that it is ind

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Jason Ekstrand
On Tue, Aug 9, 2016 at 1:12 PM, Dave Airlie wrote: > > > > tbh, git submodules are more annoying than they need to be, and I'm > > not really terribly excited to use that for something that is a build > > dependency. Maybe just move it into libdrm instead? > > > > I've only had to use git submod

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Dave Airlie
> > tbh, git submodules are more annoying than they need to be, and I'm > not really terribly excited to use that for something that is a build > dependency. Maybe just move it into libdrm instead? > I've only had to use git submodules once with spice project, and it was a nightmare. It makes pac

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Erik Faye-Lund
On Tue, Aug 9, 2016 at 7:24 PM, Nicolai Hähnle wrote: > > On 09.08.2016 18:22, Erik Faye-Lund wrote: >> >> On Tue, Aug 9, 2016 at 4:59 PM, Nicolai Hähnle wrote: >>> >>> On 09.08.2016 15:58, Rob Clark wrote: tbh, git submodules are more annoying than they need to be, and I'm no

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Nicolai Hähnle
On 09.08.2016 18:22, Erik Faye-Lund wrote: On Tue, Aug 9, 2016 at 4:59 PM, Nicolai Hähnle wrote: On 09.08.2016 15:58, Rob Clark wrote: tbh, git submodules are more annoying than they need to be, and I'm not really terribly excited to use that for something that is a build dependency. Maybe

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Nicolai Hähnle
On 09.08.2016 19:18, Marek Olšák wrote: On Tue, Aug 9, 2016 at 5:35 PM, Nicolai Hähnle wrote: On 09.08.2016 17:21, Marek Olšák wrote: On Tue, Aug 9, 2016 at 3:47 PM, Nicolai Hähnle wrote: Hi everybody, addrlib is the addressing and alignment calculator which is used by radeonsi. It's deve

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Marek Olšák
On Tue, Aug 9, 2016 at 5:35 PM, Nicolai Hähnle wrote: > On 09.08.2016 17:21, Marek Olšák wrote: >> >> On Tue, Aug 9, 2016 at 3:47 PM, Nicolai Hähnle wrote: >>> >>> Hi everybody, >>> >>> addrlib is the addressing and alignment calculator which is used by >>> radeonsi. It's developed (and also used

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Erik Faye-Lund
On Tue, Aug 9, 2016 at 4:59 PM, Nicolai Hähnle wrote: > On 09.08.2016 15:58, Rob Clark wrote: >> >> tbh, git submodules are more annoying than they need to be, and I'm >> not really terribly excited to use that for something that is a build >> dependency. Maybe just move it into libdrm instead? >

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Marek Olšák
On Tue, Aug 9, 2016 at 3:47 PM, Nicolai Hähnle wrote: > Hi everybody, > > addrlib is the addressing and alignment calculator which is used by > radeonsi. It's developed (and also used) internally at AMD, and so far we've > had one open source copy living in the Mesa repository at > src/gallium/win

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Christian König
Am 09.08.2016 um 15:47 schrieb Nicolai Hähnle: Hi everybody, addrlib is the addressing and alignment calculator which is used by radeonsi. It's developed (and also used) internally at AMD, and so far we've had one open source copy living in the Mesa repository at src/gallium/winsys/amdgpu/drm

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Nicolai Hähnle
On 09.08.2016 17:21, Marek Olšák wrote: On Tue, Aug 9, 2016 at 3:47 PM, Nicolai Hähnle wrote: Hi everybody, addrlib is the addressing and alignment calculator which is used by radeonsi. It's developed (and also used) internally at AMD, and so far we've had one open source copy living in the Me

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Enrico Weigelt, metux IT consult
On 09.08.2016 16:59, Nicolai Hähnle wrote: > So shared linking is right out. Not exactly. Just everything needs to be linked against the matching versions. More a dist-layer problem. addrlibs folks should learn to introduce a proper versioning and provide MVCC-capable build rules. That really is

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Enrico Weigelt, metux IT consult
On 09.08.2016 15:47, Nicolai Hähnle wrote: > I think the best way forward is to create a dedicated repository for > addrlib which is then integrated into Mesa as a git submodule. If you really wanna make a lot of people, especially dist-maintainers very unhappy ... > From initial experiments, th

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Nicolai Hähnle
On 09.08.2016 15:58, Rob Clark wrote: On Tue, Aug 9, 2016 at 9:47 AM, Nicolai Hähnle wrote: Hi everybody, addrlib is the addressing and alignment calculator which is used by radeonsi. It's developed (and also used) internally at AMD, and so far we've had one open source copy living in the Mesa

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Rob Clark
On Tue, Aug 9, 2016 at 9:47 AM, Nicolai Hähnle wrote: > Hi everybody, > > addrlib is the addressing and alignment calculator which is used by > radeonsi. It's developed (and also used) internally at AMD, and so far we've > had one open source copy living in the Mesa repository at > src/gallium/win

[Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Nicolai Hähnle
Hi everybody, addrlib is the addressing and alignment calculator which is used by radeonsi. It's developed (and also used) internally at AMD, and so far we've had one open source copy living in the Mesa repository at src/gallium/winsys/amdgpu/drm/addrlib. The question of using addrlib in non