On 8 September 2013 10:05, Paul Berry wrote:
> On 4 September 2013 15:22, Kenneth Graunke wrote:
>
>> Hello!
>>
>> This series (at long last!) rewrites the GLSL built-in function handling,
>> for the third time. It's available on the builtins-v3 branch of
>> ~kwg/mesa.
>>
>> The existing built-
On 4 September 2013 15:22, Kenneth Graunke wrote:
> Hello!
>
> This series (at long last!) rewrites the GLSL built-in function handling,
> for the third time. It's available on the builtins-v3 branch of ~kwg/mesa.
>
> The existing built-in function code had a lot of drawbacks:
>
> 1. Writing new
Awesome work. I had comments about 9, 14, 16, and 20 and with those
addressed 1-17, and 19-21 are
Reviewed-by: Matt Turner
I'm not sure if there's value in trying to review all of patch 18,
given a lack of piglit regressions? What do you think?
At the very least, patch 18 gets an
Acked-by: Mat
Hello!
This series (at long last!) rewrites the GLSL built-in function handling,
for the third time. It's available on the builtins-v3 branch of ~kwg/mesa.
The existing built-in function code had a lot of drawbacks:
1. Writing new built-ins in the S-Expression style IR was painful:
Somethin