Re: [Mesa-dev] FLAG-DAY: NIR derefs

2018-03-15 Thread Jason Ekstrand
For those interested in following along, I've pushed a bunch of stuff to a branch: https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/nir-deref-instr I will continue force-pushing that branch as I go. My current approach to doing things incrementally is to try and do it by type of dereferen

Re: [Mesa-dev] FLAG-DAY: NIR derefs

2018-03-15 Thread Alejandro Piñeiro
On 15/03/18 15:39, Jason Ekstrand wrote: > On Thu, Mar 15, 2018 at 1:12 AM, Alejandro Piñeiro > mailto:apinhe...@igalia.com>> wrote: > > Hi, > > On 14/03/18 21:32, Jason Ekstrand wrote: >> All, >> >> Connor and I along with several others have been discussing for a >> while chan

Re: [Mesa-dev] FLAG-DAY: NIR derefs

2018-03-15 Thread Jason Ekstrand
On Thu, Mar 15, 2018 at 1:12 AM, Alejandro Piñeiro wrote: > Hi, > On 14/03/18 21:32, Jason Ekstrand wrote: > > All, > > Connor and I along with several others have been discussing for a while > changing the way NIR dereferences work. In particular, adding a new > nir_deref_instr type where the f

Re: [Mesa-dev] FLAG-DAY: NIR derefs

2018-03-15 Thread Alejandro Piñeiro
Hi, On 14/03/18 21:32, Jason Ekstrand wrote: > All, > > Connor and I along with several others have been discussing for a > while changing the way NIR dereferences work.  In particular, adding a > new nir_deref_instr type where the first one in the chain takes a > variable and is followed by a ser

Re: [Mesa-dev] FLAG-DAY: NIR derefs

2018-03-14 Thread Rob Clark
On Wed, Mar 14, 2018 at 8:44 PM, Connor Abbott wrote: > On Wed, Mar 14, 2018 at 6:07 PM, Rob Clark wrote: >> On Wed, Mar 14, 2018 at 7:42 PM, Connor Abbott wrote: >>> On Wed, Mar 14, 2018 at 5:05 PM, Rob Clark wrote: On Wed, Mar 14, 2018 at 4:58 PM, Connor Abbott wrote: > FWIW, the wa

Re: [Mesa-dev] FLAG-DAY: NIR derefs

2018-03-14 Thread Connor Abbott
On Wed, Mar 14, 2018 at 6:07 PM, Rob Clark wrote: > On Wed, Mar 14, 2018 at 7:42 PM, Connor Abbott wrote: >> On Wed, Mar 14, 2018 at 5:05 PM, Rob Clark wrote: >>> On Wed, Mar 14, 2018 at 4:58 PM, Connor Abbott wrote: FWIW, the way I imagined doing this was something like: 1. Add

Re: [Mesa-dev] FLAG-DAY: NIR derefs

2018-03-14 Thread Rob Clark
On Wed, Mar 14, 2018 at 7:42 PM, Connor Abbott wrote: > On Wed, Mar 14, 2018 at 5:05 PM, Rob Clark wrote: >> On Wed, Mar 14, 2018 at 4:58 PM, Connor Abbott wrote: >>> FWIW, the way I imagined doing this was something like: >>> >>> 1. Add nir_deref_instr and nir_deref_type_pointer. At this point,

Re: [Mesa-dev] FLAG-DAY: NIR derefs

2018-03-14 Thread Connor Abbott
On Wed, Mar 14, 2018 at 5:05 PM, Rob Clark wrote: > On Wed, Mar 14, 2018 at 4:58 PM, Connor Abbott wrote: >> FWIW, the way I imagined doing this was something like: >> >> 1. Add nir_deref_instr and nir_deref_type_pointer. At this point, just >> make everything assert if the base deref isn't a nir

Re: [Mesa-dev] FLAG-DAY: NIR derefs

2018-03-14 Thread Rob Clark
On Wed, Mar 14, 2018 at 4:58 PM, Connor Abbott wrote: > FWIW, the way I imagined doing this was something like: > > 1. Add nir_deref_instr and nir_deref_type_pointer. At this point, just > make everything assert if the base deref isn't a nir_deref_var. This > will be a bit of a flag-day, but also

Re: [Mesa-dev] FLAG-DAY: NIR derefs

2018-03-14 Thread Connor Abbott
FWIW, the way I imagined doing this was something like: 1. Add nir_deref_instr and nir_deref_type_pointer. At this point, just make everything assert if the base deref isn't a nir_deref_var. This will be a bit of a flag-day, but also very mechanical. It'll also help us catch cases where we don't h

[Mesa-dev] FLAG-DAY: NIR derefs

2018-03-14 Thread Jason Ekstrand
All, Connor and I along with several others have been discussing for a while changing the way NIR dereferences work. In particular, adding a new nir_deref_instr type where the first one in the chain takes a variable and is followed by a series of instructions which take another deref instruction