My patch should fix those too.
Since this is glBlitFramebuffer, it shouldn't need any gallium states,
so the st_validate_state call is mostly useless and all unnecessary
operations should skipped. Sadly, there is little interest in such
optimizations nowadays, but I understand that people are busy
Yeah, but there are a whole bunch of places, non-blit-related, where
we call st_validate_state that will hit this same problem.
On Fri, Jun 26, 2015 at 11:43 AM, Brian Paul wrote:
> If we really do need to call _mesa_update_state() for this, I think the
> right place would be in _mesa_blit_frameb
If we really do need to call _mesa_update_state() for this, I think the
right place would be in _mesa_blit_framebuffer(), not in the state tracker.
-Brian
On 06/26/2015 09:17 AM, Ilia Mirkin wrote:
So that obviously avoids the crash. I guess I was unsure if that was
the right way forward. The
So that obviously avoids the crash. I guess I was unsure if that was
the right way forward. The way that I understand it, there's "direct"
state in the context, and there's derived state. And
_mesa_update_state() will update the derived state. Since the various
st atoms use derived state, doesn't i
On a different note, finalize_textures only finalizes fragment shader
textures and ignores other stages, which means that either other
stages have unfinalized textures (unlikely) or finalize_textures is
useless.
Marek
On Fri, Jun 26, 2015 at 11:02 AM, Marek Olšák wrote:
> I think the best way is
I think the best way is not to do anything if one of the shaders is
NULL. Just like my patch that I just sent.
Marek
On Fri, Jun 26, 2015 at 3:04 AM, Ilia Mirkin wrote:
> Hello,
>
> A user reported a crash in wine in finalize_textures (called via
> st_validate_state). In this particular case it
Hello,
A user reported a crash in wine in finalize_textures (called via
st_validate_state). In this particular case it was happening through
st_BlitFramebuffer (piglit test sent), but there are a number of
callsites of st_validate_state from st/mesa.
The reason it dies is that the fragment progra
