Re: [Mesa-dev] DRI2 pixmap swapping

2011-12-07 Thread Adam Jackson
On 12/7/11 4:16 AM, Michel Dänzer wrote: On Mit, 2011-12-07 at 08:40 +, Dave Airlie wrote: I have a feeling, since dri2 is not strictly restricted to GLX, whether this should really be implemented in the glx code before calling into dri2? Otoh that would mean the server side would need to b

Re: [Mesa-dev] DRI2 pixmap swapping

2011-12-07 Thread Michel Dänzer
On Mit, 2011-12-07 at 09:44 +, Dave Airlie wrote: > > Indeed, but fixing it without invasive protocol work may be messy, but > > I'm not really a GLX or DRI2 expert and its hard to fathom the > > intentions of DRI2 original authors wrt this GLX case. > > Also client side fixing is not in any

Re: [Mesa-dev] DRI2 pixmap swapping

2011-12-07 Thread Dave Airlie
> Indeed, but fixing it without invasive protocol work may be messy, but > I'm not really a GLX or DRI2 expert and its hard to fathom the > intentions of DRI2 original authors wrt this GLX case. Also client side fixing is not in any way going to help broken clients that exist in the field now. i.e

Re: [Mesa-dev] DRI2 pixmap swapping

2011-12-07 Thread Dave Airlie
2011/12/7 Michel Dänzer : > On Mit, 2011-12-07 at 09:20 +, Dave Airlie wrote: >> 2011/12/7 Michel Dänzer : >> > On Mit, 2011-12-07 at 08:40 +, Dave Airlie wrote: >> >> > >> >> > I have a feeling, since dri2 is not strictly restricted to GLX, whether >> >> > this >> >> > should really be >>

Re: [Mesa-dev] DRI2 pixmap swapping

2011-12-07 Thread Michel Dänzer
On Mit, 2011-12-07 at 09:20 +, Dave Airlie wrote: > 2011/12/7 Michel Dänzer : > > On Mit, 2011-12-07 at 08:40 +, Dave Airlie wrote: > >> > > >> > I have a feeling, since dri2 is not strictly restricted to GLX, whether > >> > this > >> > should really be > >> > implemented in the glx code

Re: [Mesa-dev] DRI2 pixmap swapping

2011-12-07 Thread Dave Airlie
2011/12/7 Michel Dänzer : > On Mit, 2011-12-07 at 08:40 +, Dave Airlie wrote: >> > >> > I have a feeling, since dri2 is not strictly restricted to GLX, whether >> > this >> > should really be >> > implemented in the glx code before calling into dri2? Otoh that would mean >> > the server side >

Re: [Mesa-dev] DRI2 pixmap swapping

2011-12-07 Thread Michel Dänzer
On Mit, 2011-12-07 at 08:40 +, Dave Airlie wrote: > > > > I have a feeling, since dri2 is not strictly restricted to GLX, whether this > > should really be > > implemented in the glx code before calling into dri2? Otoh that would mean > > the server side > > would need to be able to handle the

Re: [Mesa-dev] DRI2 pixmap swapping

2011-12-07 Thread Dave Airlie
> > I have a feeling, since dri2 is not strictly restricted to GLX, whether this > should really be > implemented in the glx code before calling into dri2? Otoh that would mean > the server side > would need to be able to handle the case anyway. The problem is that GLX doesn't get a chance, since

Re: [Mesa-dev] DRI2 pixmap swapping

2011-12-07 Thread Thomas Hellstrom
On 12/06/2011 07:58 PM, Eric Anholt wrote: On Tue, 6 Dec 2011 16:44:30 +, Dave Airlie wrote: Hi, So GLX has a rule about not swapping pixmaps, and I've been trying to track down why with DRI2 my driver gets requests for swapping pixmaps (piglit glx-swap-pixmap test). So it appears in

Re: [Mesa-dev] DRI2 pixmap swapping

2011-12-06 Thread Eric Anholt
On Tue, 6 Dec 2011 16:44:30 +, Dave Airlie wrote: > Hi, > > So GLX has a rule about not swapping pixmaps, and I've been trying to > track down why with DRI2 my driver gets requests for swapping pixmaps > (piglit glx-swap-pixmap test). > > So it appears in the DRI2 buffer swap case, we bypass

[Mesa-dev] DRI2 pixmap swapping

2011-12-06 Thread Dave Airlie
Hi, So GLX has a rule about not swapping pixmaps, and I've been trying to track down why with DRI2 my driver gets requests for swapping pixmaps (piglit glx-swap-pixmap test). So it appears in the DRI2 buffer swap case, we bypass the GLX protocol and use the DRI2SwapBuffers protocol, now nowhere o