Re: [Mesa-dev] Bug in 48157b904a9 found by Coverity

2014-11-19 Thread Damien Lespiau
On Wed, Nov 19, 2014 at 12:42:45PM -0500, Ilia Mirkin wrote: > On Wed, Nov 19, 2014 at 12:28 PM, Damien Lespiau > wrote: > > On Wed, Nov 19, 2014 at 12:13:41PM -0500, Ilia Mirkin wrote: > >> Hey guys, > >> > >> Just got around to looking at the Coverity email about newly > >> introduced bugs, and

Re: [Mesa-dev] Bug in 48157b904a9 found by Coverity

2014-11-19 Thread Ilia Mirkin
On Wed, Nov 19, 2014 at 12:28 PM, Damien Lespiau wrote: > On Wed, Nov 19, 2014 at 12:13:41PM -0500, Ilia Mirkin wrote: >> Hey guys, >> >> Just got around to looking at the Coverity email about newly >> introduced bugs, and this seems like a legit issue. Based on the >> context of the code, I'm gue

Re: [Mesa-dev] Bug in 48157b904a9 found by Coverity

2014-11-19 Thread Damien Lespiau
On Wed, Nov 19, 2014 at 12:13:41PM -0500, Ilia Mirkin wrote: > Hey guys, > > Just got around to looking at the Coverity email about newly > introduced bugs, and this seems like a legit issue. Based on the > context of the code, I'm guessing you meant to do (input_index - 16) > << 1. Oh my. The pr

[Mesa-dev] Bug in 48157b904a9 found by Coverity

2014-11-19 Thread Ilia Mirkin
Hey guys, Just got around to looking at the Coverity email about newly introduced bugs, and this seems like a legit issue. Based on the context of the code, I'm guessing you meant to do (input_index - 16) << 1. Cheers, -ilia ** CID 1251308: Bad bit shift operation (BAD_SHIFT) /src/mesa/driv