Re: [Mesa-dev] A few fixes for the preprocessor for GLSL 1.30

2013-02-22 Thread Kenneth Graunke
On 02/22/2013 01:14 PM, Carl Worth wrote: Ian Romanick writes: Though, it turns out that this deviates from what C99 specifies. Specifically, the ISO/IEC 9899:TC2 Committee Draft dated May 6, 2005 says: "After all replacements due to macro expansion and the defined unary operator h

Re: [Mesa-dev] A few fixes for the preprocessor for GLSL 1.30

2013-02-22 Thread Carl Worth
Ian Romanick writes: > Though, it turns out that this deviates from what C99 specifies. > Specifically, the ISO/IEC 9899:TC2 Committee Draft dated May 6, 2005 says: > > "After all replacements due to macro expansion and the defined unary > operator have been performed, all remaining ide

Re: [Mesa-dev] A few fixes for the preprocessor for GLSL 1.30

2011-09-30 Thread Carl Worth
On Fri, 30 Sep 2011 12:32:13 -0700, Ian Romanick wrote: > > In any case, the test quotes specific language from the GLSL spec that > > explicitly forbids this behavior, so I'm somewhat reluctant to deviate > > from the spec'ed behavior. We're not deviating from what is specified. We do raise an

Re: [Mesa-dev] A few fixes for the preprocessor for GLSL 1.30

2011-09-30 Thread Ian Romanick
On 09/30/2011 12:18 PM, Ian Romanick wrote: On 09/29/2011 11:00 PM, Carl Worth wrote: 2. if/if-arg-must-be-defined-02.frag Neither this test nor if-arg-must-be-defined-01 produce the desired result on NVIDIA's blob or AMD's blob. I'd be curious to know what it does on Apple's implementation.

Re: [Mesa-dev] A few fixes for the preprocessor for GLSL 1.30

2011-09-30 Thread Ian Romanick
On 09/29/2011 11:00 PM, Carl Worth wrote: Eric recentl mentioned to me that when setting the following environment variables with current master mesa: MESA_GL_VERSION_OVERRIDE=3.0 MESA_GLSL_VERSION_OVERRIDE=130 that 8 piglit preprocessor tests start to fail. I've investigated a

Re: [Mesa-dev] A few fixes for the preprocessor for GLSL 1.30

2011-09-30 Thread Carl Worth
On Thu, 29 Sep 2011 23:43:49 -0700, Kenneth Graunke wrote: > For the series: > Reviewed-by: Kenneth Graunke > > Thanks for fixing these, Carl! No problem. Thanks to you (and Eric) for the review. > > I'll be glad to push changes to piglit to fix these cases unless > > someone can argue aginst

Re: [Mesa-dev] A few fixes for the preprocessor for GLSL 1.30

2011-09-29 Thread Kenneth Graunke
On 09/29/2011 11:00 PM, Carl Worth wrote: > Eric recentl mentioned to me that when setting the following > environment variables with current master mesa: > > MESA_GL_VERSION_OVERRIDE=3.0 > MESA_GLSL_VERSION_OVERRIDE=130 > > that 8 piglit preprocessor tests start to fail. > > I've in

[Mesa-dev] A few fixes for the preprocessor for GLSL 1.30

2011-09-29 Thread Carl Worth
Eric recentl mentioned to me that when setting the following environment variables with current master mesa: MESA_GL_VERSION_OVERRIDE=3.0 MESA_GLSL_VERSION_OVERRIDE=130 that 8 piglit preprocessor tests start to fail. I've investigated all of these failures and am here attaching a