Re: [Mesa-dev] [PATCH 2/3] panfrost: Make the gitlab-ci.yml file more robust

2019-06-21 Thread Rohan Garg
On Friday, 21 June 2019 07:40:02 CEST Tomeu Vizoso wrote: > On 6/20/19 6:33 PM, Rohan Garg wrote: > >> Not sure I understand how this works. Isn't this going to cause > >> unnecessary container builds? > >> > >> And, why cannot developers just add whatever they want to DEBIAN_TAG > >> to that end?

Re: [Mesa-dev] [PATCH 2/3] panfrost: Make the gitlab-ci.yml file more robust

2019-06-20 Thread Tomeu Vizoso
On 6/20/19 6:33 PM, Rohan Garg wrote: Not sure I understand how this works. Isn't this going to cause unnecessary container builds? And, why cannot developers just add whatever they want to DEBIAN_TAG to that end? This will spin a container for each branch, yes, though I think that is how it

Re: [Mesa-dev] [PATCH 2/3] panfrost: Make the gitlab-ci.yml file more robust

2019-06-20 Thread Rohan Garg
Not sure I understand how this works. Isn't this going to cause unnecessary container builds? And, why cannot developers just add whatever they want to DEBIAN_TAG to that end? This will spin a container for each branch, yes, though I think that is how it should be. The patch allows for someone

Re: [Mesa-dev] [PATCH 2/3] panfrost: Make the gitlab-ci.yml file more robust

2019-06-20 Thread Tomeu Vizoso
On Thu, 20 Jun 2019 at 15:59, Rohan Garg wrote: > > This enables developers to add packages to the container > when working on their own branches by creating > a container tag which features the branch name. Not sure I understand how this works. Isn't this going to cause unnecessary container bui

[Mesa-dev] [PATCH 2/3] panfrost: Make the gitlab-ci.yml file more robust

2019-06-20 Thread Rohan Garg
This enables developers to add packages to the container when working on their own branches by creating a container tag which features the branch name. Dropped the IMAGE_LOCAL variable since I did not see it being used anywhere. --- src/gallium/drivers/panfrost/ci/gitlab-ci.yml | 6 +++--- 1 file