Re: [Mesa-dev] [PATCH 1/3] glsl: removing double semi-colons

2016-04-14 Thread Jakob Sinclair
On 2016-04-14 00:43, Ian Romanick wrote: It looks like there are a couple other instances dangling around the tree. src/glx/dri2_glx.c, src/mesa/math/m_debug_norm.c, etc. I did 'grep -r ';[[:space:]]*;' src/'. Most of the hits were for-loops. On 04/13/2016 09:43 AM, Jakob Sinclair wrote: Tr

Re: [Mesa-dev] [PATCH 1/3] glsl: removing double semi-colons

2016-04-13 Thread Ian Romanick
It looks like there are a couple other instances dangling around the tree. src/glx/dri2_glx.c, src/mesa/math/m_debug_norm.c, etc. I did 'grep -r ';[[:space:]]*;' src/'. Most of the hits were for-loops. On 04/13/2016 09:43 AM, Jakob Sinclair wrote: > Trivial change. Removing unnecessary semi-colo

Re: [Mesa-dev] [PATCH 1/3] glsl: removing double semi-colons

2016-04-13 Thread eocallaghan
This series is, Reviewed-by: Edward O'Callaghan On 2016-04-14 02:43, Jakob Sinclair wrote: Trivial change. Removing unnecessary semi-colons from the code. I don't have push access so someone reviewing this can push it. Signed-off-by: Jakob Sinclair --- src/compiler/glsl/ast_function.cpp

Re: [Mesa-dev] [PATCH 1/3] glsl: removing double semi-colons

2016-04-13 Thread Alex Deucher
On Wed, Apr 13, 2016 at 12:43 PM, Jakob Sinclair wrote: > Trivial change. Removing unnecessary semi-colons from the code. > I don't have push access so someone reviewing this can push it. > > Signed-off-by: Jakob Sinclair For the series: Reviewed-by: Alex Deucher > --- > src/compiler/glsl/ast

[Mesa-dev] [PATCH 1/3] glsl: removing double semi-colons

2016-04-13 Thread Jakob Sinclair
Trivial change. Removing unnecessary semi-colons from the code. I don't have push access so someone reviewing this can push it. Signed-off-by: Jakob Sinclair --- src/compiler/glsl/ast_function.cpp | 2 +- src/compiler/glsl/ir_rvalue_visitor.cpp | 2 +- 2 files changed, 2 insertions(+), 2 de