Re: [Mesa-dev] [PATCH] radeon: fixed division by zero

2016-05-18 Thread Jakob Sinclair
On 2016-05-18 16:08, Nicolai Hähnle wrote: On 18.05.2016 08:17, Jakob Sinclair wrote: In the function r600_test_dma the max_width and max_height can be set to zero. Thanks for looking into that. Can they really? I see max_width = MIN2(tsrc.width0, tdst.width0); max_height = MIN2(tsrc.height0

Re: [Mesa-dev] [PATCH] radeon: fixed division by zero

2016-05-18 Thread Marek Olšák
I guess Coverity doesn't know that rand() can't return a negative number. Marek On Wed, May 18, 2016 at 4:08 PM, Nicolai Hähnle wrote: > On 18.05.2016 08:17, Jakob Sinclair wrote: >> >> In the function r600_test_dma the max_width and max_height can be set to >> zero. > > > Thanks for looking int

Re: [Mesa-dev] [PATCH] radeon: fixed division by zero

2016-05-18 Thread Nicolai Hähnle
On 18.05.2016 08:17, Jakob Sinclair wrote: In the function r600_test_dma the max_width and max_height can be set to zero. Thanks for looking into that. Can they really? I see max_width = MIN2(tsrc.width0, tdst.width0); max_height = MIN2(tsrc.height0, tdst.height0); and

[Mesa-dev] [PATCH] radeon: fixed division by zero

2016-05-18 Thread Jakob Sinclair
In the function r600_test_dma the max_width and max_height can be set to zero. These variables are later used to do a modulo operation which can lead to unexpected behavior if they are zero. This patch corrects that by first checking if the max_width or max_height are zero and if they are it sets w