Re: [Mesa-dev] [PATCH] r600, compute: setup compute sampler states and views

Reviewed-by: Marek Olšák I can't review the other patch completely, because it contains some compute stuff I'm not familiar with. Marek On Wed, Aug 12, 2015 at 2:19 PM, Zoltan Gilian wrote: > v2: Add compute mode flag to sampler state setup (Marek). > Drop branches which avoid reference co

[Mesa-dev] [PATCH] r600, compute: setup compute sampler states and views

v2: Add compute mode flag to sampler state setup (Marek). Drop branches which avoid reference counting (Marek). Simplify unset branch condition (Marek). --- src/gallium/drivers/r600/evergreen_compute.c | 25 --- src/gallium/drivers/r600/evergreen_state.c | 46

Re: [Mesa-dev] [PATCH] r600, compute: setup compute sampler states and views

On 8/11/15, Marek Olšák wrote: > Do compute sampler states need RADEON_CP_PACKET3_COMPUTE_MODE as well? Oops, I've forgotten to add it. My mistake. I'm not sure if needed (I have a working test which uses linear filtering), but the SET_SAMPLER packet too has a header with the graphics/compute fie

Re: [Mesa-dev] [PATCH] r600, compute: setup compute sampler states and views

-- Edward O'Callaghan edward.ocallag...@koparo.com On Wed, Aug 12, 2015, at 05:54 AM, Marek Olšák wrote: > On Mon, Aug 10, 2015 at 8:30 PM, Zoltan Gilian > wrote: > > --- > > src/gallium/drivers/r600/evergreen_compute.c | 25 ++ > > src/gallium/drivers/r600/evergreen_s

Re: [Mesa-dev] [PATCH] r600, compute: setup compute sampler states and views

On Mon, Aug 10, 2015 at 8:30 PM, Zoltan Gilian wrote: > --- > src/gallium/drivers/r600/evergreen_compute.c | 25 ++ > src/gallium/drivers/r600/evergreen_state.c | 30 -- > src/gallium/drivers/r600/evergreend.h| 5 + > src/gallium/drivers/

[Mesa-dev] [PATCH] r600, compute: setup compute sampler states and views

--- src/gallium/drivers/r600/evergreen_compute.c | 25 ++ src/gallium/drivers/r600/evergreen_state.c | 30 -- src/gallium/drivers/r600/evergreend.h| 5 + src/gallium/drivers/r600/r600_pipe.h | 7 +- src/gallium/drivers/r600/r6