> Strange because of the types -- presumably fb_samples is an int because its
> uses are in a comparison with another int (that probably doesn't need to be
> an int :)
I am really hesitant to start changing types all over the place; I have a
sinking suspicion that changing the types of fb_width
On Thu, May 21, 2015 at 4:44 PM, Rogovin, Kevin wrote:
>> struct brw_state_flags state = brw->state.pipelines[pipeline];
>> + int fb_samples = (int)_mesa_geometric_samples(ctx->DrawBuffer);
>
>> The cast looks strange
>
> Is there a spacing missing in the cast? or is it strange because of th
>> src/mesa/drivers/dri/i965/brw_misc_state.c | 10 +++---
> > src/mesa/drivers/dri/i965/brw_sf_state.c | 8
> As is this?
brw_misc_state.c is active for all Gens. The change to brw_sf_state.c is to
add a comment warning that using gl_framebuffer::Width and so o
On Thu, May 21, 2015 at 2:30 PM, wrote:
> From: Kevin Rogovin
>
> Change references to gl_framebuffer::Width, Height, MaxNumLayers
> and Visual::samples to use the _mesa_geometry_ convenience functions
> for those places where the geometry of the gl_framebuffer is needed
> (in contrast to the ge
From: Kevin Rogovin
Change references to gl_framebuffer::Width, Height, MaxNumLayers
and Visual::samples to use the _mesa_geometry_ convenience functions
for those places where the geometry of the gl_framebuffer is needed
(in contrast to the geometry of the intersection of the attachments
of the
