On Thu, May 21, 2015 at 8:51 PM, Rogovin, Kevin wrote:
>
>> FWIW, the kernel standards for commit messages are at:
>> https://www.kernel.org/doc/Documentation/SubmittingPatches
>> Most of those rules apply to Mesa too. It says the body should be wrapped to
>> 75 chars (although I've been using 72
On Thu, May 21, 2015 at 8:40 PM, Rogovin, Kevin wrote:
>
>
>> I suppose it could be useful, but I think we've been mostly successful at
>> just expecting people to recognize when what they're writing doesn't look
>> like the code around it.
>
> This is my point. Older code had different style/ex
> FWIW, the kernel standards for commit messages are at:
> https://www.kernel.org/doc/Documentation/SubmittingPatches
> Most of those rules apply to Mesa too. It says the body should be wrapped to
> 75 chars (although I've been using 72 like Matt said).
This is my point: "use most rules, but no
On Thu, May 21, 2015 at 5:26 PM, Rogovin, Kevin wrote:
> HI,
>
>
>
>>Or 78 columns, to be safe, but there's exceptions, like if you're
>> defining a big static table/array of info.
>
> Uggg I don't mind exceptions, but knowing them is key.
>
>
>
>>> 4. successive parenthesis must have spaces
On Thu, May 21, 2015 at 8:05 PM, Rogovin, Kevin wrote:
>
>> This line is too long. (It will not fit in 80 columns in git log since git
>> log adds some spaces before each commit message line.)
>
> What is the accepted maximum length for a line in a commit message?
>
>>> - extension table
>>> -
> I suppose it could be useful, but I think we've been mostly successful at
> just expecting people to recognize when what they're writing doesn't look
> like the code around it.
This is my point. Older code had different style/expectations than newer code.
For this patch series, I have hit a
On 05/21/2015 05:26 PM, Rogovin, Kevin wrote:
HI,
Or 78 columns, to be safe, but there's exceptions, like if you're
defining a big static table/array of info.
Uggg I don't mind exceptions, but knowing them is key.
4. successive parenthesis must have spaces between parenthesis
HI,
>Or 78 columns, to be safe, but there's exceptions, like if you're
> defining a big static table/array of info.
Uggg I don't mind exceptions, but knowing them is key.
>> 4. successive parenthesis must have spaces between parenthesis
> Example?
if (some_func(some_argument))
is
On Thu, May 21, 2015 at 5:05 PM, Rogovin, Kevin wrote:
>
>> This line is too long. (It will not fit in 80 columns in git log since git
>> log adds some spaces before each commit message line.)
>
> What is the accepted maximum length for a line in a commit message?
Gentoo's default vim configurat
On 05/21/2015 05:05 PM, Rogovin, Kevin wrote:
This line is too long. (It will not fit in 80 columns in git log since git log
adds some spaces before each commit message line.)
What is the accepted maximum length for a line in a commit message?
Probably 75 chars since there's 4 spaces of in
> This line is too long. (It will not fit in 80 columns in git log since git
> log adds some spaces before each commit message line.)
What is the accepted maximum length for a line in a commit message?
>> - extension table
>> - additions to gl_framebuffer
>>
>> v1 -> v2
>> Spacing and trail
Some commit message nits... :)
On 2015-05-21 14:30:48, wrote:
> From: Kevin Rogovin
>
> Define the infrastructure for the extension GL_ARB_framebuffer_no_attachments:
This line is too long. (It will not fit in 80 columns in git log since
git log adds some spaces before each commit message line
> Subject: mesa:Define extension ARB_framebuffer_no_attachments
Space after "mesa:"
On Thu, May 21, 2015 at 2:30 PM, wrote:
> From: Kevin Rogovin
>
> Define the infrastructure for the extension GL_ARB_framebuffer_no_attachments:
> - extension table
> - additions to gl_framebuffer
>
> v1 -> v
From: Kevin Rogovin
Define the infrastructure for the extension GL_ARB_framebuffer_no_attachments:
- extension table
- additions to gl_framebuffer
v1 -> v2
Spacing and trailing spaces fixes.
v2 -> v3
mtypes.h: Correct comment on _HasAttachments.
Signed-off-by: Kevin Rogovin
---
src/mesa/
14 matches
Mail list logo
