Re: [Mesa-dev] [RFC PATCH v1 00/30] anv: dma-buf and DRM format modifiers

2017-11-08 Thread Chad Versace
On Tue 07 Nov 2017, Jason Ekstrand wrote: > All of the pre-work patches have been reviewed by myself and Lionel.  I've > also > read through the rest of the series and things look pretty good to me.  I did > make some scattered comments but they shouldn't be a big deal. > > My primary concern wit

Re: [Mesa-dev] [RFC PATCH v1 00/30] anv: dma-buf and DRM format modifiers

2017-11-07 Thread Jason Ekstrand
All of the pre-work patches have been reviewed by myself and Lionel. I've also read through the rest of the series and things look pretty good to me. I did make some scattered comments but they shouldn't be a big deal. My primary concern with the series is the lack of CCS support. Getting that

Re: [Mesa-dev] [RFC PATCH v1 00/30] anv: dma-buf and DRM format modifiers

2017-11-07 Thread Jason Ekstrand
On Tue, Nov 7, 2017 at 9:04 AM, Chad Versace wrote: > On Tue 07 Nov 2017, Jason Ekstrand wrote: > > On Tue, Nov 7, 2017 at 8:11 AM, Jason Ekstrand <[1]ja...@jlekstrand.net> > wrote: > > > > On Tue, Nov 7, 2017 at 6:47 AM, Chad Versace <[2] > chadvers...@chromium.org> > > wrote: > > > >

Re: [Mesa-dev] [RFC PATCH v1 00/30] anv: dma-buf and DRM format modifiers

2017-11-07 Thread Chad Versace
On Tue 07 Nov 2017, Jason Ekstrand wrote: > On Tue, Nov 7, 2017 at 8:11 AM, Jason Ekstrand <[1]ja...@jlekstrand.net> > wrote: > > On Tue, Nov 7, 2017 at 6:47 AM, Chad Versace <[2]chadvers...@chromium.org> > wrote: > >     - crucible > >       We really need to write cruc

Re: [Mesa-dev] [RFC PATCH v1 00/30] anv: dma-buf and DRM format modifiers

2017-11-07 Thread Jason Ekstrand
On Tue, Nov 7, 2017 at 8:11 AM, Jason Ekstrand wrote: > On Tue, Nov 7, 2017 at 6:47 AM, Chad Versace > wrote: > >> Overview: >> >> This series implements 3 extensions: >> >> VK_EXT_external_memory_dma_buf >> VK_EXT_queue_family_foreign >> VK_EXT_image_drm_format_modif

Re: [Mesa-dev] [RFC PATCH v1 00/30] anv: dma-buf and DRM format modifiers

2017-11-07 Thread Jason Ekstrand
On Tue, Nov 7, 2017 at 6:47 AM, Chad Versace wrote: > Overview: > > This series implements 3 extensions: > > VK_EXT_external_memory_dma_buf > VK_EXT_queue_family_foreign > VK_EXT_image_drm_format_modifier > > The patch series lives on my tag 'chadv/review/anv-dma-b

[Mesa-dev] [RFC PATCH v1 00/30] anv: dma-buf and DRM format modifiers

2017-11-07 Thread Chad Versace
Overview: This series implements 3 extensions: VK_EXT_external_memory_dma_buf VK_EXT_queue_family_foreign VK_EXT_image_drm_format_modifier The patch series lives on my tag 'chadv/review/anv-dma-buf-v01'. http://git.kiwitree.net/cgit/~chadv/mesa/log/?h=chadv/re