Re: [Mesa-dev] [RFC 3/7] nir: coverity unitialized pointer read

2016-05-19 Thread Rob Clark
On Thu, May 19, 2016 at 4:42 PM, Matt Turner wrote: > On Wed, May 18, 2016 at 8:54 AM, Rob Clark wrote: >> From: Rob Clark >> >> Not sure how coverity arrives at the conclusion that we can read comp[j] >> unitialized (around line 204), other than not being aware that ncomp is >> greater than 1 s

Re: [Mesa-dev] [RFC 3/7] nir: coverity unitialized pointer read

2016-05-19 Thread Matt Turner
On Wed, May 18, 2016 at 8:54 AM, Rob Clark wrote: > From: Rob Clark > > Not sure how coverity arrives at the conclusion that we can read comp[j] > unitialized (around line 204), other than not being aware that ncomp is > greater than 1 so it won't underflow in the 'if (tex->is_array)' case. > ---

[Mesa-dev] [RFC 3/7] nir: coverity unitialized pointer read

2016-05-18 Thread Rob Clark
From: Rob Clark Not sure how coverity arrives at the conclusion that we can read comp[j] unitialized (around line 204), other than not being aware that ncomp is greater than 1 so it won't underflow in the 'if (tex->is_array)' case. --- src/compiler/nir/nir_lower_tex.c | 6 ++ 1 file changed,