Re: [Mesa-dev] [RFC 12/12] nir: Add a pass to inline functions

2015-12-27 Thread Connor Abbott
On Sun, Dec 27, 2015 at 4:35 PM, Jason Ekstrand wrote: > On Sun, Dec 27, 2015 at 10:15 AM, Connor Abbott wrote: >> >> On Sat, Dec 26, 2015 at 2:09 PM, Jason Ekstrand >> wrote: >> > This commit adds a new NIR pass that lowers all function calls away by >> > inlining the functions. >> > --- >> > >

Re: [Mesa-dev] [RFC 12/12] nir: Add a pass to inline functions

2015-12-27 Thread Jason Ekstrand
On Sun, Dec 27, 2015 at 10:15 AM, Connor Abbott wrote: > On Sat, Dec 26, 2015 at 2:09 PM, Jason Ekstrand > wrote: > > This commit adds a new NIR pass that lowers all function calls away by > > inlining the functions. > > --- > > > > There are still two things missing here: > > > > 1) We really

Re: [Mesa-dev] [RFC 12/12] nir: Add a pass to inline functions

2015-12-27 Thread Connor Abbott
On Sat, Dec 26, 2015 at 2:09 PM, Jason Ekstrand wrote: > This commit adds a new NIR pass that lowers all function calls away by > inlining the functions. > --- > > There are still two things missing here: > > 1) We really shouldn't do the inline recursively. We should keep a > hash-table of

[Mesa-dev] [RFC 12/12] nir: Add a pass to inline functions

2015-12-26 Thread Jason Ekstrand
This commit adds a new NIR pass that lowers all function calls away by inlining the functions. --- There are still two things missing here: 1) We really shouldn't do the inline recursively. We should keep a hash-table of inlined versions or something. 2) It doesn't properly handle things