Re: [Mesa-dev] [RFC] opencl: mega-cl

2018-02-27 Thread Francisco Jerez
Rob Clark writes: > On Mon, Feb 26, 2018 at 6:12 PM, Francisco Jerez > wrote: >> Rob Clark writes: >> >>> On Sun, Feb 25, 2018 at 3:00 PM, Francisco Jerez >>> wrote: Seems like a serious hack to me to work around broken linking... IMO we should just fix the linking issue. The sym

Re: [Mesa-dev] [RFC] opencl: mega-cl

2018-02-27 Thread Rob Clark
On Tue, Feb 27, 2018 at 6:47 AM, Emil Velikov wrote: > On 27 February 2018 at 00:26, Rob Clark wrote: >> On Mon, Feb 26, 2018 at 6:12 PM, Francisco Jerez >> wrote: >>> Rob Clark writes: >>> On Sun, Feb 25, 2018 at 3:00 PM, Francisco Jerez wrote: > Seems like a serious hack to m

Re: [Mesa-dev] [RFC] opencl: mega-cl

2018-02-27 Thread Emil Velikov
On 27 February 2018 at 00:26, Rob Clark wrote: > On Mon, Feb 26, 2018 at 6:12 PM, Francisco Jerez > wrote: >> Rob Clark writes: >> >>> On Sun, Feb 25, 2018 at 3:00 PM, Francisco Jerez >>> wrote: Seems like a serious hack to me to work around broken linking... IMO we should just fix

Re: [Mesa-dev] [RFC] opencl: mega-cl

2018-02-26 Thread Rob Clark
On Mon, Feb 26, 2018 at 6:12 PM, Francisco Jerez wrote: > Rob Clark writes: > >> On Sun, Feb 25, 2018 at 3:00 PM, Francisco Jerez >> wrote: >>> Seems like a serious hack to me to work around broken linking... IMO we >>> should just fix the linking issue. The symbols for the various GLSL >>> t

Re: [Mesa-dev] [RFC] opencl: mega-cl

2018-02-26 Thread Francisco Jerez
Rob Clark writes: > On Sun, Feb 25, 2018 at 3:00 PM, Francisco Jerez > wrote: >> Seems like a serious hack to me to work around broken linking... IMO we >> should just fix the linking issue. The symbols for the various GLSL >> types need to be linked with the proper binding and visibility --

Re: [Mesa-dev] [RFC] opencl: mega-cl

2018-02-26 Thread Karol Herbst
On Mon, Feb 26, 2018 at 2:28 PM, Rob Clark wrote: > On Mon, Feb 26, 2018 at 7:15 AM, Karol Herbst wrote: >> On Mon, Feb 26, 2018 at 1:10 PM, Emil Velikov >> wrote: >>> Hi guys, >>> >>> Having attempted a similar thing in the past, I think there are two >>> things at play here. >>> As such I'd r

Re: [Mesa-dev] [RFC] opencl: mega-cl

2018-02-26 Thread Rob Clark
On Mon, Feb 26, 2018 at 7:15 AM, Karol Herbst wrote: > On Mon, Feb 26, 2018 at 1:10 PM, Emil Velikov > wrote: >> Hi guys, >> >> Having attempted a similar thing in the past, I think there are two >> things at play here. >> As such I'd recommend trying to keep them separate. >> >> 1) Having a sin

Re: [Mesa-dev] [RFC] opencl: mega-cl

2018-02-26 Thread Rob Clark
On Mon, Feb 26, 2018 at 8:06 AM, Rob Clark wrote: > On Mon, Feb 26, 2018 at 7:10 AM, Emil Velikov > wrote: >> Hi guys, >> >> Having attempted a similar thing in the past, I think there are two >> things at play here. >> As such I'd recommend trying to keep them separate. >> >> 1) Having a single

Re: [Mesa-dev] [RFC] opencl: mega-cl

2018-02-26 Thread Rob Clark
On Mon, Feb 26, 2018 at 7:10 AM, Emil Velikov wrote: > Hi guys, > > Having attempted a similar thing in the past, I think there are two > things at play here. > As such I'd recommend trying to keep them separate. > > 1) Having a single and/or modular - state-tracker <> pipe-driver setup > 2) "Hila

Re: [Mesa-dev] [RFC] opencl: mega-cl

2018-02-26 Thread Karol Herbst
On Mon, Feb 26, 2018 at 1:10 PM, Emil Velikov wrote: > Hi guys, > > Having attempted a similar thing in the past, I think there are two > things at play here. > As such I'd recommend trying to keep them separate. > > 1) Having a single and/or modular - state-tracker <> pipe-driver setup > 2) "Hila

Re: [Mesa-dev] [RFC] opencl: mega-cl

2018-02-26 Thread Emil Velikov
Hi guys, Having attempted a similar thing in the past, I think there are two things at play here. As such I'd recommend trying to keep them separate. 1) Having a single and/or modular - state-tracker <> pipe-driver setup 2) "Hilarities" when having NIR code multiple times per process On 26 Febru

Re: [Mesa-dev] [RFC] opencl: mega-cl

2018-02-25 Thread Rob Clark
On Sun, Feb 25, 2018 at 3:00 PM, Francisco Jerez wrote: > Seems like a serious hack to me to work around broken linking... IMO we > should just fix the linking issue. The symbols for the various GLSL > types need to be linked with the proper binding and visibility -- I > assume that the cause of

Re: [Mesa-dev] [RFC] opencl: mega-cl

2018-02-25 Thread Francisco Jerez
Seems like a serious hack to me to work around broken linking... IMO we should just fix the linking issue. The symbols for the various GLSL types need to be linked with the proper binding and visibility -- I assume that the cause of your problem is that people are making assumptions about the equ

[Mesa-dev] [RFC] opencl: mega-cl

2018-02-25 Thread Rob Clark
This is a sort of workaround for an issue encountered with the ongoing work for clover clc->spirv->nir work for supporting OpenCL with drivers that support consuming nir instead of llvm-ir. The problem is that libnir (and therefore glsl_types) ends up statically linked into both clover and the pip