Re: [Mesa-dev] [RFC] discard optimization and lowering passes

2010-11-29 Thread Marek Olšák
Please could we get this feature committed to master? I'd like to close Bug 31827. Thank you. Marek On Thu, Nov 25, 2010 at 6:49 PM, Kenneth Graunke wrote: > On Thursday 25 November 2010 06:55:54 you wrote: > > I am ok with either solution as long as it fixes *Bug > > 31827*

Re: [Mesa-dev] [RFC] discard optimization and lowering passes

2010-11-25 Thread Marek Olšák
I am ok with either solution as long as it fixes *Bug 31827* . I have tested my patch and it works. There was a bug in lower_jumps that made discard statements with a condition be treated as without it, causing the removal of all instructions aft

[Mesa-dev] [RFC] discard optimization and lowering passes

2010-11-25 Thread Kenneth Graunke
I was actually working on the same thing today, and wrote two passes for dealing with discards. I was just looking into adding ir_to_mesa and brw_fs support when I saw your patch, so I just split that out and reused it. Thanks for writing that! I'm not sure whether doing it in a separate pass (l