Re: [Mesa-dev] [RFC] Gallium debug options printing

2010-04-24 Thread canbaby
On Thu, 2010-04-22 at 22:28 +0100, Jakob Bornecrantz wrote: > +#define DEBUG_GET_ONCE_FLAGS_OPTION(sufix, name, flags, dfault) \ > +static unsigned long \ > +debug_get_option_ ## sufix (void) \ > +{ \ > + static boolean first = TRUE; \ > + unsigned long value; \ should be static > + if (first

Re: [Mesa-dev] [RFC] Gallium debug options printing

2010-04-23 Thread Jakob Bornecrantz
On Fri, Apr 23, 2010 at 2:51 PM, canbaby wrote: > On Thu, 2010-04-22 at 22:28 +0100, Jakob Bornecrantz wrote: >> +#define DEBUG_GET_ONCE_FLAGS_OPTION(sufix, name, flags, dfault) \ >> +static unsigned long \ >> +debug_get_option_ ## sufix (void) \ >> +{ \ >> +   static boolean first = TRUE; \ >> +

Re: [Mesa-dev] [RFC] Gallium debug options printing

2010-04-23 Thread José Fonseca
On Thu, 2010-04-22 at 14:28 -0700, Jakob Bornecrantz wrote: > Hi José et al > > So I got a bit annoyed at seeing the debug_get_*_option print outs > every single time it checks the value. > > The first patch just adds another option to control if we print the > options or not. > > The second add

[Mesa-dev] [RFC] Gallium debug options printing

2010-04-22 Thread Jakob Bornecrantz
Hi José et al So I got a bit annoyed at seeing the debug_get_*_option print outs every single time it checks the value. The first patch just adds another option to control if we print the options or not. The second adds helper defines so you can easily add functions which only check the argument