Re: [Mesa-dev] [RFC] Gallium constant handling speed improvements

2010-12-04 Thread Marek Olšák
Hi Jakob, I like the idea behind the first patch and there is a slight performance improvement with it on r300g, so I hope we'll get it accepted soon. r300g has no requirements on alignment of the offset but other drivers might have. The only change that's needed for r300g in set_constant_buffer i

Re: [Mesa-dev] [RFC] Gallium constant handling speed improvements

2010-12-03 Thread Brian Paul
On 12/03/2010 12:47 PM, Jakob Bornecrantz wrote: Hi all I have attached two patches that should help with speed on applications that causes a lot of constant buffers to be emitted or lot of constant state as in the case of the second patch as it eliminates a memcpy. The first patch just adds a

[Mesa-dev] [RFC] Gallium constant handling speed improvements

2010-12-03 Thread Jakob Bornecrantz
Hi all I have attached two patches that should help with speed on applications that causes a lot of constant buffers to be emitted or lot of constant state as in the case of the second patch as it eliminates a memcpy. The first patch just adds a offset and size argument to the set_constant_buffer