Re: [Mesa-dev] [RFC] DRI3 support for EGL (v2)

2015-07-28 Thread Emil Velikov
Hello Boyan, On 21 July 2015 at 16:43, Boyan Ding wrote: > This is the second version of my effort to bring dri3 to EGL on X. This > time I took Emil's advice and moved common logic of GLX and EGL into > loader/loader_dri3_helper.[ch]. With this, the dri3 code in libEGL is > only ~650 lines, with

[Mesa-dev] [RFC] DRI3 support for EGL (v2)

2015-07-21 Thread Boyan Ding
This is the second version of my effort to bring dri3 to EGL on X. This time I took Emil's advice and moved common logic of GLX and EGL into loader/loader_dri3_helper.[ch]. With this, the dri3 code in libEGL is only ~650 lines, with a bunch of trivial code, and glx/dri3 code also shrinks a lot. I

Re: [Mesa-dev] [RFC] DRI3 support for EGL

2015-07-01 Thread Michel Dänzer
On 02.07.2015 13:34, Boyan Ding wrote: > Forgot to mention that I was running piglit on platform x11_egl. > > Actually, I found egl and glx on dri2 both passes this test, but > glx/dri3 fails. That's why you saw the failure without my patch. I know, my point is that the failure probably isn't dir

Re: [Mesa-dev] [RFC] DRI3 support for EGL

2015-07-01 Thread Boyan Ding
Forgot to mention that I was running piglit on platform x11_egl. Actually, I found egl and glx on dri2 both passes this test, but glx/dri3 fails. That's why you saw the failure without my patch. Regards, Boyan Ding 2015-07-02 10:58 GMT+08:00 Michel Dänzer : > On 02.07.2015 00:31, Boyan Ding wr

Re: [Mesa-dev] [RFC] DRI3 support for EGL

2015-07-01 Thread Michel Dänzer
On 02.07.2015 00:31, Boyan Ding wrote: > > piglit shows only one regression, gl-1.0-swapbuffers-behavior went from > pass to fail (quite strange, I don't know why). That test also breaks when enabling DRI3 without your patch. -- Earthling Michel Dänzer | http://www.

Re: [Mesa-dev] [RFC] DRI3 support for EGL

2015-07-01 Thread Axel Davy
On Wed, 1 Jul 2015, Eero Tamminen wrote: Hi, Does this address comments raised for the 2014 EGL/DRI3 patch: http://patchwork.freedesktop.org/patch/35399/ ? - Eero Hello, The patch you mention wasn't really bringing DRI3 support to EGL, it was just using PRESENT to speed up

Re: [Mesa-dev] [RFC] DRI3 support for EGL

2015-07-01 Thread Eero Tamminen
Hi, Does this address comments raised for the 2014 EGL/DRI3 patch: http://patchwork.freedesktop.org/patch/35399/ ? - Eero On 07/01/2015 06:31 PM, Boyan Ding wrote: The patch that follows implements DRI3 support for EGL API. Most of the code is directly ported from dri3_glx.c, w

[Mesa-dev] [RFC] DRI3 support for EGL

2015-07-01 Thread Boyan Ding
The patch that follows implements DRI3 support for EGL API. Most of the code is directly ported from dri3_glx.c, with changes to match the EGL API and to fit the style of egl_dri2 driver. And most of the code specific to DRI3 lives in platform_x11_dri3.c (and .h). It depends on another patch [1] fo