Re: [Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

2018-08-20 Thread Ian Romanick
On 08/20/2018 04:02 PM, Marek Olšák wrote: > I wouldn't add _DepthClamp. Having just DepthClampNear and > DepthClampFar should be enough. Drivers not supporting the extension > can use either variable, because they will be equal. > > The glGet query can be handled as LOC_CUSTOM. Yeah, that works

Re: [Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

2018-08-20 Thread Marek Olšák
I wouldn't add _DepthClamp. Having just DepthClampNear and DepthClampFar should be enough. Drivers not supporting the extension can use either variable, because they will be equal. The glGet query can be handled as LOC_CUSTOM. Marek On Sun, Aug 19, 2018 at 6:43 PM Sagar Ghuge wrote: > > > > On

Re: [Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

2018-08-20 Thread Sagar Ghuge
On 08/13/2018 03:52 PM, Ian Romanick wrote: > On 08/09/2018 01:09 PM, Marek Olšák wrote: >> On Wed, Aug 1, 2018 at 11:31 PM, Sagar Ghuge wrote: >>> enable _mesa_PushAttrib() and _mesa_PopAttrib() >>> to handle GL_DEPTH_CLAMP_NEAR_AMD and >>> GL_DEPTH_CLAMP_FAR_AMD tokens. >>> >>> Signed-off-by:

Re: [Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

2018-08-14 Thread Sagar Ghuge
On 08/13/2018 03:43 PM, Ian Romanick wrote: > On 08/09/2018 01:14 PM, Sagar Ghuge wrote: >> >> >> On 08/09/2018 01:09 PM, Marek Olšák wrote: >>> On Wed, Aug 1, 2018 at 11:31 PM, Sagar Ghuge wrote: enable _mesa_PushAttrib() and _mesa_PopAttrib() to handle GL_DEPTH_CLAMP_NEAR_AMD and >>>

Re: [Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

2018-08-13 Thread Ian Romanick
On 08/09/2018 01:09 PM, Marek Olšák wrote: > On Wed, Aug 1, 2018 at 11:31 PM, Sagar Ghuge wrote: >> enable _mesa_PushAttrib() and _mesa_PopAttrib() >> to handle GL_DEPTH_CLAMP_NEAR_AMD and >> GL_DEPTH_CLAMP_FAR_AMD tokens. >> >> Signed-off-by: Sagar Ghuge >> --- >> src/mesa/main/attrib.c | 16 ++

Re: [Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

2018-08-13 Thread Ian Romanick
On 08/09/2018 01:14 PM, Sagar Ghuge wrote: > > > On 08/09/2018 01:09 PM, Marek Olšák wrote: >> On Wed, Aug 1, 2018 at 11:31 PM, Sagar Ghuge wrote: >>> enable _mesa_PushAttrib() and _mesa_PopAttrib() >>> to handle GL_DEPTH_CLAMP_NEAR_AMD and >>> GL_DEPTH_CLAMP_FAR_AMD tokens. >>> >>> Signed-off-b

Re: [Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

2018-08-09 Thread Sagar Ghuge
On 08/09/2018 01:09 PM, Marek Olšák wrote: > On Wed, Aug 1, 2018 at 11:31 PM, Sagar Ghuge wrote: >> enable _mesa_PushAttrib() and _mesa_PopAttrib() >> to handle GL_DEPTH_CLAMP_NEAR_AMD and >> GL_DEPTH_CLAMP_FAR_AMD tokens. >> >> Signed-off-by: Sagar Ghuge >> --- >> src/mesa/main/attrib.c | 16

Re: [Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

2018-08-09 Thread Marek Olšák
On Wed, Aug 1, 2018 at 11:31 PM, Sagar Ghuge wrote: > enable _mesa_PushAttrib() and _mesa_PopAttrib() > to handle GL_DEPTH_CLAMP_NEAR_AMD and > GL_DEPTH_CLAMP_FAR_AMD tokens. > > Signed-off-by: Sagar Ghuge > --- > src/mesa/main/attrib.c | 16 > 1 file changed, 16 insertions(+) >

Re: [Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

2018-08-02 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 08/01/2018 08:31 PM, Sagar Ghuge wrote: > enable _mesa_PushAttrib() and _mesa_PopAttrib() > to handle GL_DEPTH_CLAMP_NEAR_AMD and > GL_DEPTH_CLAMP_FAR_AMD tokens. > > Signed-off-by: Sagar Ghuge > --- > src/mesa/main/attrib.c | 16 >

[Mesa-dev] [RFC][PATCH 3/5] mesa: Add support for AMD_depth_clamp_separate

2018-08-01 Thread Sagar Ghuge
enable _mesa_PushAttrib() and _mesa_PopAttrib() to handle GL_DEPTH_CLAMP_NEAR_AMD and GL_DEPTH_CLAMP_FAR_AMD tokens. Signed-off-by: Sagar Ghuge --- src/mesa/main/attrib.c | 16 1 file changed, 16 insertions(+) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c index c