Re: [Mesa-dev] [PATCHES] implement GL_ARB_robustness

2011-04-21 Thread Brian Paul
On Thu, Apr 21, 2011 at 4:21 PM, nobled wrote: > On Thu, Apr 21, 2011 at 10:18 AM, Brian Paul wrote: >> I've applied your patches and pushed a new branch (arb_robustness).  I found >> a few little issues in your changes (s/disp/exec/, missing "offset=" line >> the .xml file, etc).  Please grab th

Re: [Mesa-dev] [PATCHES] implement GL_ARB_robustness

2011-04-21 Thread nobled
On Thu, Apr 21, 2011 at 10:18 AM, Brian Paul wrote: > I've applied your patches and pushed a new branch (arb_robustness).  I found > a few little issues in your changes (s/disp/exec/, missing "offset=" line > the .xml file, etc).  Please grab the branch and test it a bit (anyone). Oops, thanks for

Re: [Mesa-dev] [PATCHES] implement GL_ARB_robustness

2011-04-21 Thread Jose Fonseca
- Original Message - > On Wed, Apr 20, 2011 at 1:57 PM, nobled > wrote: > > On Wed, Apr 20, 2011 at 11:19 AM, Brian Paul > > wrote: > >> On Tue, Apr 19, 2011 at 8:31 PM, nobled > >> wrote: > >> I'd also like to see a new piglit test for this extension.  In > >> fact, I > >> think we sh

Re: [Mesa-dev] [PATCHES] implement GL_ARB_robustness

2011-04-21 Thread Brian Paul
I've applied your patches and pushed a new branch (arb_robustness). I found a few little issues in your changes (s/disp/exec/, missing "offset=" line the .xml file, etc). Please grab the branch and test it a bit (anyone). Will you be able to write a new piglit test for this? -Brian

Re: [Mesa-dev] [PATCHES] implement GL_ARB_robustness

2011-04-20 Thread Brian Paul
On Wed, Apr 20, 2011 at 1:57 PM, nobled wrote: > On Wed, Apr 20, 2011 at 11:19 AM, Brian Paul wrote: >> On Tue, Apr 19, 2011 at 8:31 PM, nobled wrote: >> I'd also like to see a new piglit test for this extension.  In fact, I >> think we should require a piglit test for any new feature we add to

Re: [Mesa-dev] [PATCHES] implement GL_ARB_robustness

2011-04-20 Thread nobled
On Wed, Apr 20, 2011 at 11:19 AM, Brian Paul wrote: > On Tue, Apr 19, 2011 at 8:31 PM, nobled wrote: > [...] >> I added an XML file now, too; regenerating didn't work for me though, >> because I'm missing some >> XORG thing? (Also I had to run `apt-get install indent` first, but >> then I hit the

Re: [Mesa-dev] [PATCHES] implement GL_ARB_robustness

2011-04-20 Thread Brian Paul
On Tue, Apr 19, 2011 at 8:31 PM, nobled wrote: [...] > I added an XML file now, too; regenerating didn't work for me though, > because I'm missing some > XORG thing? (Also I had to run `apt-get install indent` first, but > then I hit the missing XORG thing error.) The server-side generated files

Re: [Mesa-dev] [PATCHES] implement GL_ARB_robustness

2011-04-20 Thread Henri Verbeet
On 20 April 2011 04:31, nobled wrote: > Sorry about that; I'll send the updated patch series inline. There > tend to be word wrapping issues with 80+ character lines though (like > in extensions.c), so I'll also attach them as files here. > Just use git send-email, it tends to avoid that kind of i

Re: [Mesa-dev] [PATCHES] implement GL_ARB_robustness

2011-04-19 Thread Brian Paul
On 04/19/2011 02:43 PM, Ian Romanick wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/19/2011 12:23 PM, nobled wrote: spec file: http://www.opengl.org/registry/specs/ARB/robustness.txt The first four parts of this series add infrastructure to support bounds-checking client memory buf

Re: [Mesa-dev] [PATCHES] implement GL_ARB_robustness

2011-04-19 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/19/2011 12:23 PM, nobled wrote: > spec file: > http://www.opengl.org/registry/specs/ARB/robustness.txt > > The first four parts of this series add infrastructure to support > bounds-checking client memory buffers by re-using the PBO > bounds-che