Re: [Mesa-dev] [PATCH v5 00/21] Introducing SPIR-V support to clover

2018-07-17 Thread Pierre Moreau
I have no idea how, but it seems I messed up the commit message for that one, since the ML version (https://patchwork.freedesktop.org/patch/212834/) has a Rb tag from me and has "v5: Fix return type of clCreateCommandQueueWithProperties", whereas the version I have on GitHub does not have the Rb ta

Re: [Mesa-dev] [PATCH v5 00/21] Introducing SPIR-V support to clover

2018-07-15 Thread Karol Herbst
the second patch also lacks review: "clover: update ICD table to support everything up to 2.2" On Sun, Jul 15, 2018 at 9:26 PM, Pierre Moreau wrote: > Hello, > > I would appreciate if the following patches could be reviewed: > * Patch 07 (latest: v6): clover/api: Rework the validation of devices

Re: [Mesa-dev] [PATCH v5 00/21] Introducing SPIR-V support to clover

2018-07-15 Thread Pierre Moreau
Hello, I would appreciate if the following patches could be reviewed: * Patch 07 (latest: v6): clover/api: Rework the validation of devices for building; @Francisco: I made the modifications you asked for, but I am not sure whether the “LGTM” should be translated as an Ack or a Rb. * Patch 14

Re: [Mesa-dev] [PATCH v5 00/21] Introducing SPIR-V support to clover

2018-05-23 Thread Pierre Moreau
Hello everyone, I updated a few patches of the series to have it use the new official SPIR-V <-> LLVM translator, that can be found at https://github.com/KhronosGroup/SPIRV-LLVM-Translator. The whole series, rebased on the current Mesa HEAD, can be found at https://github.com/pierremoreau/mesa/tr

[Mesa-dev] [PATCH v5 00/21] Introducing SPIR-V support to clover

2018-03-25 Thread Pierre Moreau
Hello, This has only minor changes compared to the previous version, but as it introduces a new patch, I preferred to resend the whole series, as patch numbering would be messed up otherwise. As is_valid_spirv will be also used by the SPIR-V backend, I moved that function away from api/program.cp